Running procedures concurrently

Question

Hi,
I am having some issues with the time it takes for one of my packages to complete.
Here is an overview of what it does.
1) Extracts data input last night and populates a specific table - basic raw data with FK's to other tables
2) Validate a given set of data fields, 20 of them, based on the raw data inserted above
I have created one function to validate each data item i.e.
fnc_validate_dob
fnc_vaidate_address
fnc_vaidate_telephone
There are 20 of these, each with varying complexity. They are all called one after the other. Problem is, there are 6 vaidation functions that take approx 15 mins each to complete - so instantly we have 90 mins taken up which is unacceptable.
Is there anyway I can call these so they run concurrently?
Any ideas would be very helpful.
Regards
Mark

Answer 1

Hi,
Each of the functions update a specific table that holds rejections - linked back to the raw data by the key.
The business what to identify what fields are failing and also see the data entered, so they can change business process etc.
Most of the validation functions are pretty straight forward - it is jus the 6 that I am having troubles with, due to the way the data is stored and how it has be extrated.
I will try and post some code to help explain.
Here is the main body of the validation script for a particular field.
    --VALIDATE FIN CLASS CODE
    --AS STORED IN QUESTIONS AND ANSWERS, BRING BACK ALL RECORDS FIRST - INCLUDING
    --NULLS, THEN FILTER THESE TO REMOVE VALID CODES
    INSERT INTO E2e_Rejected_Fin_Class
      (Appt_Id,
       Rejected,
       Value_Entered,
       Control)
      SELECT Ap.Appt_Id,
             0 Rejected,
             (SELECT a."answer_externalcode"
              FROM   Ugp.e_Episode       e,
                     Ugp.e_Answerepisode Ae,
                     Ugp.e_Answer        a,
                     Ugp.e_Question      q
              WHERE  e."episode_id" = Ap.Episode_Id
              AND    ae."episode_id" = e."episode_id"
              AND    a."answer_id" = ae."answer_id"
              AND    q."quest_id" = a."quest_id"
              AND    e."episode_iscurrent" = 1
              AND    q."quest_externalcode" = 'Finclass'),
             Ap.Control
      FROM   E2e_Appointments Ap;
    COMMIT;
    --OPEN CURSOR TO IDENTIFY THOSE RECORDS WITH AN ENTRY AND VALIDATE THEM
    --SET REJECTED = 1 IF THE CODE IS INVALID
    OPEN Cur_Fin_Class;
    LOOP
      FETCH Cur_Fin_Class
        INTO Rec_Fin_Class;
      EXIT WHEN Cur_Fin_Class%NOTFOUND;
      IF Commons.Pkg_Data_Validation.Fnc_Validate_Financial_Class(Rec_Fin_Class.Value_Entered,
                                                                  Rec_Fin_Class.Funder) = 1 THEN
        UPDATE E2e_Rejected_Fin_Class
        SET    Rejected = 1
        WHERE  Fin_Class_Id = Rec_Fin_Class.Fin_Class_Id;
      END IF;
    END LOOP;
    CLOSE Cur_Fin_Class;
    COMMIT;
    --DELETE EVERYTHING FROM TABLE WHERE REJECTED = 0
    DELETE FROM E2e_Rejected_Fin_Class WHERE Rejected = 0;
    COMMIT;And this is the function that is called - returns 1 if fails validation
FUNCTION Fnc_Validate_Financial_Class(Pin_Fin_Class IN VARCHAR2,
                                        Pin_Funder    IN VARCHAR2) RETURN NUMBER IS
    -- Author:  MLLOYD
    -- Purpose: Validate Financial Class - fails if null and funder != 'NONE'
    --          (InsuranceType_code from UG where Self Paid
    -- Created: 22/12/2010
    -- Revision History
    -- Date            Version        Comments
    -- 22/12/2010         1           Created
  BEGIN
    IF Pin_Fin_Class IS NULL
       AND Pin_Funder != 'NONE' THEN
      RETURN 1;
    ELSE
      RETURN 0;
    END IF;
  END Fnc_Validate_Financial_Class;
  -- ************************************************************************************I am thinking that it isnt actually the validation that takes the time, it is the initial data select - I have the DBA's looking at tuning the database for me, as I think the indexes required are there.
It would be great to be able to call the all of the 6 procedures together.
Regards
Mark