Run procedure - error handling

Question

Hi,
I 've created a run procedure to fire off my test cases. In cases of success he puts ' PASS', in case of failure he puts 'FAIL' as status , however when the sql query is invalid he currently stops the procedure and RAISES the error.
I would like to let the procedure continue till the end and as status insert 'ERRO' for that query rather than that the procedure stops and raises teh error. This, to enable the procedure to be run completely even if a test case is badly written.
Could someone pls help out?
thnx
CREATE OR REPLACE PROCEDURE              RUN_TEST_CASES 
   AS
    cursor c_etrm_test_cases
    is
        select   test_group,
                 test_id,
                 test_type,
                 test_desc,
                 test_level,
                 test_query,
                 test_owner,
                 test_creation,
                 expected_result
          from   etrm_test_cases;
    v_result          number (10);
    v_tstart          timestamp (0);
    v_tend            timestamp (0);
    v_cresult         char (4);
    v_remark          varchar2 (2000);
    v_runid           number (3);
begin
    --check for active run_id
    select   a.run
      into   v_runid
      from   zainet_dev_mig.ZN_TEC_INFRA_RUN a
     where   a.active = 'Y';
    for r_etrm_test_cases in c_etrm_test_cases
    loop
        --start timestamp
        select   CURRENT_TIMESTAMP (0) into v_tstart from DUAL;
        --execute the query - test case
        begin
            execute immediate TO_CHAR (r_etrm_test_cases.test_query)
                into   v_result;
        exception
            when others
            then raise;
        end;
        --was the result as expected?
        if v_result = r_etrm_test_cases.expected_result
        then
            v_cresult := 'PASS';
            v_remark := null;
        else
            v_cresult := 'FAIL';
            v_remark :=
                   'Expected '
                || TO_CHAR (r_etrm_test_cases.expected_result)
                || ', got '
                || TO_CHAR (v_result);
        end if;
        --end timestamp
        select   CURRENT_TIMESTAMP (0) into v_tend from DUAL;
        BEGIN
        UPDATE ZAINET_DEV_MIG.etrm_test_log
        SET ZAINET_DEV_MIG.etrm_test_log.result = v_result,
            ZAINET_DEV_MIG.etrm_test_log.time_start = v_tstart,
            ZAINET_DEV_MIG.etrm_test_log.time_end = v_tend,
            ZAINET_DEV_MIG.etrm_test_log.status = v_cresult,
            ZAINET_DEV_MIG.etrm_test_log.run_id = v_runid,
            ZAINET_DEV_MIG.etrm_test_log.action = 'UPDATE'
            WHERE ZAINET_DEV_MIG.etrm_test_log.test_id in (select test_id from ZAINET_DEV_MIG.etrm_test_cases);
       EXCEPTION WHEN others
       THEN
       BEGIN
       insert into ZAINET_DEV_MIG.etrm_test_log (test_group,
                                              test_id,
                                              test_type,
                                              test_desc,
                                              test_level,
                                              test_query,
                                              test_owner,
                                              test_creation,
                                              expected_result,
                                              result,
                                              status,
                                              remark,
                                              time_start,
                                              time_end,
                                              run_id,
                                              action)
          values   (r_etrm_test_cases.test_group,
                    r_etrm_test_cases.test_id,
                    r_etrm_test_cases.test_type,
                    r_etrm_test_cases.test_desc,
                    r_etrm_test_cases.test_level,
                    r_etrm_test_cases.test_query,
                    r_etrm_test_cases.test_owner,
                    r_etrm_test_cases.test_creation,
                    r_etrm_test_cases.expected_result,
                    v_result,
                    v_cresult,
                    v_remark,
                    v_tstart,
                    v_tend,
                    v_runid,
                    'INSERT');
          EXCEPTION when others
          then raise;
          end;         
    end;
        commit;
    end loop;
end run_test_cases;Edited by: BluShadow on 29-Jul-2011 13:39
added {noformat}{noformat} tags.  Please read {message:id=9360002} to learn to do this yourself.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                   

Answer 1

It could be that the insert into etrm_test_log is raising another invalid number exception - completely unrelated to the first. You should have a full error stack which will point to the line number that is raising the exception.
Check the types of the variables against each column you are inserting.
Also with reference to the Merge that BluShadow mentioned, you've not really done anything about it. The very least you should do if you're not going to follow that advice is to get rid of the WHEN OTHERS and replace it with WHEN DUP_VAL_ON_INDEX. That is more precise than WHEN OTHERS...
/* Formatted on 01/08/2011 10:21:26 (QP5 v5.163.1008.3004) */
CREATE OR REPLACE PROCEDURE run_test_cases
AS
   CURSOR c_etrm_test_cases
   IS
      SELECT test_group,
             test_id,
             test_type,
             test_desc,
             test_level,
             test_query,
             test_owner,
             test_creation,
             expected_result
        FROM etrm_test_cases;
   v_result    NUMBER (10);
   v_tstart    TIMESTAMP (0);
   v_tend      TIMESTAMP (0);
   v_cresult   CHAR (4);
   v_remark    VARCHAR2 (2000);
   v_runid     NUMBER (3);
BEGIN
   --check for active run_id
   SELECT a.run
     INTO v_runid
     FROM zainet_dev_mig.zn_tec_infra_run a
    WHERE a.active = 'Y';
   FOR r_etrm_test_cases IN c_etrm_test_cases
   LOOP
      --start timestamp
      SELECT CURRENT_TIMESTAMP (0) INTO v_tstart FROM DUAL;
      --execute the query - test case
      BEGIN
         EXECUTE IMMEDIATE TO_CHAR (r_etrm_test_cases.test_query)
            INTO v_result;
      EXCEPTION
         WHEN INVALID_NUMBER
         THEN
            INSERT INTO zainet_dev_mig.etrm_test_log (test_group,
                                                      test_id,
                                                      test_type,
                                                      test_desc,
                                                      test_level,
                                                      test_query,
                                                      test_owner,
                                                      test_creation,
                                                      expected_result,
                                                      result,
                                                      status,
                                                      remark,
                                                      time_start,
                                                      time_end,
                                                      run_id,
                                                      action)
                 VALUES (r_etrm_test_cases.test_group,
                         r_etrm_test_cases.test_id,
                         r_etrm_test_cases.test_type,
                         r_etrm_test_cases.test_desc,
                         r_etrm_test_cases.test_level,
                         r_etrm_test_cases.test_query,
                         r_etrm_test_cases.test_owner,
                         r_etrm_test_cases.test_creation,
                         r_etrm_test_cases.expected_result,
                         'ERROR: INVALID NUMBER',
                         'ERROR: INVALID NUMBER',
                         'CHECK QUERY - ERROR: INVALID NUMBER',
                         NULL,
                         NULL,
                         v_runid,
                         'ERROR: INVALID NUMBER');
      END;                                       --was the result as expected?
      IF v_result = r_etrm_test_cases.expected_result
      THEN
         v_cresult := 'PASS';
         v_remark := NULL;
      ELSE
         v_cresult := 'FAIL';
         v_remark :=
               'Expected '
            || TO_CHAR (r_etrm_test_cases.expected_result)
            || ', got '
            || TO_CHAR (v_result);
      END IF;
      --end timestamp
      SELECT CURRENT_TIMESTAMP (0) INTO v_tend FROM DUAL;
      BEGIN
         INSERT INTO zainet_dev_mig.etrm_test_log (test_group,
                                                   test_id,
                                                   test_type,
                                                   test_desc,
                                                   test_level,
                                                   test_query,
                                                   test_owner,
                                                   test_creation,
                                                   expected_result,
                                                   result,
                                                   status,
                                                   remark,
                                                   time_start,
                                                   time_end,
                                                   run_id,
                                                   action)
              VALUES (r_etrm_test_cases.test_group,
                      r_etrm_test_cases.test_id,
                      r_etrm_test_cases.test_type,
                      r_etrm_test_cases.test_desc,
                      r_etrm_test_cases.test_level,
                      r_etrm_test_cases.test_query,
                      r_etrm_test_cases.test_owner,
                      r_etrm_test_cases.test_creation,
                      r_etrm_test_cases.expected_result,
                      v_result,
                      v_cresult,
                      v_remark,
                      v_tstart,
                      v_tend,
                      v_runid,
                      'INSERT');
      EXCEPTION
         WHEN DUP_VAL_ON_INDEX
         THEN
               UPDATE zainet_dev_mig.etrm_test_log
                  SET zainet_dev_mig.etrm_test_log.result = v_result,
                      zainet_dev_mig.etrm_test_log.time_start = v_tstart,
                      zainet_dev_mig.etrm_test_log.time_end = v_tend,
                      zainet_dev_mig.etrm_test_log.status = v_cresult,
                      zainet_dev_mig.etrm_test_log.run_id = v_runid,
                      zainet_dev_mig.etrm_test_log.action = 'UPDATE'
                WHERE zainet_dev_mig.etrm_test_log.test_id =
                         r_etrm_test_cases.test_id;
      END;
      COMMIT;
   END LOOP;
END run_test_cases;HTH
David