Runtime.getRuntime().exec() in JSP - Starting a batch

Question

Hi,
I am trying to start a batch from a jsp in the following way:
try{
String path = "bat/drucken";
ProcessBuilder processBuilder = new ProcessBuilder(path);
Process process = processBuilder.start();
out.println("<script type=\"text/javascript\">alert('ausgeführt.');</script>");
}catch(Throwable t){
t.printStackTrace();
out.println("<script type=\"text/javascript\"> alert('Fehler beim Drucken.');</script>");
But onfortunately it does not work the way I want.
If I double click the batch file, it works properly and starts a visual basic script, that makes out of n word-documents one single one.
If I start it like above, then nothing happens and just the alert('ausgeführt') appears.
How can I start a VB script or a commands of the shell from inside a jsp ?
PS: using Windows XP, jsp should work on a Windows Server

Answer 1

As Liane said, this should NOT be in your JSP. This should be in a normal Java file, compiled to a class, in a package, and deployed in the Web Application's /WEB-INF/classes/ directory.
Example. Change the code to this:
//Put your class in a package
package debbie.in.florida;
import java.io.*;
public class Console{
    String error = null;
    String output = null;
    public String getError(){
        return error;
    public String getOutput(){
        return output;
    /** Called from inside the jsp like new Console().exec("cscript drucken.vbs param1 param2") **/
    public void exec(){
        try{
            String osName = System.getProperty("os.name" );
            String[] cmd = new String[3];
            cmd[0] = "cmd.exe" ;
            cmd[1] = "/C" ;
            cmd[2] = "Test.exe";
            Runtime rt = Runtime.getRuntime();
            System.out.println("Execing " + cmd[0] + " " + cmd[1] + " " + cmd[2]);
            Process proc = rt.exec(cmd);
            // any error message?
            grabStream(proc.getErrorStream(), "error");
            // any output?
            grabStream(proc.getInputStream(), "output");
            // any error???
            int exitVal = proc.waitFor();
            if (exitVal != 0)
                error += "ExitValue: "+exitVal;
        } catch (Exception e){
            e.printStackTrace();
    private void grabStream(InputStream is, String msg){
        if (!(msg.equals("error") || msg.equals("output")))
            return;
        String message = "";
        try{
            InputStreamReader isr = new InputStreamReader(is);
            BufferedReader br = new BufferedReader(isr);
            String line=null;
            while ( (line = br.readLine()) != null)
                message += line;
        } catch (IOException ioe){
            ioe.printStackTrace();
        if (msg.equals("error"))
            error = message;
        else
            output = message;
}Then compile the code and move the Console.class file to <web application>/WEB-INF/class/debbie/in/florida/Console.class. The folder should be debbie/in/florida because the package is defined as debbie.in.florida.
Then your JSP would look like:
    <%//Use the debbie.in.florida namespace because your class is in a package
        debbie.in.florida.Console console = new debbie.in.florida.Console();
    %>
    <script type="text/javascript">
        alert("start");
    </script>
    <%
        console.exec();
        String error = console.getError();
        String output = console.getOutput();
    %>
    <script type="text/javascript">
        alert("end, output = <%=output%> and error = <%=error%>");
    </script>There is a lot wrong with this code, but I won't go and try to fix design problems here, That will be for a later day. But if things are working you should get two popups, one at the start, then your code should execute (or you should get an error message if something is wrong with the code), then a second popup at the end with the response from your application.