Script to create multiple tablespaces

Question

Below is the korne shell script that i have written to create tablespaces for db unitst. Can any1 please verify the execute immediate statement whetherit is correct or not
#!/bin/ksh
########################Set up oracle environment############
ORACLE_SID=unitst
ORACLE_HOME=/ora/product/v102
ORAENV_ASK=NO
PATH=$PATH:/usr/local/bin
export ORACLE_SID PATH ORAENV_ASK
. oraenv
a=`date +"%Y-%m-%d"`
echo "Current Date:$a"
for i in `cat try.txt | awk '{print $1}'`
do
echo "Starting :$i"
     Tsize=`cat try.txt | grep $i | awk '{print $2}'`
     connect1=`sqlplus -s /nolog<< END
     connect / as sysdba
     set pagesize 1000 linesize 1000 feedback off verify off
     execute immediate 'create tablespace' || $i || 'datafile '/unitst/data003/$i.dbf' size' || $Tsize || 'NOLOGGING';
     END`
echo "completed :$i"
doneContents of file try.txt
T_APOGEE_FY_1998_DATA   40M
T_APOGEE_FY_1998_IDX    7M
T_APOGEE_FY_1999_DATA   776M
T_APOGEE_FY_1999_IDX    126M
T_APOGEE_FY_2000_DATA   1060M
T_APOGEE_FY_2000_IDX    171M
T_APOGEE_FY_2001_DATA   1012M
T_APOGEE_FY_2001_IDX    160M
T_APOGEE_FY_2002_DATA   1180M
T_APOGEE_FY_2002_IDX    200MEdited by: 832812 on May 4, 2011 9:58 PM

Answer 1

You need two single quotes around that datafile name,
execute immediate 'create tablespace ' || $i || ' datafile ''/unitst/data003/'||$i||'.dbf'' size ' || $Tsize || ' NOLOGGING';In dynamic sql, two single quotes in the middle of the string is considered as one quote.
You need to take care of the spaces as well.
G.
Edited by: Ganesh Srivatsav on May 5, 2011 1:25 AM
Added spaces