Security System CLD Exam Problem Solution? Insane?

Question

I just started working on the CLD example problems.  I've been using Labview for about 10 years - so everything I do is old-school.
I'm posting this solution for the Security System example.  There are arrays of switches to represent the alarm, bypass, and tamper
signals - and then a loop to go through each "zone" to logically determine the state (normal, alarm, bypass or tamper).  To make the
"zone status" indicator an easily scalable indicator I have the "zone" loop change the color of a boolean LED indicator.  Then I take a 
picture of it and display an array of pix.  
Question:  This works fine, good response - but would it pass?  Is there a better way? I attached the diagram...
Solved!
Go to Solution.
Attachments:
security system.png ‏43 KB

Answer 1

I don't like the detour over an array of images and property nodes. Seems indirect and inefficient. Is that a requirement or your idea?
Also I assume that the FOR loop executes quickly, so you should probably do the timestamping once before the loop.
The "wait for FP activity is really "old school" and not very good. You typically get extra triggers, which is expensive since you write to the file every time. I would strongly suggest an event structure instead.
The small FOR loop can be replaced by "search array". Much cleaner!
It might be better and more efficient to open/create the file once before the loop, write using lowlevel functions during the loop, and close after the while loop has finished.
LabVIEW Champion . Do more with less code and in less time .