Select count in view question

Question

The sql view below does not do what I want it to and not sure which string function to use. The goal is to get the two columns with instr to only count the rows that the INSTR actually finds the string. Basically I am looking for a substring function that returns a boolean value and only count those when true. How I go about this in an oracle view.
code:
CREATE OR REPLACE VIEW LOGONREPORT
AS
SELECT USERNAME,
COUNT(*) ATTEMPTS,
COUNT(INSTR(ACTION,'LOG IN SUCCESS',1,1)) SUCCESS,
COUNT(INSTR(ACTION,'LOG IN FAILED',1,1)) FAILED
FROM AUDITRECORD
GROUP BY USERNAME;
--------------------

Answer 1

Hi,
for example:
SQL> select ename, deptno from emp;
&nbsp
ENAME          DEPTNO
SMITH              20
ALLEN              30
WARD               30
JONES              20
MARTIN             30
BLAKE              30
CLARK              10
SCOTT              20
KING               10
TURNER             30
ADAMS              20
JAMES              30
FORD               20
MILLER             10
&nbsp
14 rows selected.
&nbsp
SQL> select deptno, instr(ename,'M') from emp order by 1,2;
&nbsp
    DEPTNO INSTR(ENAME,'M')
        10                0
        10                0
        10                1
        20                0
        20                0
        20                0
        20                2
        20                4
        30                0
        30                0
        30                0
        30                0
        30                1
        30                3
&nbsp
14 rows selected.
&nbsp
SQL> select deptno,
  2  count(decode(instr(ename,'M'),0,null,instr(ename,'M'))) cnt
  3  from emp group by deptno
  4  /
&nbsp
    DEPTNO        CNT
        10          1
        20          2
        30          2Rgds.