Select out of loop

Question

my previous code is
data : begin of itab occurs 0,
               matnr like zcst-zmatnr,
              checked type i,
          def11 type i,
               def14 type i,
end of itab.
DATA : ind TYPE i.
LOOP AT itab.
  ind = sy-tabix.
  SELECT COUNT( DISTINCT zcst~zcastn )
    FROM zcst INNER JOIN zvtrans
    ON ( zcstzcastn = zvtranszcastn AND
         zcstzmatnr = zvtranszmatnr AND
         zcstzwerks = zvtranszwerks AND
         zcstgjahr  = zvtransgjahr )
    INTO itab-checked
    WHERE
        zcst~zmatnr = itab-matnr AND
        zcst~zwerks IN s_plant AND
        zcastpd IN s_castpd AND
        zcatg IN s_categ.
  PERFORM defect_count USING itab-def11 '11'.
  PERFORM defect_count USING itab-def14 '14'.
  MODIFY itab INDEX ind.
ENDLOOP.
*&      Form  defect_count
      text
     -->P_DEFECT       text
     -->VALUE(P_CODE)  text
FORM defect_count  USING    p_defect
                            value(p_code).
  IF r1 = 'X'.
    SELECT COUNT( DISTINCT  zcst~zcastn )
    FROM zcst INNER JOIN zvtrans
    ON ( zcstzcastn = zvtranszcastn AND
         zcstzmatnr = zvtranszmatnr AND
         zcstzwerks = zvtranszwerks AND
         zcstgjahr  = zvtransgjahr )
    INTO p_defect
    WHERE
        zcst~zmatnr = itab-matnr AND
        zcst~zwerks IN s_plant AND
        zcastpd IN s_castpd AND
        zcatg IN s_categ AND
        zvtrans~zvcode = 'S' AND
        zdcode = p_code.
  ENDFORM.                    "defect_count
  what i have written is as new code is this. is this correct instead of above code.
  DATA : BEGIN OF w_final,
                zmatnr LIKE zcst-zmatnr,
               checked TYPE i,
            def11 TYPE i,
                 def14 TYPE i, END OF w_final.
  DATA : BEGIN OF w_chkd,
           zmatnr TYPE zcst-zmatnr,
           checked TYPE i,
         END OF w_chkd.
  DATA : BEGIN OF w_tab,
          zmatnr LIKE zcst-zmatnr,
         END OF w_tab.
  itab like standard table of w_tab,
     i_final like standard table of w_final.
  i_chkd like standard table of w_chkd,
  i_chkd1 like standard table of w_chkd.
  SELECT zcstzmatnr COUNT( DISTINCT zcstzcastn )
         FROM zcst INNER JOIN zvtrans
         ON ( zcstzcastn = zvtranszcastn AND
              zcstzmatnr = zvtranszmatnr AND
              zcstzwerks = zvtranszwerks AND
              zcstgjahr  = zvtransgjahr )
         INTO TABLE i_chkd
         WHERE
            zcst~zmatnr = w_tab-matnr AND
             zcst~zwerks EQ p_plant AND
             zcastpd IN s_castpd AND
             zcatg IN s_categ GROUP BY zcst~zmatnr.
  LOOP AT itab INTO w_tab.
    LOOP AT i_chkd INTO w_chkd WHERE zmatnr = w_tab-zmatnr.
      IF sy-subrc EQ 0.
        w_chkd-zmatnr = w_chkd-zmatnr.
        w_chkd-checked = w_chkd-checked.
        APPEND w_chkd TO i_chkd1.
      ENDIF.
    ENDLOOP.
  ENDLOOP.
  SELECT zcst~zmatnr
           zcst~zcastn
           zvtrans~zdcode
     FROM zcst INNER JOIN zvtrans
     ON ( zcstzcastn = zvtranszcastn AND
          zcstzmatnr = zvtranszmatnr AND
          zcstzwerks = zvtranszwerks AND
          zcstgjahr  = zvtransgjahr )
     INTO TABLE i_defect
     WHERE
       zcst~zmatnr = itab-matnr AND
         zcst~zwerks EQ p_plant AND
         zcastpd IN s_castpd AND
         zcatg IN s_categ AND
         zvtrans~zvcode = 'S' AND
         zdcode IN ('11','14','16','83','19','20','22','24','26','34',
                    '35','36','37','39','40','41','45','48','53','55',
                    '56','67','68','72','73','92','84','85','78','75').
  SORT i_defect BY zcastn.
  DELETE ADJACENT DUPLICATES FROM i_defect COMPARING zcastn.
  LOOP AT itab INTO w_tab.
    LOOP AT i_defect INTO w_defect WHERE zmatnr = w_tab-zmatnr.
      IF sy-subrc EQ 0.
        w1_defect-zmatnr = w_defect-zmatnr.
        w1_defect-zcastn = w_defect-zcastn.
        w1_defect-zdcode = w_defect-zdcode.
        APPEND w1_defect TO it_defect.
        CLEAR w1_defect.
      ENDIF.
    ENDLOOP.
  ENDLOOP.
  LOOP AT i_final INTO w_final.
    ind = sy-tabix.
*checked
    READ TABLE i_chkd1 INTO w_chkd WITH KEY zmatnr = w_final-zmatnr.
    w_final-checked = w_chkd-checked.
    PERFORM defect_count USING w_final-def11 '11'.
    PERFORM defect_count USING w_final-def14 '14'.
    MODIFY i_final FROM w_final INDEX ind.
  ENDLOOP.
*&      Form  defect_count
      text
     -->P_DEFECT       text
     -->VALUE(P_CODE)  text
FORM defect_count  USING    p_defect
                            value(p_code).
  LOOP AT it_defect INTO w_defect WHERE zdcode = p_code.
    IF sy-subrc EQ 0.
      p_defect = p_defect + 1.
    ENDIF.
  ENDLOOP.
ENDFORM.                    "defect_count

Answer 1

Hi,
DATA :  i_bkpf LIKE BKPF OCCURS 0 WITH
            HEADER LINE.
SELECT * FROM BKPF
INTO TABLE i_BKPF
FOR ALL ENTRIES IN WK
WHERE BUKRS = '4187' AND
             BELNR = WK-BELNR AND
             GJAHR = PROCYR.
LOOP AT WK.
READ TABLE i_BKPF WITH KEY
BUKRS = '4187'
BELNR = WK-BELNR
GJAHR = PROCYR.
IF SY-SUBRC EQ 0.
ENDIF.
ENDLOOP.
Don't forget to reward if useful...