Set label colour to files in loop.

Question

This Script works in part to open a folder select the image to create a text document of the files, at the same time I would like to label them as red.
set myFile to (Macintosh HD:Users:Matt:Desktop:
SelectedImages.txt")
open for access file myFile with write permission
set eof file myFile to 0
set resultFiles to (choose file with prompt "Choose Files" with multiple selections allowed)
set tc to (count resultFiles)
repeat with i from 1 to tc
  set theNfile to (item i of resultFiles) & return
  write ((theNfile as list) as text) to file myFile
  log theNfile
  tell application "Finder"
  set label index of file (theNfile as text) to 2 --red
  end tell
end repeat
close access file myFile
My end result is this
Result:
error "Finder got an error: Can’t set file \"Macintosh HD:Users:User:Desktop:Bits and bobs:DP GOOD:Untitled1.psd
\" to 2." number -10006 from file "Macintosh HD:Users:User:Desktop:Bits and bobs:DP GOOD:Untitled1.psd
yet run the line below on its own and it has no problems?
tell application "Finder" to  set label index of file "StudioA:Users:StudioA:Desktop:Bits and bobs:DP GOOD:Untitled1.psd" to 2

Answer 1

Hello
Error -4960 is a generic error that tells little about what is wrong.
/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/Headers/MacErrors.h:  coreFoundationUnknownErr      = -4960
Fortunately I can reproduce this error when I pass HFS path instead of POSIX path to the write_to_file() handler. So I guess you're doing it as well by replacing:
my write_to_file("", myFile's POSIX path, {_append:false, _class:«class utf8»})
with:
my write_to_file("", myFile, {_append:false, _class:«class utf8»})
when myFile is HFS path.
If myFile is HFS path and the file at the path already exists, you may call the handler like this:
my write_to_file("", (myFile as alias)'s POSIX path, {_append:false, _class:«class utf8»})
If myFile does not exist yet, the above won't work because (myFile as alias) fails. In such case, you'd need to build myFile as POSIX path from the beginning.
Having that said, here's a revised handler that seems to work with both HFS path and POSIX path under 10.6.8 although it does NOT conform to the definition of "open for access" and "close access" commands in OSAX dictionary. I do not like this sort of loose coding in undocumented way, but if it works for you and you're fine with the looseness, you may use it with due caution.
on write_to_file(x, p, {_append:_append, _class:_class})
        anything x : anything to be written to output file
        string p : POSIX path or HFS path of output file
        boolean _append: true to append data, false to replace data
        type class _class: type class as which the data is written
    local fd
    try
        set fd to open for access (p) with write permission
        if not _append then set eof fd to 0
        write x as _class to fd starting at eof
        close access fd
    on error errs number errn
        try
            close access (p)
        end try
        error "write_to_file(): " & errs number errn
    end try
end write_to_file
Good luck,
H