[SOLVED] EurKEY PKGBUILD request for comments

Question

Hi, I just finished a PKGBUILD for EurKEY "European Keyboard Layout". It installs and removes fine on my system, and I took care to respect the packaging standards, but before submitting it to AUR I would like to get any comments/suggestions.
PKGBUILD
# Maintainer: Christoph Roeper <cr (at) roeper (dot) biz>
pkgname=eurkey
pkgver=1.1
pkgrel=1
pkgdesc="The European Keyboard Layout"
arch=('any')
url="http://eurkey.steffen.bruentjen.eu/"
license=('GPL3')
depends=('xkeyboard-config' 'sed' 'gawk')
install="$pkgname.install"
source=(http://eurkey.steffen.bruentjen.eu/download/debian/binary/eurkey.deb)
md5sums=('8da8472f8f8d30baaa6a50145264024b')
package() {
cd "$srcdir"
ar x $pkgname.deb
tar xzf data.tar.gz -C "$pkgdir/"
cd "${pkgdir}"
# euro on '5', swap with pound
awk='\
BEGIN { fix = 0 } \
if ( $2 == "<AE04>" ) { $7="sterling,"; fix = 1 } \
else if ( $2 == "<AE05>" ) { $7="EuroSign,"; fix = 1 } \
if ( fix == 1 ) { printf "%11s %s %s %s%16s%19s%22s%21s %s %s\n",$1,$2,$3,$4,$5,$6,$7,$8,$9,$10; fix = 0 } \
else { print } \
file="usr/share/X11/xkb/symbols/eurkey"
tmpfile="$file".`date +%FT%T`.temp
awk -- "$awk" $file > $tmpfile
cat $tmpfile > $file
rm $tmpfile
pkgname.install
post_install() {
# Installs the EurKEY layout.
if test "$EUID" = 0; then SUDO=; else SUDO=sudo; fi
exec $SUDO bash /dev/stdin "$@" <<'ENDSUDO'
set -e
str=" <layout>\n\
<configItem>\n\
<name>eurkey</name>\n\
<shortDescription>EUR</shortDescription>\n\
<description>EurKEY</description>\n\
<languageList>\n\
<iso639Id>cat</iso639Id>\n\
<iso639Id>dan</iso639Id>\n\
<iso639Id>eng</iso639Id>\n\
<iso639Id>est</iso639Id>\n\
<iso639Id>fao</iso639Id>\n\
<iso639Id>fin</iso639Id>\n\
<iso639Id>ger</iso639Id>\n\
<iso639Id>gre</iso639Id>\n\
<iso639Id>gsw</iso639Id>\n\
<iso639Id>ita</iso639Id>\n\
<iso639Id>lav</iso639Id>\n\
<iso639Id>lit</iso639Id>\n\
<iso639Id>nld</iso639Id>\n\
<iso639Id>nor</iso639Id>\n\
<iso639Id>por</iso639Id>\n\
<iso639Id>spa</iso639Id>\n\
<iso639Id>swe</iso639Id>\n\
</languageList>\n\
</configItem>\n\
</layout>\n\
</layoutList>"
for file in /usr/share/X11/xkb/rules/{base,evdev}.xml; do
if [ ! -f "$file" ]; then
echo "File $file is not a regular file (skipped)"
elif [ $(grep -ci eurkey "$file") -ne 0 ]; then
echo "File $file already constains eurkey (skipped)"
else
echo "processing $file"
sed -i "s~</layoutList>~$str~" "$file"
fi
done
ENDSUDO
pre_remove() {
# Removes the EurKEY layout.
if test "$EUID" = 0; then SUDO=; else SUDO=sudo; fi
exec $SUDO bash /dev/stdin "$@" <<'ENDSUDO'
set -e
for file in {/etc/vconsole.conf,/etc/X11/xorg.conf.d/*keyboard*}; do
if [ -f $file ]; then
[ `grep -ci '^\s*[^#].*eurkey' $file` -ne 0 ] && echo -e "Cannot completely remove EurKEY since it's still configured in $file.\nPlease remove it manually or use the settings manager." && exit 1
fi
done
exit 0
ENDSUDO
post_remove() {
# Removes the EurKEY layout.
if test "$EUID" = 0; then SUDO=; else SUDO=sudo; fi
exec $SUDO bash /dev/stdin "$@" <<'ENDSUDO'
set -e
awk='
BEGIN { output = 1 ; buffer = "" }
$0~/<layout>/ { output = 0 ; deleteSection = 0 }
output == 1 { print $0 }
$0~/<\/layout>/ { output = 1 ; buffer = buffer $0 ; if (deleteSection == 0) print buffer ; buffer = "" }
$0~/<name>eurkey<\/name>/ { deleteSection = 1 }
output == 0 { buffer = buffer $0 "\n" }
for file in /usr/share/X11/xkb/rules/{base,evdev}.xml; do
if test -f "$file"; then
tmpfile="$file".`date +%FT%T`.temp
echo "processing $file"
awk -- "$awk" $file > $tmpfile
cat $tmpfile > $file
rm $tmpfile
fi
done
ENDSUDO
'sed' and 'awk' are neither build nor run-time dependencies, both are install dependencies, but I did not find a proper option for that.
The (un-)install-scripts are taken from the Debian source, however with deb-packages it is obviously possible to abort  pre/post_remove on failure (here used if the keyboard layout is still in use => no uninstall). I did not find a proper way to accomplish this with PKGBUILD install scripts.
Both scripts a rather long, but in other review requests forum veterans preferred to have scripts posted here instead of a link to AUR or pastebin. If it's nevertheless wrong I will relocate the scripts.
Thanks in advance.
Last edited by roepi (2014-03-17 17:42:44)

Answer 1

If you still want to modify the XML, I would use xmlstarlet instead of awk/sed. I haven't tested the following scripts so they will probably need some debugging but they should give you a general idea of what I would do.
The post remove script would be reduced to:
set -e
# xpath selector to select layouts that are named eurkey
xpath='/xkbConfigRegistry/layoutList/layout/configItem/name[text()="eurkey"]/../..'
for file in /usr/share/X11/xkb/rules/{base,evdev}.xml; do
[[ -f "$file" ]] && xml ed --inplace -d "$xpath" "$file"
done
And the post install script would become:
set -e
xpath='/xkbConfigRegistry/layoutList/layout/configItem/name[text()="eurkey"]'
for file in /usr/share/X11/xkb/rules/{base,evdev}.xml; do
if [[ ! -f "$file" ]]; then
echo "File $file is not a regular file (skipped)"
elif xml sel -t -c "$xpath" $file >/dev/null; then
echo "File $file already constains eurkey (skipped)"
else
echo "processing $file"
xml ed -P -L \
-s /xkbConfigRegistry/layoutList -t elem -n layoutTMP -v '' \
-s //layoutTMP -t elem -n configItem -v '' \
-s //layoutTMP/configItem -t elem -n name -v 'eurkey' \
-s //layoutTMP/configItem -t elem -n shortDescription -v 'EUR' \
-s //layoutTMP/configItem -t elem -n description -v 'EurKEY' \
-s //layoutTMP/configItem -t elem -n languageList -v '' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'cat' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'dan' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'eng' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'est' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'fao' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'fin' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'ger' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'gre' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'gsw' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'ita' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'lav' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'lit' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'nld' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'nor' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'por' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'spa' \
-s //layoutTMP/configItem/languageList -t elem -n iso639Id -v 'swe' \
-r //layoutTMP -v layout \
"$file"
fi
done