[SOLVED] ipager does not build. Patched! Now it does.

Question

Dig in, children. ipager really is the coolest little thing!
Some thanks should go to berbae. I just mashed up an AUR comment post of his with a little code fix I located in a blog post at the confignewton tech blog (dittoThanks).
This patch supercedes the two other patches that package maintainer wakwanza is shipping with ipager-1.1.0-8. To clarify... Please swap out both of those patches (ipager.patch + ipager-gcc43.patch), instead using ipager-1.1.0-20120429.patch for a flawless build. (3 warnings of deprecation + 1 harmless other warning remain, though)
   ipager-1.1.0-20120429.patch:
--- SConstruct.orig 2005-11-06 05:23:24.000000000 -0600
+++ SConstruct 2012-04-29 06:59:11.927253922 -0500
@@ -7,15 +7,16 @@
# options
ipager_optfile = [ 'scons.opts', 'user.opts' ]
-ipager_options = Options(ipager_optfile)
-ipager_options.AddOptions(
- BoolOption('debug', 'build debug version', 0),
- BoolOption('debug_events', 'debug xserve events', 0),
- BoolOption('xinerama', 'support xinerama', 0),
+ipager_options = Variables(ipager_optfile)
+ipager_options.AddVariables(
+ BoolVariable('debug', 'build debug version', 0),
+ BoolVariable('debug_events', 'debug xserve events', 0),
- PathOption('PREFIX', 'install-path base', '/usr/local'),
- PathOption('DESTDIR', 'install to $DESTDIR/$PREFIX', '/')
+ BoolVariable('xinerama', 'support xinerama', 0),
+
+ PathVariable('PREFIX', 'install-path base', '/usr'),
+ PathVariable('DESTDIR', 'install to $DESTDIR/$PREFIX', '/')
@@ -31,10 +32,10 @@
ipager_env = Environment(options = ipager_options, ENV = os.environ)
ipager_env.Append(
- CPPFLAGS = [ '-Wall' ],
- CPPPATH = [ '/usr/X11R6/include' ],
- LIBPATH = ['/usr/X11R6/lib']
+ CPPFLAGS = [ '-Wall', '-march=native', '-O' ],
+ CPPPATH = [ '/usr/include' ],
+ LIBPATH = [ '/usr/lib' ]
+)
ipager_options.Update(ipager_env)
@@ -115,11 +116,10 @@
else:
print "yes"
ipager_env.AppendUnique(
- CPPPATH = imlib2_env.Dictionary()['CPPPATH'],
- CCFLAGS = imlib2_env.Dictionary()['CCFLAGS'],
- LIBPATH = imlib2_env.Dictionary()['LIBPATH'],
- LIBS = imlib2_env.Dictionary()['LIBS']
+ CPPPATH = imlib2_env.Dictionary().get('CPPPATH'),
+ CCFLAGS = imlib2_env.Dictionary().get('CCFLAGS'),
+ LIBPATH = imlib2_env.Dictionary().get('LIBPATH'),
+ LIBS = imlib2_env.Dictionary().get('LIBS')
conf.Finish()
--- iconfig.cpp.orig 2012-04-28 19:34:36.902151855 -0500
+++ iconfig.cpp 2012-04-28 18:31:28.000000000 -0500
@@ -30,11 +30,11 @@
#include <iostream>
#include <fstream>
#include <sstream>
+#include <cstdlib>
#include <sys/stat.h>
#include <sys/types.h>
+using namespace std;
template <class T>
bool from_string(T &t,
--- ipager.cpp.orig 2012-04-28 19:34:36.928818549 -0500
+++ ipager.cpp 2012-04-28 18:43:26.000000000 -0500
@@ -31,6 +31,7 @@
#include <iostream>
#include <string>
+#include <unistd.h>
using namespace std;
#include "pager.h"
--- pager.cpp.orig 2012-04-28 19:34:36.928818549 -0500
+++ pager.cpp 2012-04-28 19:07:28.000000000 -0500
@@ -266,13 +266,13 @@
/* Window updates go here */
if (m_window_update.updateNetWindowList())
updateNetWindowList();
- if (m_window_update.displayIcons())
- if (m_window_update.motion())
+ if (m_window_update.displayIcons()) {
+ if (m_window_update.motion()) {
displayIcons(m_window_update.getX(), m_window_update.getY());
- else
+ } else {
displayIcons();
+ }
+ }
/* ImLib updates go here */
--- wm.cpp.orig 2012-04-28 19:34:36.928818549 -0500
+++ wm.cpp 2012-04-28 18:42:07.000000000 -0500
@@ -27,7 +27,9 @@
#include <time.h>
#include "atoms.h"
+#include <cstdlib>
+using namespace std;
WM * WM::m_instance = 0;
bool WM::x_error = false;
This md5sum is what you'll get, IF you'll please add a newline at the patch EOF.
f147f6a4ec3f8779bdc1c12cfbd5e03f ipager-1.1.0-20120429.patch
Note: I messed with 3 pastebin sites, and now these \[code\] tags, never once able to successfully share without the truncation of the trailing newline at EOF. Hours of learning (yes, googling) how not to do it properly. Anyone care to point me to a non-truncating solution?  EDIT: [SOLVED] The patch program will ignore lines beginning with '#'. The solution is obvious, after re-reading the manual.
P.S. My first post! (pat self on back) Sorry for my excellent english. :]
Last edited by zero2cx (2012-04-29 20:10:01)

Answer 1

berbae wrote:Thank you for sharing this.
But it would be nice to have the maintainer wakwanza make the changes in AUR and increment the package release to 1.1.0-9
Could you send a mail to him, and if there is no answer in one month, ask a TU in the AUR-general mailing list to orphan the package.
And then you or someone else can adopt it and make the changes.
You're welcome.
wakwanza has been notified and on the clock since yesterday a.m. The aur commenting system generates an email to the maintainer with every new comment, I've read. But since this package's recent maintenance history is sketchy at best, I reached out to him/her myself. We will wait now.
berbae wrote:
Also you should have posted the link of the blog you found, but here it is: http://confignewton.com/?p=152
I didn't try to rebuild the package recently, I presume it doesn't build with actual build chain tools...
I will try your patch, but I prefer first that the maintainer updates the package in AUR to 1.1.0-9 with your modifications.
Thank you for the link. I did not want to cross any lines into website solicitation, so I proceeded too catiously there.
Yes, please try this and post back.
[EDIT]: Awesome, wakwanza! --> Fresh ipager available: https://aur.archlinux.org/packages.php?ID=5415
Last edited by zero2cx (2012-05-01 21:00:31)