SQL statement in servlet giving error

Question

Please let me know if I need to post this on a different forum, but I thought it was applicable to here.
First, let me preface this post by saying I've inserted hardcoded values at the DB (Oracle) level and it worked just fine, so most of the statement is sound. All the values inserted properly when testing it that way. Also, I've printed the SQL statement to the console and all looks ok there, too.
Out of this, I'm getting an error citing the following:
java.lang.ArrayIndexOutOfBoundsException
also occasionally getting the following error:
java.sql.SQLException: [Microsoft][ODBC Driver Manager] Invalid cursor state
In my servlet, I'm attempting the following:
prior to the insert statement, I'm retrieving the last row number to start the increment from as in:
Statement stmt = connection.createStatement(ResultSet.TYPE_SCROLL_SENSITIVE, ResultSet.CONCUR_READ_ONLY);
ResultSet rst = stmt.executeQuery("select CHANGE_CTRL_ID from CHANGE_CONTROL_USER order by CHANGE_CTRL_ID");
     rst.last();
     int lastRowNum = Integer.valueOf(rst.getString("CHANGE_CTRL_ID")).intValue();
     rst.close();
     stmt.close();
------------ then ------------------------------------------------
String preparedQuery = "INSERT ALL " +
"INTO CHANGE_CONTROL_USER " +
"(CHANGE_CTRL_ID,REQUESTOR_NAME,REQUESTOR_EMAIL,BUS_CONTACT,DEPT,LOCATION,PHONE_NUM,DATE_REQ," +
"BUSVP,VP_PHONE,VP_DATE,BRANCH,PRIORITY,OPS_MAN_CHG,OPS_MAN_PPCHAP,TRAIN_REQ," +
"EXIST_SYS_FLD_CHG,BUS_RULES_CHG,NEW_CODING,NEW_BUS_RULE,NEW_SYS_FIELD,REQ_TYPE_OTHER,REQ_OTHER_SPECIFY,IMPACT_RE_COLL," +
"IMPACT_DEF_LM,IMPACT_DEF_REC_NRE,IMPACT_AUDIT,IMPACT_PERS_COLL,IMPACT_DEF_FCL,IMPACT_BUS_TECH,IMPACT_LEGAL,IMPACT_PRIV_COLL," +
"IMPACT_DEF_BKRUP_RE,IMPACT_DEC_SUPT,IMPACT_RISK_MGT,IMPACT_DEF_REO,IMPACT_DEF_BKRUP_NRE,IMPACT_QUALSVCS,IMPACT_INTERNAL_CTRL,IMPACT_DEF_WKFL," +
"IMPACT_DEF_WKOUT,IMPACT_TRAIN_TPI,IMPACT_OTHER,IMPACT_DEF_MGT,IMPACT_DEF_TAX,IMPACT_VEND_MGT,IMPACT_DEF_CTRL,IMPACT_DEF_REC_RE," +
"IMPACT_BUS_ADMIN,IMPACT_OTHER_SPECIFY,CHANGE_IN_KPMG,CHANGE_IN_OTS,CHANGE_IN_NFR,CHANGE_IN_ARR,CHANGE_IN_BRR, CHANGE_IN_PROC_IMP," +
"CHANGE_IN_INT_CITI_POL,CHANGE_IN_OTHER,CHANGE_IN_OTHER_SPECIFY, CHANGE_INIT_DETAILS,REQ_INFO_DESCRIPT,REQ_INFO_EXPLAIN_CURRBUS,REQ_INFO_EXPLAIN_PROPOSED,REQ_BEN_PROP_BENEFIT,REQ_BEN_FIN_IMPLEMENT," +
"REQ_BEN_OPS_IMPLEMENT,YES_FORM,VULN_ASSESS, CBA_CHG, RISK_ACCEPT,MARSITEM, GCCRFP, APP_COMPL_QUES,CAP_EXPEND)" +
" VALUES (changecontrol_user_seq.nextval,?,?,?,?,?,?,to_date(?,'YYYY-MON-DD HH:MI:SS'),?,?,to_date(?,'YYYY-MON-DD HH:MI:SS'),?,?," + "?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,"
+ "?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)"
+ "INTO CHANGE_CONTROL_ADMIN "
+ "(AID,CHANGE_CTRL_ID,ADMNAME,CLOSEDATE,ACTIVE)"
+ "VALUES (changecontrol_admin_seq.nextval, changecontrol_user_seq.currval,NULL, NULL, -1)"
+ "SELECT object_name AS REQUESTOR_NAME FROM all_objects where rownum <= 1;";     
also I've declared all the respective strings for the PreparedQuery statement.
If you need to see those, here they are:
PreparedStatement pstmt = connection.prepareStatement(preparedQuery);
               // stmt = connection.stmt("INSERT INTO RMIS_USER VALUES (?,?,?,?,to_date(?,'YYYY-MON-DD HH:MI:SS'),?,?,?,?,to_date(?,'YYYY-MM-DD HH:MI:SS')");
          pstmt.setInt(1,++lastRowNum);
          pstmt.setString(2,reqName);
          pstmt.setString(3,reqemail);
          pstmt.setString(4,buscont);
          pstmt.setString(5,reqDept);
          pstmt.setString(6,reqLocale);
          pstmt.setString(7,phone_num);
          pstmt.setDate(8,dtreq);
          //pstmt.setCalendar(8,rtnow);
          pstmt.setString(9,busvp_email);
          pstmt.setString(10,vpphone);
          pstmt.setDate(11,dt);
          pstmt.setString(12,branch);
          pstmt.setString(13,priority);
          pstmt.setString(14,opsmanchg);
          pstmt.setString(15,opsmanppchap);
          pstmt.setString(16,train_req);
          pstmt.setString(17,reqexist_sys_fld_chg);
          pstmt.setString(18,reqbus_rules_chg);
          pstmt.setString(19,reqnew_coding);
          pstmt.setString(20,reqnewbus_rule );
          pstmt.setString(21,reqnew_sys_fld);
          pstmt.setString(22,reqother);
          pstmt.setString(23,req_other_specify);
          pstmt.setString(24,imp_recoll);
          pstmt.setString(25,imp_deflm);
          pstmt.setString(26,imp_defrecnre);
          pstmt.setString(27,imp_audit);
          pstmt.setString(28,imppers_coll);
          pstmt.setString(29,imp_deffcl);
          pstmt.setString(30,imp_bustech);
          pstmt.setString(31,imp_legal);
          pstmt.setString(32,imp_privcoll);
          pstmt.setString(33,imp_defbkre);
          pstmt.setString(34,imp_decsupt);
          pstmt.setString(35,imp_riskmgt);
          pstmt.setString(36,imp_defreo);
          pstmt.setString(37,imp_defbknre);
          pstmt.setString(38,imp_qualsvc);
          pstmt.setString(39,imp_intlctrl);
          pstmt.setString(40,imp_defwkfl);
          pstmt.setString(41,imp_defwkout);
          pstmt.setString(42,imp_trtpi);
          pstmt.setString(43,impact_other);
          pstmt.setString(44,imp_defmgt);
          pstmt.setString(45,imp_deftax);
          pstmt.setString(46,imp_vendmgt);
          pstmt.setString(47,imp_defctrl);
          pstmt.setString(48,imp_defrecre);
          pstmt.setString(49,imp_busadm);
          pstmt.setString(50,impact_other_specify);
          pstmt.setString(51,change_in_kpmg);
          pstmt.setString(52,change_in_ots);
          pstmt.setString(53,change_in_nfr);
          pstmt.setString(54,change_in_arr);
          pstmt.setString(55,change_in_brr);
          pstmt.setString(56,change_in_proc_imp);
          pstmt.setString(57,change_inter_citpol);
          pstmt.setString(58,change_in_other);
          pstmt.setString(59,change_in_other_specify);
          pstmt.setString(60,change_init_details);
          pstmt.setString(61,req_info_descript);
          pstmt.setString(62,req_info_explain_currbus);
          pstmt.setString63,req_info_explain_proposed);
          pstmt.setString(64,req_ben_prop_benefit);
          pstmt.setString(65,req_ben_fin_implement);
          pstmt.setString(66,req_ben_ops_implement);
          pstmt.setString(67,projyes);
          pstmt.setString(68,vulnass);
          pstmt.setString(69,cbachg);
          pstmt.setString(70,riskacc);
          pstmt.setString(71,marsitem);
          pstmt.setString(72,gccrfp);
          pstmt.setString(73,applcomp);
          pstmt.setString(74,capexpend);
          pstmt.executeUpdate();
if anyone sees anything flawed here, please let me know!
Thanks!
Message was edited by:
bpropes20
Message was edited by:
bpropes20
Message was edited by:
bpropes20

Answer 1

What a mess. First off, the line pstmt.setInt(1,++lastRowNum); just needs to go away. You're already using a sequence to set the value for the primary keys, you don't need to add a mistake like this.
I then count 73 question marks (you can verify, I'm not counting again.) That would mean that your indices are off by one, and the ArrayIndexOutOfBounds is probably coming from pstmt.setString(74,capexpend); Dump the ++lastRowNum line, change all of your indices (after verifying the bind count!) and try it again.
You can see an inherent weakness in the PreparedStatement clauses - one change means manually rewriting all of the indices. A solution is dumping all of your bind values into a List, then loop through the list to do your setXXX statements. If all binds are not of the same type, you can bind the values to some object that identifies type and use those objects in the list instead of the values. A little more complex, but easier to maintain in my opinion.