Swap method for list of Nodes not working correctly

Question

Ok so I'm basically messing with a list of nodes, swapping, reversing, and cycling. My only problem is the swap method that I am implementing.
It starts out with a boolean to see if the position is valid, and if so, it will go through the instructions.
The first condition is that if the the position to be swapped( which is named secondPosition) equals 2, it goes through a certain method, which I have no problem with...BUT in the second condition, if secondPosition is greater than 2, I have to use a different way of swapping them...Of course, I have to change their references and not positions, since that's the way nodes work. Also, at the end of the list of nodes, the reference will be null, so I have to deal with that as well, which is to set it to the first node in the list. I am very sure I am writing the code for swapping correctly, but yet it seems that the lists that I swap in the second condition don't even change at all! I don't really see how its happening...could anyone help???
Here is the run:
TESTING SWAP
Trying an invalid swap (position 0)
Passed test
Passed test
Trying an invalid swap (position 4/list size 3)
Passed test
Passed test
Trying a valid swap (position 3/list size 3)
Passed test
*** Failed test (bad list on swap)
*// the result is supposed to be: John Jack Jill, but the list stays in its initial state*
Jack
Jill
John
Trying a valid swap (position 3/list size 4)
Passed test
*** Failed test (bad list on swap)
*// result is supposed to be Jill Jack John Jerry, yet the list stays in its initial state*
Jill
John
Jack
Jerry
Trying a valid swap (position 4/list size 4)
Passed test
*** Failed test (bad list on swap)
*//result is supposed to be Jill Jack John Jerry, yet it still stays in its initial state*
Jill
John
Jack
Jerry
Trying a valid swap (position 2/list size 3)
Passed test
Passed test
Here is the method:
     public boolean swap(int secondPosition)
          boolean valid = false;
          if( secondPosition == 2)
               valid = true;
               Node<T> nodeOne = this.firstNode;
               Node<T> nodeTwo = nodeOne.getNextNode();
               Node<T> nodeThree = nodeTwo.getNextNode();
               firstNode = nodeThree;
               nodeThree = nodeOne;
               nodeOne = nodeTwo;
          else if( secondPosition > 2 && secondPosition <= length)  //this loop is where I'm having problems
               valid = true;
               Node<T> nodeBefore = getNodeAt(secondPosition -2);
               Node<T> nodeOne = nodeBefore.getNextNode();
               Node<T> nodeTwo = nodeOne.getNextNode();
               Node<T> nodeAfter = nodeTwo.getNextNode();
               if( nodeAfter == null)
                    nodeAfter = firstNode;
               nodeBefore = nodeTwo;
               nodeTwo = nodeOne;
               nodeOne = nodeAfter;
          return valid;
     }

Answer 1

I'm sure there is a bug in swap method.
if( secondPosition == 2)
               valid = true;
               Node<T> nodeOne = this.firstNode;
               Node<T> nodeTwo = nodeOne.getNextNode();
               Node<T> nodeThree = nodeTwo.getNextNode();
               firstNode = nodeThree;
               nodeThree = nodeOne;
               nodeOne = nodeTwo;
          }All this code does not actually reorder your nodes. All it does is move a bunch of pointers about. For example firstNode will end up pointing to the last node in the list but this does not automagically make it the first node. If you were to make a call to firstNode .getNextNode I'm sure it will return null and not the next node in the list like you think.