The timer clash wif the actionperformed of the clicked button, hw to solve

Question

// This program demo on the followings:
// 1. To create a JFrame
// 2. To create JLabel and JButton.
// 3. The use of TTimer to automatically update the position of a JLabel
// every 2 seconds
// To learn more about Swing, go to this website:
// http://java.sun.com/docs/books/tutorial/uiswing/index.html
// There's a lot of demo program in this tutorial:
// Down the JFC/Swing Trail tutorial from:
// http://java.sun.com/docs/books/tutorial/information/download.html
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.awt.event.ActionEvent;
public class TimerDemo3 extends JPanel implements ActionListener
     private static final int origX = 1700; //starting position of the shark
private int posX; //position of the small picture,
private int posX3;
private int posX4;
private int posX5;
private int posY; //to be updated every second
     private int posY2;
     private int posY3;
     private int posY4;
     private int posY5;
JLabel label1; //will be loaded with the hunter picture
JLabel label2; //will be loaded with the sharks picture
JLabel label3;
JLabel label4;
JLabel label5;
JButton buttonQuit;
JLabel label10;
     JLabel label11;
     JTextField name;
     JLabel ans;
     JButton enterButton;
     JLabel label;
ImageIcon icon1;
ImageIcon icon2;
ImageIcon icon3;
ImageIcon icon4;
ImageIcon icon5;
ImageIcon sharkImage;
Timer timer;
int delay = 100; // 1000 milliseconds = 1 seconds.
Timer timer2;
int delay2 = 300; // 3000 milliseconds = 3 seconds.
int noKilled = 0;
int i = 1;
public TimerDemo3() {
          // Create the 3 icons
icon1 = new ImageIcon("pic/hunter.jpg");
          icon2 = new ImageIcon("pic/shark2.jpg");
          icon3 = new ImageIcon("pic/shark3.jpg");
          icon4 = new ImageIcon("pic/shark4.jpg");
          icon5 = new ImageIcon("pic/shark2.jpg");
setLayout(null);
setBackground(Color.blue);
//Create and add the 2nd, 3rd .... label.
label2 = new JLabel(icon2);
          label2.setBounds(origX, 100, 250, 90);
          posX = origX;
          posY = 100;
          add(label2, null);
label3 = new JLabel(icon3);
          label3.setBounds(origX, 100, 250, 90);
          posX = origX;
          posY = 100;
          add(label3, null);
          label4 = new JLabel(icon4);
          label4.setBounds(origX, 100, 250, 90);
          posX = origX;
          posY = 100;
          add(label4, null);
          label5 = new JLabel(icon5);
          label5.setBounds(origX, 100, 250, 90);
          posX = origX;
          posY = 100;
          add(label5, null);
//Create and add the first label.
label1 = new JLabel(icon1);
          label1.setBounds(20,-390, 80, 390);
          posY2 = -390;
          add(label1, null);
          // create and place 1 buttons on the frame's content pane
          enterButton = new JButton ("ENTER");
enterButton.setBounds (250,675, 80, 30);
add (enterButton);
          // register this frame as an action listener of the 1 buttons
          enterButton.addActionListener (this);
          // Add label, text field and action listener
          ans = new JLabel ();
          ans.setText ("Please type the word");
          ans.setBounds (85,650,150,25);
          add (ans);
          name = new JTextField();
          name.setBounds (90,680,130,25);
          add (name);
          label10 = new JLabel("Score");
          label10.setBounds(700,650, 100, 30);
          add(label10, null);
          label11 = new JLabel("Mega Harpoon:");
          label11.setBounds(750,650, 100, 30);
          add(label11, null);
//Create and add the OK button.
          buttonQuit = new JButton("Quit");
          buttonQuit.setBounds(900, 675, 60, 30);
          buttonQuit.setActionCommand("Quit");
buttonQuit.addActionListener(this);
//Add button on the panel
          add(buttonQuit, null);
          //Set up a timer that calls this object's action handler.
          //For more info: http://java.sun.com/docs/books/tutorial/uiswing/misc/timer.html
timer = new Timer(delay, this);
timer.start();
          //Set up a timer that calls this object's action handler.
          //For more info: http://java.sun.com/docs/books/tutorial/uiswing/misc/timer.html
timer2 = new Timer (delay2, this);
timer2.start();
public void actionPerformed(ActionEvent e)
          // If this action is not activated by the button, but by the timer.
          // It will update the position of the picture
          posX -= 5;//for every 0.1 sec, the shark wil move 5 pixel.
          if (posX < 100)//the boundary that the shark meets
          posX = origX;// the shark return to origX position.
          posY = 100;
          label2.setBounds(posX, posY, 250, 90);
          posX3 -= 5;
          if (posX3 < 100)
          posX3 = 2300;
          posY3 = 500;
          label3.setBounds(posX3, posY3, 250, 90);
          posX4 -= 5;
          if (posX4 < 100)
          posX4 = 2500;
          posY4 = 300;
          label4.setBounds(posX4, posY4, 250, 90);
          posX5 -= 7;//every 0.1s, shark wil move 7 pixel forward
          if (posX5 < 100)// if the shark reach the boundary of 100, it will return
          posX5 = 2100;// return to the position
          posY5 = 400;
          label5.setBounds(posX5, posY5, 250, 90);
          // If this action is not activated by the button, but by the timer.
          // It will update the position of the picture
          if (posY2 < 0)
               posY2 += 3;//for every 0.1 sec, the hunter wil move 3 pixel.
               label1.setBounds(20, posY2, 80, 390);
          noKilled ++;
          if (noKilled > 10){
          timer2.setDelay(200);
          else if (noKilled > 20){
          timer2.setDelay(100);
          /*if (e.getSource== buttonQuit){
               Toolkit.getDefaultToolkit().beep();
               JButton clickedbutton = (JButton)e.getSource();
                    if (clickedbutton == enterButton)
                              String nameString = name.getText(); // get textbox value
                              String ansString = ans.getText(); // get label value
                              if ((nameString.equals(ansString)) == true)
                                        sharkImage = new ImageIcon("pic/shark2.jpg");
                                        i = i++;
                                        String k = "" + i;
                                        label11.setText(k);
                              else
                                        label3.setLocation(getX() + 5 , getY());
                                        label.setText("error, please try again ");
//     EnterButton.addActionListener(new ActionListener(
//          public void actionPerformed(ActionEvent f)
//      EnterButton_actionPerformed(f);
     public void EnterButton_actionPerformed(ActionEvent f)
     String name = inputLine.getText(); // get textbox value
     String ans = labelinput.getText(); // get label value
     if (name.equalsTo(ans)) = true
          sharkImage= "deadshark";
          i = i +1;
          harpoon.setText(i);
     } else{
          shark.setLocation(getX() + 5 , getY());
          label.setText("error, please try again ");
     public static void main(String[] args)
               //Create and set up the window.
          JFrame frame = new JFrame("MAD HUNTER");
          frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
          frame.setContentPane(new TimerDemo3());
               frame.setSize(1024, 768);
               frame.setLocation(0, 0);
          //Display the window.
          frame.setVisible(true);      

Answer 1

I'm not a big fan of subclassing components so that you can implement interfaces.
Here are two reasons why it's a bad idea:
1. Generally, the types of an object are its surface area, its contract with the world, to mix
metaphors. If your panel subclass implements ActionListener that means that I'm allowed
to add it as a listener of some of my buttons, too? I don't think that's your design. That fact that
you need to implement ActionListeners is purely an implementation detail.
2. If an object is an ActionListener for different, unrelated reasons, you're forced to do a
case analysis in the actionPerformed method. I thought Lincoln freed all the slaves and that
OOP freed us from that kind of case analysis.
What should you do instead? Write separate classes that implement ActionListener. If
those classes are reusable or only loosely coupled to the panel, make them top level classes.
If they are inseparable from your panel, they can be inner classes.