Thread Contention Issue , Help !

Question

public class vipThread implements Runnable
private static volatile boolean lockMe=false;
public synchronized static boolean getLock ()
     return lockMe;
public synchronized static void setLock (boolean lock)
     lockMe = lock;
public void run ()
synchronized(this)
               if(!this.getLock ()) {
               this.setLock(true);
               ret = vipRequestProcessor.getNewRequests ();                         
               this.setLock(false);
getNewRequests is not a synchronized method. Do i need to have it synchronized ? i do have a thread contention issue here. Couple of threds pickup the same request fromt he database.
Help appreciated
thanks
pras

Answer 1

public class vipThread implements Runnable
private static volatile boolean lockMe=false;
public synchronized static boolean getLock ()
return lockMe;
public synchronized static void setLock (boolean
an lock)
lockMe = lock;
public void run ()
synchronized(this)
if(!this.getLock ()) {
this.setLock(true);
ret = vipRequestProcessor.getNewRequests ();
this.setLock(false);
getNewRequests is not a synchronized method. Do i need
to have it synchronized ? i do have a thread
contention issue here. Couple of threds pickup the
same request fromt he database.
Help appreciated
thanks
prasIf the "getNewRequests() method is only called from your vipThread, then you don't have thread contention problem.