Time Out error problem when i run the report for the whole plant

Question

Dear all,
pls find the below coding, when i execute this report for the whole plant , it gives me time out error since it has to process huge database. pls suggest me in which part of my below coding i can improvise or any other better way to fetch the same result.
pls note that
i m using Views for querying.pls also note the comments given in Bold to understand the reason behind the coding.
Views used in are - ZVPOD and ZVPRDCONF.
START-OF-SELECTION.
  Data: zstat type jest-stat.
  data: stklocaf type mska-lgort.
  data: stklocas type mska-lgort.
<u><b>To collect the status of the production order by joining the ZVPOD and JEST table.</b></u>
  CLEAR it_ZVPRODDET.
  SELECT DISTINCT ZVPOD~bukrs ZVPOD~aufnr ZVPOD~objnr
  jest~stat ZVPOD~werks ZVPOD~arbpl ZVPOD~J_3AKORD2
  FROM  ZVPOD
  INNER JOIN jest ON ZVPOD~objnr = jest~objnr
  INTO CORRESPONDING FIELDS OF wa_ZVPRODDET where
  plnbez in FGM and arbpl in wc and werks in plant
  and SSAVD in eldate
  and J_3AKORD2 in cups and jest~inact ne 'X'.
    APPEND wa_ZVPRODDET TO it_ZVPRODDET.
  ENDSELECT.
  SORT it_ZVPRODDET BY aufnr stat.
<u><b>Loop thru Itab to check and delete the records from itab for the specified status.</b></u>
  LOOP AT it_ZVPRODDET INTO wa_ZVPRODDET.
    IF wa_ZVPRODDET-stat = 'I0045' .  " TECO - compl
      DELETE it_ZVPRODDET WHERE aufnr = wa_ZVPRODDET-aufnr.
    ELSEIF wa_ZVPRODDET-stat = 'I0009' .  " CNF - Confirmed
      DELETE it_ZVPRODDET WHERE aufnr = wa_ZVPRODDET-aufnr.
    ELSEIF wa_ZVPRODDET-stat = 'I0012' .  " DLV - Delivered
      DELETE it_ZVPRODDET WHERE aufnr = wa_ZVPRODDET-aufnr.
    ELSEIF wa_ZVPRODDET-stat = 'I0046' .  " CLSD - Closed
      DELETE it_ZVPRODDET WHERE aufnr = wa_ZVPRODDET-aufnr.
    ELSEIF wa_ZVPRODDET-stat = 'I0076' .  " DLFL - Del Flag
      DELETE it_ZVPRODDET WHERE aufnr = wa_ZVPRODDET-aufnr.
    ELSEIF wa_ZVPRODDET-stat = 'E0003' .  " SCLS - Short Close
      CLEAR tj30t.
      SELECT SINGLE txt04
      FROM tj30t INTO tj30t-txt04
      WHERE stsma = 'PRDHOLD' AND
            estat = 'E0003' AND
            txt04 = 'SCLS' AND
            spras = 'EN'.
      IF sy-subrc = 0.
        DELETE it_ZVPRODDET WHERE aufnr = wa_ZVPRODDET-aufnr.
      ENDIF.
    ENDIF.
*      Condition for Prod Order released - REL
    IF wa_ZVPRODDET-stat = 'I0002'.
      mreleased = 'Y'.
    else.
      mreleased = 'N'.
    endif.
    zstat = wa_ZVPRODDET-stat.
    IF mreleased = 'N'.
      DELETE it_ZVPRODDET WHERE aufnr = wa_ZVPRODDET-aufnr
      and stat = zstat.
    ENDIF.
  ENDLOOP.
<u><b>Loop thru the filtered ITAB to get all the production order details for the production order number specified in the where clause( zaufnr ) and populate another internal table.</b></u>
      LOOP AT it_ZVPRODDET INTO wa_ZVPRODDET.
        zaufnr = wa_zvproddet-aufnr.
        zarbid = wa_zvproddet-arbid.
        at new aufnr.
          SELECT DISTINCT * INTO CORRESPONDING FIELDS OF  walnpln
          FROM zvpod where plnbez in FGM and arbpl in wc and SSAVD in
         eldate and werks in plant and J_3AKORD2 in cups and aufnr = zaufnr.
            APPEND walnpln TO itablnpln.
          endselect.
        endat.
      endloop.
      clear walnpln.
<u><b>
Looping thru Internal table and performs all the following calculations and inner loop
and also relevant querying.</b></u>
<u><b>Assume that ITABLNPLN holds appox. 8000 records.</b></u>
LOOP AT itablnpln  INTO walnpln.
        contot = 0.
        SELECT distinct * INTO CORRESPONDING FIELDS OF TABLE itablnp
        FROM zvprdconf where aufnr = walnpln-aufnr and
        j_3asize = walnpln-j_3akordx and stzhl ne '2' and stokz ne 'X'.
        clear zvprdconf.
        SELECT single isdd
        FROM zvprdconf into  zvprdconf-isdd
        where aufnr = walnpln-aufnr and
        j_3asize = walnpln-j_3akordx and stzhl ne '2' and stokz ne 'X'.
        SELECT single isdz
        FROM zvprdconf into  zvprdconf-isdz
        where aufnr = walnpln-aufnr and
        j_3asize = walnpln-j_3akordx and stzhl ne '2' and stokz ne 'X'.
        IF sy-subrc EQ 0.
          <u><b>Assume that ITABLNP  holds appox. 30 records.</b></u>
          loop at itablnp into walnp.
            contot = contot + walnp-J_3ALMNGA.
            move walnp-J_3ASIZE to walnpln-J_3ASIZE.
            move zvprdconf-isdd to walnpln-zdate.
            move zvprdconf-isdz to walnpln-ztime.
          endloop.
          walnpln-output = contot.
        endif.
        walnpln-wip = walnpln-menge - contot.
        if walnpln-werks = '1000'.
          stklocaf = '1050'.
          stklocas = '1060'.
        elseif walnpln-werks = '2000'.
          stklocaf = '2150'.
          stklocas = '2160'.
        endif.
       select single kunnr into walnpln-ship from vbpa where
       vbeln = walnpln-KDAUF and PARVW = 'WE'.
        zship = walnpln-ship.
        move zship to walnpln-ship.
        select  single kalab into walnpln-zactqty from mska
        where matnr = walnpln-plnbez
        and j_3asize = walnpln-J_3AKORDX and LGORT = stklocaf.
        condense walnpln-kdauf.
        zsales = walnpln-kdauf.
        concatenate zsales 'S' into zso.
        select single kalab into walnpln-zsndqty from mska
        where matnr = walnpln-plnbez
        and j_3asize = walnpln-J_3AKORDX and LGORT = stklocas
        and J_4KSCAT = zso.
        zmatn = walnpln-plnbez.
        zsale = walnpln-KDAUF.
        walnpln-kdauf = zsale.
        walnpln-plnbez = zmatn.
        zcust = walnpln-kunnr.
        walnpln-kunnr = zcust.
        select single bezei into walnpln-season from TVV2T where
        kvgr2 = walnpln-kvgr2 and SPRAS = 'E'.
        select single bezei into walnpln-shipmode from T173T where
        vsart = walnpln-vsart and SPRAS = 'E'.
        STRL = strlen( walnpln-j_3akord2 ).
        if  strl = 4.
          move walnpln-j_3akord2 to walnpln-j_3akord3.
          clear walnpln-j_3akord2.
        endif.
        move zremk to walnpln-remk.
        MODIFY itablnpln FROM  walnpln.
        contot = 0.
        clear itablnp.
      ENDLOOP.
      PERFORM build_fieldcatalog.
      PERFORM build_layout.
      PERFORM display_alv_report.

Answer 1

Hi raja,
Plese go through the suggessitions.
1.avoide the select ...endselect. write the below select
CLEAR IT_ZVPRODDET.
SELECT DISTINCT
     ZVPOD~BUKRS
     ZVPOD~AUFNR
     ZVPOD~OBJNR
     JEST~STAT
     ZVPOD~WERKS
     ZVPOD~ARBPL
     ZVPOD~J_3AKORD2
  FROM ZVPOD
  INNER JOIN JEST ON ZVPOD~OBJNR = JEST~OBJNR
  INTO CORRESPONDING FIELDS TABLE  IT_ZVPRODDET
  WHERE PLNBEZ IN FGM AND
        ARBPL IN WC AND
        WERKS IN PLANT AND
        SSAVD IN ELDATE AND
        J_3AKORD2 IN CUPS AND
        JEST~INACT NE 'X'.
  IF SY-SUBRC = 0.
    SORT TABLE IT_ZVPRODDET.
  ENDIF.
2..first of all dont delete a record inside the loop. instead use the Field symobols.
have u obsereved you code in the loop!!!!. wht u r doing..
u r removing the same record which u in the loop..
If u wanto delete the entires with check to<b> stat</b>... <b>then.. why dont u put the STAT field in Wher e condition..?</b> by this you reduce the data base select time..
Now the select query is like the below....
CLEAR IT_ZVPRODDET.
SELECT DISTINCT
     ZVPOD~BUKRS
     ZVPOD~AUFNR
     ZVPOD~OBJNR
     JEST~STAT
     ZVPOD~WERKS
     ZVPOD~ARBPL
     ZVPOD~J_3AKORD2
  FROM ZVPOD
  INNER JOIN JEST ON ZVPOD~OBJNR = JEST~OBJNR
  INTO CORRESPONDING FIELDS TABLE  IT_ZVPRODDET
  WHERE PLNBEZ IN FGM AND
        ARBPL IN WC AND
        WERKS IN PLANT AND
        SSAVD IN ELDATE AND
        J_3AKORD2 IN CUPS AND
        JEST~INACT NE 'X' AND
        ( STAT <> 'I0045' AND
          STAT <> 'I0045' AND
          STAT <> 'I0009' AND
          STAT <> 'I0012' AND
          STAT <> 'I0046' AND
          STAT <> 'I0076' AND
          STAT <> 'E0003' ).
  IF SY-SUBRC = 0.
    SORT TABLE IT_ZVPRODDET.
  ENDIF.
<b>3.</b> WHT IS MEANING OF THE SELECT
<b>  CLEAR TJ30T.
  SELECT SINGLE TXT04
  FROM TJ30T INTO TJ30T-TXT04
  WHERE STSMA = 'PRDHOLD' AND
        ESTAT = 'E0003' AND
        TXT04 = 'SCLS' AND
        SPRAS = 'EN'.
  IF SY-SUBRC = 0.
    DELETE IT_ZVPRODDET WHERE AUFNR = WA_ZVPRODDET-AUFNR.
  ENDIF.</b>....... IN WHERE CONDION U R GIven all are constant values right?..
why u need select it inside the loop.. u can write before the SELECT from ZVPOD..
that why first checke this field then go for fur thure selects..
<b>now u r code looks like this....</b>
CLEAR TJ30T.
SELECT SINGLE TXT04
  FROM TJ30T INTO TJ30T-TXT04
WHERE STSMA = 'PRDHOLD' AND
      ESTAT = 'E0003' AND
      TXT04 = 'SCLS' AND
      SPRAS = 'EN'.
IF SY-SUBRC = 0.
  CLEAR IT_ZVPRODDET.
  SELECT DISTINCT
       ZVPOD~BUKRS
       ZVPOD~AUFNR
       ZVPOD~OBJNR
       JEST~STAT
       ZVPOD~WERKS
       ZVPOD~ARBPL
       ZVPOD~J_3AKORD2
    FROM ZVPOD
    INNER JOIN JEST ON ZVPOD~OBJNR = JEST~OBJNR
    INTO CORRESPONDING FIELDS TABLE  IT_ZVPRODDET
    WHERE PLNBEZ IN FGM AND
          ARBPL IN WC AND
          WERKS IN PLANT AND
          SSAVD IN ELDATE AND
          J_3AKORD2 IN CUPS AND
          JEST~INACT NE 'X' AND
          JEST~STAT <> 'I0045' AND
          JEST~STAT <> 'I0045' AND
          JEST~STAT <> 'I0009' AND
          JEST~STAT <> 'I0012' AND
          JEST~STAT <> 'I0046' AND
          JEST~STAT <> 'I0076' AND
          JEST~STAT <> 'E0003' ).
    IF SY-SUBRC = 0.
      SORT TABLE IT_ZVPRODDET.
    ENDIF.
  ENDIF.
there are so many select inside the loop...... please Delete all of them.... write them be for the loop.......using the FOR ALL ENTRIES.....
THEN LOOP THE TABLE USING THE WHERE CONDITIONS.
<b>Plese write u updated code here again</b>..