Transfer of records

Question

I need some recored to be transfers
and my procedures take care of it.. now if there is an errors the counter bumps upp..
What my problem is that. the ocunter bumps up for just one record and it is not going on to the second record.. insed it exits..
I believe there is a prblem in the Exception hadeling section.. If soem can helo me figure out.. how I can write it soo it will go on to the other records bump up the counter if necessary..
followin is my Procedure
Create or Replace Procedure appmstansfer IS
Cursor C1 is
Select * from appms_mri_errors;
lv_cntr Number(2);
err_code_current NUMBER := SQLCODE;
err_msg_current VARCHAR2(60):= SUBSTR(SQLERRM,1,60);
insert_failure Exception;
lv_val appms_mri_errors.barcode%type;
lv_new_val appms_mri_errors.barcode%type;
lv_err_record Number(4);
Begin
Select count (*)
Into lv_err_record
from appms_mri_errors;
If lv_err_record > 0 then
For my_rec in C1
Loop
DBMS_OUTPUT.PUT_LINE('1');
lv_val := my_rec.barcode;
Insert into appmslog
(ROWSTAMP, KEYNUM, ERRORMSG, DESCRIPTION, TRANSDATE, STATUS,
STATUSDATE, BARCODE, FOA, HRHNUM, HRHNAME, CHANGEBY,
CHANGEDATE, NSN, ACQDATE, ACQCOST, DISPOSITIONCODE,
SERIALNUM, LOCATION, ROOMNUM, PRNUM, VENDOR,
MANUFACTURER, PARTNUM, MODELNUM, ECC, EIC, EUMPCODE,
APPMSLOG01, APPMSLOG02, APPMSLOG03, APPMSLOG04,
APPMSLOG05, APPMSLOG06, APPMSLOG07, APPMSLOG08,
APPMSLOG09, APPMSLOG10, LDKEY)
Values
(my_rec.ROWSTAMP, my_rec.KEYNUM, my_rec.ERRORMSG,
my_rec.DESCRIPTION, my_rec.TRANSDATE, my_rec.STATUS,
my_rec.STATUSDATE, my_rec.BARCODE, my_rec.FOA,
my_rec.HRHNUM, my_rec.HRHNAME, my_rec.CHANGEBY,
my_rec.CHANGEDATE, my_rec.NSN, my_rec.ACQDATE,
1200000000000, my_rec.DISPOSITIONCODE,
my_rec.SERIALNUM, my_rec.LOCATION, my_rec.ROOMNUM,
my_rec.PRNUM, my_rec.VENDOR, my_rec.MANUFACTURER,
my_rec.PARTNUM, my_rec.MODELNUM, my_rec.ECC,
my_rec.EIC, my_rec.EUMPCODE, my_rec.APPMSLOG01,
my_rec.APPMSLOG02, my_rec.APPMSLOG03, my_rec.APPMSLOG04,
my_rec.APPMSLOG05, my_rec.APPMSLOG06,
my_rec.APPMSLOG07, my_rec.APPMSLOG08, my_rec.APPMSLOG09,
my_rec.APPMSLOG10, my_rec.LDKEY);
Commit;
Select barcode
Into lv_new_val
from appmslog
where barcode = my_rec.barcode;
If lv_new_val = my_rec.barcode then
Delete from appms_mri_errors
where barcode = lv_new_val;
Else
raise insert_failure;
End if;
DBMS_OUTPUT.PUT_LINE('2');
Commit;
End Loop;
end if;
EXCEPTION
WHEN insert_failure then
Select reconcile_attempt_cntr
Into lv_cntr
from appms_mri_errors
where barcode = lv_val;
Update appms_mri_errors
Set
Error_Code_Current = err_code_current,
Error_Text_Current = err_msg_current,
Reconcile_Attempt_CNTR = lv_cntr + 1,
Failuredate_Current = Sysdate
where barcode = lv_val;
When others then
Select reconcile_attempt_cntr
Into lv_cntr
from appms_mri_errors
where barcode = lv_val;
Update appms_mri_errors
Set
Error_Code_Current = err_code_current,
Error_Text_Current = err_msg_current,
Reconcile_Attempt_CNTR = lv_cntr + 1,
Failuredate_Current = Sysdate
where barcode = lv_val;
DBMS_OUTPUT.PUT_LINE('3');
Commit;
END;

Answer 1

After a procedure goes to the exception section, the block terminates. It will not resume processing the cursor within your loop. So, try to handle everything that you can within the loop. For example, to move the insert_failure from the exception section to within the loop:
Create or Replace Procedure appmstansfer
IS
Cursor C1
is
Select *
from appms_mri_errors;
lv_cntr Number(2);
err_code_current NUMBER := SQLCODE;
err_msg_current VARCHAR2(60) := SUBSTR(SQLERRM,1,60);
lv_val appms_mri_errors.barcode%type;
lv_new_val appms_mri_errors.barcode%type;
lv_err_record Number(4);
Begin
Select count (*)
Into lv_err_record
from appms_mri_errors;
If lv_err_record > 0
then
For my_rec in C1
Loop
DBMS_OUTPUT.PUT_LINE('1');
lv_val := my_rec.barcode;
Insert into appmslog
(ROWSTAMP, KEYNUM, ERRORMSG, DESCRIPTION, TRANSDATE, STATUS,
STATUSDATE, BARCODE, FOA, HRHNUM, HRHNAME, CHANGEBY,
CHANGEDATE, NSN, ACQDATE, ACQCOST, DISPOSITIONCODE,
SERIALNUM, LOCATION, ROOMNUM, PRNUM, VENDOR,
MANUFACTURER, PARTNUM, MODELNUM, ECC, EIC, EUMPCODE,
APPMSLOG01, APPMSLOG02, APPMSLOG03, APPMSLOG04,
APPMSLOG05, APPMSLOG06, APPMSLOG07, APPMSLOG08,
APPMSLOG09, APPMSLOG10, LDKEY)
Values
(my_rec.ROWSTAMP, my_rec.KEYNUM, my_rec.ERRORMSG,
my_rec.DESCRIPTION, my_rec.TRANSDATE, my_rec.STATUS,
my_rec.STATUSDATE, my_rec.BARCODE, my_rec.FOA,
my_rec.HRHNUM, my_rec.HRHNAME, my_rec.CHANGEBY,
my_rec.CHANGEDATE, my_rec.NSN, my_rec.ACQDATE,
1200000000000, my_rec.DISPOSITIONCODE,
my_rec.SERIALNUM, my_rec.LOCATION, my_rec.ROOMNUM,
my_rec.PRNUM, my_rec.VENDOR, my_rec.MANUFACTURER,
my_rec.PARTNUM, my_rec.MODELNUM, my_rec.ECC,
my_rec.EIC, my_rec.EUMPCODE, my_rec.APPMSLOG01,
my_rec.APPMSLOG02, my_rec.APPMSLOG03, my_rec.APPMSLOG04,
my_rec.APPMSLOG05, my_rec.APPMSLOG06,
my_rec.APPMSLOG07, my_rec.APPMSLOG08, my_rec.APPMSLOG09,
my_rec.APPMSLOG10, my_rec.LDKEY);
Commit;
Select barcode
Into lv_new_val
from appmslog
where barcode = my_rec.barcode;
If lv_new_val = my_rec.barcode
then
Delete from appms_mri_errors
where barcode = lv_new_val;
Else
Select reconcile_attempt_cntr
Into lv_cntr
from appms_mri_errors
where barcode = lv_val;
Update appms_mri_errors
Set Error_Code_Current = err_code_current,
Error_Text_Current = err_msg_current,
Reconcile_Attempt_CNTR = lv_cntr + 1,
Failuredate_Current = Sysdate
where barcode = lv_val;
End if;
DBMS_OUTPUT.PUT_LINE('2');
Commit;
End Loop;
end if;
EXCEPTION
When others then
Select reconcile_attempt_cntr
Into lv_cntr
from appms_mri_errors
where barcode = lv_val;
Update appms_mri_errors
Set Error_Code_Current = err_code_current,
Error_Text_Current = err_msg_current,
Reconcile_Attempt_CNTR = lv_cntr + 1,
Failuredate_Current = Sysdate
where barcode = lv_val;
DBMS_OUTPUT.PUT_LINE('3');
Commit;
END;
null