Trouble looping

Question

Hi, I've been given a crash course in java but now have to complete a random shapes program and I have 2 main problems - I've managed to create an infinite loop and I appear to expect two entries of shape name instead of one. I'm baffled and have been staring at this for ten hours - at this stage I think I'm making it worse. Any help would be greatly appreciated.
import java.util.Random;
import java.lang.*;
public class Tester {
  private static RandomShapeGenerator gen = new RandomShapeGenerator();
  public static void printMenu(){
       System.out.println("Please choose one of the following options ");
       System.out.println("1. Show shapes details                     ");
       System.out.println("2. Modify shape dimensions                 ");
       System.out.println("3. Modify shape colour                 ");
       System.out.println("4. Move shape to a location                 ");
       System.out.println("5. Exit                           ");
       System.out.println("*******************************************");
  public static String checkTypeOfObject(Object obj){//instance of an object- review notes
     if (obj instanceof Circle)
          return "Circle";
    else if (obj instanceof Square)
         return "Square";
     else if(obj instanceof Rectangle)
          return "Rectangle";
    else if(obj instanceof Ellipse)
          return "Ellipse";
    else if(obj instanceof Triangle)
          return "Triangle";
     else
          return "";
     public static void main(String[] args) {
     boolean done = false;
     int userOption;
     System.out.println("*******************************************");
     System.out.println("**   Shape Project    **                   ");
     System.out.println("* Author:              *                   ");
     System.out.println("*******************************************");
     System.out.println("About to Create random Shapes... Please wait...\n\n");
         {     Shape[] s = new Shape[5];
    // Fill up the array with shapes:
    for (int i = 0; i < s.length; i++)
      s[i] = gen.next();
    // Make polymorphic method calls:
    for (int i = 0; i < s.length; i++)
      s.getMyDetails();
while(!done){System.out.println("Please Enter name of shape you wish to modify or view: ");
    String shapeName=Console.readString();
       Shape shapeToModify;
    boolean found =false;
         if(!found)
     System.out.println("**   Shape NOT Found   **");
   for (int j=0; j < s.length; j++){
      shapeToModify =s[j];
shapeName = shapeToModify.getName();
     if(shapeName.equalsIgnoreCase(shapeName.trim())){
          System.out.println("** Shape Found **");
          found =true;
     printMenu();
          userOption = Console.readInt();
     //try{
          if (userOption == 5)
               done = true;
{ System.out.println("**   Exiting... **");     
               System.out.println("** Goodbye **");
               if(userOption == 1)
               { shapeToModify.getMyDetails();
          else if (userOption == 2)      
     { if(checkTypeOfObject(shapeToModify).equals("Circle"))
     {System.out.print("Please enter the radius: ");
                double Input = Console.readDouble();
                Circle circle1 =(Circle)shapeToModify;
                 circle1.setRadius(Input);
                 System.out.print("Sucessfully changed dimensions of circle : Details are ..\n ");
                circle1.getMyDetails();
                userOption = 0;
     if(checkTypeOfObject(shapeToModify).equals("Square"))
     {System.out.print("Please enter the length: ");
                 Double length = Console.readDouble();
                 //System.out.print("Please enter the width: ");
                 //String width = Console.readDouble();
                Square square1 =(Square)shapeToModify;
                 square1.setLength(length);
                 //square1.setWidth((new Double(width).doubleValue()));
                 System.out.print("Sucessfully changed dimensions of square : Details are ..\n ");
                 square1.getMyDetails();
     if(checkTypeOfObject(shapeToModify).equals("Rectangle"))
     {System.out.print("Please enter the length: ");
                 Double length = Console.readDouble();
                 System.out.print("Please enter the width: ");
                 Double width = Console.readDouble();
                Rectangle rectangle1 =(Rectangle)shapeToModify;
                 rectangle1.setwidth(length);
                 rectangle1.setHeight(width);
                 System.out.print("Sucessfully changed dimensions of rectangle : Details are ..\n ");
                 rectangle1.getMyDetails();
     if(checkTypeOfObject(shapeToModify).equals("Triangle"))
     {System.out.print("Please enter the length: ");
                 Double length = Console.readDouble();
                 System.out.print("Please enter the height: ");
                 Double height = Console.readDouble();
                 System.out.print("Please enter the width: ");
                 Double width = Console.readDouble();
                Triangle triangle1 =(Triangle)shapeToModify;
                 triangle1.setLength(length);
                 triangle1.setHeight(height);
                 triangle1.setWidth(width);     
                 System.out.print("Sucessfully changed dimensions of triangle : Details are ..\n ");
                 triangle1.getMyDetails();
     if(checkTypeOfObject(shapeToModify).equals("Ellipse"))
     {System.out.print("Please enter the MajorAxis: ");
                 Double semiMajorAxis = Console.readDouble();
                 System.out.print("Please enter the MinorAxis: ");
                 Double semiMinorAxis = Console.readDouble();
                Ellipse ellipse1 =(Ellipse)shapeToModify;
                 ellipse1.setSemiMajorAxis(semiMajorAxis);
                 ellipse1.setSemiMinorAxis(semiMinorAxis);
                 System.out.print("Sucessfully changed dimensions of triangle : Details are ..\n ");
                 ellipse1.getMyDetails();
          else if (userOption == 3)
          { System.out.print("Please enter a colour: ");      
               String colour = Console.readString();
          shapeToModify.setColour(colour.trim());
          System.out.print("Sucessfully changed dimensions : Details are ..\n ");
     shapeToModify.getMyDetails();
          else if (userOption == 4)
               System.out.print("Please enter the xCooridinate: ");
     int x = Console.readInt();
     System.out.print("Please enter the yCoordinate: ");
     int y = Console.readInt();
     Coordinate coordinate =shapeToModify.getLocation();
     coordinate.setXCoOrdinate(x);
          coordinate.setYCoOrdinate(y);
          System.out.print("Sucessfully changed coordinate : Details are ..\n ");
     shapeToModify.getMyDetails();
          else if ((1 < userOption) | (userOption > 5));
          { System.out.println("Sorry, that is not a valid value. Please try again.");
/*catch(Exception ex)
          System.out.println("ERROR - Exiting....");     }
class RandomShapeGenerator {
private Random rand = new Random();
private String[] names =new String[]{"Shape1","Shape2","Shape3","Shape4","Shape5"};
private String[] colours =new String[]{"white","red","indigo","black","purple"};
private double[] widthArray =new double[]{10.00,11.00,12.00,13.00,14.00,15.00};
private double[] heightArray =new double[]{10.00,11.00,12.00,13.00,14.00,15.00};
private double[] lengthArray =new double[]{10.00,11.00,12.00,13.00,14.00,15.00};
private double[] radiusArray =new double[]{10.00,11.00,12.00,13.00,14.00,15.00};
private double[] majorAxisArray =new double[]{10.00,11.00,12.00,13.00,14.00,15.00};
private double[] minorAxisArray =new double[]{10.00,11.00,12.00,13.00,14.00,15.00};
public Shape next() {
     switch (rand.nextInt(5)) {
     default:
     case 0:
     return new Circle(radiusArray[2],names[5],colours[3],new Coordinate(0,0));
     case 1:
     return new Square(lengthArray[1], widthArray[2],names[1],colours[1],new Coordinate(0,0));
     case 2:
     return new Triangle(lengthArray[2],heightArray[2],widthArray[3],names[2],colours[2],new Coordinate(0,0));
     case 3:
          return new Rectangle (lengthArray[3],heightArray[3],names[0],colours[0],new Coordinate(0,0));
     case 4:
     return new Ellipse (majorAxisArray[4],minorAxisArray[4],names[4],colours[4],new Coordinate(0,0));

Answer 1

I can't seem to duplicate the read error but this will show you what I mean about the shape name. The array that creates shapes calls them "Shape1" to "Shape5". This says 'shape found' for anything you type in. I'm sure I'm doing something silly but I can't see it.
public class errors {
private static RandomShapeGenerator gen = new RandomShapeGenerator();
     public static void main(String[] args) {
     boolean done = false;
     int userOption;
         {     Shape[] s = new Shape[5];
    // Fill up the array with shapes:
    for (int i = 0; i < s.length; i++)
      s[i] = gen.next();
    // Make polymorphic method calls:
    for (int i = 0; i < s.length; i++)
      s.getMyDetails();
{System.out.println("Please Enter name of shape you wish to modify or view: ");
    String shapeName=Console.readString();
       Shape shapeToModify;
    boolean found =false;
    //     if(!found)
   for (int j=0; j < s.length; j++){
      shapeToModify =s[j];
shapeName = shapeToModify.getName();
     if(shapeName.equalsIgnoreCase(shapeName.trim())){
          System.out.println("** Shape Found **");
          found =true;}
          else {System.out.println("**   Shape NOT Found   **");
               break;}
     printMenu();
          userOption = Console.readInt();
               if(userOption == 1)
               { shapeToModify.getMyDetails();