Unable to update the values from store procedure

Question

hi ,
I have simple table with 3 columns. id, name , sal. am updating the salary based on names. 
alter PROCEDURE p1(@names varchar(100))
AS
BEGIN
declare @empData varchar(200)
set @empData= '''' + replace(@names,',',''',''')+''''
print @empData
update tmp set sal =10 where name in ( @empData )
END
GO
if I execute same query (update tmp set sal =10 where name in ( @empData )) outside with printed @empData data it is working fine.
why the same is not working with SP ?
any ideas...

Answer 1

You need to split the list into a temporary table or table valued variable:
alter PROCEDURE p1(@names varchar(100))
AS
BEGIN
declare @empTable table ([name] varchar(100));
declare @p int = 1;
declare @len int = len(@names);
declare @nextP int = charindex(',', @name, @p) ;
set @nextP = case when @nextP = 0 then @len else @nextP end;
while @p < @len
begin
insert into @empTable
values (substring(@names, @p, @nextP-1));
set @p = @nextP + 1;
Set @nextP int = charindex(',', @name, @p) ;
set @nextP = case when @nextP = 0 then @len else @nextP
end
update tmp
set sal =10
where name in (Select [name] from @empTable );
END
GO
Russel Loski, MCT, MCSE Data Platform/Business Intelligence. Twitter: @sqlmovers; blog: www.sqlmovers.com