Update Con Inner Join

haber tengo una duda, existe en oracle los Inner join, si existen me podrian decir cual es el error en este update
me envia este codigo de oracle
ORA-00933: SQL command not properly ended
Código HTML:
UPDATE NOTAS SET C5=0, P5=0, C6=0, P6=0, C7=0, P7=0, C8=0, P8=0, C9=0, P9=0, C10=0, P10=0, C11=0, P11=0, C12=0, P12=0, C13=0, P13=0, C14=0, P14=0, C15=0, P15=0, EX3=0, PEX3=0, P1=0, GLOSA_C1='SIN COMENTARIO', P2=0, GLOSA_C2='SIN COMENTARIO', P3=0, GLOSA_C3='SIN COMENTARIO', P4=0, GLOSA_C4='SIN COMENTARIO', PEX1=0, GLOSA_EX1='SIN COMENTARIO', PEX2=0, GLOSA_EX2='SIN COMENTARIO', CANT_NOTAS=4, CANT_EXAMENES=2 INNER JOIN DETALLE_ASIGNACION_ALUMNO ON(DETALLE_ASIGNACION_ALUMNO.ID_ALUMNO=ALUMNO.ID_ALUMNO) INNER JOIN NOTAS ON(DETALLE_ASIGNACION_ALUMNO.ID_ALUMNO=NOTAS.ID_ALUMNO) WHERE DETALLE_ASIGNACION_ALUMNO.ID_DETALLE_ALUMNO='1' AND NOTAS.ID_ASIGNATURA='2'
grax por la ayuda
Responder Con Cita

Check from the INNER JOIN.

Similar Messages

MS Access Update Inner Join command conversion

I have code in a Microsoft Access Database View, that I'm trying to convert to Oracle. I tried using Oracle SQL Developer's Migration tool and it basically skipped this command.
Update Table1 INNER JOIN Table2 On Table1.COL1 = Table2.COL2 SET Table1.COL3 = 1;
I've tried a number of things including selecting all the rows with something like
select * from Table1 o inner join Table2 t on o.COL1 = t.COL2
and then trying to somehow hook it to an update command where the command gets the above results and does a Table1.COL3 = 1 on all of those rows.
However I can't get the syntax correct.
Can someone please help?
Thanks,
Jeff
BTW: The code is in a MS Access view but probably belongs in a stored procedure. It also uses a Access-only Boolean instead of 1, which may be part of the reason the command conversion failed.

maybe this?
Update Table1
   set Table1.COL3 = 1
Where Table1.col1 in (select table2.col2 from table2);
or
Update Table1
   set Table1.COL3 = 1
Where exists (select 'x'
                 from table2
                where table2.col2 = table1.col1);note: untested.

Syntax errors in update query with inner joins and sub query.

Below is the query:
UPDATE sp_CFQ_Coord_Corrections
INNER JOIN (CFQ_Coord_Corrections
INNER JOIN CFQ_Referrals ON CFQ_Coord_Corrections.CorrID = CFQ_Referrals.RecID)
ON sp_CFQ_Coord_Corrections.ID = CFQ_Referrals.RecID
SET CFQ_Coord_Corrections.MatchFound = 1,
CFQ_Coord_Corrections.RecTblID = [CFQ_Referrals].[RecTblID],
sp_CFQ_Coord_Corrections.MatchFound = 1
WHERE (((CFQ_Coord_Corrections.MatchFound)=0)
AND ((sp_CFQ_Coord_Corrections.MatchFound)=0)
AND ((CFQ_Coord_Corrections.RecImported)=1)
AND ((CFQ_Referrals.RecFileName)='COORDCORR_SPOINT')
AND ((CFQ_Referrals.RecCombKey)='No.Match')
AND ((sp_CFQ_Coord_Corrections.RecImported)=1));
Error messages seen when executed:
Msg 156, Level 15, State 1, Line 3
Incorrect syntax near the keyword 'INNER'.
Msg 102, Level 15, State 1, Line 10
Incorrect syntax near 'CFQ_Coord_Corrections'.
Please help.....

Below is the query:
UPDATE sp_CFQ_Coord_Corrections
INNER JOIN (CFQ_Coord_Corrections
INNER JOIN CFQ_Referrals ON CFQ_Coord_Corrections.CorrID = CFQ_Referrals.RecID)
ON sp_CFQ_Coord_Corrections.ID = CFQ_Referrals.RecID
SET CFQ_Coord_Corrections.MatchFound = 1,
CFQ_Coord_Corrections.RecTblID = [CFQ_Referrals].[RecTblID],
sp_CFQ_Coord_Corrections.MatchFound = 1
WHERE (((CFQ_Coord_Corrections.MatchFound)=0)
AND ((sp_CFQ_Coord_Corrections.MatchFound)=0)
AND ((CFQ_Coord_Corrections.RecImported)=1)
AND ((CFQ_Referrals.RecFileName)='COORDCORR_SPOINT')
AND ((CFQ_Referrals.RecCombKey)='No.Match')
AND ((sp_CFQ_Coord_Corrections.RecImported)=1));
Error messages seen when executed:
Msg 156, Level 15, State 1, Line 3
Incorrect syntax near the keyword 'INNER'.
Msg 102, Level 15, State 1, Line 10
Incorrect syntax near 'CFQ_Coord_Corrections'.
Please help.....
sp_CFQ_Coord_Corrections is a table and not a stored procedure.
are these both tables "sp_CFQ_Coord_Corrections" and "CFQ_Coord_Corrections" different ??

QUESTION INNER JOIN FOR UPDATE

Dear All,
does oracle support this sql update statement?
UPDATE Tb1 INNER JOIN Tb2 ON Tb1.empid = Tb2.empid2 SET
Tb2.salary = Tb1.salary * 0.5
Best Regards
Terence Chua

No - because you are trying to update the salary in Tb2
in an update statement for TB1
If you are trying to update the salary in T1 based on the salary in T2, use the following
UPDATE Tb1
set Tb1.salary = (
select TB2.salary * 0.5
from TB2
where TB2.empid2 = TB1.empid
However, I am wondering if you have your model confused.
Can you please confirm that you have two separate tables.
TB1 has column EMPID
TB2 has column EMPID2
or - are TB1 and TB2 the same table
If they are the same table - please confirm if you have one EMPID column - or an EMPID column and an EMPID2 columns.

About a question using Update ... inner join ?

select *
FROM a
INNER JOIN b ON a.ProductID=b.ProductID
WHERE a.HeadID='000246'
this statement is ok ;
But the following statement does not work ! Why ?
UPDATE a SET
a.Quantity=a.PurchaseQuantity/b.ConversionGene
FROM a
INNER JOIN b ON a.ProductID=b.ProductID
WHERE a.HeadID='000246'

"Because Oracle syntactically does not support that type of construct..." Is a correct statement, but not because "It expects only one table in UPDATE statement". The synatax for an updateable join in Oracle requires a "proper" in-line view to be updated.
As long as the table joined (in my example t1) has a declared unique constraint on the columns used to join by (in my example id), you can do it like:
SQL> SELECT * FROM t;
        ID DESCR
         1 One
         2 Two
         3 Three
SQL> SELECT * FROM t1;
        ID DESCR2
         1 Un
         2 Deux
SQL> UPDATE (SELECT t.descr, t1.descr2
2          FROM t
3             JOIN t1 ON t.id = t1.id)
4 SET descr = descr2;
2 rows updated.
SQL> SELECT * FROM t;
        ID DESCR
         1 Un
         2 Deux
         3 ThreeTTFN
John

Update Query with Inner Joins

Dear Experts,
Update Employee set desicode = o.dcod from employee e inner join operator o on
e.employee_id = o.employe_id
waiting for suggestions,

The other thread from yesterday that Satyaki mentioned Update.
William:
The SQL Server syntax from the OP is their version of an updateable join view. One interesting quirk of the implementation is that it does not require a unique key in the joined table, and will not error even if there are multiple rows that could update a row in the main table. I am still trying to figure out how it decides which row to use for the update, or if it actually updates multiple times and last update wins.
John

Noob: failed attempt to update inner join

I'm attempting to update fields in joined tables bh and bhp, based on information contained in both. The updated fields are not the fields the tables are joined on. I'd expect that to fail but I can't figure out why what I'm trying to do fails. I've read elsewhere in this forum that you can't update views containing joins, and I suspect that's related to this problem, but don't have the experience to understand this better.
I can easily accomplish this update through Access linked by ODBC. What I can't do is write SQL script to do the same. I want to do that so the update can be scheduled with cron.
The tables are logs of having run production batches. batchhistory logs the details of the batch (run time, current status) and batchhistorypatient logs details specific to each affected customer. The tables are joined on batchname, starttime, and facility. The 'last' fields are in both tables but they're not a join field and the distinction is maintained with a fully-qualified field name.
Do I have to create some kind of intermediate view on the fly, and update that?
Thanks in advance for suggestions or referral to specific documentation and examples.
UPDATE HCS.BatchHistory BH INNER JOIN HCS.BatchHistoryCustomer BHC ON
BH.STARTTIME = BHC.STARTTIME AND
BH.BATCHNAME = BHC.BATCHNAME AND
BH.facility = BHC.facility
SET
BH.LAST = "Y",
BHC.LAST = "Y"
WHERE
BH.STATE="COMPLETE" AND
BH.DATEOFSERVICE)<GetDate() AND
BH.last="N" OR
BHC.last="N"
Edited by: Chris Cowles on Feb 16, 2009 11:18 AM. Changed
BHC.LAST = "Y",
BHC.LAST = "Y" to
BH.LAST = "Y",
BHC.LAST = "Y"
Please excuse my error.

Example data:
batchhistory
batchname, starttime, facility, dateofservice, state, last
north, 1/1/2009 0900, abc, 1/1/2009 0830, complete, N
north, 1/2/2009 0900, abc, 1/1/2009 0835, complete, N
north, 1/3/2009 0900, abc, 1/1/2009 0835, complete, Y
batchhistorycustomer
batchname, starttime, facility, customer, dateofservice, state, last
north, 1/1/2009 0900, abc, 0001, 1/1/2009 0830, complete, N
north, 1/1/2009 0900, abc, 0002, 1/1/2009 0830, complete, Y
north, 1/1/2009 0900, abc, 0003, 1/1/2009 0830, complete, Y
north, 1/2/2009 0900, abc, 0001, 1/1/2009 0835, complete, Y
north, 1/2/2009 0900, abc, 0002, 1/1/2009 0835, complete, Y
north, 1/2/2009 0900, abc, 0003, 1/1/2009 0835, complete, N
north, 1/3/2009 0900, abc, 0001, 1/1/2009 0835, complete, N
north, 1/3/2009 0900, abc, 0002, 1/1/2009 0835, complete, Y
north, 1/3/2009 0900, abc, 0003, 1/1/2009 0835, complete, N
batchhistory.last and batchhistorycustomer.last are independent.

Trying to convert SELECT query to Update query with INNER JOINS

Assalam O Alaikum!
I've tried to convert this query of mine but failed.
I wish to use it for update datasource in data GridView. I'm fetching data with it but converting it to update is not helping giving multiple errors.
I tried to share the pic but they don't let me do so. Its actually a gridView with check boxes. check the item and update it..
Here is the query. Please help me with that.
<pre>
SELECT [rightsId], [saveRights], [updateRights],
[viewRights], [deleteRights], [printRights],
[processRights], [verifyRights], [unProcessRights],
[unVerifyRights], CONVERT(VARCHAR(100),tblGroup.groupId)as groupId, convert(varchar(100),tblmenu.[menuId])as menuid
FROM [tblRights] inner join tblMenu ON
tblMenu.menuId=tblRights.menuId INNER JOIN
tblGroup ON tblGroup.groupId=tblRights.rightsId
</pre>

code is fine the above query works fine with the fetching(select) but when I try to write it with update it doesn't. Here is the asp code. I'm doing nothing with c# or vb.
<asp:GridView ID="GridView1" runat="server" AllowPaging="True"
            DataSourceID="ratGrid" AutoGenerateColumns="False"
            CssClass="GridViewStyle" Width="100%" AllowSorting="True" AutoGenerateEditButton="True" BackColor="#DEBA84" BorderColor="#DEBA84" BorderStyle="None" BorderWidth="1px" CellPadding="3" CellSpacing="2">
            <Columns>
                <asp:BoundField DataField="rightsId" HeaderText="rightsId" ItemStyle-Width="75px" SortExpression="rightsId" Visible="False">
                <ItemStyle Width="75px" />
                </asp:BoundField>
                <asp:CheckBoxField DataField="saveRights" HeaderText="Save" SortExpression="saveRights" />
                <asp:CheckBoxField DataField="updateRights" HeaderText="Update" SortExpression="updateRights" />
                <asp:CheckBoxField DataField="viewRights" HeaderText="View" SortExpression="viewRights" />
                <asp:CheckBoxField DataField="deleteRights" HeaderText="Delete" SortExpression="deleteRights" />
                <asp:CheckBoxField DataField="printRights" HeaderText="Print" SortExpression="printRights" />
                <asp:CheckBoxField DataField="processRights" HeaderText="Process" SortExpression="processRights" />
                <asp:CheckBoxField DataField="verifyRights" HeaderText="Verify" SortExpression="verifyRights" />
                <asp:CheckBoxField DataField="unProcessRights" HeaderText="UnProcess" SortExpression="unProcessRights" />
                <asp:CheckBoxField DataField="unVerifyRights" HeaderText="UnVerify" SortExpression="unVerifyRights" />
                <asp:BoundField DataField="groupId" HeaderText="groupId" ReadOnly="True" SortExpression="groupId" Visible="False" />
                <asp:BoundField DataField="menuid" HeaderText="menuid" SortExpression="menuid" ReadOnly="True" Visible="False" />
            </Columns>
            <RowStyle CssClass="RowStyle" BackColor="#FFF7E7" ForeColor="#8C4510" />
            <PagerStyle CssClass="PagerStyle" ForeColor="#8C4510" HorizontalAlign="Center" />
            <SelectedRowStyle CssClass="SelectedRowStyle" BackColor="#738A9C" Font-Bold="True" ForeColor="White" />
            <FooterStyle BackColor="#F7DFB5" ForeColor="#8C4510" />
            <HeaderStyle CssClass="HeaderStyle" BackColor="#A55129" Font-Bold="True" ForeColor="White" />
            <AlternatingRowStyle CssClass="AltRowStyle" />
            <SortedAscendingCellStyle BackColor="#FFF1D4" />
            <SortedAscendingHeaderStyle BackColor="#B95C30" />
            <SortedDescendingCellStyle BackColor="#F1E5CE" />
            <SortedDescendingHeaderStyle BackColor="#93451F" />
        </asp:GridView>
        <asp:SqlDataSource ID="ratGrid"
             runat="server"
            ConnectionString="<%$ ConnectionStrings:Conn_Str %>"
            SelectCommand="SELECT [rightsId], [saveRights], [updateRights],
[viewRights], [deleteRights], [printRights],
[processRights], [verifyRights], [unProcessRights],
[unVerifyRights], CONVERT(VARCHAR(100),tblGroup.groupId)as groupId, convert(varchar(100),tblmenu.[menuId])as menuid
FROM [tblRights] inner join tblMenu ON
tblMenu.menuId=tblRights.menuId INNER JOIN
tblGroup ON tblGroup.groupId=tblRights.rightsId"
           FilterExpression="menuId like '{0}%' and [groupId] like '{1}%'" >
                        <FilterParameters>
            <asp:ControlParameter ControlID="ddlmenu" Name="menu"
                    PropertyName="SelectedValue" Type="String" />
            <asp:ControlParameter ControlID="ddlgroup" Name="Country"
                    PropertyName="SelectedValue" Type="String" />
            </FilterParameters>
        </asp:SqlDataSource>
Your table needs key(s) and you need to assign the key as DataKeys property for the GridView to make your UpDate and Delete work without coding.

Edit form with an Inner Join - Can not update/delete data?!

Hi all,
I have an Edit form which shows me data from 2 tables (through an Inner Join SQL-Statement). I just realized that I can not edit data anymore, the following error msg appears:
Error in mru internal routine: ORA-20001: no data found in tabular form
Error Unable to process update.
OK
Can someone please help me?

The ringed in red are from the second table, but the first table has some more data. Here is the SQL Statement I have (D1 and D2 are from the second table - Whereas the DOBJ_NR1 and the DOBJ_NR2 are both primary keys and foreign keys in table one, but the user selects the key from table two...):
SELECT
D1.DOBJ_NR DOBJ_NR1,
D1.NAMSP NAMSP1,
D1.DOBJ_NAME DOBJ_NAME1,
D2.DOBJ_NR DOBJ_NR2,
D2.NAMSP NAMSP2,
D2.DOBJ_NAME DOBJ_NAME2,
R.RS_NAME,
R.ROLE1TO2,
R.CARDMIN1TO2,
R.CARDMAX1TO2,
R.ROLE2TO1,
R.CARDMIN2TO1,
R.CARDMAX2TO1,
R.ON_DELETE,
R.ON_UPDATE,
R.O_RS_COMMENT,
R.INS_BY REL_INS_BY
FROM
DO_RELATIONSHIP R
INNER JOIN DATAOBJECT D1 ON R.DOBJ1_NR = D1.DOBJ_NR
INNER JOIN DATAOBJECT D2 ON R.DOBJ2_NR = D2.DOBJ_NR
Edited by: user12067949 on Dec 5, 2009 3:18 AM

Update statement with inner join issues

I have searched for the answer on this and not really 100%....so figured I would ask...be nice :)
what have I done wrong? Or am I just going about this the wrong way? I have looked at the oracle docs and I can't find an example showing me this. I do see where you SET values based on the select query results. I want to update the result of a query based on the join with static values....
UPDATE table.a
SET table.a_STATUS=9,table.a.INDEX = 'N'
WHERE (SELECT table.a INNER JOIN table.b ON (table.a.COMPANY = table.b.COMPANY) AND (table.a.PO_NUMBER =table.b.PO_NUMBER) AND (table.a.PO_RELEASE =table.b.PO_RELEASE) AND (table.a.PO_CODE =table.b.PO_CODE) AND (table.a_STATUS=1) AND (table.b.CLOSED_FL = 'Y'));

Hi,
Welcome to the forum!
user11360811 wrote:
I have searched for the answer on this and not really 100%....so figured I would ask...be nice :)
what have I done wrong? Or am I just going about this the wrong way? I have looked at the oracle docs and I can't find an example showing me this. I do see where you SET values based on the select query results. I want to update the result of a query based on the join with static values....
UPDATE table.aThat's updating a table called A in a schema called TABLE (which is not a good name for any user-named object). Are those really your table and schema names? Perhaps you meant to have an underscore instead of a dot:
UPDATE table_ais much, much more reasonable. It means the table name is TABLE_A (a perfectly good name) in the current schema.
SET table.a_STATUS=9,table.a.INDEX = 'N'
WHERE ( ...There's a syntax error. You can't just say
"WHERE (sub-query)"; it has to be
"WHERE EXISTS (sub-suery)" or
"WHERE (sub-query) = some_value" or
"WHERE some_value IN (sub_query)", or something similar. WHERE can never be used without some kind of comparison operator, such as EXISTS, = or IN.
SELECT table.a INNER JOIN table.b ON ...Here are some more syntax errors. The correct syntax for any query is
SELECT column_list
FROM table_name ...If table.a is your (first) table name, then you're missing the list of columns to SELECT, and the mandatory keyword FROM.
(table.a.COMPANY = table.b.COMPANY) AND (table.a.PO_NUMBER =table.b.PO_NUMBER) AND (table.a.PO_RELEASE =table.b.PO_RELEASE) AND (table.a.PO_CODE =table.b.PO_CODE) AND (table.a_STATUS=1) AND (table.b.CLOSED_FL = 'Y'));Some general advice about UPDATE:
If it's not obvious how to use UPDATE to do what you want, then there's a good chance that UPDATE is the wrong tool for the job. MERGE might be much simpler, and more efficient as well. This is especially likely if you need to join the table that's being updated to some other table.
Whenever you have a problem, please post a little sample data (CREATE TABLE and INSERT statements, relevant columns only) from all tables involved. That way, the people who want to help you can re-create the problem and test their ideas.
Also post the results you want from that data, and an explanation of how you get those results from that data, with specific examples.
Simplify the problem as much as possible. Remove all tables and columns that play no role in this problem.
If you're asking about a DML statement, such as UPDATE, the CREATE TABLE and INSERT statements should re-create the tables as they are before the DML, and the results will be the contents of the changed table(s) when everything is finished.
Always say which version of Oracle you're using (for example, 11.2.0.2.0).
See the forum FAQ {message:id=9360002}
Edited by: Frank Kulash on Jan 17, 2013 4:58 PM

Update statement with inner join

Hello everyone. I am am trying to do an update statement with an inner join. I have found several examples of SQL statements that work with Sql server and mysql but they don't work in Oracle. Does anyone know the proper way in Oracle 10G? I am trying to update all fields in one table from fields in another table.
for example:
UPDATE table3
SET
TL3.name = TL2.name,
TL3.status = TL2.status,
TL3.date = TL2.date
FROM table3 TL3 JOIN table2 TL2
ON (TL3.unique_id = TL2.unique_id);
any help will be appreciated.

Hi,
You can also use MERGE, like this:
MERGE INTO table3     dst
USING   (
         SELECT unique_id
         ,         name
         ,         status
         ,         dt          -- DATE is not a good column name
         FROM    table2
     )          src
ON     (dst.unique_id     = src.unique_id)
WHEN MATCHED THEN UPDATE
SET     dst.name     = src.name
,     dst.status     = src.status
,     dst.dt          = src.dt
;Unlike UPDATE, this lets you avoid essentially doing the same sub-query twice: once in the SET clause and then again in the WHERE clause.
Like UPDATE, you don't acutally join the table being changed (table3 in this case) to the other table(s); that is, the FROM clause of the suib-query does not include table3.
Riedelme is right; you'll get better response to SQL questions like this in the SQL and PL/SQL forum:
PL/SQL

How to use Inner join of table as Source in Merge statement in SQL

Hi All,
I am trying to make source as multiple tables output using Join while coding there is no any syntax error but when i am executing this statement is giving following error
Following is the query
Merge Into EmpDept Target
Using (select E.Address,e.Design,e.EmailId,e.EmpId,e.Ename,e.ManagerId, e.Salary,D.DeptId,D.DeptName,D.Location from Employee E Inner join Dept D on E.DeptId=D.DeptId )As Source (Address,Design,EmailId,EmpId,EName,ManagerId,Salary,DeptId,DeptName,Location)
On Source.EmpId=Target.EmpId
when not matched then
Insert (Target.Address,Target.Design,Target.EmailId,Target.EmpId,Target.Ename,Target.ManagerId, Target.Salary,Target.DeptId,Target.DeptName,Target.Location)
values
(Address,Design,EmailId,EmpId,EName,ManagerId, Salary,DeptId,DeptName,Location)
When matched then
Update set Target.Address = Source.Address ,Target.Design = Source.Design,Target.EmailId = Source.EmailId ,Target.Ename = Source.Ename ,Target.ManagerId = Source.ManagerId , Target.Salary = Source.Salary ,Target.DeptId = Source.DeptId ,Target.DeptName = Source.DeptName ,Target.Location = Source.Location;
This is error while executing the above merge statement
The insert column list used in the MERGE statement cannot contain multi-part identifiers. Use single part identifiers instead.
Please suggest me where i am wrong..
Niraj Sevalkar

MERGE INTO EmpDept Target
Using (SELECT E.Address,
e.Design,
e.EmailId,
e.EmpId,
e.Ename,
e.ManagerId,
e.Salary,
D.DeptId,
D.DeptName,
D.Location
FROM Employee E
INNER JOIN Dept D
ON E.DeptId = D.DeptId) AS Source (Address, Design, EmailId, EmpId, EName, ManagerId, Salary, DeptId, DeptName, Location)
ON Source.EmpId = Target.EmpId
WHEN NOT matched THEN
INSERT (Address,
Design,
EmailId,
EmpId,
Ename,
ManagerId,
Salary,
DeptId,
DeptName,
Location)
VALUES (Address,
Design,
EmailId,
EmpId,
EName,
ManagerId,
Salary,
DeptId,
DeptName,
Location)
WHEN matched THEN
UPDATE SET Address = Source.Address,
Design = Source.Design,
EmailId = Source.EmailId,
Ename = Source.Ename,
ManagerId = Source.ManagerId,
Salary = Source.Salary,
DeptId = Source.DeptId,
DeptName = Source.DeptName,
Location = Source.Location;

Very Slow Query with CTE inner join

I have 2 tables (heavily simplified here to show relevant columns):
CREATE TABLE tblCharge
(ChargeID int NOT NULL,
ParentChargeID int NULL,
ChargeName varchar(200) NULL)
CREATE TABLE tblChargeShare
(ChargeShareID int NOT NULL,
ChargeID int NOT NULL,
TotalAmount money NOT NULL,
TaxAmount money NULL,
DiscountAmount money NULL,
CustomerID int NOT NULL,
ChargeShareStatusID int NOT NULL)
I have a very basic View to Join them:
CREATE VIEW vwBASEChargeShareRelation as
Select c.ChargeID, ParentChargeID, s.CustomerID, s.TotalAmount, isnull(s.TaxAmount, 0) as TaxAmount, isnull(s.DiscountAmount, 0) as DiscountAmount
from tblCharge c inner join tblChargeShare s
on c.ChargeID = s.ChargeID Where s.ChargeShareStatusID < 3
GO
I then have a view containing a CTE to get the children of the Parent Charge:
ALTER VIEW [vwChargeShareSubCharges] AS
WITH RCTE AS
SELECT ParentChargeId, ChargeID, 1 AS Lvl, ISNULL(TotalAmount, 0) as TotalAmount, ISNULL(TaxAmount, 0) as TaxAmount,
ISNULL(DiscountAmount, 0) as DiscountAmount, CustomerID, ChargeID as MasterChargeID
FROM vwBASEChargeShareRelation Where ParentChargeID is NULL
UNION ALL
SELECT rh.ParentChargeID, rh.ChargeID, Lvl+1 AS Lvl, ISNULL(rh.TotalAmount, 0), ISNULL(rh.TaxAmount, 0), ISNULL(rh.DiscountAmount, 0) , rh.CustomerID
, rc.MasterChargeID
FROM vwBASEChargeShareRelation rh
INNER JOIN RCTE rc ON rh.PArentChargeID = rc.ChargeID and rh.CustomerID = rc.CustomerID
Select MasterChargeID as ChargeID, CustomerID, Sum(TotalAmount) as TotalCharged, Sum(TaxAmount) as TotalTax, Sum(DiscountAmount) as TotalDiscount
from RCTE
Group by MasterChargeID, CustomerID
GO
So far so good, I can query this view and get the total cost for a line item including all children.
The problem occurs when I join this table. The query:
Select t.* from vwChargeShareSubCharges t
inner join
tblChargeShare s
on t.CustomerID = s.CustomerID
and t.MasterChargeID = s.ChargeID
Where s.ChargeID = 1291094
Takes around 30 ms to return a result (tblCharge and Charge Share have around 3.5 million records).
But the query:
Select t.* from vwChargeShareSubCharges t
inner join
tblChargeShare s
on t.CustomerID = s.CustomerID
and t.MasterChargeID = s.ChargeID
Where InvoiceID = 1045854
Takes around 2 minutes to return a result - even though the only charge with that InvoiceID is the same charge as the one used in the previous query.
The same thing occurs if I do the join in the same query that the CTE is defined in.
I ran the execution plan for each query. The first (fast) query looks like this:
The second(slow) query looks like this:
I am at a loss, and my skills at decoding execution plans to resolve this are lacking.
I have separate indexes on tblCharge.ChargeID, tblCharge.ParentChargeID, tblChargeShare.ChargeID, tblChargeShare.InvoiceID, tblChargeShare.ChargeShareStatusID
Any ideas? Tested on SQL 2008R2 and SQL 2012

>> The database is linked [sic] to an established app and the column and table names can't be changed. <<
Link? That is a term from pointer chains and network databases, not SQL. I will guess that means the app came back in the old pre-RDBMS days and you are screwed.
>> I am not too worried about the money field [sic], this is used for money and money based calculations so the precision and rounding are acceptable at this level. <<
Field is a COBOL concept; columns are totally different. MONEY is how Sybase mimics the PICTURE clause that puts currency signs, commas, period, etc in a COBOL money field.
Using more than one operation (multiplication or division) on money columns will produce severe rounding errors. A simple way to visualize money arithmetic is to place a ROUND() function calls after
every operation. For example,
Amount = (Portion / total_amt) * gross_amt
can be rewritten using money arithmetic as:
Amount = ROUND(ROUND(Portion/total_amt, 4) *
gross_amt, 4)
Rounding to four decimal places might not seem an
issue, until the numbers you are using are greater
than 10,000.
BEGIN
DECLARE @gross_amt MONEY,
@total_amt MONEY,
@my_part MONEY,
@money_result MONEY,
@float_result FLOAT,
@all_floats FLOAT;
SET @gross_amt = 55294.72;
SET @total_amt = 7328.75;
SET @my_part = 1793.33;
SET @money_result = (@my_part / @total_amt) *
@gross_amt;
SET @float_result = (@my_part / @total_amt) *
@gross_amt;
SET @Retult3 = (CAST(@my_part AS FLOAT)
/ CAST( @total_amt AS FLOAT))
* CAST(FLOAT, @gross_amt AS FLOAT);
SELECT @money_result, @float_result, @all_floats;
END;
@money_result = 13525.09 -- incorrect
@float_result = 13525.0885 -- incorrect
@all_floats = 13530.5038673171 -- correct, with a -
5.42 error
>> The keys are ChargeID(int, identity) and ChargeShareID(int, identity). <<
Sorry, but IDENTITY is not relational and cannot be a key by definition. But it sure works just like a record number in your old COBOL file system.
>> .. these need to be int so that they are assigned by the database and unique. <<
No, the data type of a key is not determined by physical storage, but by logical design. IDENTITY is the number of a parking space in a garage; a VIN is how you identify the automobile.
>> What would you recommend I use as keys? <<
I do not know. I have no specs and without that, I cannot pull a Kabbalah number from the hardware. Your magic numbers can identify Squids, Automobile or Lady Gaga! I would ask the accounting department how they identify a charge.
>> Charge_Share_Status_ID links [sic] to another table which contains the name, formatting [sic] and other information [sic] or a charge share's status, so it is both an Id and a status. <<
More pointer chains! Formatting? Unh? In RDBMS, we use a tiered architecture. That means display formatting is in a presentation layer. A properly created table has cohesion – it does one and only one data element. A status is a state of being that applies
to an entity over a period time (think employment, marriage, etc. status if that is too abstract).
An identifier is based on the Law of Identity from formal logic “To be is to be something in particular” or “A is A” informally. There is no entity here! The Charge_Share_Status table should have the encoded values for a status and perhaps a description if
they are unclear. If the list of values is clear, short and static, then use a CHECK() constraint.
On a scale from 1 to 10, what color is your favorite letter of the alphabet? Yes, this is literally that silly and wrong.
>> I understand what a CTE is; is there a better way to sum all children for a parent hierarchy? <<
There are many ways to represent a tree or hierarchy in SQL. This is called an adjacency list model and it looks like this:
CREATE TABLE OrgChart
(emp_name CHAR(10) NOT NULL PRIMARY KEY,
boss_emp_name CHAR(10) REFERENCES OrgChart(emp_name),
salary_amt DECIMAL(6,2) DEFAULT 100.00 NOT NULL,
<< horrible cycle constraints >>);
OrgChart
emp_name boss_emp_name salary_amt
==============================
'Albert' NULL 1000.00
'Bert' 'Albert' 900.00
'Chuck' 'Albert' 900.00
'Donna' 'Chuck' 800.00
'Eddie' 'Chuck' 700.00
'Fred' 'Chuck' 600.00
This approach will wind up with really ugly code -- CTEs hiding recursive procedures, horrible cycle prevention code, etc. The root of your problem is not knowing that rows are not records, that SQL uses sets and trying to fake pointer chains with some
vague, magical non-relational "id".
This matches the way we did it in old file systems with pointer chains. Non-RDBMS programmers are comfortable with it because it looks familiar -- it looks like records and not rows.
Another way of representing trees is to show them as nested sets.
Since SQL is a set oriented language, this is a better model than the usual adjacency list approach you see in most text books. Let us define a simple OrgChart table like this.
CREATE TABLE OrgChart
(emp_name CHAR(10) NOT NULL PRIMARY KEY,
lft INTEGER NOT NULL UNIQUE CHECK (lft > 0),
rgt INTEGER NOT NULL UNIQUE CHECK (rgt > 1),
CONSTRAINT order_okay CHECK (lft < rgt));
OrgChart
emp_name lft rgt
======================
'Albert' 1 12
'Bert' 2 3
'Chuck' 4 11
'Donna' 5 6
'Eddie' 7 8
'Fred' 9 10
The (lft, rgt) pairs are like tags in a mark-up language, or parens in algebra, BEGIN-END blocks in Algol-family programming languages, etc. -- they bracket a sub-set. This is a set-oriented approach to trees in a set-oriented language.
The organizational chart would look like this as a directed graph:
Albert (1, 12)
Bert (2, 3) Chuck (4, 11)
/ | \
/ | \
/ | \
/ | \
Donna (5, 6) Eddie (7, 8) Fred (9, 10)
The adjacency list table is denormalized in several ways. We are modeling both the Personnel and the Organizational chart in one table. But for the sake of saving space, pretend that the names are job titles and that we have another table which describes the
Personnel that hold those positions.
Another problem with the adjacency list model is that the boss_emp_name and employee columns are the same kind of thing (i.e. identifiers of personnel), and therefore should be shown in only one column in a normalized table. To prove that this is not
normalized, assume that "Chuck" changes his name to "Charles"; you have to change his name in both columns and several places. The defining characteristic of a normalized table is that you have one fact, one place, one time.
The final problem is that the adjacency list model does not model subordination. Authority flows downhill in a hierarchy, but If I fire Chuck, I disconnect all of his subordinates from Albert. There are situations (i.e. water pipes) where this is true, but
that is not the expected situation in this case.
To show a tree as nested sets, replace the nodes with ovals, and then nest subordinate ovals inside each other. The root will be the largest oval and will contain every other node. The leaf nodes will be the innermost ovals with nothing else inside them
and the nesting will show the hierarchical relationship. The (lft, rgt) columns (I cannot use the reserved words LEFT and RIGHT in SQL) are what show the nesting. This is like XML, HTML or parentheses.
At this point, the boss_emp_name column is both redundant and denormalized, so it can be dropped. Also, note that the tree structure can be kept in one table and all the information about a node can be put in a second table and they can be joined on employee
number for queries.
To convert the graph into a nested sets model think of a little worm crawling along the tree. The worm starts at the top, the root, makes a complete trip around the tree. When he comes to a node, he puts a number in the cell on the side that he is visiting
and increments his counter. Each node will get two numbers, one of the right side and one for the left. Computer Science majors will recognize this as a modified preorder tree traversal algorithm. Finally, drop the unneeded OrgChart.boss_emp_name column
which used to represent the edges of a graph.
This has some predictable results that we can use for building queries. The root is always (left = 1, right = 2 * (SELECT COUNT(*) FROM TreeTable)); leaf nodes always have (left + 1 = right); subtrees are defined by the BETWEEN predicate; etc. Here are
two common queries which can be used to build others:
1. An employee and all their Supervisors, no matter how deep the tree.
SELECT O2.*
FROM OrgChart AS O1, OrgChart AS O2
WHERE O1.lft BETWEEN O2.lft AND O2.rgt
AND O1.emp_name = :in_emp_name;
2. The employee and all their subordinates. There is a nice symmetry here.
SELECT O1.*
FROM OrgChart AS O1, OrgChart AS O2
WHERE O1.lft BETWEEN O2.lft AND O2.rgt
AND O2.emp_name = :in_emp_name;
3. Add a GROUP BY and aggregate functions to these basic queries and you have hierarchical reports. For example, the total salaries which each employee controls:
SELECT O2.emp_name, SUM(S1.salary_amt)
FROM OrgChart AS O1, OrgChart AS O2,
Salaries AS S1
WHERE O1.lft BETWEEN O2.lft AND O2.rgt
AND S1.emp_name = O2.emp_name
GROUP BY O2.emp_name;
4. To find the level and the size of the subtree rooted at each emp_name, so you can print the tree as an indented listing.
SELECT O1.emp_name,
SUM(CASE WHEN O2.lft BETWEEN O1.lft AND O1.rgt
THEN O2.sale_amt ELSE 0.00 END) AS sale_amt_tot,
SUM(CASE WHEN O2.lft BETWEEN O1.lft AND O1.rgt
THEN 1 ELSE 0 END) AS subtree_size,
SUM(CASE WHEN O1.lft BETWEEN O2.lft AND O2.rgt
THEN 1 ELSE 0 END) AS lvl
FROM OrgChart AS O1, OrgChart AS O2
GROUP BY O1.emp_name;
5. The nested set model has an implied ordering of siblings which the adjacency list model does not. To insert a new node, G1, under part G. We can insert one node at a time like this:
BEGIN ATOMIC
DECLARE rightmost_spread INTEGER;
SET rightmost_spread
= (SELECT rgt
FROM Frammis
WHERE part = 'G');
UPDATE Frammis
SET lft = CASE WHEN lft > rightmost_spread
THEN lft + 2
ELSE lft END,
rgt = CASE WHEN rgt >= rightmost_spread
THEN rgt + 2
ELSE rgt END
WHERE rgt >= rightmost_spread;
INSERT INTO Frammis (part, lft, rgt)
VALUES ('G1', rightmost_spread, (rightmost_spread + 1));
COMMIT WORK;
END;
The idea is to spread the (lft, rgt) numbers after the youngest child of the parent, G in this case, over by two to make room for the new addition, G1. This procedure will add the new node to the rightmost child position, which helps to preserve the idea
of an age order among the siblings.
6. To convert a nested sets model into an adjacency list model:
SELECT B.emp_name AS boss_emp_name, E.emp_name
FROM OrgChart AS E
LEFT OUTER JOIN
OrgChart AS B
ON B.lft
= (SELECT MAX(lft)
FROM OrgChart AS S
WHERE E.lft > S.lft
AND E.lft < S.rgt);
7. To find the immediate parent of a node:
SELECT MAX(P2.lft), MIN(P2.rgt)
FROM Personnel AS P1, Personnel AS P2
WHERE P1.lft BETWEEN P2.lft AND P2.rgt
AND P1.emp_name = @my_emp_name;
I have a book on TREES & HIERARCHIES IN SQL which you can get at Amazon.com right now. It has a lot of other programming idioms for nested sets, like levels, structural comparisons, re-arrangement procedures, etc.
--CELKO-- Books in Celko Series for Morgan-Kaufmann Publishing: Analytics and OLAP in SQL / Data and Databases: Concepts in Practice Data / Measurements and Standards in SQL SQL for Smarties / SQL Programming Style / SQL Puzzles and Answers / Thinking
in Sets / Trees and Hierarchies in SQL

Oracle UPDATE syntax with JOIN and WHERE clause

I need to update one of my tables, and can't seem to get the syntax right. I've tried a 4 different approaches, but not having any luck. Any help would be greatly appreciated.
Attempt #1: Error: SQL command not properly ended
UPDATE TESTDTA.F4941
SET TESTDTA.F4941.RSDSTN=TESTDTA.F4981.FHRTDQ,TESTDTA.F4941.RSUMD1=TESTDTA.F4981.FHUOM
FROM TESTDTA.F4941
INNER JOIN TESTDTA.F4981
ON TESTDTA.F4941.RSSHPN = TESTDTA.F4981.FHSHPN
WHERE TESTDTA.F4941.RSSHPN = 647143
AND TESTDTA.F4941.RSDSTN = 0
AND TESTDTA.F4941.RSADDJ > 110365
AND TESTDTA.F4981.FHCGC1 = 'DIS';
Attempt #2: Error report: SQL Error: ORA-00904: "TESTDTA"."F4981"."FHUOM": invalid identifier 00904. 00000 - "%s: invalid identifier"
UPDATE (SELECT TESTDTA.F4941
FROM TESTDTA.F4941
INNER JOIN TESTDTA.F4981
ON TESTDTA.F4941.RSSHPN = TESTDTA.F4981.FHSHPN
WHERE TESTDTA.F4941.RSSHPN = 647143
AND TESTDTA.F4941.RSDSTN = 0
AND TESTDTA.F4941.RSADDJ > 110365
AND TESTDTA.F4981.FHCGC1 = 'DIS')
SET TESTDTA.F4941.RSDSTN=TESTDTA.F4981.FHRTDQ,TESTDTA.F4941.RSUMD1=TESTDTA.F4981.FHUOM
Attempt #3: Error report: SQL Error: ORA-00904: "TESTDTA"."F4941": invalid identifier 00904. 00000 - "%s: invalid identifier"
UPDATE (SELECT *
FROM TESTDTA.F4941
INNER JOIN TESTDTA.F4981
ON TESTDTA.F4941.RSSHPN = TESTDTA.F4981.FHSHPN
WHERE TESTDTA.F4941.RSSHPN = 647143
AND TESTDTA.F4941.RSDSTN = 0
AND TESTDTA.F4941.RSADDJ > 110365
AND TESTDTA.F4981.FHCGC1 = 'DIS')
SET TESTDTA.F4941.RSDSTN=TESTDTA.F4981.FHRTDQ,TESTDTA.F4941.RSUMD1=TESTDTA.F4981.FHUOM;
Attempt #4: Error: ORA-00925: missing INTO keyword 00925. 00000 - "missing INTO keyword"
MERGE TESTDTA.F4941
USING TESTDTA.F4981
ON (TESTDTA.F4941.RSSHPN = TESTDTA.F4981.FHSHPN
AND TESTDTA.F4941.RSSHPN = 647143
AND TESTDTA.F4941.RSDSTN = 0
AND TESTDTA.F4941.RSADDJ > 110365
AND TESTDTA.F4981.FHCGC1 = 'DIS'
WHEN MATCHED THEN
UPDATE SET TESTDTA.F4941.RSDSTN=TESTDTA.F4981.FHRTDQ
   ,TESTDTA.F4941.RSUMD1=TESTDTA.F4981.FHUOM;

thank you for the attempt, but I get this error trying your method...
Error report:
SQL Error: ORA-01779: cannot modify a column which maps to a non key-preserved table
01779. 00000 - "cannot modify a column which maps to a non key-preserved table"
*Cause:    An attempt was made to insert or update columns of a join view which
           map to a non-key-preserved table.
*Action:   Modify the underlying base tables directly.
as for the background of what I'm trying to...
I have 2 tables, one that has shipments with no miles (F4941 / Routing Steps), and another that does have miles (F4981 / Freight Audit History).
I want to update the miles & UnitOfMeasure columns for all shipments in the F4941 that currently have 0 miles with the miles found in the F4981 which are connected by Shipment number. Here's my same script, with simpler naming.
UPDATE RoutingSteps
SET RoutingSteps.Miles=FreightAuditHistory.Miles,RoutingSteps.UnitOfMeasure=FreightAuditHistory.UnitOfMeasure
FROM RoutingSteps
INNER JOIN FreightAuditHistory
ON RoutingSteps.ShipmentNumber = FreightAuditHistory.ShipmentNumber
WHERE RoutingSteps.ShipmentNumber = 647143
AND RoutingSteps.Miles = 0
AND RoutingSteps.ShipmentDate > 110365
AND FreightAuditHistory.Category = 'DIS';
hope this helps visualize my intent

Update with Outer Join, round 2

Thanks for those of you who helped me out on the first one (I never thought that you could use a one-row SELECT like that).
However, here is a new version of my problem:
I have three tables.
Table_1 has a column that needs to be updated based on values in Table_2 and Table_3.
Both Table_1 and Table_2 have values used to determine which Table_3 row to use.
However, not every Table_1 row has a corresponding Table_3 row, in which case the Table_3 value to use is assumed to be 1.
The tables and corresponding columns are:
TABLE_1
value_1 - the value to be updated
key_2 - a pointer to TABLE_2
key_3a - a pointer to TABLE_3, or a dummy value if there is no corresponding TABLE_3 record
TABLE_2
key_2 - the primary key
key_3b - a secondary pointer to TABLE_3
value_2 - a value to be used in calculating TABLE_1.value_1
TABLE_3
key_3a - the first part of the unique key
ley_3b - the second part of the unique key
value_3 - a value to be used in calculating TABLE_1.value_1
If there is a row in table_3 that matches the table_1.key_3a and table_2.key_3b values (where table_2.key_2 = table_1.key_2):
set table_1.value_1 = table_2.value_2 * table_3.value_3
If there is no such row in table_3:
set table_1.value_1 = table_2.value_2
I want to do something like this:
UPDATE table_1 t1
SET value_1 =
SELECT t2.value_2 * NVL(t3.value_3, 1)
FROM table_2 t2
LEFT JOIN table_3 t3
ON (t3.key_3b = t2.key_3b and t3.key_3a = t1.key_3a)
WHERE t2.key_2 = t1.key_2
However, Oracle does not allow t1 to be referenced in the ON clause of the outer join.
(Assume that every key_2 value in table_1 is in table_2 as well - it is only the key_3 value that can be a dummy.)
If I move "t3.key_3 = t1.key_3" to the WHERE clause, then t1.value_1 is null for rows without the corresponding table_3 value.
I can do it with a clone of table_1 using ROWIDs:
UPDATE table_1 t1
SET value_1 =
SELECT t2.value_2 * NVL(t3.value_3, 1)
FROM table_1 t1a
JOIN table_2 t2
ON t2.key_2 = t1a.key_2
LEFT JOIN table_3 t3
ON (t3.key_3b = t2.key_3b and t3.key_3a = t1a.key_3a)
WHERE t1a.row_id = t1.row_id
However, is there an easier way to do this using ANSI joins (i.e. without (+) syntax)?
I have this feeling I am missing something reasonably obvious here.

ddelgran wrote:
Thanks for those of you who helped me out on the first one (I never thought that you could use a one-row SELECT like that).
I want to do something like this:
UPDATE table_1 t1
SET value_1 =
SELECT t2.value_2 * NVL(t3.value_3, 1)
FROM table_2 t2
LEFT JOIN table_3 t3
ON (t3.key_3b = t2.key_3b and t3.key_3a = t1.key_3a)
WHERE t2.key_2 = t1.key_2
However, Oracle does not allow t1 to be referenced in the ON clause of the outer join.
(Assume that every key_2 value in table_1 is in table_2 as well - it is only the key_3 value that can be a dummy.)
If I move "t3.key_3 = t1.key_3" to the WHERE clause, then t1.value_1 is null for rows without the corresponding table_3 value.
I can do it with a clone of table_1 using ROWIDs:
UPDATE table_1 t1
SET value_1 =
SELECT t2.value_2 * NVL(t3.value_3, 1)
FROM table_1 t1a
JOIN table_2 t2
ON t2.key_2 = t1a.key_2
LEFT JOIN table_3 t3
ON (t3.key_3b = t2.key_3b and t3.key_3a = t1a.key_3a)
WHERE t1a.row_id = t1.row_id
However, is there an easier way to do this using ANSI joins (i.e. without (+) syntax)?
I have this feeling I am missing something reasonably obvious here.You might want to refer to my post in your original thread how to use join views in updates. You can use ANSI join syntax there, too:
Re: Update with Outer Join
You would end up with something like this (note: untested):
UPDATE
SELECT t1.value_1, t2.value_2 * NVL(t3.value_3, 1) as new_val
FROM table_1 t1
INNER JOIN table_2 t2 ON (t2.key_2 = t1.key_2)
LEFT JOIN table_3 t3
ON (t3.key_3b = t2.key_3b and t3.key_3a = t1.key_3a)
SET value_1 = new_val;And again the same restrictions regarding key-preserved tables apply as described in the post referred to.
Regards,
Randolf
Oracle related stuff blog:
http://oracle-randolf.blogspot.com/
SQLTools++ for Oracle (Open source Oracle GUI for Windows):
http://www.sqltools-plusplus.org:7676/
http://sourceforge.net/projects/sqlt-pp/

Update Con Inner Join

Similar Messages

Maybe you are looking for