Urgent: Regarding Inner join relation b/w MSEG, MKPF, MARA and MAKT

Question

I have written o code like below for inner join. However, The program has take much more time to give out put. Could any one please correct the below inner join statement. Its very urgent.
Thanks for your help.
SELECT  mseg~mblnr
          mseg~matnr
          mseg~werks
          mseg~charg
          mseg~lifnr
          mseg~bualt
          mseg~erfmg
          mseg~ebeln
          mseg~ebelp
          mkpf~budat   
          mara~zzshelf_life                              
          makt~maktx
          FROM mseg
          INNER JOIN mkpf
            ON mkpfmblnr EQ msegmblnr
          INNER JOIN mara
            ON msegmatnr EQ maramatnr
          INNER JOIN makt
            ON maramatnr EQ maktmatnr
          INTO TABLE gt_mat_doc
          WHERE  mseg~matnr IN s_matnr
            AND  mseg~werks IN s_werks
            AND  mseg~lifnr IN s_lifnr
            AND  mseg~bwart EQ p_bwart
            AND  ( msegebeln NE ' ' AND msegebeln IN s_ebeln )
            AND  mkpf~budat IN s_budat
            AND  mara~mtart IN s_mtart
            AND  makt~spras EQ sy-langu.

Answer 1

Hi,
Do like this
Types: begin of ty_mesg_mkpf,
         mblnr type mseg-mblnr,
         matnr type mseg-matnr,
         werks type mseg-werks,
         charg type mseg-charg,
         lifnr type mseg-lifnr,
         bualt type mseg-bualt,
         erfmg type mseg-erfmg,
         ebeln type mseg-ebeln,
         ebelp type mseg-ebelp,
         budat type mkpf-budat,
       end of ty_mseg_mkpf,
       Begin og ty_mara_makt,
        matnr type mara-matnr,
        zzshelf_life type mara-zzshelf_life,
        maktx type makt-maktx,
       end of ty_mara_makt.
Data: it_mseg_mkpf type table of ty_mseg_mkpf,
      wa_mseg_mkpf type ty_mseg_mkpf,
      it_mara_makt type table of ty_mara_makt,
      wa_mara_makt type ty_mara_makt.
SELECT m1~mblnr
m1~matnr
m1~werks
m1~charg
m1~lifnr
m1~bualt
m1~erfmg
m1~ebeln
m1~ebelp
m2~budat
FROM mseg
INTO TABLE it_mseg_mkpf
INNER JOIN mkpf
ON m1mblnr EQ m2mblnr
WHERE m1~matnr IN s_matnr
AND m1~werks IN s_werks
AND m1~lifnr IN s_lifnr
AND m1~bwart EQ p_bwart
AND ( m1ebeln NE ' ' AND m1ebeln IN s_ebeln )
AND m2~budat IN s_budat
if sy-subrc = 0.
Select m3~matnr
m3~zzshelf_life
m4~maktx from mara as m3
INNER JOIN makt as m4
ON m3matnr EQ m4matnr
INTO TABLE it_mara_makt
where m3~mtart IN s_mtart
AND m4~spras EQ sy-langu.
endif.
loop at it_mseg_mkpf into wa_mseg_mkpf.
Move necessary field values from wa_mseg_mkpf to wa_mat_doc.
Read table it_mara_makt into wa_mara_makt with key matnr = wa_mseg_mkpf-matnr.
if sy-subrc = 0.
  move remaining field values to wa_mat_doc.
  append wa_mat_doc to gt_mat_doc.
  clear wa_mat_doc.
endif.
endloop.
Regards,
Satish