Use Buttons to move square from left to right

Question

Hey,
I am working a a Java Game for school, it's kind of a Space Invaders clone. I want to control the shooting object at te bottom of the screen by 2 buttons, one for left movement, and one for right. But my buttons won't react to it being clicked. I have pasted the code below so you can take a look. Please can anybody help me?
import javax.swing.*;
import java.awt.event.*;
import java.awt.*;
class Animation extends JPanel implements ActionListener{
JButton button=new JButton("links");
JButton button2=new JButton("rechts");
ClickCounter clickCounter=new ClickCounter();
int xpos=0;
int xpos2=0;
int height=15;
int width=60;
int dx=3;
int dxshooter=3;
int shoot=300;
int ykogel=0;
int dxkogel=3;
int number=12;
int xposkogel;
int yposkogel;
int ovalx1=xpos,ovalx2=xpos+100,ovalx3=xpos+200,ovalx4=xpos+300,ovalx5=xpos+400,ovalx6=xpos+500;
int ovaly1=15,ovaly2=15,ovaly3=15,ovaly4=15,ovaly5=15,ovaly6=15;
int ovalxb1=xpos+19,ovalxb2=xpos+19+100,ovalxb3=xpos+19+200,ovalxb4=xpos+19+300,ovalxb5=xpos+19+400,ovalxb6=xpos+19+500;
int ovalyb1=5,ovalyb2=5,ovalyb3=5,ovalyb4=5,ovalyb5=5,ovalyb6=5;
Timer fastTicker;
Animation(){
fastTicker=new Timer(25,this);
void start(){
this.add(button);
button.setSize(100,50);
button.move(0,320);
button.addActionListener(this);
this.add(button2);
button2.setSize(100,50);
button2.move(600,320);
button2.addActionListener(this);
fastTicker.start();
public void actionPerformed(ActionEvent e){
yposkogel=312-ykogel;
ovalx1=xpos;ovalx2=xpos+100;ovalx3=xpos+200;ovalx4=xpos+300;ovalx5=xpos+400;ovalx6=xpos+500;
ovalxb1=xpos+19;ovalxb2=xpos+19+100;ovalxb3=xpos+19+200;ovalxb4=xpos+19+300;ovalxb5=xpos+19+400;ovalxb6=xpos+19+500;
//bolletjesanimatie
if(e.getSource()==fastTicker){
xpos+=dx;
ykogel+=dxkogel;
xposkogel=xpos2;
if (xpos>this.getWidth()-width-500||xpos<0){
dx=-dx;
if(e.getSource()==fastTicker){
xpos2+=dxshooter;
//schietding
if (xpos2>240||xpos2<-210){
dxshooter=-dxshooter;
//kogelanimatie
if(ykogel>310){
ykogel=0;}
//vergelijking van bolletje/kogel
if(yposkogel==15&&xposkogel>=ovalx6&&xposkogel<=ovalx6+60){
ovaly6=1500;
ovalyb6=1500;}
if(yposkogel==15&&xposkogel>=ovalx5&&xposkogel<=ovalx5+60){
ovaly5=1500;
ovalyb5=1500;}
if(yposkogel==15&&xposkogel>=ovalx4&&xposkogel<=ovalx4+60){
ovaly4=1500;
ovalyb4=1500;}
if(yposkogel==15&&xposkogel>=ovalx3&&xposkogel<=ovalx3+60){
ovaly3=1500;
ovalyb3=1500;}
if(yposkogel==15&&xposkogel>=ovalx2&&xposkogel<=ovalx2+60){
ovaly2=1500;
ovalyb2=1500;}
if(yposkogel==15&&xposkogel>=ovalx1&&xposkogel<=ovalx1+60){
ovaly1=1500;
ovalyb1=1500;}
this.repaint();
public void actionPerformed2(ActionEvent b){
if (b.getActionCommand().equals("button")){
xpos2=xpos2-50;}
if(b.getActionCommand().equals("button2")){
xpos2=xpos2+50;
public void paintComponent(Graphics g){
super.paintComponent(g);
//ufo's
g.setColor(Color.black);
g.fillOval(ovalxb1,ovalyb1, 25,25);
g.setColor(Color.orange);
g.fillOval(ovalx1,ovaly1,width,height);
g.setColor(Color.black);
g.fillOval(ovalxb2,ovalyb2, 25,25);
g.setColor(Color.orange);
g.fillOval(ovalx2,ovaly2,width,height);
g.setColor(Color.black);
g.fillOval(ovalxb3,ovalyb3, 25,25);
g.setColor(Color.orange);
g.fillOval(ovalx3,ovaly3,width,height);
g.setColor(Color.black);
g.fillOval(ovalxb4,ovalyb4, 25,25);
g.setColor(Color.orange);
g.fillOval(ovalx4,ovaly4,width,height);
g.setColor(Color.black);
g.fillOval(ovalxb5,ovalyb5, 25,25);
g.setColor(Color.orange);
g.fillOval(ovalx5,ovaly5,width,height);
g.setColor(Color.black);
g.fillOval(ovalxb6,ovalyb6, 25,25);
g.setColor(Color.orange);
g.fillOval(ovalx6,ovaly6,width,height);
//schietding
g.fillRect(xpos2+350-17,317,6,40);
g.setColor(Color.green);
g.fillOval(xpos2+350-30,330,30,30);
g.setColor(Color.black);
g.fillRect(xpos2+350-40,350,50,height);
//kogel
g.fillRect(xposkogel+350-16,yposkogel,5,5);
public class AnimationDemo{
JFrame frame;
Animation animation;
void demo(){
frame=new JFrame("**Spees Inveeders** All rights reserved (Dave Senden and Joeri Oomen)");
animation=new Animation();
frame.getContentPane().add(animation);
frame.setSize(700,400);
frame.setVisible(true);
animation.start();
public static void main(String[] args){
AnimationDemo animationDemo=new AnimationDemo();
animationDemo.demo();
}

Answer 1

Jukka, thanks a lot! The buttons now work! I have updated my code, but now my problem is to compare the position of the bullet with the position of the ufo. I have marked the part where I wrote my solution, but it doesn't really work, do you have any suggestions?
Thanks.import javax.swing.*;
import java.awt.event.*;
import java.awt.*;
class Animation extends JPanel implements ActionListener{
    JButton button=new JButton("links");
    JButton button2=new JButton("rechts");
    int xpos=60;
    int xpos2=0;
    int height=15;
    int width=60;
    int dx=3;
    int dxshooter=3;
    int shoot=300;
    int ykogel=0;
    int dxkogel=6;
    int number=12;
    int xposkogel;
    int yposkogel;
    int ovalx1=xpos,ovalx2=xpos+100,ovalx3=xpos+200,ovalx4=xpos+300,ovalx5=xpos+400,ovalx6=xpos+500;
    int ovaly1=15,ovaly2=15,ovaly3=15,ovaly4=15,ovaly5=15,ovaly6=15;
    int ovalxb1=xpos+19,ovalxb2=xpos+19+100,ovalxb3=xpos+19+200,ovalxb4=xpos+19+300,ovalxb5=xpos+19+400,ovalxb6=xpos+19+500;
    int ovalyb1=5,ovalyb2=5,ovalyb3=5,ovalyb4=5,ovalyb5=5,ovalyb6=5;
    Timer fastTicker;
    Animation(){
    fastTicker=new Timer(25,this);
    void start(){
                     Listener ear = new Listener();
                     this.add(button);
                     button.setSize(100,50);
                     button.move(0,320);
                     button.addActionListener(ear);
                     this.add(button2);
                     button2.setSize(100,50);
                     button2.move(600,320);
                     button2.addActionListener(ear);
        fastTicker.start();
class Listener implements ActionListener{
  public void actionPerformed(ActionEvent b)
    Object o =b .getSource();
    if (o == button){
      if(dxshooter==3){
          dxshooter=-3;}
    if (o == button2){
    if(dxshooter==-3){
        dxshooter=3;}
   public void actionPerformed(ActionEvent e){     
   yposkogel=312-ykogel;
   ovalx1=xpos;
   ovalx2=xpos+100;
   ovalx3=xpos+200;
   ovalx4=xpos+300;
   ovalx5=xpos+400;
   ovalx6=xpos+500;
   ovalxb1=xpos+19;
   ovalxb2=xpos+19+100;
   ovalxb3=xpos+19+200;
   ovalxb4=xpos+19+300;
   ovalxb5=xpos+19+400;
   ovalxb6=xpos+19+500;   
              //bolletjesanimatie
               if(e.getSource()==fastTicker){
                ykogel+=dxkogel;
                xposkogel=xpos2;
                xpos2+=dxshooter;
                 if(ykogel>=3){
                 xposkogel=xposkogel;}          
                //schietding
                    if (xpos2>240){
                            dxshooter=-3;}
                    if(xpos2<-210){
                        dxshooter=3;}
               //kogelanimatie
                   if(ykogel>310){
                   ykogel=0;}
               //COMPARING THE POSITION OF THE BULLET WITH THE UFO's
            if(yposkogel<=15){
                    if(xposkogel>=ovalx6&&xposkogel<=ovalx6+60){
                    ovaly6=1500;
                    ovalyb6=1500;}
                    if(xposkogel>=ovalx5&&xposkogel<=ovalx5+60){
                    ovaly5=1500;
                    ovalyb5=1500;}
                    if(xposkogel>=ovalx4&&xposkogel<=ovalx4+60){
                    ovaly4=1500;
                    ovalyb4=1500;}
                    if(xposkogel>=ovalx3&&xposkogel<=ovalx3+60){
                    ovaly3=1500;
                    ovalyb3=1500;}
                    if(xposkogel>=ovalx2&&xposkogel<=ovalx2+60){
                    ovaly2=1500;
                    ovalyb2=1500;}
                    if(xposkogel>=ovalx1&&xposkogel<=ovalx1+60){
                    ovaly1=1500;
                    ovalyb1=1500;}
                 this.repaint();
public void paintComponent(Graphics g){
             super.paintComponent(g);
             //ufo's
             g.setColor(Color.black);
             g.fillOval(ovalxb1,ovalyb1, 25,25); 
             g.setColor(Color.orange); 
             g.fillOval(ovalx1,ovaly1,width,height);
             g.setColor(Color.black);
             g.fillOval(ovalxb2,ovalyb2, 25,25); 
             g.setColor(Color.orange); 
             g.fillOval(ovalx2,ovaly2,width,height);
             g.setColor(Color.black);
             g.fillOval(ovalxb3,ovalyb3, 25,25); 
             g.setColor(Color.orange); 
             g.fillOval(ovalx3,ovaly3,width,height);
             g.setColor(Color.black);
             g.fillOval(ovalxb4,ovalyb4, 25,25); 
             g.setColor(Color.orange); 
             g.fillOval(ovalx4,ovaly4,width,height);
             g.setColor(Color.black);
             g.fillOval(ovalxb5,ovalyb5, 25,25); 
             g.setColor(Color.orange); 
             g.fillOval(ovalx5,ovaly5,width,height);
             g.setColor(Color.black);
             g.fillOval(ovalxb6,ovalyb6, 25,25); 
             g.setColor(Color.orange); 
             g.fillOval(ovalx6,ovaly6,width,height);
            //schietding
             g.fillRect(xpos2+350-17,317,6,40);
             g.setColor(Color.green);
             g.fillOval(xpos2+350-30,330,30,30);
             g.setColor(Color.black);
             g.fillRect(xpos2+350-40,350,50,height);
            //kogel
             g.fillRect(xposkogel+350-16,yposkogel,5,5);     
             public class AnimationDemo{
                 JFrame frame;
                 Animation animation;
                 void demo(){
                     frame=new JFrame("**Spees Inveeders** All rights reserved (Dave Senden and Joeri Oomen)");
                     animation=new Animation();
                     frame.getContentPane().add(animation);
                     frame.setSize(700,400);
                     frame.setVisible(true);
                     animation.start();
  public static void main(String[] args){
        AnimationDemo animationDemo=new AnimationDemo();
        animationDemo.demo();
        }