Using variables in procedures

Question

hey guys
I'm trying to create a procedure to insert data into certain table
what i want to do is :
1)get the max(ID) of a certain table so i can increase it by 1 and insert a new record
2)check a condition and depending on that some execution will be run
here is what i have reached so far but of course it gives a compilation error as I'm not very good at PL/SQL
create or replace procedure Add_Asset(TABLE_NAME VARCHAR2, GEO varchar2)
is
DECLARE
maxID number;
geo_Type varchar(20);
BEGIN
select max(ID) into maxID from PUMP;
select geom_type into geo_Type from geometry_type where table_name='|| TABLE_NAME ||' ;
if geo_Type='POINT' then
execute immediate 'INSERT INTO '|| TABLE_NAME ||' (ID,GEOMETRY) VALUES((geo_Type,SDO_GEOMETRY(3001, -1, SDO_POINT_TYPE('|| GEO ||' ),NULL,NULL))';
end if;
end;
please correct what i have write wrong
and i want to know if I'm using the declared variable within the procedure correctly in the insert statement or what...
thanxxxx a lot

Answer 1

I don't see yet where your max(id) comes in exactly and I am not sure how to pass the SDO_GEOMETRY object in (but I'll give two alternatives):
create or replace procedure add_asset (table_name varchar2, geo varchar2)
is
   maxid      number;
   geo_type   varchar (20);
begin
/* please specify where to use this one: */
  select max (id)
     into maxid
     from pump;
   select geom_type
     into geo_type
     from geometry_type
    where geometry_type.table_name = add_asset.table_name;
   if geo_type = 'POINT'
   then
      /* either this:  */
      execute immediate 'INSERT INTO ' || table_name || ' (ID,GEOMETRY) VALUES (:1,SDO_GEOMETRY(3001, -1, SDO_POINT_TYPE(:2 ),NULL,NULL))' using geo_type, geo;
      /* or this:  */
--    execute immediate 'INSERT INTO ' || table_name || ' (ID,GEOMETRY) VALUES (:1,:2)' using geo_type, sdo_geometry (3001,-1,sdo_point_type (geo),null,null);
   end if;
end add_asset;
/