Where to put GUI_PROGRESS_INDICATOR and error in CLOI_PUT_SIGN_IN_FRONT.

Question

Hello experts,
I am currently debuggin my report and it is giving me a dump when I am trying to use FM
CLOI_PUT_SIGN_IN_FRONT. It says that it only accepts character based values. Also,
based on my code below, where can I put the function GUI_PROGRESS_INDICATOR so users can know
what is happening in my report. This report is kinda long to execute. Also, will it hamper
the performance of my report when using those 2 function modules?
LOOP AT it_final ASSIGNING <fs_final>.
  get records from BKPF
    SELECT SINGLE bukrs belnr gjahr budat bldat xblnr bktxt FROM bkpf
    INTO (bkpf-bukrs, bkpf-belnr, bkpf-gjahr, <fs_final>-budat,
          <fs_final>-bldat, <fs_final>-xblnr, <fs_final>-bktxt)
    WHERE bukrs = <fs_final>-bukrs
      AND belnr = <fs_final>-belnr
      AND gjahr = <fs_final>-gjahr.
  if <fs_final>-shkzg = 'H', multiply dmbtr(amount in local currency)
  by negative 1
    IF <fs_final>-shkzg = 'H'.
       <fs_final>-dmbtr = <fs_final>-dmbtr * -1.
      CALL FUNCTION 'CLOI_PUT_SIGN_IN_FRONT'
      CHANGING
        value         =       <fs_final>-dmbtr.
    ENDIF.
  combine needed data to get long text
    CONCATENATE: <fs_final>-bukrs <fs_final>-belnr
                 <fs_final>-gjahr <fs_final>-buzei
                 INTO it_thead-tdname.
    CALL FUNCTION 'READ_TEXT'
      EXPORTING
        client                        = sy-mandt
        id                            = '0001'
        language                      = sy-langu
        name                          = it_thead-tdname
        object                        = 'DOC_ITEM'
      ARCHIVE_HANDLE                = 0
      LOCAL_CAT                     = ' '
    IMPORTING
      HEADER                        =
      TABLES
        lines                         = it_lines
     EXCEPTIONS
       id                            = 1
       language                      = 2
       name                          = 3
       not_found                     = 4
       object                        = 5
       reference_check               = 6
       wrong_access_to_archive       = 7
       OTHERS                        = 8.
   IF sy-subrc <> 0.
     MESSAGE ID sy-msgid TYPE sy-msgty NUMBER sy-msgno
             WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4.
   ENDIF.
  if successful, split long text into start and end date
    IF sy-subrc = 0.
      READ TABLE it_lines TRANSPORTING tdline.
      IF sy-subrc = 0.
        SPLIT it_lines-tdline AT '-' INTO
              <fs_final>-s_dat <fs_final>-e_dat.
      ENDIF.
    ENDIF.
  get vendor name
    SELECT SINGLE name1 FROM lfa1
    INTO <fs_final>-name1
    WHERE lifnr = <fs_final>-lifnr.
    lv_age_of_rec = p_budat - <fs_final>-budat.
  condition for age of deposits
    IF lv_age_of_rec < 30.
      <fs_final>-amount1 = <fs_final>-dmbtr.
    ELSEIF lv_age_of_rec > 30 AND lv_age_of_rec < 60.
      <fs_final>-amount2 = <fs_final>-dmbtr.
    ELSEIF lv_age_of_rec > 60 AND lv_age_of_rec < 90.
      <fs_final>-amount3 = <fs_final>-dmbtr.
    ELSEIF lv_age_of_rec > 90 AND lv_age_of_rec < 120.
      <fs_final>-amount4 = <fs_final>-dmbtr.
    ELSEIF lv_age_of_rec > 180.
      <fs_final>-amount5 = <fs_final>-dmbtr.
    ENDIF.
    CLEAR: bkpf, it_lines-tdline.
  ENDLOOP.
Again, thanks alot guys and take care!

Answer 1

1) CLOI_PUT_SIGN_IN_FRONT will take any values, Character and numeric. It basically make the sign as pre-fix. Eg 53.6- to -53.6. Better way you could assign it to a Packed decimal and pass it to FM and then reassign it to the field.
2)GUI_PROGRESS_INDICATOR  can be used before the process stats.. For example: you can use it before the select statment with the text 'Database selection...'
rgds,
TM
Message was edited by: Thomas Mann
Message was edited by: Thomas Mann