Zip File Creation

Question

I have a problem with my method for making zip files:
When going throught the folder it appears to be 'skipping' files.
ZipOutputStream output;
    public void createZipFile(String fileName)throws FileNotFoundException
     output = new ZipOutputStream(new BufferedOutputStream(
          new FileOutputStream(fileName)));
    public void zip(String fileName) throws IOException {
     System.out.println("fileName: " + fileName);
     BufferedInputStream input;
     File file = new File(fileName);
     if (!file.exists())
         System.out.println("No such directory");
     File[] list = null;
     if (file.isDirectory())
         list = file.listFiles();
     else {
         byte[] buffer = new byte[512];
         int in = 0;
         System.out.println("File: " + file.getName());
         output.putNextEntry(new ZipEntry(file.getPath()));
         input = new BufferedInputStream(new FileInputStream(file));
         while (true) {
          in = input.read(buffer, 0, 512);
          if (in == -1)
              break;
          output.write(buffer, 0, in);
         output.closeEntry();
         return;
     byte[] buffer = new byte[512];
     int in = 0;
     if (list != null) {
         for (int i = 0; i < list.length; i++) {
          if (list.isDirectory()) {
          zip(list[i].getPath());
          continue;
          System.out.println("File: " + list[i].getName());
          output.putNextEntry(new ZipEntry(list[i].getPath()));
          input = new BufferedInputStream(new FileInputStream(list[i]));
          while (true) {
          in = input.read(buffer, 0, 512);
          if (in == -1)
               break;
          output.write(buffer, 0, in);
          output.closeEntry();
     } else
     return;
Note: createZipFile is called from another function.

Answer 1

I have a problem with my method for making zip files:
When going throught the folder it appears to be 'skipping' files.
ZipOutputStream output;
    public void createZipFile(String fileName)throws FileNotFoundException
     output = new ZipOutputStream(new BufferedOutputStream(
          new FileOutputStream(fileName)));
    public void zip(String fileName) throws IOException {
     System.out.println("fileName: " + fileName);
     BufferedInputStream input;
     File file = new File(fileName);
     if (!file.exists())
         System.out.println("No such directory");
     File[] list = null;
     if (file.isDirectory())
         list = file.listFiles();
     else {
         byte[] buffer = new byte[512];
         int in = 0;
         System.out.println("File: " + file.getName());
         output.putNextEntry(new ZipEntry(file.getPath()));
         input = new BufferedInputStream(new FileInputStream(file));
         while (true) {
          in = input.read(buffer, 0, 512);
          if (in == -1)
              break;
          output.write(buffer, 0, in);
         output.closeEntry();
         return;
     byte[] buffer = new byte[512];
     int in = 0;
     if (list != null) {
         for (int i = 0; i < list.length; i++) {
          if (list.isDirectory()) {
          zip(list[i].getPath());
          continue;
          System.out.println("File: " + list[i].getName());
          output.putNextEntry(new ZipEntry(list[i].getPath()));
          input = new BufferedInputStream(new FileInputStream(list[i]));
          while (true) {
          in = input.read(buffer, 0, 512);
          if (in == -1)
               break;
          output.write(buffer, 0, in);
          output.closeEntry();
     } else
     return;
Note: createZipFile is called from another function.