Insertion error

Question

hi
I am getting an error "ORA-00923: FROM keyword not found where expected" while running the below insert statement.
insert into rp_rpt_sql
select '1','6000100','1','1','insert into rn_rpt_data(dt, rpt_id, rpt_row_id, rpt_col_id, col1, col2, col3, col4, col5, col6, col7, col8, col9, col10) select ''##as_on_dt##'', 6000100, 1, 1, rownum sr_no, v.* from (select e.IECD, (e.IMPORTER_NAME||' '||e.IMPORTER_ADDRESS), (e.IMP_LIC_NO||' '||e.IMP_LIC_DT), e.IMP_ITEMS, e.IMP_REMIT_DT, e.IMP_REMIT_AMT_CCY_ID, e.IMP_REMIT_AMT_CCY, e.IMP_REMIT_AMT_RS, e.REM from rm_bef e where e.as_on_dt = ''##as_on_dt##'' and e.bef_default_id = '1' and e.cust_type = '2') v','select rownum "Sr_No", (IMPORTER_NAME+IMPORTER_ADDRESS) "Name and address of the importer", (IMP_LIC_NO+IMP_LIC_DT) "No. and date of import licenses if any", IMP_ITEMS "Brief Description of goods", IMP_REMIT_DT "Date of reimittances", IMP_REMIT_AMT_CCY_ID "Currency", IMP_REMIT_AMT_CCY "Amount", IMP_REMIT_AMT_RS "Rupee Equivalent", rem "Remarks" from (select e.IECD, (e.IMPORTER_NAME||' '||e.IMPORTER_ADDRESS), (e.IMP_LIC_NO||' '||e.IMP_LIC_DT), e.IMP_ITEMS, e.IMP_REMIT_DT, e.IMP_REMIT_AMT_CCY_ID, e.IMP_REMIT_AMT_CCY, e.IMP_REMIT_AMT_RS, e.REM from rm_bef e where e.as_on_dt = ''##as_on_dt##'' and e.bef_default_id = '1' and e.cust_type = '2')','14' from dual where not exists (select 1 from rp_rpt_sql where rpt_id=6000100);
What could be the problem ?

Answer 1

If you bothered to format your code so you could read it you would easily spot that you've missed escaping your single quotes within strings...
insert into rp_rpt_sql
  select '1'
        ,'6000100'
        ,'1'
        ,'1'
        ,'insert into rn_rpt_data(dt
                                 ,rpt_id
                                 ,rpt_row_id
                                 ,rpt_col_id
                                 ,col1
                                 ,col2
                                 ,col3
                                 ,col4
                                 ,col5
                                 ,col6
                                 ,col7
                                 ,col8
                                 ,col9
                                 ,col10)
          select ''##as_on_dt##''
                ,6000100
                ,1
                ,1
                ,rownum sr_no
                ,v.*
          from (select e.IECD
                      ,(e.IMPORTER_NAME||' '||e.IMPORTER_ADDRESS)  <-- HERE
                      ,(e.IMP_LIC_NO||' '||e.IMP_LIC_DT)           <-- HERE
                      ,e.IMP_ITEMS
                      ,e.IMP_REMIT_DT
                      ,e.IMP_REMIT_AMT_CCY_ID
                      ,e.IMP_REMIT_AMT_CCY
                      ,e.IMP_REMIT_AMT_RS
                      ,e.REM
                from  rm_bef e
                where e.as_on_dt = ''##as_on_dt##''
                and   e.bef_default_id = '1'                       <-- HERE
                and   e.cust_type = '2'                            <-- HERE
               ) v'
        ,'select rownum "Sr_No"
                ,(IMPORTER_NAME+IMPORTER_ADDRESS) "Name and address of the importer"
                ,(IMP_LIC_NO+IMP_LIC_DT) "No. and date of import licenses if any"
                ,IMP_ITEMS "Brief Description of goods"
                ,IMP_REMIT_DT "Date of reimittances"
                ,IMP_REMIT_AMT_CCY_ID "Currency"
                ,IMP_REMIT_AMT_CCY "Amount"
                ,IMP_REMIT_AMT_RS "Rupee Equivalent"
                ,rem "Remarks"
          from (select e.IECD
                      ,(e.IMPORTER_NAME||' '||e.IMPORTER_ADDRESS)  <-- HERE
                      ,(e.IMP_LIC_NO||' '||e.IMP_LIC_DT)           <-- HERE
                      ,e.IMP_ITEMS
                      ,e.IMP_REMIT_DT
                      ,e.IMP_REMIT_AMT_CCY_ID
                      ,e.IMP_REMIT_AMT_CCY
                      ,e.IMP_REMIT_AMT_RS
                      ,e.REM
                from  rm_bef e
                where e.as_on_dt = ''##as_on_dt##''
                and   e.bef_default_id = '1'                       <-- HERE
                and   e.cust_type = '2'                            <-- HERE
        ,'14'
from  dual
where not exists (select 1 from rp_rpt_sql where rpt_id=6000100);... though why you are storing SQL statements in a table, I don't know. Ever heard of SQL injection?