Actions in JPopupMenu
Hello,
I noticed lately by using a reference viewer tool that I've got more and more instances of a JPopupmenu on the heap. Every time I right click I create a new menu and show it. The menu uses actions as menuitems. The problem seems to be, that I use actions that are singletons or used elsewhere. When I add them to the popupmenu they get linked in both directions to the menu item. So, as long an action lives, that long will the popupmenu stay on the heap.
A solution I found is to set the action of all JMenuItems of the popupmenu to null (with setAction(null)) which deregisters the MenuItem as listener and so the Popupmenu is no longer referenced and can be GCed.
The point is, when should this happen? I tried it with popupMenuListener.popupMenuWillBecomeInvisible(). Yeah, it cleans everything fine, but too early. The event is not dispatched to the action anymore.
I think its not a severe problem by now, but now I know that there are useless objects created with every popupmenu and I want to clean them up in the right way.
Did anybody have the same problem? Is there a solution?
Some thoughts:
- is it a bad idea to use actions that are singletons?
- should I reuse the JPopupmenus (singletons/manager)
- when could I clean up independently? Is there an event I can listen for?
Thank you for reading this post,
hope you've got an answer.
Michael
what if you reuse the same JPopupMenu for all popups?
Similar Messages
-
JWindow, JPopupMenu and flicker.
I've trawled through earlier posts to these forums and found problems which, from their description, appear similar, but I haven't been able to find any answers that work for me. I would be very grateful for any assistance.
I have a JWindow sized to fill the entire screen. This JWindow contains a subclass of JPanel which draws a diagram. The user clicks on elements of the diagram and pops up a JPopupMenu to select actions. JPopupMenu.show() is called with the JPanel as the invoker argument and x and y coords calculated so that it is always contained within the JPanel. As the JPopupMenu is shown and hidden there is a very noticable flicker.
However, when the JPanel is contained in a JFrame there is no flicker.
At first I thought this was a double buffering problem, but this doesn't seem to be the case.
Any thoughts?
Thanks.Try to call the JPopupMenu on a new Thread.
Noah -
Hello, In a JTable i want when the user press the right button of the mouse to chose an action on JPopupMenu it automaticly select the row where the Press The Right Button.
In your MouseListener you use table.getRowAtPoint(...) to get the row, then you can use table.setRowSelectionInverval(...) to select the row.
-
Messagebox that displays a different randum number every 2 secs
well im having trouble with putting a messagebox that displays a different randum number every 2 secs and closes with a close button. it goes in the print menu option of this simple text editor,you shoud also be able to work in the background while this message box is been displayed.
import javax.swing.*;
import javax.swing.text.*;
import javax.swing.text.rtf.*;
import javax.swing.event.*;
import javax.swing.filechooser.*;
import javax.swing.undo.*;
import java.util.Timer;
import java.util.TimerTask;
import java.awt.*;
import java.awt.event.*;
import java.io.*;
import java.util.*;
import java.beans.*;
-------------------| Simple Text Editor example application using Java 1.3 with Swing |--------------
public class SimpleTextEditor extends JFrame
private JTextPane textpane;
private JMenuBar mb;
private JFileChooser chooser,picChooser;
private Hashtable actions;
private JPopupMenu popup;
private JMenuItem exit, newDoc, save, open, saveAs,print;
private About ab;
private StyledEditorKit edkit;
private RTFEditorKit rtfkit;
private DefaultStyledDocument doc;
private MyDocumentListener doclistener;
private MyUndoableEditListener undolistener;
//Useful variables
private String filename="untitled1.txt",filetype=".txt";
private File thisfile;
protected String FileFormats[],FileDescriptions[],PicFileFormats[],PicFileDescriptions[];
protected boolean DocumentIsUnedited=true, DocumentIsSaved=false;
public static int SQUARE=0,TRIANGLE=1,CIRCLE=2;
public String newline="\n";
protected UndoManager undo ;
protected UndoAction undoAction;
protected RedoAction redoAction;
// These are the actions used in the menus and on the toolbar
protected Action bold, italic, underline, alignleft, alignright, aligncentre;
protected Action spellchecker, alignjustify, more, cut, copy, paste, tools[];
public SimpleTextEditor()
super("SimpleTextEditor - untitled1.rtf");
this.setLocation(200,200);
this.setIconImage(getMyIcon("Icon.gif").getImage());
getContentPane().setLayout(new BorderLayout());
undo = new UndoManager();
//Set up the file formats and file choosers etc
FileFormats = new String[]{".rtf",".txt",".java",".bat"};
FileDescriptions = new String[]{"Rich Text Format Files","Text Files","Java Source Files","DOS Batch Files"};
PicFileFormats = new String[]{".gif",".bmp",".jpg"};
PicFileDescriptions = new String[]{"Gif Images","Bitmap Images","JPEG Images"};
chooser = new JFileChooser();
picChooser = new JFileChooser();
picChooser.setAccessory(new ImagePreview(picChooser));
javax.swing.filechooser.FileFilter defaultFilter = new SimpleFilter(FileFormats[0],FileDescriptions[0]);
javax.swing.filechooser.FileFilter defaultPicFilter = new SimpleFilter(PicFileFormats[0],PicFileDescriptions[0]);
for(int i=1;i<FileFormats.length;i++){
chooser.addChoosableFileFilter(new SimpleFilter(FileFormats,FileDescriptions[i]));
for(int i=1;i<PicFileFormats.length;i++){
picChooser.addChoosableFileFilter(new SimpleFilter(PicFileFormats[i],PicFileDescriptions[i]));
chooser.setFileFilter(defaultFilter);
picChooser.setFileFilter(defaultPicFilter);
File working = new File("C:/Documents");
if(!working.exists()){
working= new File("C:/MyDocuments");
if(!working.exists()) working = new File("C:/");
if(working.exists()) {
chooser.setCurrentDirectory(working);
picChooser.setCurrentDirectory(working);
// Set up Document object and Editor kits
doc = new DefaultStyledDocument();
edkit = new StyledEditorKit();
rtfkit = new RTFEditorKit();
// Set up Listener objects
doclistener= new MyDocumentListener();
undolistener= new MyUndoableEditListener();
doc.addDocumentListener(doclistener);
doc.addUndoableEditListener(undolistener);
//Set up main GUI content
textpane=new JTextPane(doc);
textpane.setPreferredSize(new Dimension(400,400));
textpane.setMinimumSize(new Dimension(400,400));
JScrollPane scroller=new JScrollPane(textpane);
scroller.setPreferredSize(new Dimension(400,400));
mb=new JMenuBar(); // Create a menu bar
JMenu File=new JMenu("File");
JMenu Help=new JMenu("Help");
//Sort out Actions etc
createActionTable(textpane);
createToolbarActions();
JMenu Style=createStyleMenu();
undoAction = new UndoAction();
redoAction = new RedoAction();
//Create Style, Edit and Format menus + Toolbar
JMenu Edit=createEditMenu();
JMenu Format=createFormatMenu();
JMenu Insert = createInsertMenu();
JToolBar toolbar = createToolbar();
getContentPane().add("North",toolbar);
// set up main menu items with ActionListeners
newDoc=new JMenuItem("New");
newDoc.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
newDoc();
exit=new JMenuItem("Exit");
exit.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
exit();
print=new JMenuItem("Print");
print.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
print();
save=new JMenuItem("Save");
save.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
save();
saveAs=new JMenuItem("Save As...");
saveAs.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
saveas();
open=new JMenuItem("Open...");
open.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
open();
JMenuItem about=new JMenuItem("About");
about.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
ab=new About(SimpleTextEditor.this);
ab.show();
ab.setLocation(400,300);
// Create the popup menu
popup = createEditMenu().getPopupMenu();
popup.addSeparator();
popup.add(createStyleMenu());
popup.add(createFormatMenu());
textpane.add(popup);
// set up Help and File menus
Help.add(about);
File.add(newDoc);
File.add(open);
File.add(print);
File.add(save);
File.add(saveAs);
File.addSeparator();
File.add(exit);
// add the menus to the menubar
mb.add(File);
mb.add(Edit);
mb.add(Format);
mb.add(Style);
mb.add(Insert);
mb.add(Help);
this.setJMenuBar(mb);
getContentPane().add("Center",scroller);
// Add mouse Listener to the textpane for popup events
textpane.addMouseListener(new MouseAdapter(){
public void mousePressed(MouseEvent e)
if(e.isPopupTrigger())
popup.show(textpane, e.getX(), e.getY());
e.consume();
public void mouseReleased(MouseEvent e)
if(e.isPopupTrigger())
popup.show(textpane, e.getX(), e.getY());
e.consume();
//-----------------| Main active methods |------------------
public void exit()// Main Exit method
if(DocumentIsUnedited){//Check that document is saved/unedited etc
dispose();
setVisible(false);
System.exit(0);
else{
switch(showNotSavedDialog("Exit")){
case JOptionPane.YES_OPTION: save(); exit(); break;
case JOptionPane.NO_OPTION: DocumentIsUnedited=true;exit();break;
case JOptionPane.CANCEL_OPTION: break;
public void newDoc()//Method to create new documents
if(DocumentIsUnedited){
initDoc();
filename="untitled.txt";
filetype=".txt";
resetTitle();
else
switch(showNotSavedDialog("New Document")){
case JOptionPane.YES_OPTION: save(); newDoc(); break;
case JOptionPane.NO_OPTION: DocumentIsUnedited=true;newDoc();break;
case JOptionPane.CANCEL_OPTION: break;
private void initDoc()// Helper method to initialize a new document
doc = null;
doc = (DefaultStyledDocument)edkit.createDefaultDocument();
doc.addDocumentListener(doclistener);
textpane.setStyledDocument(doc);
public void print()
new TimerTestFrame();
class TimerTestFrame extends JFrame
Timer timer;
TimerTestFrame()
super();
timer = new Timer(true);
TimerTask task = new MessageTimer(TimerTestFrame.this);
timer.schedule(task,2000,2000);
class MessageTimer extends TimerTask
Component parent;
public MessageTimer(Component parent)
this.parent = parent;
public void run()
int randnum = (1 +(int)(Math.random()*10));
JOptionPane.showMessageDialog(parent,""+randnum,"Timer Message",JOptionPane.INFORMATION_MESSAGE);
public void saveas()
int n = chooser.showSaveDialog(this);
if(n==0){
filename=chooser.getSelectedFile().getName();
boolean ext = false;
setFiletype();
thisfile = new File(chooser.getCurrentDirectory(),filename);
DocumentIsSaved=true;
save();
resetTitle();
repaint();
public void save()// Save method. Used by "Save As..." as well
if( DocumentIsSaved)
try
FileOutputStream out = new FileOutputStream(thisfile);
if((filetype.equals(".rtf"))||(filetype.equals(".doc"))){
rtfkit.write(out,doc,0,doc.getLength());
else edkit.write(out,doc,0,doc.getLength());
catch(Exception e)
System.out.println(""+e.getMessage()+"");
DocumentIsUnedited=true;
else saveas();
public void open()// Find a file and read it into the document
if(DocumentIsUnedited){
int n = chooser.showOpenDialog(this); // get the outcome of the dialog
if(n==0){
File file = chooser.getSelectedFile();
filename=chooser.getName(file);
setFiletype();
resetTitle();
initDoc();
try
FileInputStream in= new FileInputStream(file);
if(filetype.equals(".rtf")){
rtfkit.read(in,doc,0);
edkit.read(in,doc,0);
catch(Exception e)
System.out.println(""+e.getMessage()+"");
thisfile= new File(chooser.getCurrentDirectory(),chooser.getSelectedFile().getName());
DocumentIsUnedited=true;
DocumentIsSaved=true;
resetTitle();
repaint();
else
switch(showNotSavedDialog("Open")){
case JOptionPane.YES_OPTION: save(); open(); break;
case JOptionPane.NO_OPTION: DocumentIsUnedited=true; open(); break;
case JOptionPane.CANCEL_OPTION: break;
private void setFiletype()// Helper method to get the filetype of saved/opened documents
filetype=null;
for(int i=0;i<FileFormats.length;i++){
if(filename.toLowerCase().endsWith(FileFormats[i])) filetype = FileFormats[i];
else{
for(i=0;i<filename.length();i++){
if(filename.toLowerCase().charAt(i)=='.')
filetype=filename.substring(i);
if(filetype==null) filetype=".txt";
private void resetTitle()
this.setTitle("SimpleTextEditor - "+filename);
private ImageIcon getMyIcon(String filename){
ImageIcon pic = new ImageIcon("Images/"+filename);
return pic;
private int showNotSavedDialog(String title)// Helper method to create "Save? Yes/No/Cancel" dialogs
int n = JOptionPane.showConfirmDialog(this,"The last document has not been saved. \nDo you want to save it first?",
title,
JOptionPane.YES_NO_CANCEL_OPTION,
JOptionPane.QUESTION_MESSAGE);
return n;
//-----------------| Listeners and Helper classes |----------------
protected class MyDocumentListener implements DocumentListener
public void insertUpdate(DocumentEvent e) {
SimpleTextEditor.this.DocumentIsUnedited=false;
public void removeUpdate(DocumentEvent e) {
SimpleTextEditor.this.DocumentIsUnedited=false;
public void changedUpdate(DocumentEvent e) {
SimpleTextEditor.this.DocumentIsUnedited=false;
protected class MyUndoableEditListener implements UndoableEditListener {
public void undoableEditHappened(UndoableEditEvent e) {
//Remember the edit and update the menus.
undo.addEdit(e.getEdit());
undoAction.updateUndoState();
redoAction.updateRedoState();
//Helper class for FileFilter, allows a description to be assigned to a filetype
protected class SimpleFilter extends javax.swing.filechooser.FileFilter
String type,des;
public SimpleFilter(String type, String des)
this.des=des;
this.type=type;
public boolean accept(File f){
if(f.isDirectory())return true;
else{
if(f.getName().toLowerCase().endsWith(type)) return true;
else return false;
public String getDescription(){
return des;
//------------| Methods to help create menus and toolbar |--------------
protected JMenu createStyleMenu()
JMenu menu = new JMenu("Style");
menu.add(bold);
menu.add(italic);
menu.add(underline);
menu.addSeparator();
menu.add(new StyledEditorKit.FontSizeAction("12", 12));
menu.add(new StyledEditorKit.FontSizeAction("14", 14));
menu.add(new StyledEditorKit.FontSizeAction("18", 18));
menu.addSeparator();
menu.add(new StyledEditorKit.FontFamilyAction("Serif","Serif"));
menu.add(new StyledEditorKit.FontFamilyAction("SansSerif","SansSerif"));
menu.addSeparator();
Action red = new StyledEditorKit.ForegroundAction("Red", new Color(255,0,0));
red.putValue(Action.SMALL_ICON,getMyIcon("red.gif"));
menu.add(red);
Action green = new StyledEditorKit.ForegroundAction("Green", new Color(0,150,0));
green.putValue(Action.SMALL_ICON,getMyIcon("green.gif"));
menu.add(green);
Action blue = new StyledEditorKit.ForegroundAction("Blue", new Color(0,50,150));
blue.putValue(Action.SMALL_ICON,getMyIcon("blue.gif"));
menu.add(blue);
Action black = new StyledEditorKit.ForegroundAction("Black", new Color(0,0,0));
black.putValue(Action.SMALL_ICON,getMyIcon("black.gif"));
menu.add(black);
menu.add(more);
return menu;
protected JMenu createEditMenu() {
JMenu menu = new JMenu("Edit");
menu.add(undoAction);
menu.add(redoAction);
menu.addSeparator();
menu.add(cut);
menu.add(copy);
menu.add(paste);
menu.addSeparator();
Action selectall=getActionByName(DefaultEditorKit.selectAllAction);
selectall.putValue(Action.NAME, "Select All");
menu.add(selectall);
return menu;
protected JMenu createFormatMenu(){
JMenu menu = new JMenu("Format");
menu.add(spellchecker);
menu.add(alignleft);
menu.add(alignright);
menu.add(aligncentre);
menu.add(alignjustify);
return menu;
protected JMenu createInsertMenu(){
JMenu menu = new JMenu("Insert");
Action insertimage = new InsertImageAction(this);
menu.add(insertimage);
Action insertdate = new InsertDateAction();
menu.add(insertdate);
Action insertline = new InsertLineAction();
menu.add(insertline);
JMenu bullets =new JMenu("Bullet Points");
bullets.add(new InsertBulletAction(CIRCLE,"Circle"));
bullets.add(new InsertBulletAction(TRIANGLE,"Triangle"));
bullets.add(new InsertBulletAction(SQUARE,"Square"));
menu.add(bullets);
return menu;
public JToolBar createToolbar(){
JToolBar bar= new JToolBar();
JButton newbutton=new JButton(getMyIcon("new.gif"));
newbutton.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
newDoc();
bar.add(newbutton);
JButton savebutton=new JButton(getMyIcon("save.gif"));
savebutton.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
save();
bar.add(savebutton);
JButton openbutton=new JButton(getMyIcon("open.gif"));
openbutton.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e)
open();
bar.add(openbutton);
bar.addSeparator();
for(int i=0;i<tools.length;i++){
JButton button=new JButton();
button.setAction(tools[i]);
button.setIcon(getMyIcon(tools[i].getValue(Action.NAME)+".gif"));
button.setText("");
bar.add(button);
if((i==2)||(i==6))bar.addSeparator();
return bar;
public void createToolbarActions(){
bold = new StyledEditorKit.BoldAction();
bold.putValue(Action.NAME, "Bold");
italic = new StyledEditorKit.ItalicAction();
italic.putValue(Action.NAME, "Italic");
underline = new StyledEditorKit.UnderlineAction();
underline.putValue(Action.NAME, "Underline");
more = new MoreColorsAction();
cut = getActionByName(DefaultEditorKit.cutAction);
cut.putValue(Action.NAME, "Cut");
copy = getActionByName(DefaultEditorKit.copyAction);
copy.putValue(Action.NAME, "Copy");
paste = getActionByName(DefaultEditorKit.pasteAction);
paste.putValue(Action.NAME, "Paste");
alignleft = new StyledEditorKit.AlignmentAction("Left Justify",StyleConstants.ALIGN_LEFT);
alignright = new StyledEditorKit.AlignmentAction("Right Justify",StyleConstants.ALIGN_RIGHT);
aligncentre = new StyledEditorKit.AlignmentAction("Align Centre",StyleConstants.ALIGN_CENTER);
alignjustify = new StyledEditorKit.AlignmentAction("Fully Justify",StyleConstants.ALIGN_JUSTIFIED);
spellchecker = new StyledEditorKit.AlignmentAction("Spell Checker",StyleConstants.ALIGN_JUSTIFIED);
tools = new Action[]{ cut, copy, paste, bold, italic, underline, more, alignleft, alignright, aligncentre, alignjustify, spellchecker };
// helper methods to enable menu creators to get their actions by name
private void createActionTable(JTextComponent textComponent) {
actions = new Hashtable();
Action[] actionsArray = textComponent.getActions();
for (int i = 0; i < actionsArray.length; i++) {
Action a = actionsArray[i];
actions.put(a.getValue(Action.NAME), a);
private Action getActionByName(String name) {
return (Action)(actions.get(name));
//----------------| Custom Actions |--------------------
class InsertImageAction extends AbstractAction {
protected SimpleTextEditor parent;
public InsertImageAction(SimpleTextEditor parent){
super("Image...");
this.parent=parent;
public void actionPerformed(ActionEvent e) {
int n = parent.picChooser.showOpenDialog(parent);
if(n==0){
String filename=picChooser.getSelectedFile().getName();
File file = new File(picChooser.getCurrentDirectory(),filename);
Icon pic = new ImageIcon(file.getAbsolutePath());
textpane.insertIcon(pic);
SimpleTextEditor.this.repaint();
class InsertDateAction extends AbstractAction {
public InsertDateAction(){
super("Date");
public void actionPerformed(ActionEvent ble) {
Calendar c= Calendar.getInstance();
String[] months= new String[]{"01","02","03","04","05","06","07","08","09","10","11","12"};
textpane.replaceSelection(c.get(c.DAY_OF_MONTH)+"/"+months[c.get(c.MONTH)]+"/"+c.get(c.YEAR));
class InsertLineAction extends AbstractAction {
public InsertLineAction(){
super("Horizontal line");
public void actionPerformed(ActionEvent e) {
Icon pic = new ImageIcon("Images/line.gif");
textpane.insertIcon(pic);
class InsertBulletAction extends AbstractAction {
protected int type;
protected String filenames[] = new String[]{"square.gif","triangle.gif","circle.gif"};
public InsertBulletAction(int type,String name){
super(name);
this.type=type;
this.putValue(SMALL_ICON,new ImageIcon("Images/"+filenames[type]));
public void actionPerformed(ActionEvent e) {
Icon pic = new ImageIcon("Images/"+filenames[type]);
textpane.insertIcon(pic);
textpane.replaceSelection(" ");
class MoreColorsAction extends AbstractAction {
public MoreColorsAction(){
super("More Colors");
public void actionPerformed(ActionEvent e){
AttributeSet as = textpane.getCharacterAttributes();
SimpleAttributeSet sas = new SimpleAttributeSet(as);
Color newColor = JColorChooser.showDialog(
SimpleTextEditor.this,
"CHere you go guys:
Peace!
import javax.swing.*;
import javax.swing.Timer;
import javax.swing.border.BevelBorder;
import javax.swing.text.*;
import javax.swing.text.rtf.*;
import javax.swing.event.*;
import javax.swing.filechooser.*;
import javax.swing.undo.*;
import java.awt.*;
import java.awt.event.*;
import java.io.*;
import java.util.*;
import java.beans.*;
-------------------| Simple Text Editor example application using Java 1.3 with Swing |--------------
public class SimpleTextEditor extends JFrame
private JTextPane textpane;
private JMenuBar mb;
private JFileChooser chooser,picChooser;
private Hashtable actions;
private JPopupMenu popup;
private JMenuItem exit, newDoc, save, open, saveAs,print;
private About ab;
private StyledEditorKit edkit;
private RTFEditorKit rtfkit;
private DefaultStyledDocument doc;
private MyDocumentListener doclistener;
private MyUndoableEditListener undolistener;
//Useful variables
private String filename = "untitled1.txt",filetype = ".txt";
private File thisfile;
protected String FileFormats[],FileDescriptions[],PicFileFormats[],PicFileDescriptions[];
protected boolean DocumentIsUnedited = true, DocumentIsSaved = false;
public static int SQUARE = 0,TRIANGLE = 1,CIRCLE = 2;
public String newline = "\n";
protected UndoManager undo;
protected UndoAction undoAction;
protected RedoAction redoAction;
// These are the actions used in the menus and on the toolbar
protected Action bold, italic, underline, alignleft, alignright, aligncentre;
protected Action spellchecker, alignjustify, more, cut, copy, paste, tools[];
public SimpleTextEditor()
super("SimpleTextEditor - untitled1.rtf");
this.setLocation(200, 200);
this.setIconImage(getMyIcon("Icon.gif").getImage());
getContentPane().setLayout(new BorderLayout());
undo = new UndoManager();
//Set up the file formats and file choosers etc
FileFormats = new String[]{".rtf", ".txt", ".java", ".bat"};
FileDescriptions = new String[]{"Rich Text Format Files", "Text Files", "Java Source Files", "DOS Batch Files"};
PicFileFormats = new String[]{".gif", ".bmp", ".jpg"};
PicFileDescriptions = new String[]{"Gif Images", "Bitmap Images", "JPEG Images"};
chooser = new JFileChooser();
picChooser = new JFileChooser();
picChooser.setAccessory(new ImagePreview(picChooser));
javax.swing.filechooser.FileFilter defaultFilter = new SimpleFilter(FileFormats[0], FileDescriptions[0]);
javax.swing.filechooser.FileFilter defaultPicFilter = new SimpleFilter(PicFileFormats[0], PicFileDescriptions[0]);
for (int i = 1; i < FileFormats.length; i++)
chooser.addChoosableFileFilter(new SimpleFilter(FileFormats, FileDescriptions[i]));
for (int i = 1; i < PicFileFormats.length; i++)
picChooser.addChoosableFileFilter(new SimpleFilter(PicFileFormats[i], PicFileDescriptions[i]));
chooser.setFileFilter(defaultFilter);
picChooser.setFileFilter(defaultPicFilter);
File working = new File("C:/Documents");
if (!working.exists())
working = new File("C:/MyDocuments");
if (!working.exists()) working = new File("C:/");
if (working.exists())
chooser.setCurrentDirectory(working);
picChooser.setCurrentDirectory(working);
// Set up Document object and Editor kits
doc = new DefaultStyledDocument();
edkit = new StyledEditorKit();
rtfkit = new RTFEditorKit();
// Set up Listener objects
doclistener = new MyDocumentListener();
undolistener = new MyUndoableEditListener();
doc.addDocumentListener(doclistener);
doc.addUndoableEditListener(undolistener);
//Set up main GUI content
textpane = new JTextPane(doc);
textpane.setPreferredSize(new Dimension(400, 400));
textpane.setMinimumSize(new Dimension(400, 400));
JScrollPane scroller = new JScrollPane(textpane);
scroller.setPreferredSize(new Dimension(400, 400));
mb = new JMenuBar(); // Create a menu bar
JMenu File = new JMenu("File");
JMenu Help = new JMenu("Help");
//Sort out Actions etc
createActionTable(textpane);
createToolbarActions();
JMenu Style = createStyleMenu();
undoAction = new UndoAction();
redoAction = new RedoAction();
//Create Style, Edit and Format menus + Toolbar
JMenu Edit = createEditMenu();
JMenu Format = createFormatMenu();
JMenu Insert = createInsertMenu();
JToolBar toolbar = createToolbar();
getContentPane().add("North", toolbar);
// set up main menu items with ActionListeners
newDoc = new JMenuItem("New");
newDoc.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
newDoc();
exit = new JMenuItem("Exit");
exit.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
exit();
print = new JMenuItem("Print");
print.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
print();
save = new JMenuItem("Save");
save.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
save();
saveAs = new JMenuItem("Save As...");
saveAs.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
saveas();
open = new JMenuItem("Open...");
open.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
open();
JMenuItem about = new JMenuItem("About");
about.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
ab = new About(SimpleTextEditor.this);
ab.show();
ab.setLocation(400, 300);
// Create the popup menu
popup = createEditMenu().getPopupMenu();
popup.addSeparator();
popup.add(createStyleMenu());
popup.add(createFormatMenu());
textpane.add(popup);
// set up Help and File menus
Help.add(about);
File.add(newDoc);
File.add(open);
File.add(print);
File.add(save);
File.add(saveAs);
File.addSeparator();
File.add(exit);
// add the menus to the menubar
mb.add(File);
mb.add(Edit);
mb.add(Format);
mb.add(Style);
mb.add(Insert);
mb.add(Help);
this.setJMenuBar(mb);
getContentPane().add("Center", scroller);
// Add mouse Listener to the textpane for popup events
textpane.addMouseListener(new MouseAdapter()
public void mousePressed(MouseEvent e)
if (e.isPopupTrigger())
popup.show(textpane, e.getX(), e.getY());
e.consume();
public void mouseReleased(MouseEvent e)
if (e.isPopupTrigger())
popup.show(textpane, e.getX(), e.getY());
e.consume();
//-----------------| Main active methods |------------------
public void exit()// Main Exit method
if (DocumentIsUnedited)
{//Check that document is saved/unedited etc
dispose();
setVisible(false);
System.exit(0);
else
switch (showNotSavedDialog("Exit"))
case JOptionPane.YES_OPTION:
save();
exit();
break;
case JOptionPane.NO_OPTION:
DocumentIsUnedited = true;
exit();
break;
case JOptionPane.CANCEL_OPTION:
break;
public void newDoc()//Method to create new documents
if (DocumentIsUnedited)
initDoc();
filename = "untitled.txt";
filetype = ".txt";
resetTitle();
else
switch (showNotSavedDialog("New Document"))
case JOptionPane.YES_OPTION:
save();
newDoc();
break;
case JOptionPane.NO_OPTION:
DocumentIsUnedited = true;
newDoc();
break;
case JOptionPane.CANCEL_OPTION:
break;
private void initDoc()// Helper method to initialize a new document
doc = null;
doc = (DefaultStyledDocument) edkit.createDefaultDocument();
doc.addDocumentListener(doclistener);
textpane.setStyledDocument(doc);
public void print()
new TimerTestDialog(this);
class TimerTestDialog extends JDialog
TimerTestDialog(Frame parent)
super(parent);
setLocationRelativeTo(parent);
setupDialog();
setModal(false); // this will allow you to do still stuff with the main frame
* sorry, using a Timer instead of your original TimerTask - it's simpler
Timer t = new Timer(2000, ticker);
t.start();
private void setupDialog()
Container c = getContentPane();
c.setLayout(new BorderLayout());
c.add(getDisplayPanel(), BorderLayout.CENTER);
c.add(getButtonPanel(), BorderLayout.SOUTH);
setSize(300, 150);
setVisible(true);
private Component getDisplayPanel()
label = new JLabel("---", JLabel.CENTER);
label.setBorder(BorderFactory.createBevelBorder(BevelBorder.LOWERED));
JPanel panel = new JPanel(new BorderLayout());
panel.setBorder(BorderFactory.createEmptyBorder(10, 10, 10, 10));
JPanel backing = new JPanel(new BorderLayout());
backing.add(label, BorderLayout.NORTH); // this will ensure the label doesn't go all tall
panel.add(backing, BorderLayout.CENTER);
return panel;
private Component getButtonPanel()
JPanel panel = new JPanel(new BorderLayout());
panel.setBorder(BorderFactory.createEmptyBorder(10, 10, 10, 10));
JPanel backing = new JPanel(new BorderLayout());
JButton closeButton = new JButton("close");
closeButton.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
dispose();
backing.add(closeButton, BorderLayout.NORTH);
panel.add(backing, BorderLayout.EAST);
return panel;
private ActionListener ticker = new ActionListener()
public void actionPerformed(ActionEvent e)
label.setText(String.valueOf(getRandomNumber()));
private int getRandomNumber()
return r.nextInt(10) + 1; // shift from 0-9 to 1-10
private JLabel label;
* NOTE - this is the best way to use random stuff in java. if you use instance members
* you can sometimes get the same result each time. not really sure how that works but
* i've seen it happen
private static Random r = new Random();
public void saveas()
int n = chooser.showSaveDialog(this);
if (n == 0)
filename = chooser.getSelectedFile().getName();
boolean ext = false;
setFiletype();
thisfile = new File(chooser.getCurrentDirectory(), filename);
DocumentIsSaved = true;
save();
resetTitle();
repaint();
public void save()// Save method. Used by "Save As..." as well
if (DocumentIsSaved)
try
FileOutputStream out = new FileOutputStream(thisfile);
if ((filetype.equals(".rtf")) || (filetype.equals(".doc")))
rtfkit.write(out, doc, 0, doc.getLength());
else
edkit.write(out, doc, 0, doc.getLength());
catch (Exception e)
System.out.println("" + e.getMessage() + "");
DocumentIsUnedited = true;
else
saveas();
public void open()// Find a file and read it into the document
if (DocumentIsUnedited)
int n = chooser.showOpenDialog(this); // get the outcome of the dialog
if (n == 0)
File file = chooser.getSelectedFile();
filename = chooser.getName(file);
setFiletype();
resetTitle();
initDoc();
try
FileInputStream in = new FileInputStream(file);
if (filetype.equals(".rtf"))
rtfkit.read(in, doc, 0);
edkit.read(in, doc, 0);
catch (Exception e)
System.out.println("" + e.getMessage() + "");
thisfile = new File(chooser.getCurrentDirectory(), chooser.getSelectedFile().getName());
DocumentIsUnedited = true;
DocumentIsSaved = true;
resetTitle();
repaint();
else
switch (showNotSavedDialog("Open"))
case JOptionPane.YES_OPTION:
save();
open();
break;
case JOptionPane.NO_OPTION:
DocumentIsUnedited = true;
open();
break;
case JOptionPane.CANCEL_OPTION:
break;
private void setFiletype()// Helper method to get the filetype of saved/opened documents
filetype = null;
for (int i = 0; i < FileFormats.length; i++)
if (filename.toLowerCase().endsWith(FileFormats[i]))
filetype = FileFormats[i];
else
for (i = 0; i < filename.length(); i++)
if (filename.toLowerCase().charAt(i) == '.')
filetype = filename.substring(i);
if (filetype == null) filetype = ".txt";
private void resetTitle()
this.setTitle("SimpleTextEditor - " + filename);
private ImageIcon getMyIcon(String filename)
ImageIcon pic = new ImageIcon("Images/" + filename);
return pic;
private int showNotSavedDialog(String title)// Helper method to create "Save? Yes/No/Cancel" dialogs
int n = JOptionPane.showConfirmDialog(this, "The last document has not been saved. \nDo you want to save it first?",
title,
JOptionPane.YES_NO_CANCEL_OPTION,
JOptionPane.QUESTION_MESSAGE);
return n;
//-----------------| Listeners and Helper classes |----------------
protected class MyDocumentListener implements DocumentListener
public void insertUpdate(DocumentEvent e)
SimpleTextEditor.this.DocumentIsUnedited = false;
public void removeUpdate(DocumentEvent e)
SimpleTextEditor.this.DocumentIsUnedited = false;
public void changedUpdate(DocumentEvent e)
SimpleTextEditor.this.DocumentIsUnedited = false;
protected class MyUndoableEditListener implements UndoableEditListener
public void undoableEditHappened(UndoableEditEvent e)
//Remember the edit and update the menus.
undo.addEdit(e.getEdit());
undoAction.updateUndoState();
redoAction.updateRedoState();
//Helper class for FileFilter, allows a description to be assigned to a filetype
protected class SimpleFilter extends javax.swing.filechooser.FileFilter
String type,des;
public SimpleFilter(String type, String des)
this.des = des;
this.type = type;
public boolean accept(File f)
if (f.isDirectory())
return true;
else
if (f.getName().toLowerCase().endsWith(type))
return true;
else
return false;
public String getDescription()
return des;
//------------| Methods to help create menus and toolbar |--------------
protected JMenu createStyleMenu()
JMenu menu = new JMenu("Style");
menu.add(bold);
menu.add(italic);
menu.add(underline);
menu.addSeparator();
menu.add(new StyledEditorKit.FontSizeAction("12", 12));
menu.add(new StyledEditorKit.FontSizeAction("14", 14));
menu.add(new StyledEditorKit.FontSizeAction("18", 18));
menu.addSeparator();
menu.add(new StyledEditorKit.FontFamilyAction("Serif", "Serif"));
menu.add(new StyledEditorKit.FontFamilyAction("SansSerif", "SansSerif"));
menu.addSeparator();
Action red = new StyledEditorKit.ForegroundAction("Red", new Color(255, 0, 0));
red.putValue(Action.SMALL_ICON, getMyIcon("red.gif"));
menu.add(red);
Action green = new StyledEditorKit.ForegroundAction("Green", new Color(0, 150, 0));
green.putValue(Action.SMALL_ICON, getMyIcon("green.gif"));
menu.add(green);
Action blue = new StyledEditorKit.ForegroundAction("Blue", new Color(0, 50, 150));
blue.putValue(Action.SMALL_ICON, getMyIcon("blue.gif"));
menu.add(blue);
Action black = new StyledEditorKit.ForegroundAction("Black", new Color(0, 0, 0));
black.putValue(Action.SMALL_ICON, getMyIcon("black.gif"));
menu.add(black);
menu.add(more);
return menu;
protected JMenu createEditMenu()
JMenu menu = new JMenu("Edit");
menu.add(undoAction);
menu.add(redoAction);
menu.addSeparator();
menu.add(cut);
menu.add(copy);
menu.add(paste);
menu.addSeparator();
Action selectall = getActionByName(DefaultEditorKit.selectAllAction);
selectall.putValue(Action.NAME, "Select All");
menu.add(selectall);
return menu;
protected JMenu createFormatMenu()
JMenu menu = new JMenu("Format");
menu.add(spellchecker);
menu.add(alignleft);
menu.add(alignright);
menu.add(aligncentre);
menu.add(alignjustify);
return menu;
protected JMenu createInsertMenu()
JMenu menu = new JMenu("Insert");
Action insertimage = new InsertImageAction(this);
menu.add(insertimage);
Action insertdate = new InsertDateAction();
menu.add(insertdate);
Action insertline = new InsertLineAction();
menu.add(insertline);
JMenu bullets = new JMenu("Bullet Points");
bullets.add(new InsertBulletAction(CIRCLE, "Circle"));
bullets.add(new InsertBulletAction(TRIANGLE, "Triangle"));
bullets.add(new InsertBulletAction(SQUARE, "Square"));
menu.add(bullets);
return menu;
public JToolBar createToolbar()
JToolBar bar = new JToolBar();
JButton newbutton = new JButton(getMyIcon("new.gif"));
newbutton.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
newDoc();
bar.add(newbutton);
JButton savebutton = new JButton(getMyIcon("save.gif"));
savebutton.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
save();
bar.add(savebutton);
JButton openbutton = new JButton(getMyIcon("open.gif"));
openbutton.addActionListener(new ActionListener()
public void actionPerformed(ActionEvent e)
open();
bar.add(openbutton);
bar.addSeparator();
for (int i = 0; i < tools.length; i++)
JButton button = new JButton();
button.setAction(tools[i]);
button.setIcon(getMyIcon(tools[i].getValue(Action.NAME) + ".gif"));
button.setText("");
bar.add(button);
if ((i == 2) || (i == 6)) bar.addSeparator();
return bar;
public void createToolbarActions()
bold = new StyledEditorKit.BoldAction();
bold.putValue(Action.NAME, "Bold");
italic = new StyledEditorKit.ItalicAction();
italic.putValue(Action.NAME, "Italic");
underline = new StyledEditorKit.UnderlineAction();
underline.putValue(Action.NAME, "Underline");
more = new MoreColorsAction();
cut = getActionByName(DefaultEditorKit.cutAction);
cut.putValue(Action.NAME, "Cut");
copy = getActionByName(DefaultEditorKit.copyAction);
copy.putValue(Action.NAME, "Copy");
paste = getActionByName(DefaultEditorKit.pasteAction);
paste.putValue(Action.NAME, "Paste");
alignleft = new StyledEditorKit.AlignmentAction("Left Justify", StyleConstants.ALIGN_LEFT);
alignright = new StyledEditorKit.AlignmentAction("Right Justify", StyleConstants.ALIGN_RIGHT);
aligncentre = new StyledEditorKit.AlignmentAction("Align Centre", StyleConstants.ALIGN_CENTER);
alignjustify = new StyledEditorKit.AlignmentAction("Fully Justify", StyleConstants.ALIGN_JUSTIFIED);
spellchecker = new StyledEditorKit.AlignmentAction("Spell Checker", StyleConstants.ALIGN_JUSTIFIED);
tools = new Action[]{cut, copy, paste, bold, italic, underline, more, alignleft, alignright, aligncentre, alignjustify, spellchecker};
// helper methods to enable menu creators to get their actions by name
private void createActionTable(JTextComponent textComponent)
actions = new Hashtable();
Action[] actionsArray = textComponent.getActions();
for (int i = 0; i < actionsArray.length; i++)
Action a = actionsArray[i];
actions.put(a.getValue(Action.NAME), a);
private Action getActionByName(String name)
return (Action) (actions.get(name));
//----------------| Custom Actions |--------------------
class InsertImageAction extends AbstractAction
protected SimpleTextEditor parent;
public InsertImageAction(SimpleTextEditor parent)
super("Image...");
this.parent = parent;
public void actionPerformed(ActionEvent e)
int n = parent.picChooser.showOpenDialog(parent);
if (n == 0)
String filename = picChooser.getSelectedFile().getName();
File file = new File(picChooser.getCurrentDirectory(), filename);
Icon pic = new ImageIcon(file.getAbsolutePath());
textpane.insertIcon(pic);
SimpleTextEditor.this.repaint();
class InsertDateAction extends AbstractAction
public InsertDateAction()
super("Date");
public void actionPerformed(ActionEvent ble)
Calendar c = Calendar.getInstance();
String[] months = new String[]{"01", "02", "03", "04", "05", "06", "07", "08", "09", "10", "11", "12"};
textpane.replaceSelection(c.get(c.DAY_OF_MONTH) + "/" + months[c.get(c.MONTH)] + "/" + c.get(c.YEAR));
class InsertLineAction extends AbstractAction
public InsertLineAction()
super("Horizontal line");
public void actionPerformed(ActionEvent e)
Icon pic = new ImageIcon("Images/line.gif");
textpane.insertIcon(pic);
class InsertBulletAction extends AbstractAction
protected int type;
protected String filenames[] = new String[]{"square.gif", "triangle.gif", "circle.gif"};
public InsertBulletAction(int type, String name)
super(name);
this.type = type;
this.putValue(SMALL_ICON, new ImageIcon("Images/" + filenames[type]));
public void actionPerformed(ActionEvent e)
Icon pic = new ImageIcon("Images/" + filenames[type]);
textpane.insertIcon(pic);
textpane.replaceSelection(" ");
class MoreColorsAction extends AbstractAction
public MoreColorsAction()
super("More Colors");
public void actionPerformed(ActionEvent e)
AttributeSet as = textpane.getCharacterAttributes();
SimpleAttributeSet sas = new SimpleAttributeSet(as);
Color newColor = JColorChooser.showDialog(
SimpleTextEditor.this,
"Choose Text Color",
doc.getForeground(as));
if (newColor != null)
StyleConstants.setForeground(sas, newColor);
textpane.setCharacterAttributes(sas, true);
SimpleTextEditor.this.repaint();
class UndoAction extends AbstractAction
public UndoAction()
super("Undo");
setEnabled(false);
public void actionPerformed(ActionEvent e)
try
undo.undo();
catch (CannotUndoException ex)
System.out.println("Unable to undo: " + ex);
ex.printStackTrace();
updateUndoState();
redoAction.updateRedoState();
protected void updateUndoState()
if (undo.canUndo())
setEnabled(true);
putValue(Action.NAME, undo.getUndoPresentationName());
else
setEnabled(false);
putValue(Action.NAME, "Undo");
class RedoAction extends AbstractAction
public RedoAction()
super("Redo");
setEnabled(false);
public void actionPerformed(ActionEvent e)
try
undo.redo();
catch (CannotRedoException ex)
System.out.println("Unable to redo: " + ex);
ex.printStackTrace();
updateRedoState();
undoAction.updateUndoState();
protected void updateRedoState()
if (undo.canRedo())
setEnabled(true);
putValue(Action.NAME, undo.getRedoPresentationName());
else
setEnabled(false);
putValue(Action.NAME, "Redo");
//-------------| Very nice Image Previewer 'borrowed' from Sun's Java Tutorial
class ImagePreview extends JComponent implements PropertyChangeListener
ImageIcon thumbnail = null;
File file = null;
public ImagePreview(JFileChooser fc)
setPreferredSize(new Dimension(100, 50));
fc.addPropertyChangeListener(this);
public void loadImage()
if (file == null)
return;
ImageIcon tmpIcon = new ImageIcon(file.getPath());
if (tmpIcon.getIconWidth() > 90)
thumbnail = new ImageIcon(tmpIcon.getImage().getScaledInstance(90, -1,
Image.SCALE_DEFAULT));
else
thumbnail = tmpIcon; -
Why all JMenuItem's of JPopupMenu perform the same action?
Why all JMenuItem's of JPopupMenu perform the same action?
I trying to do something similar to what there is in JBuilder where you right click a method or a class - you get a popUpMenu and if you choose the
"Browse Symbol" JBuilder browses to that method/class.
I'm trying to do the same and to browse to some class of mine (not a java class). But there's a problem.
This is my code : -
OMClass desiredClass = event.getNavigationClass();
if(desiredClass instanceof OMComplexClass) {
Set classSet = desiredClass.getSimpleClasses();
JPopupMenu menu = new JPopupMenu();
JMenuItem menuItem = null;
menu.add("Browse to :");
menu.addSeparator();
Iterator it = classSet.iterator();
for(; it.hasNext(); ) {
OMConcept concept = (OMConcept)it.next();
menuItem = new JMenuItem(concept.getName());
menuItem.addActionListener(new NavigateToComplexClass(concept));
menu.add(menuItem);
menu.show((JComponent)(event.getMouseEvent().getSource()), getX(), event.getMouseEvent().getY());
ComplexClass is build of SimpleClasses - so if I want to browse to complex class I ask the user by a JPopupMenu what specific SimpleClass he would like to browse to. My ActionListener is a NavigateToComplexClass class - and hewe is the code : -
public class NavigateToComplexClass implements ActionListener, ItemListener {
private static OMClass classToShow = null;
GUI_Location currentLocation = null;
public NavigateToComplexClass(OMConcept desiredClass) {
classToShow = (OMClass)desiredClass;
public void actionPerformed(ActionEvent evt) {
currentLocation = frame.fillGUI_Location();
frame.getProject().getHistoryManager().updateHistory(currentLocation);
if(classToShow == null) {
return;
frame.getClassDisplay().getTabbedPane().setSelectedIndex(1);// 1 - parameeter : Property tab.
frame.getConceptViewPanel().selectConcept((OMConcept)classToShow);
public void itemStateChanged(ItemEvent e) {
The problem is that no matter what JMenuItem I select and press it's navigating to the same simpleClass like if I have a
b
c
no matter what I'll press I'll always goto a (or b or c but always the same)hi,
for your actionlistener all those items are more or less the same. when browsing to them you have to give them different names or better different actioncommands.
regards -
Hi,
I am trying to perform an action based upon clicking of a particular selection in JPopupMenu.
Can i use JPopupMenu.addActionListener?
Could you kindly let me know the right path?Hi,
This is what I am doing now.
{public void mousePressed(MouseEvent e) {
JPopupMenu popup = new JPopupMenu();
//PopupMenuListener popupMenuListener;
if (e.getButton() == 3) {
TreePath path = jTree2.getPathForLocation(e.getX(), e.getY());
System.out.println(path);
if(path==null)
return;
DefaultMutableTreeNode node = (DefaultMutableTreeNode) (path.getLastPathComponent());
//Object nodeInfo = node.getUserObject();
//String vints = node.toString();
//if (path != null)
if(node.toString()=="relational")
jTree2.setSelectionPath(path);
popup.add("Add Table");
popup.show(jTree2, e.getX(), e.getY());
Now when I click on Add Table in popmenu I would like to perform an action say to create a new node in the tree.
How could i do it? -
How can I distinguish a JMenuItem , JPopupMenu and TopLevelMenu?
I used the following methods to get the component who (a menu)gains the focus:
JComponent com = JFrmame.getFocusOwner();
or
MenuSelectionManager menuMgr = MenuSelectionManager.defaultManager();
MenuElement[] menuPath = menuMgr.getSelectedPath();
if(menuPath != 0) {
JComponent comp = Array.get(menuPath, menuPath.length-1); // this is the item with the focus
then I need to use getAction() to get the menuItem's action. But how can I filter JMenuItem and JPopUpMenu from TopLevelMenu (JMenuBar item) ?
Thanks!The instanceof may provide the simplest solution, since JPopupMenu, JMenuBar and JMenuItem don't have any kind of ancestor relationship with each other.if (comp instanceof JPopupMenu) {
// Popup
} else if (comp instanceof JMenuItem) {
// Item
} else if (comp instanceof JMenuBar) {
// Bar
} else ...?Hope this helps,
-Troy -
Undo,redo not working properly with JPopupMenu
if i use JButton for undo ,redo it is working fine. but the same code is not
working properly if i add it in JPopupMenu.
what could be the problem.
thankswhat could be the problem.Your code is different or written incorrectly and since you didn't post any we can't help.
[url http://java.sun.com/docs/books/tutorial/uiswing/misc/action.html]How to Use Actions
If you need further help then you need to create a [url http://homepage1.nifty.com/algafield/sscce.html]Short, Self Contained, Compilable and Executable, Example Program that demonstrates the incorrect behaviour, because I can't guess exactly what you are doing based on the information provided.
And don't forget to use the [url http://forum.java.sun.com/help.jspa?sec=formatting]Code Formatting Tags so the code retains its original formatting. -
JPopupMenu with a submenu (doesn't work)
I have a JPopupMenu that displays some info for me and I would like to add a submenu but it doesn't seem to work. I can successfully add the submenu but it doesn't "expand" when I mouse over the submen.
JPopupMenu pm = new JPopupMenu();
JMenu submenu = new JMenu("submenu");
JMenuItem jmi = new JMenuItem(...);
submenu.add(jmi);
pm.add(submenu);The popup menu looks as it should and the only thing that is missing is the action that should expand the submenu when I mouse over (and clicking doesn't work either).
Any ideas?I don't think it is my code because I have tried it with other JPopupMenu stuff and it never works. Here is a simple working example of it. If you can modify this code to work I will be a bielver...
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.awt.event.MouseMotionListener;
import javax.swing.JFrame;
import javax.swing.JMenu;
import javax.swing.JMenuItem;
import javax.swing.JPanel;
import javax.swing.JPopupMenu;
public class PopUpMenuTest extends JPanel implements MouseListener, MouseMotionListener {
private JPopupMenu jpm;
private JFrame frame;
public PopUpMenuTest() {
super();
addMouseListener(this);
addMouseMotionListener(this);
JFrame.setDefaultLookAndFeelDecorated(true);
frame = new JFrame("Testing PopUpMenuTest");
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.setContentPane(this);
frame.setSize(600, 400);
frame.setVisible(true);
public static void main(String[] args) {
new PopUpMenuTest();
public void mouseClicked(MouseEvent me) {
System.out.println("Mouse clicked...");
jpm = new JPopupMenu();
jpm.setLightWeightPopupEnabled(false);
jpm.add(new JMenuItem("Testing 1"));
jpm.add(new JMenuItem("Testing 2"));
jpm.addSeparator();
JMenu submenu = new JMenu("A submenu");
JMenuItem menuItem1 = new JMenuItem("An item in the submenu");
submenu.add(menuItem1);
JMenuItem menuItem2 = new JMenuItem("Another item");
submenu.add(menuItem2);
jpm.add(submenu);
jpm.setVisible(true);
jpm.setLocation(frame.getX()+me.getX(), frame.getY()+me.getY());
jpm.setVisible(true);
public void mouseMoved(MouseEvent arg0) {
if (jpm != null) {
jpm.setVisible(false);
jpm = null;
public void mouseEntered(MouseEvent arg0) {}
public void mouseExited(MouseEvent arg0) {}
public void mousePressed(MouseEvent arg0) {}
public void mouseReleased(MouseEvent arg0) {}
public void mouseDragged(MouseEvent arg0) {}
} -
Jpopupmenu visibility problem with JWindows
Hello,
BACKGROUND:
I am attempting to implement a feature similar to one found in the netbeans IDE for a programming editor I am helping to write. The feature is an autocomplete/function suggestion based on the current word being typed, and an api popup for the selected function.
Currently a JPopupMenu is used to provide a list of suggested functions based on the current word being typed. EG, when a user types 'array_s' a JPopupMenu pops up with array_search, array_shift, array_slice, etc.
When the user selects one of these options (using the up/down arrow keys) a JWindow (with a jscrollpane embedded in it) is made visible which displays the api page for that particular function.
PROBLEM:
The problem is that when a user scrolls down the JWindow the JPopupmenu disappears so he user cannot select another function.
I have added a ComponentListener to the JPopupMenu so that when componentHidden is called I can do checks to see if it should be visible and make visible if necessary. However, componentHidden is never called.
I have added a focuslistener to the JPopupMenu so that when it loses focus I can do the same checks/make visible if necessary. This function is never called.
I have added a popupMenuListener but this tells me when it is going to make something invisible, not actually when it's done it, so I can't call popup.setVisible(true) from popupMenuWillBecomeInvisible because at that point the menu is still visible.
Does anyone have any suggestions about how I can scroll through a scrollpane in a JWindow whilst still keeping the focus on a separate JPopupMenu in a separate frame?
CheersThe usual way to do popup windows (such as autocomplete as you're doing) is not to create a JPopupMenu, but rather an undecorated (J)Window. Stick a JList in the popup window for the user to select their choice from. The problem with using a JPopupMenu is just what you're experiencing - they're designed to disappear when they lose focus. Using an undecorated JWindow, you can control when it appears/disappears.
See this thread for information on how to do this:
http://forum.java.sun.com/thread.jspa?threadID=5261850&messageID=10090206#10090206
It refers you to another thread describing how to create the "popup's" JWindow so that it doesn't steal input focus from the underlying text component. Then, further down, it describes how you can forward keyboard actions from the underlying text component to the JWindow's contents. This is needed, for example, so the user can keep typing when the autocomplete window is displayed, or press the up/down arrow keys to select different items in the autocomplete window.
It sounds complicated, but it really isn't. :) -
Remove the Enter key binding from a JPopupMenu
Hi,
Does anyone know how to remove the Enter key binding from a JPopupMenu?
So when the popupmenu is showing and you type Enter, nothing should happen and the menu should stay where it is.
I have tried:
popup.getActionMap().put("enter", null);
popup.getInputMap().put(KeyStroke.getKeyStroke(KeyEvent.VK_ENTER, 0), "enter");but the popup always disappears.
Any ideas?
Cheers,
patumaireFirst of all, that is not the proper way to "remove" a key binding. Read the Swing tutorial on [How to Use Key Bindings|http://java.sun.com/docs/books/tutorial/uiswing/misc/keybinding.html#howto] for more information.
However, we still have a couple of problems:
a) the input map is dynamically built as the popup menu is displayed
b) the input map is built for the root pane, not the popup menu
The following seems to work:
popup.show(...);
InputMap map = getRootPane().getInputMap(JTable.WHEN_IN_FOCUSED_WINDOW);
map.put(KeyStroke.getKeyStroke("ENTER"), "none");
KeyStroke[] keys = map.allKeys();
for (int i = 0; i < keys.length; i++)
KeyStroke key = keys;
Object action = map.get( key );
System.out.println(key + " : " + action); -
Spawning my own JPopupMenu breaks every single JComboBox in the application
That's pretty much it.
I have determined the problem is in no way caused by the contents of the popup menu, but rather the popup menu itself. I have a popup menu which contains only a button which does nothing (I've tried this same thing with just a checkbox, just a radio box, just a text widget...same thing happens). If I bring up the popup and then hide it right away, everything else works fine. If I bring up the popup and click the button, every single combo box in the application (there are dozens) is suddenly in this weird state where even though you can bring up their list popups, selecting items there won't change the contents of the text portion of the widget and in fact an action listener won't even report that an event has taken place.
When the CBs are in this state, you can use the keyboard to select items. You can also click and HOLD the mouse button and release on your selection and that will properly select the item, but clicking to select list items doesn't work.
Somehow, the JPopupMenus are swallowing all the mouse pressed events for any other popupmenus in the system. Sounds like a REALLY low level java bug to me...
OS: Win XP, Win 2000, Win ME, Solaris, FreeBSD, Linux.
JVMS: Pretty much all the ones you can run on those platforms.
- JoeOf course it's been a while since the original poster brought up this problem, but I was just having this same issue. It had nothing to do with mixing light-weight and heavy-weight components though.
In my case, I was using a JPopupMenu with some buttons in it as a sort of toolbar flyout, and whenever you would click one of the buttons, all combo boxes in the application would cease to allow simple mouse selection of items in the list. This behavior is evidently related to bug #4492892 and supposedly only applies to the Windows look and feel.
I think I've found a reasonable work-around. Setting all of the components in the popup menu to be non-focusable (ie. button.setFocusable(false); ) seems to do the trick. Just hoping others might benefit from this solution. Cheers. -
Multiple selection in JPopupMenu
Hi
I was in need of allowing multiple selection in JPopupmenu.... I had 50 checkBocMenuitems in JPopupmenu.... Default behaviour of JPopupmenu is if an action that means a selection is done then the popupmenu will gets disappear.. But i want to select multiple items and then want the popupmenu to disappear.. can anyone help me...
ThankQ
Chaluyeah i agree with u..
but if i want to change the behaviour wat to do....
I have to select several menuitems and if i click the table or any where other than popupmenu, the popupmenu should get disappear..
Is it possible...
can u answer me please...
Chalu.. -
Hi :
I have a problems with a JPopupMenu.
I have a JTable in a modal JDialog with some rows and I want to make some action with some rows so I make JPopupMenu visible with right click (no problem) but, when it reachs the JDialog border, it appears cut because it can't paint out of JDialog limits.
What can I do to watch the entire JPopupMenu ? It's urgent.
Thanks.
MiquelThis is because the Popupmenu is a lightweight component (which can't display beyond the borders of the window), try myPopup.setLightWeightPopupEnabled(false); that makes all popups in your app heavyweight.
-
I need to make a custom PopupMenu Button . This button needs to be added to the custom JPopupmenu . This custom button must have the look and feel of a typical menu item. Basically it should have a typical features of a checkboxmenuitem where I have an check.jpg for check and uncheck of the button. How do I reproduce the look and feel of a menuitem. What changes do i make in the below code. Basically no border, button press should not be there. It should not look like we are adding JButtons to the user
import javax.swing.Action;
import javax.swing.Icon;
import javax.swing.ImageIcon;
import javax.swing.JButton;
import javax.swing.border.EmptyBorder;
public class XCheckedButton
extends JButton {
private boolean flag;
private ImageIcon checkedIcon;
public XCheckedButton() {
super();
public XCheckedButton(Action a) {
this();
setAction(a);
public XCheckedButton(Icon icon) {
super(icon);
public XCheckedButton(String text, Icon icon) {
super(text, icon);
public XCheckedButton(String text) {
super(text);
public ImageIcon getCheckedIcon() {
return checkedIcon;
public void setCheckedIcon(boolean state) {
this.checkedIcon = checkedIcon;
}Thanks a lot. Here are my 2 java files and right below is the probelm I am facing when USing JMenuItems. Thats the reason why i switched over to JButtons.
JframePopupMenu.java
import java.awt.FlowLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.KeyEvent;
import javax.swing.JButton;
import javax.swing.JCheckBoxMenuItem;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JMenuItem;
import javax.swing.JPanel;
import javax.swing.JScrollPane;
import javax.swing.JTextArea;
import javax.swing.JTextField;
import javax.swing.SwingUtilities;
public class JFramePopupMenu extends JFrame {
private static final long serialVersionUID = 1;
private JPanel jContentPane = null;
private JButton jbnPopup = null;
private JTextField jtfNumOfMenus = null;
private JLabel lblNumElem = null;
JTextArea output;
JScrollPane scrollPane;
String newline = "\n";
ScrollablePopupMenu scrollablePopupMenu = new ScrollablePopupMenu(JFramePopupMenu.this.getGraphicsConfiguration());
private JButton getBtnPopup() {
if (jbnPopup == null) {
jbnPopup = new JButton();
jbnPopup.setText("View Popup");
jbnPopup.addActionListener(new ActionListener() {
public void actionPerformed(ActionEvent e) {
int n = Integer.parseInt(getTxtNumElem().getText());
JCheckBoxMenuItem cbMenuItem = new JCheckBoxMenuItem("A check box menu item");
cbMenuItem.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e) {
System.out.println( e );
scrollablePopupMenu.hidemenu();
cbMenuItem.setMnemonic(KeyEvent.VK_C);
scrollablePopupMenu.add(cbMenuItem);
for (int i=0;i<n;i++){
JMenuItem xx = new JMenuItem(" JMenuItem " + (i+1));
xx.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e) {
System.out.println( e );
scrollablePopupMenu.hidemenu();
// scrollablePopupMenu.add(new JButton(" JMenuItem " + (i+1)));
scrollablePopupMenu.add(xx);
scrollablePopupMenu.show(jbnPopup, jbnPopup.getWidth()*3, 0);
return jbnPopup;
private JTextField getTxtNumElem() {
if (jtfNumOfMenus == null) {
jtfNumOfMenus = new JTextField();
jtfNumOfMenus.setColumns(3);
jtfNumOfMenus.setText("60");
return jtfNumOfMenus;
public static void main(String[] args) {
SwingUtilities.invokeLater(new Runnable() {
public void run() {
JFramePopupMenu thisClass = new JFramePopupMenu();
thisClass.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
thisClass.setVisible(true);
public JFramePopupMenu() {
super();
initialize();
private void initialize() {
this.setSize(274, 109);
this.setContentPane(getJContentPane());
this.setTitle("Scrollable JPopupMenu");
private JPanel getJContentPane() {
if (jContentPane == null) {
lblNumElem = new JLabel();
// lblNumElem.setText("N�mero de elementos del Men�");
FlowLayout flowLayout = new FlowLayout();
flowLayout.setHgap(8);
flowLayout.setVgap(8);
jContentPane = new JPanel();
jContentPane.setLayout(flowLayout);
jContentPane.add(getBtnPopup(), null);
jContentPane.add(lblNumElem, null);
jContentPane.add(getTxtNumElem(), null);
return jContentPane;
ScrollablePopupMenu.java
import java.awt.Component;
import java.awt.Dimension;
import java.awt.GraphicsConfiguration;
import java.awt.GridLayout;
import javax.swing.JFrame;
import javax.swing.JMenuItem;
import javax.swing.JPanel;
import javax.swing.JPopupMenu;
import javax.swing.JScrollPane;
import javax.swing.JSeparator;
public class ScrollablePopupMenu extends JPopupMenu {
private static final long serialVersionUID = 1;
private JPanel panelMenus = null;
private JScrollPane scroll = null;
public ScrollablePopupMenu(GraphicsConfiguration gc) {
super();
scroll = new JScrollPane();
panelMenus = new JPanel();
panelMenus.setLayout(new GridLayout(0,1));
scroll.setViewportView(panelMenus);
scroll.setBorder(null);
scroll.setMaximumSize(new Dimension(scroll.getMaximumSize().width,
this.getToolkit().getScreenSize().height -
this.getToolkit().getScreenInsets(gc).top -
this.getToolkit().getScreenInsets(gc).bottom - 4));
super.add(scroll);
public void show(Component invoker, int x, int y) {
this.pack();
panelMenus.validate();
int maxsize = scroll.getMaximumSize().height;
int realsize = panelMenus.getPreferredSize().height;
int sizescroll = 0;
if (maxsize < realsize) {
sizescroll = scroll.getVerticalScrollBar().getPreferredSize().width;
scroll.setPreferredSize(new Dimension(
scroll.getPreferredSize().width + sizescroll,
scroll.getPreferredSize().height));
this.setLocation( x, y);
this.setVisible(true);
public void hidemenu(){
if(this.isVisible()){
this.setVisible(false);
public JMenuItem add(JMenuItem menuItem) {
panelMenus.add(menuItem);
return menuItem;
public void addSeparator() {
panelMenus.add(new JSeparator());
Problem 1: Not able to Scroll down when frame is Large
My application is a large frame and when I invoke the JPopupMenu on it I am not able to scroll.
In the example application also I found the same problem when I maximize the frame. I am able to see the JPopupMenu but not able to scroll on it.
Maybe you are looking for
-
Voicemail not working - after removing and adding Dialplan
Exchange 2013 Lync 2013 I had a UM dial plan configured and it was working properly. I removed that plan and added a new one. The new one does not work. When ever you leave a Voice-mail for a user, they never get it. If the user logs in, they sti
-
Help needed - software installation on Nokia N8
I've got a Nokia N8 and wanted to get "weather maps". I already have the Nokia weather application, and the SPB Weather application as well. After looking around on the internet, I found some good information recommending "Weatherbug" for the N8.
-
My Macbook (safari) suddenly thinks it has adblocker but i never installed it and its not in extensions. its blocking a tv site i watch - how to remove it if it's not there?
-
Hello, Can I execute a loop in a BPEL Process? Or must I execute the loop in the program which invokes the BPEL Process by SOAP? Thanks!
-
Skype number used in a different country
Hello, are we able to use skype with a local number of a certain area and use it in a different country? hope to get a response