Any improvements?

Question

Just being picky, but I don't like the way I had to code this (required too much casting and rounding). Any ideas how I could have done it better?
            FileInputStream fileReader = new FileInputStream(file);
            byte buffer[] = new byte[bufferSize];
            for (int i = 0; i < (file.length() / bufferSize); i++) {
                fileReader.read(buffer);
            byte lastBuffer[] = new byte[(int)file.length() - ((int)(file.length() / bufferSize) * bufferSize)];
            fileReader.read(lastBuffer);The code splits the file into bytes, which are read into a byte array of BufferSize, until there isn't enough bytes to fill a byte array of BufferSize, and then it writes the remaining bytes into a perfectly-sized byte array because I don't want the fileReader.read(buffer) to block.
Thanks in advance.
Message was edited by:
abu5e

Answer 1

Why don't you use the returned int from the method read(byte[] buffer) ?
byte[] buffer = new byte[BUFFER];
int n = 0;
while((n = in.read(buffer)) != -1) {
//TODO (save it on another file or send it through sockets... or whatever)
}Maybe I don't understand what you're trying to achieve.. but if it is a simple lecture from a File, this is the best way of doing it...
Message was edited by:
Ruly-o_O