Apache-zip.jar name attachment file bad encoding

Question

I have following code. which create zip archive, but name attachment files bad encoding.
name attachment files in encoding UTF-8. letters of Russian alphabet -"имя.txt". get - "¯à¨ï⨥  à鸞.txt" OS - Ubuntu 9.10 64-b
package action;
import org.apache.tools.zip.ZipEntry;
import org.apache.tools.zip.ZipOutputStream;
import java.io.*;
import java.util.Arrays;
import java.util.List;
public class CreateArchive {
    private byte[] getByteFromFile(String file) throws IOException {
        InputStream is = new FileInputStream(file);
        long length = file.length();
        if (length > Integer.MAX_VALUE) {
            throw new IOException("Size file bad: "+file);
        byte[] bytes = new byte[(int)length];
        int offset = 0;
        int numRead;
        while (offset < bytes.length && (numRead=is.read(bytes, offset, bytes.length-offset)) >= 0) {
            offset += numRead;
        if (offset < bytes.length) {
            throw new IOException("Could not completely read file "+file);
        is.close();
        return bytes;
    public void createZip(OutputStream outputStream, List<String> files) {
        byte[] buf = new byte[1024];
        try {
            ZipOutputStream out = new ZipOutputStream(outputStream);
            out.setEncoding("UTF-8");
            for (String fileName: files) {
                ByteArrayInputStream sourceStream = new ByteArrayInputStream(getByteFromFile(fileName));
                out.putNextEntry(new ZipEntry(fileName));
                int len;
                while ((len = sourceStream.read(buf)) != -1) {
                    out.write(buf, 0, len);
                out.closeEntry();
            out.close();
        } catch (IOException e) {
            System.out.print(e);
    public static void main(String[] args) throws IOException {
        CreateArchive files = new CreateArchive();
        OutputStream outputStream = new FileOutputStream("file.zip");
        files.createZip(outputStream, Arrays.asList("&#1080;&#1084;&#1103;.txt"));
        outputStream.close();
}Sorry for me bad english
Edited by: P1tBull on Mar 24, 2010 5:35 AM

Answer 1

Real task was create general archive is selected users files and transmission he in one stream
package action;
import org.apache.tools.zip.ZipEntry;
import javax.servlet.RequestDispatcher;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import java.io.*;
import java.util.Arrays;
import java.util.List;
import java.util.zip.ZipOutputStream;
public class StreamFiles extends HttpServlet {
    protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
        doGet(request, response);
    protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
        OutputStream out = response.getOutputStream();
        try {
            response.setContentType("'application/zip'; charset='UTF-8'");
            response.setContentType("name=AllFile");
            response.setHeader("Content-disposition", "attachment; filename*=utf-8" + "''" + java.net.URLEncoder.encode("AllFile.zip", "UTF-8") + ";");
            if (request.getHeader("user-agent") != null) {
                if (request.getHeader("user-agent").indexOf("Safari") != -1) {
                    response.setHeader("Content-Disposition", "attachment");
                    response.setContentType("application/octet-stream");
                } else if (request.getHeader("user-agent").indexOf("MSIE") != -1 || request.getHeader("user-agent").indexOf("Chrome") != -1) {
                    response.setHeader("Content-disposition", "attachment; filename=" + java.net.URLEncoder.encode("AllFile.zip", "UTF-8"));
            List<String> files = Arrays.asList("catalina.bat", "startup.sh", "version.sh", "tomcat-juli.jar");
            createZip(out, files);
        } catch (Exception ex) {
            request.setAttribute("javax.servlet.jsp.jspException", ex);
            RequestDispatcher requestDispatcher = request.getRequestDispatcher("/error.jsp");
            requestDispatcher.forward(request, response);
        } finally {
            out.flush();
            out.close();
    private byte[] getByteFromFile(String file) throws IOException {
        InputStream is = new FileInputStream(file);
        long length = file.length();
        if (length > Integer.MAX_VALUE) {
        byte[] bytes = new byte[(int)length];
        int offset = 0;
        int numRead;
        while (offset < bytes.length && (numRead=is.read(bytes, offset, bytes.length-offset)) >= 0) {
            offset += numRead;
        if (offset < bytes.length) {
            throw new IOException("Could not completely read file "+file);
        is.close();
        return bytes;
    public void createZip(OutputStream outputStream, List<String> files) {
        byte[] buf = new byte[1024];
        try {
            ZipOutputStream out = new ZipOutputStream(outputStream);
            for (String fileName: files) {
                ByteArrayInputStream sourceStream = new ByteArrayInputStream(getByteFromFile(fileName));
                out.putNextEntry(new ZipEntry(fileName));
                int len;
                while ((len = sourceStream.read(buf)) != -1) {
                    out.write(buf, 0, len);
                out.closeEntry();
            out.close();
        } catch (IOException e) {
            System.out.print(e);
}but mistake on real host don't repeated, so thanks for answer
Edited by: P1tBull on Mar 24, 2010 8:14 AM