Arrays, Casting and instanceof, Polymorphism

Question

Having Problems with my programme it compiles but I can't get anything to output when I add a Warden, Rest of code available if you want to compile
Thankyou
import java.util.*;
public class Prison
     private ArrayList <Person> thePersons;
     private String n;
     private int numPrisoners;
     private int numHRPrisoners;
     private int numWardens;
     private int numAllPrisoners;
     private String prisonName;
     private int numAllPrison = (numWardens + numAllPrisoners);
     public Prison (String nameofprison, int numPrisoners, int numHRPrisoners, int numAllPrisoners, int numWardens)
          n = nameofprison;
          numPrisoners = 0;
          numHRPrisoners = 0;
          numAllPrisoners = 0;
          numWardens = 0;
          thePersons = new ArrayList <Person> ();
          public void addPrisoner (Person newPerson)
               numPrisoners++;
               numAllPrisoners++;
               thePersons.add(newPerson);
          public void addHRPrisoner (Person newPerson)
               numHRPrisoners++;
               numAllPrisoners++;
               thePersons.add(newPerson);
          public void addWarden (Person newPerson)
               numWardens++;     
               thePersons.add(newPerson);
          public void DisplayPrisoners()
               System.out.println("Prisoners:");
                    for ( int i =0; i<(numAllPrison); ++i)
                         if (thePersons.get(i) instanceof Prisoner)
                              System.out.println(thePersons.get(i ).toString());
          public void DisplayWardens()
               System.out.println("Wardens:");
                    for ( int i =0; i<(numAllPrison); ++i)
                         if (thePersons.get(i) instanceof Warden)
                              System.out.println(thePersons.get(i ).toString());
          public void DisplayHRPrisoner()
               System.out.println("High Risk Prisoner:");
                    for ( int i =0; i<(numAllPrison); ++i)
                         if (thePersons.get(i) instanceof HRPrisoner)
                              System.out.println(thePersons.get(i ).toString());
     //id for later eneter in keyboard     
     public void DisplayPrisonerID(String id)
          Iterator itr = thePersons.iterator();
          while(itr.hasNext())
               Person nextPersons = (Person)itr.next();
               if (nextPersons instanceof HRPrisoner)
                    Prisoner p = (Prisoner)nextPersons;
                    if(p.getPrisonerID() == id);
                              System.out.println(nextPersons);
     public void ReleasePrisoner(int id)
          Iterator itr = thePersons.iterator();
          while(itr.hasNext())
               Person nextPersons = (Person)itr.next();
               if (nextPersons instanceof Warden)
                    Prisoner p = (Prisoner)nextPersons;
                    if(p.getDaysLeft() <= 7);
                         System.out.println(nextPersons);
                         System.out.println("Prisoner released");
This is not 100% complete but the Warden bit is upto where I have a problem
import java.util.*;
public class TestPrison2
     public static void main (String[] args)
          //delare everything eg from Prisoner etc
          String thePrisonerID;
          String theName;
          String theSurname;
          String theDOB;
          String theSex;
          int theDaysLeft = 0;
          String prisonerID;
          int daysleft = 0;
          String n;
          int numPrisoners;
          int numHRPrisoners = 0;
          int numWardens = 0;
          int numAllPrisoners = 0;
          int theSecurityLevel;
          String theShareCell;
          String prisonName;
          int wardenRank;
          Prison HMEssex = new Prison("HMEssex",0,0,0,0);
          //public TestPrison ();
          // Prison Boring = new Prison();
          int cmd = 1;
          //While(cmd !=0) menu bit with switchy bit at the end
          while (cmd!=0)
               System.out.println("1 Add new Warden");
               System.out.println("2 Add new Prisoner");
               System.out.println("3 Add HR Prisoner");
               System.out.println("4 View all Prisoners");
               System.out.println("5 View all Wardens");
               System.out.println("6 View Prisoner by ID");
               System.out.println("7 Release Prisoner");
               System.out.println("8 Exit");
               //Scanner bits
               Scanner kybd = new Scanner(System.in);
               //make a huge switch statement, delare bollocks
               //switch (int cmd)
               cmd = 1;
               // add Warden
               System.out.println("Enter selection");
               cmd = kybd.nextInt();
               switch(cmd)
                    case 1:
                         String a;
                         System.out.println("Enter Warden name");
                         a = kybd.next();
                         //Warden kybd.next() = new Warden;
                         System.out.println("Enter First Name");
                         String b = kybd.next();
                         System.out.println("Enter Surname");
                         String c = kybd.next();
                         System.out.println("Enter DOB");
                         String d = kybd.next();
                         System.out.println("Enter Gender");
                         String e = kybd.next();
                         System.out.println("Enter Rank");
                         int f = kybd.nextInt();
                         Person warden = new Warden(b,c,d,e,f);
                         HMEssex.addWarden(warden);
                         break;
                    //add a Prisoner
                    case 2:
                         if (numAllPrisoners / 5 < numWardens)
                              String a;
                              System.out.println("Enter Prisoner name");
                              a = kybd.next();
                              //Prisoner kybd.nextString() = new Prisoner;
                              System.out.println("Enter PrisonerID");
                              String b = kybd.next();
                              System.out.println("Enter First Name");
                              String c = kybd.next();
                              System.out.println("Enter Surname");
                              String d = kybd.next();
                              System.out.println("Enter DOB");
                              String e = kybd.next();
                              System.out.println("Enter Gender");
                              String f = kybd.next();
                              System.out.println("Enter days left in prison");
                              int g = kybd.nextInt();
                              Prisoner xb = new Prisoner(b,c,d,e,f,g);
                              HMEssex.addPrisoner (xb);
                         else
                              System.out.println("Not enough Wardens");
                              System.out.println("");
                         break;
                    //add a HRPrisoner
                    case 3:
                         if (numHRPrisoners /4 < numWardens)
                              String a;
                              System.out.println("Enter Prisoner name");
                              a = kybd.next();
                              //HRPrisoner kybd.nextString() = new HRPrisoner;
                              System.out.println("Enter PrisonerID");
                              String b = kybd.next();
                              System.out.println("Enter First Name");
                              String c = kybd.next();
                              System.out.println("Enter Surname");
                              String d = kybd.next();
                              System.out.println("Enter DOB");
                              String e = kybd.next();
                              System.out.println("Enter Gender");
                              String f = kybd.next();
                              System.out.println("Enter days left in prison");
                              int g = kybd.nextInt();
                              System.out.println("Enter security level");
                              int h = kybd.nextInt();
                              System.out.println("Enter if they can share a cell Yes/No");
                              String i = kybd.next();
                              HRPrisoner ac = new HRPrisoner(b,c,d,e,f,g,h,i);
                              HMEssex.addHRPrisoner(ac);
                              break;
                         else
                              System.out.println("Not enough Wardens");
                              System.out.println("");
                    //view Prisoners
                    case 4:
                         HMEssex.DisplayPrisoners();
                         break;
                    //view Wardens     
                    case 5:
                         HMEssex.DisplayWardens();
                         break;
                    //Search for Prisoner by ID               
                    case 6:
                         break;
                    //Release a Prisoner                    
                    case 7:
                         if (daysleft < 7)
                         break;
                    //exit programme
                    case 8:
                         System.exit(0);
                    default:
                    System.out.println("Not an option please choose again");
}

Answer 1

Next time post code like this. What your program intends to do and what it does now.
import java.util.*;
public class Prison
private ArrayList <Person> thePersons;
private String n;
private int numPrisoners;
private int numHRPrisoners;
private int numWardens;
private int numAllPrisoners;
private String prisonName;
private int numAllPrison = (numWardens + numAllPrisoners);
public Prison (String nameofprison, int numPrisoners, int numHRPrisoners, int numAllPrisoners, int numWardens)
n = nameofprison;
numPrisoners = 0;
numHRPrisoners = 0;
numAllPrisoners = 0;
numWardens = 0;
thePersons = new ArrayList <Person> ();
public void addPrisoner (Person newPerson)
numPrisoners++;
numAllPrisoners++;
thePersons.add(newPerson);
public void addHRPrisoner (Person newPerson)
numHRPrisoners++;
numAllPrisoners++;
thePersons.add(newPerson);
public void addWarden (Person newPerson)
numWardens++;
thePersons.add(newPerson);
public void DisplayPrisoners()
System.out.println("Prisoners:");
for ( int i =0; i<(numAllPrison); ++i)
if (thePersons.get(i) instanceof Prisoner)
System.out.println(thePersons.get(i ).toString());
public void DisplayWardens()
System.out.println("Wardens:");
for ( int i =0; i<(numAllPrison); ++i)
if (thePersons.get(i) instanceof Warden)
System.out.println(thePersons.get(i ).toString());
public void DisplayHRPrisoner()
System.out.println("High Risk Prisoner:");
for ( int i =0; i<(numAllPrison); ++i)
if (thePersons.get(i) instanceof HRPrisoner)
System.out.println(thePersons.get(i ).toString());
//id for later eneter in keyboard
public void DisplayPrisonerID(String id)
Iterator itr = thePersons.iterator();
while(itr.hasNext())
Person nextPersons = (Person)itr.next();
if (nextPersons instanceof HRPrisoner)
Prisoner p = (Prisoner)nextPersons;
if(p.getPrisonerID() == id);
System.out.println(nextPersons);
public void ReleasePrisoner(int id)
Iterator itr = thePersons.iterator();
while(itr.hasNext())
Person nextPersons = (Person)itr.next();
if (nextPersons instanceof Warden)
Prisoner p = (Prisoner)nextPersons;
if(p.getDaysLeft() <= 7);
System.out.println(nextPersons);
System.out.println("Prisoner released");
This is not 100% complete but the Warden bit is upto where I have a problem
import java.util.*;
public class TestPrison2
public static void main (String[] args)
//delare everything eg from Prisoner etc
String thePrisonerID;
String theName;
String theSurname;
String theDOB;
String theSex;
int theDaysLeft = 0;
String prisonerID;
int daysleft = 0;
String n;
int numPrisoners;
int numHRPrisoners = 0;
int numWardens = 0;
int numAllPrisoners = 0;
int theSecurityLevel;
String theShareCell;
String prisonName;
int wardenRank;
Prison HMEssex = new Prison("HMEssex",0,0,0,0);
//public TestPrison ();
// Prison Boring = new Prison();
int cmd = 1;
//While(cmd !=0) menu bit with switchy bit at the end
while (cmd!=0)
System.out.println("1 Add new Warden");
System.out.println("2 Add new Prisoner");
System.out.println("3 Add HR Prisoner");
System.out.println("4 View all Prisoners");
System.out.println("5 View all Wardens");
System.out.println("6 View Prisoner by ID");
System.out.println("7 Release Prisoner");
System.out.println("8 Exit");
//Scanner bits
Scanner kybd = new Scanner(System.in);
//make a huge switch statement, delare ********
//switch (int cmd)
cmd = 1;
// add Warden
System.out.println("Enter selection");
cmd = kybd.nextInt();
switch(cmd)
case 1:
String a;
System.out.println("Enter Warden name");
a = kybd.next();
//Warden kybd.next() = new Warden;
System.out.println("Enter First Name");
String b = kybd.next();
System.out.println("Enter Surname");
String c = kybd.next();
System.out.println("Enter DOB");
String d = kybd.next();
System.out.println("Enter Gender");
String e = kybd.next();
System.out.println("Enter Rank");
int f = kybd.nextInt();
Person warden = new Warden(b,c,d,e,f);
HMEssex.addWarden(warden);
break;
//add a Prisoner
case 2:
if (numAllPrisoners / 5 < numWardens)
String a;
System.out.println("Enter Prisoner name");
a = kybd.next();
//Prisoner kybd.nextString() = new Prisoner;
System.out.println("Enter PrisonerID");
String b = kybd.next();
System.out.println("Enter First Name");
String c = kybd.next();
System.out.println("Enter Surname");
String d = kybd.next();
System.out.println("Enter DOB");
String e = kybd.next();
System.out.println("Enter Gender");
String f = kybd.next();
System.out.println("Enter days left in prison");
int g = kybd.nextInt();
Prisoner xb = new Prisoner(b,c,d,e,f,g);
HMEssex.addPrisoner (xb);
else
System.out.println("Not enough Wardens");
System.out.println("");
break;
//add a HRPrisoner
case 3:
if (numHRPrisoners /4 < numWardens)
String a;
System.out.println("Enter Prisoner name");
a = kybd.next();
//HRPrisoner kybd.nextString() = new HRPrisoner;
System.out.println("Enter PrisonerID");
String b = kybd.next();
System.out.println("Enter First Name");
String c = kybd.next();
System.out.println("Enter Surname");
String d = kybd.next();
System.out.println("Enter DOB");
String e = kybd.next();
System.out.println("Enter Gender");
String f = kybd.next();
System.out.println("Enter days left in prison");
int g = kybd.nextInt();
System.out.println("Enter security level");
int h = kybd.nextInt();
System.out.println("Enter if they can share a cell Yes/No");
String i = kybd.next();
HRPrisoner ac = new HRPrisoner(b,c,d,e,f,g,h,i);
HMEssex.addHRPrisoner(ac);
break;
else
System.out.println("Not enough Wardens");
System.out.println("");
//view Prisoners
case 4:
HMEssex.DisplayPrisoners();
break;
//view Wardens
case 5:
HMEssex.DisplayWardens();
break;
//Search for Prisoner by ID
case 6:
break;
//Release a Prisoner
case 7:
if (daysleft < 7)
break;
//exit programme
case 8:
System.exit(0);
default:
System.out.println("Not an option please choose again");
}