BW Extraction using DS returning empty records

Hi
I am trying to extract data using BO DS 3.2 into BW 7.0. I am using BW as well as ECC 6.0 as a source in two separate jobs. I have setup a new source system which for BO DS in BW.
The RFSserver is up and running
However whenever I am running the extract I am getting empty records i.e. records do get extracted but they are blank. The job runs successfully in BO DS. I cna see it in BW in rsmo as having run successfully.
I have tried extracting to a flat file from BO DS and that returns records
I have tried debugging by setting a breakpoint just after my transorm and just before it passes data to the transfer stucture. In all positions I am able to see data exept in my final target. In the PSA also i am getting null records.
I have used an ABAP flow as weel as a normal Data Flow.
Any help would be appretiated
Thanks & Regards
Vinieth

Vinieth Kuruppath -
Yes you can use ABAP DF inside normat data flow to extract the SAP ECC data into BODS. put SAP tables and join them with relevant queries. jott your queries with Data transport to hold the data. This all will be inside a single ABAP data flow.
for BW Integration you have to use open hub destinationa mechanism. also see below link for modelling a connection between BO & BW
BW 7.30: Modeling integration between SAP Business Objects Data Services and BW | Part 1 of 2 Connect Source System
hope it helps
thx
Deep

Similar Messages

Xslt copy-of creates a xml which returns empty while trying to access elements using XPATH

Hi
I am trying to do a copy-of function using the XSLT in jdev. This is what I do
    <xsl:param name="appdataDO"/>
    <xsl:template match="/">
    <ns1:applicationData>
      <ns1:applicationId>
        <xsl:value-of select="$appdataDO/ns1:applicationData/ns1:applicationId"/>
      </ns1:applicationId>
      <xsl:copy-of select="/fslo:ExternalapplicationData/fslo:ApplicationsHDRAddInfo">
      </xsl:copy-of>
    </ns1:applicationData>
    </xsl:template>
    </xsl:stylesheet>
After this I can see the document created in the process flow as this :
    <ns1:applicationData>
    <ns1:applicationId>MMMM</ns1:applicationId>
    <ns2:ApplicationsHDRAddInfo>
    <ns3:genericFromBasePrimitive>iuoui</ns3:genericFromBasePrimitive>
    <ns4:EstimatedMarketValue>77</ns4:EstimatedMarketValue>
    <ns4:PropertyInsuranceFee>jih</ns4:PropertyInsuranceFee>
    <ns4:LoanOriginationFee>hjh</ns4:LoanOriginationFee>
    <ns4:RegistrarFee>kkkkk</ns4:RegistrarFee>
    <ns4:LoanCashInFee>hjh</ns4:LoanCashInFee>
    <ns4:LoanPaidInCashFlag>cddffgd</ns4:LoanPaidInCashFlag>
    </ns2:ApplicationsHDRAddInfo>
    </ns1:applicationData>
But whenever I am trying to extract any of the output nodes I am getting an empty result. I can copy the whole dataset into similar kind of variable.
But I am unable to get individual elements using XPATH.
I tried using exslt function for node set and xslt 2.0 without avail.
The namespaces might be the culprit here . The test method in the jdev is able to output a result but at runtime the xpath returns empty .
I have created another transform where I try to copy data from the precious dataobject to a simple string in another data object .
This is the test sample source xml for the transform created by jdev while testing with all namespaces, where I try to copy the data in a simple string in another data object.
    <applicationData xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://xmlns.oracle.com/bpmpa/fs/ulo/types file:/C:/JDeveloper/NewAPP/Xfrm/xsd/ApplicationData.xsd" xmlns="http://xmlns.oracle.com/bpmpa/fs/ulo/types">
       <applicationId>applicationId289</applicationId>
       <ApplicationsHDRAddInfo>
          <genericFromBasePrimitive xmlns="http://xmlns.oracle.com/bpm/pa/extn/types/BasePrimitive">genericFromBasePrimitive290</genericFromBasePrimitive>
          <EstimatedMarketValue xmlns="http://xmlns.oracle.com/bpm/pa/extn/headerCategories/">291</EstimatedMarketValue>
          <PropertyInsuranceFee xmlns="http://xmlns.oracle.com/bpm/pa/extn/headerCategories/">PropertyInsuranceFee292</PropertyInsuranceFee>
          <LoanOriginationFee xmlns="http://xmlns.oracle.com/bpm/pa/extn/headerCategories/">LoanOriginationFee293</LoanOriginationFee>
          <RegistrarFee xmlns="http://xmlns.oracle.com/bpm/pa/extn/headerCategories/">RegistrarFee294</RegistrarFee>
          <LoanCashInFee xmlns="http://xmlns.oracle.com/bpm/pa/extn/headerCategories/">LoanCashInFee295</LoanCashInFee>
          <LoanPaidInCashFlag xmlns="http://xmlns.oracle.com/bpm/pa/extn/headerCategories/">LoanPaidInCashFlag296</LoanPaidInCashFlag>
       </ApplicationsHDRAddInfo>
    </applicationData>
And the xslt
    <xsl:template match="/">
        <ns1:DefaultOutput>
          <ns1:attribute1>
            <xsl:value-of select="/fslo:applicationData/fslo:ApplicationsHDRAddInfo/custom:LoanOriginationFee"/>
          </ns1:attribute1>
        </ns1:DefaultOutput>
      </xsl:template>
This results in a empty attribute1. Any help will be appreciated .

Please delete attributeFormDefault="qualified" elementFormDefault="qualified" from your XSD
Please check the next link:
http://www.oraclefromguatemala.com.gt/?p=34

Stored procedure returning multiple records without using SYS_REFCURSOR

Hello,
I am new to oracle stored procedures, have done stored procs in SQL server in past. I am trying to write single stored proc which will return multiple records. I have the stored proc as below and that is compiled without any errors.
We don't want to use SYS_REFCURSOR as output param b'coz the place from which this proc is gonna call, that system doesn't support SYS_REFCURSOR param.
create or replace
PROCEDURE p_get5500DATA_MB (
IN_plan_ID IN T_5500DATA_QWP.Plan_ID%TYPE,
IN_plan_ID_col OUT T_5500DATA_QWP.Plan_ID%TYPE,
p_SEQNUM OUT T_5500DATA_QWP.SEQNUM%TYPE,
p_HEADER_CD OUT T_5500DATA_QWP.HEADER_CD%TYPE,
p_VALUE1 OUT T_5500DATA_QWP.VALUE1%TYPE,
p_VALUE2 OUT T_5500DATA_QWP.VALUE2%TYPE
) AS
BEGIN
SELECT
Plan_ID,
SEQNUM,
HEADER_CD,
VALUE1,
VALUE2
INTO
IN_plan_ID_col,
p_SEQNUM,
p_HEADER_CD,
p_VALUE1,
p_VALUE2
FROM TRS1DBO.T_5500DATA_QWP
WHERE Plan_ID = IN_plan_ID
ORDER BY SeqNum;
-- EXCEPTION
-- WHEN OTHERS THEN
-- RAISE_APPLICATION_ERROR(-210001, 'Error in fetching data from T_5500DATA_QWP....');
END;
Error:
ORA-01422: exact fetch returns more than requested number of rows
ORA-06512: at "TRS1DBO.P_GET5500DATA_MB", line 10
ORA-06512: at line 11
My questions is:
- What would be the best practice for this type of simple stored procedures?
- Is there any alternate or is there anything i can fix in above stored proc which return multiple records?
Thank you,
Vimal

Just out of curiosity, what are you using for API or driver that doesn't support a ref cursor? Ref cursors are pretty much the defacto standard for passing multiple records out of an Oracle procedure. Oracle's ODP.NET, OLEDB, ODBC, JDBC, OCI, all support ref cursors. Chances are that if the driver you're using doesn't support something as basic/fundamental as a ref cursor, it's probably also not going to support something else either.
You'll most likely want to check with the driver/api vendor on their recommended approach.

Using index in a query return few records than full table access

Today we have an issue with a query, when it use the ok index the returned are not all records that apply to where clause condition.
See bellow
explain plan for
select * from movdb.zan_m03 where
M00AF = TO_DATE('11/01/28','YY/MM/DD') AND
M00za = 10 AND
m00AC = 50 AND
M00AD between 136906 and 136999
SELECT * FROM TABLE(dbms_xplan.display);
PLAN_TABLE_OUTPUT
Plan hash value: 1882720105
| Id | Operation | Name |
| 0 | SELECT STATEMENT | |
| 1 | TABLE ACCESS BY INDEX ROWID| ZAN_M03 |
|* 2 | INDEX RANGE SCAN | PK_ZAN_M03 |
Predicate Information (identified by operation id):
PLAN_TABLE_OUTPUT
2 - access("M00AF"=TO_DATE('11/01/28','YY/MM/DD') AND "M00ZA"=10 AND
"M00AC"=50 AND "M00AD">=136906 AND "M00AD"<=137141)
filter("M00AD"<=137141 AND "M00AD">=136906)
Note
- rule based optimizer used (consider using cbo)
20 rows selected.
The query above return only one row insted 1579 record that apply to this conditions.
When forcing a full table acess with a hint, the query return all records that apply, the 1579 record.
select /*+ FULL(zan_m03) */ M00AF, M00za, m00AC , M00AD from movdb.zan_m03 where
M00AF = TO_DATE('11/01/28','YY/MM/DD') AND
M00za = 10 AND
m00AC = 50 AND
M00AD between 136906 and 137141
Can you help me to identify what's happening?
I am with Oracle 10g R2 10.2.0.4 standard edition
the statistics are up to date
the opitimizer_mode are rule, but altering in session level to all_rows happens the same issue.
Nothing about corruption in the alert log.
Thanks in advance
Regards
Cristiano

Yes the query are the same and correct restriction for where clause are M00AD between 136906 and 137141.
I've pasted, by mistake, another test query
The corrects are:
select M00AF, M00za, m00AC , M00AD from movdb.zan_m03 where
M00AF = TO_DATE('11/01/28','YY/MM/DD') AND
M00za = 10 AND
m00AC = 50 AND
M00AD between 136906 and 137141
This use pk index and return one row
select /*+ FULL(zan_m03) */ M00AF, M00za, m00AC , M00AD from movdb.zan_m03 where
M00AF = TO_DATE('11/01/28','YY/MM/DD') AND
M00za = 10 AND
m00AC = 50 AND
M00AD between 136906 and 137141
This does a full table access and return 1579 records
I´ve been searching for wrong results bugs on my oracle support, but not found one that mentions something like our issue.
I checked the dba_tables and dba indexes and the number of rows are different, and I think this would be the same because it's is a pk.
Look this
SQL> select NUM_ROWS from dba_tables where table_name = 'ZAN_M03'
2 /
NUM_ROWS
228527878
select NUM_ROWS from dba_indexes where index_name = 'PK_ZAN_M03';
SQL> select NUM_ROWS from dba_indexes where index_name = 'PK_ZAN_M03';
NUM_ROWS
217510185
Is normal a index for pk having much fewer rows than table? I think not, but not sure.
Again
Thanks in advance
Regards
Cristiano

Use DISTINCT with two fields to return one record

I am using OleDB with a SELECT DISTINCT query that is used in C# code to populate a DataGridViewComboBox. The queried table has two fields: ID and Description. The ID field values are unique. Descriptions may be duplicated. The DataSource of my DataGridViewComboBox
is ListBoxItems which is a ListBox that is populated from a table. The ValueMember is ID and the DisplayMember is Description. A sample table might look like this:
ID    Description
1     Blue
2     Blue
3     Red
4     Blue
I want my query to return two records; one for the Red description and only one for the Blue description. I don't care which Blue description it returns, but I do need the corresponding ID for the selected Blue record and the ID value for the Red record.
Using SELECT DISTINCT ID, Description FROM... would give me four records instead of two. How can I return only two records in this scenario?
Rob E.

Using window function:
create table #temp
ID int,
description varchar(20),
insert into #temp Values(1,'blue')
insert into #temp Values(2,'blue')
insert into #temp Values(3,'red')
insert into #temp Values(4,'blue')
;WITH CTE AS (select RN=ROW_NUMBER() OVER (PARTITION BY description ORDER BY newid() ),
ID,description from #temp)
SELECT ID, description from CTE
WHERE RN = 1;
ID description
4 blue
3 red
Kalman Toth Database & OLAP Architect
SQL Server 2014 Database Design
New Book / Kindle: Beginner Database Design & SQL Programming Using Microsoft SQL Server 2014

How to Return ten records into java class by using oracle stored procedure

Hello sir/Friends
There is a procedure that returns 10 records from the oracle table and i want to display all 10 records into the table in java class.
Please reply
Thanking you.

When you execute the stored procedure it will return your results as a ResultSet. Iterate over itto get the values you need then do with them as you please.
        List<MyObject> results = new ArrayList<MyObject>();
        MyObject mo = null;
        ResultSet rs = stmt.executeQuery("SELECT a_value FROM a_table");
        while (rs.next())
            mo = new MyObject();
            mo.setValue(rs.getString(1));
            results.add(mo);
        }

Parameter Field Value returns "no records"

I am using Crystal 11 and am new to Crystal but not to other Reportwriters. I have a Crystal report that has 2 parameter fields, one is "Enter Date" that prompts for the start and end date, the other "Select Items" prompts for the supply Item Numbers to be included in the report. In the "Edit Parameter: Select Items:" edit/create parameter dialog, the Select Item parameter has "Allow Multiple values" and "Allow discrete values" set to true. The report runs fine and returns any items entered in the "Select Items" prompt that has usage during the start & end date. My problem is ... if the entered Item Number for the Select Items parameter returns no records, I cannot report that Item Number as having zero usage. I cannot find a way at the time of report running to identify and report the "not found" items. I would also like to report the Start and End Dates parameters requested, but cannot, the Enter Date parameter returns an empty parameter field across the whole report. I'm sure other users have had this problem of reporting the requested parameter values. Need assistance.

Jeff's answer is one way to do it. There are others:
If you want the items with no data interspersed with the other items (say, in item number order), then you'd change the report to use your item master table and do a left join from that to the usage data. If a field from the usage table is null, then there was no usage, and you can condition a message based on that.
Or, if your parameter selects item numbers without some type of "ALL" option, then you can use arrays to keep track of which if the selected items printed. Then in the report footer, compare the list of items reported to the parameter items, and show which item numbers had no usage. (This might run a tad faster than the separate subreport that Jeff suggested - but maybe not...)
HTH,
Carl

EntryProcessor invokeAll returning empty ConverterMap{}

Hi All,
I am trying to write a custom entryprocessor and whatever I return from the invokeAll method in the entryprocessor, I am always getting a empty ConverterMap{}. The code for the entryprocessor is as below:
public class CustomEP implements PortableObject, EntryProcessor {
     public CustomEP (){
public Map processAll(Set entries) {
          Map results=new HashMap ();
results.put ("1", "1");
System.out.println("Inside process All method");
          return results;
public Object process(Entry arg0) {
          Map results=new HashMap ();
results.put ("1", "1");
System.out.println("Inside process method");
          return results;
The client code to invoke this entryprocessor is as below:
Map results=cache.invokeAll(AlwaysFilter.INSTANCE, new CustomEP());
The processAll method on the Coherence nodes is invoked but if the print the results on the client side it return empty ConverterMap{}
On the other hand, if I invoke process method of CustomEP as below:
Map results=(Map) cache.invoke(AlwaysFilter.INSTANCE, new CustomEP());
I get the desired results. Please help me with the details why it is happening this way when the return type of the processAll is a Map.
Thanks a lot!
Regards,
S

911767 wrote:
Hi Robert and JK,
Thank you for your reply and time!
I could not find these details in any of the documentation that specifies keys passed in the result should be subset of the keys passed to the processAll method. Anyways, my problem is to invoke server-side code (avoid de-serialization) by passing a filter and then create a entirely new map (key and value will be different from the entries extracted from the passed filter) by reading the data from the passed entries. How can I implement it?
I am thinking to use aggregator as they are read-only and faster but again how to implement it using:
public Object aggregate(Set entries){
Again, I am getting an empty Map so is it necessary that the object returned should have keys matching the set of the entries passed to this method.
Secondly, there are other methods such as, finalizeResult() and init() if I extend AbstractAggregator, do I need to implement them and if yes, how? The entries set passed to the aggregate() method may not reside on the same node.
Please advise!
Regards,
SHi S,
the process() return value object, or the entry value objects in the map returned by processAll() can be arbitrary objects. So you just return a map from process(), and return a map as the entry value in the result map from processAll().
The AbstractAggregator has a fairly badly documented contract in the Javadoc (does not properly cover the values received in different scenarios for invocation). You should probably read the section about it in the Coherence book, that explains leveraging AbstractAggregator in significantly more details. It also happens to be in the sample chapter, but I recommend reading the entire book.
I am not sure about the issues relating to posting links to PDFs on Packt's webpage, so I won't do that. Please go to Packt's webpage (http://www.packtpub.com ), look for the Coherence book there and download the sample chapter (or order the book).
In short, all 3 to-be-implemented methods (init(), process(), finalizeResult()) in AbstractAggregator are called both on the server and on the caller side. You can distinguish which side you are on from looking at both the passed in fFinal boolean parameter and the m_fParallel attribute tof the aggregator instance.
There are 3 cases:
- non-parallel aggregation processing extracted values (m_fParallel is false, I don't remember what fFinal is in this case),
- parallel aggregation storage side processing extracted values (if I correctly remember, m_fParallel is true, fFinal is false),
- parallel aggregation caller side processing parallel results (m_fParallel and fFinal are both true).
Depending on which side you are on, the process method takes different object types (on server side it receievs the extracted value, on caller side it receives a parallel result object instance).
You SHOULD NOT override any of the other methods (e.g. aggregate() which you mentioned).
The advantage of this approach is that the AbstractAggregator subclass instance can pass itself off as a parallel-aggregator instance.
You should put together a temporary result in a member attribute of the AbstractAggregator subclass, which also means that it will likely not be thread-safe, but at the moment it is not necessary for it to be thread-safe either as it is called only on a single-thread.
Best regards,
Robert
Edited by: robvarga on Feb 3, 2012 10:38 AM

Extractors in CRM returning 0 records

hello evryone,
could anyone please let me know, if they have come across these Extractors such as 0CRM_CONTACT_OUT,0CRM_OPPT_H,0CRM_OPPT_I how do they really work, upon some requirement i need these datasources in use. when i try to extractor check in rsa3 all these 3 extractors are returning 0 records for the full mode. could anyone please let me know, how to work on them to pull the data from these extractors to BI.

Hi dear,
if you are working with LC datasource, you have to tun setup job to fill setup table in order to be able to see something with RSA3 !
Try OLI7BW for orders (application comp.11)
OLI8BW for 12
OLI9BW for 13
(don't forget to empty via LBWG these tables before filling them to avoid data duplication!!!)
Hope it helps!
Bye,
Roberto

How to return multiple record with Oracle Native Web Service?

Dear all,
I would like to know that the oracle native web service can be able to return multiple records to client or not?
I successfully developed the oracle native web service for returning single record but the next challenge is to develop web service in order to return multiple record (like Employees data base on each department)
Thank and Regards,
Zenoni

I successfully developed the oracle native web service for returning single record but the next challenge is to develop web service in order to return multiple record (like Employees data base on each department)You could return a list (multiple values/records) in XML format (using XMLType or CLOB), or CSV, or JSON, or whatever.
function get_employees (p_department_id in number) return clob
as
begin
return 'your_xml_string_here';
end get_employees;It would be up to the client (the caller of the web service) to extract the values from whatever format you decide upon, of course.
- Morten
http://ora-00001.blogspot.com

Infospoke on a Cube returns zero records

Hi
I am working on BW 3.5.
I am trying to extract data from a Cube using Infospoke.
Every time I run the Infospoke it returns 0 records!
I tried to extract to Table/File with same result.
When I use infospoke on ODS's or IO it works ok.
Any idea's?
Reg's
Edan

Pl check if you have data in the cube.
Secondly, if you have selections in the characteristics selection, pl check that out.
Ravi Thothadri

BAPI return empty element.

Guys,
I have created one scenario SOAP -> BAPI (sync).
BAPI
ZMMF_GET_COMPANY
My BAPI have 10 elements and 9 return with values.
But i have 1 element with name "text1" and one return empty value always.
When i execute the BAPI using tcode se37, "text1" return value, for exemplo "test test test".
But when i execute in RFCAdapter, "text1" return empty value.
Can anybody helpme me?

Hey
I had the same issue with a standard BAPI some time ago.
The way BAPI is triggered in SE37 is different from the way BAPI is triggered when a request is send from XI.
suppose you want to fetch business partner data based upon business partner number,now this partner number has been configured to be of length 10 in BAPI,now suppose you execute the BAPI via SE37 and give the partner number of only 6 digits then 4 zeros will be padded and the partner number will be made of all 10 digits,but if you send a partner number of 6 digits from XI then no padding is done hence no records are pulled up(since partner number must be 10 digits and you have only 6).
Please try to test this and make sure you are giving correct values.
Thanx
Aamir

Call RFC Function Module and return 1000 records at a time

I would like to call a Remote Enabled Function Module from a non SAP system. This function module will select data from the database and return it to the calling program.
Suppose there are 100,000 records that need to be returned, but the calling module would like the data in chunks of 1000 records. Therefore the calling program would call the FM 100 times.
How do I code the function module to know on each subsequent call to grab the next chunk of 1000 records?
Let me know if additional information is needed.
Thanks,
Aaron

Hello,
Here is how you can go for this issue:
1. Create one RFC function module with following parameter. These parameters are with respective of chunking logic.
     Import: Package Size
     Export: Total number of records
     Changing: chunk count
Implement following logic:
1. First of you need to know how many chunks you need to fetch for that get the count of total number of records. This is one
    time activity so you better maintain one flag import parameter will be set to 'X' only first call.
2. Get the number of chunk using total number of records / chunk size for e.g. 1000 / 100 so chunk count = 10.
3. Define internal chunk counter in function module which will be used to locate the correct chunk depending on the chunk
    counter value sent from calling program.
4. Send first call with package size 100 and chunk count = 1, execute select statement and increment internal
    chunk count check if chunk count = internal chunk count in current case chunk count = 1 so exit select statement and return
    with first chunk.
5. Send second call with package size 100 and chunk count = 2. Execute select statement and check chunk count with internal
    chunk counter, in current case it will be 1 so skip that data and go for next chunk of 100 records increment internal chunk
    counter. In this case it will match with external chunk count = 2. load output table with that data and return to calling program.
6. Repeat step 4 until you reach last chunk.
You need to use SELECT...ENDSELECT with PACKAGE SIZE addition so for every loop it will return number of records mentioned in package size.
Hope this helps.
Thanks,
Augustin.

DS 3.2 BW Load: Empty records in BW

Hi All,
i'm using DS 3.2 an BW 7.01 SP 5. I use the RFC Sever via Management Console and the configuration and connection between both is fine. ( my source was: https://wiki.sdn.sap.com/wiki/display/BOBJ/Loading+BW)
After running the Infopackages i get a green request in the PSA but with empty records. I've tried switching between "Compare by name or by position" in the DS Designer mapping without success. I keep the mapping easy, i've tried with just a constant or just few Fields ...
Thanks for any information
Honore

Thanks, the setting UTF-8 solved the problem.
Thanks a lot.
Honoré

Getter/setter methods -- how do I use the return values

I'm just learning Java, and I haven't been to this site since the end of July, I think. I have a question regarding getter and setter methods. I switched to the book Head First Java after a poster here recommended it. I'm only about a hundred pages into the book, so the code I'm submitting here reflects that. It's the beginnings of a program I'd eventually like to complete that will take the entered information of my CD's and alphabetize them according to whatever criteria I (or any user for that matter) choose. I realize that this is just the very beginning, and I don't expect to have the complete program completed any time soon -- it's my long term goal, but I thought I could take what I'm learning in the book and put it to practical use as I go along (or at lest try to).
Yes I could have this already done it Excel, but where's the fun and challenge in that? :) Here's the code:
// This program allows the user to enter CD information - Artist name, album title, and year of release -- and then organizes it according the the user's choice according to the user's criteria -- either by artist name, then title, then year of release, or by any other order according to the user's choice.
//First, the class CDList is created, along with the necessary variables.
class CDList{
     private String artistName;//only one string for the artist name -- including spaces.
     private String albumTitle;//only one string the title name -- including spaces.
     private int yearOfRelease;
     private String recordLabel;
     public void setArtistName(String artist){
     artistName = artist;
     public void setAlbumTitle(String album){
     albumTitle = album;
     public void setYearOfRelease(int yor){
     yearOfRelease = yor;
     public void setLabel(String label){
     recordLabel = label;
     public String getArtistName(){
     return artistName;
     public String getAlbumTitle(){
     return albumTitle;
     public int getYearOfRelease(){
     return yearOfRelease;
    public String getLabel(){
    return recordLabel;
void printout () {
       System.out.println ("Artist Name: " + getArtistName());
       System.out.println ("Album Title: " + getAlbumTitle());
       System.out.println ("Year of Release: " + getYearOfRelease());
       System.out.println ("Record Label: " + getLabel());
       System.out.println ();
import static java.lang.System.out;
import java.util.Scanner;
class CDListTestDrive {
     public static void main( String[] args ) {
          Scanner s=new Scanner(System.in);
          CDList[] Record = new CDList[4];
          int x=0;
          while (x<4) {
          Record[x]=new CDList();
          out.println ("Artist Name: ");
          String artist = s.nextLine();
          Record[x].setArtistName(artist);
          out.println ("Album Title: ");
          String album = s.nextLine();
          Record[x].setAlbumTitle(album);
          out.println ("Year of Release: ");
          int yor= s.nextInt();
                s.nextLine();
          Record[x].setYearOfRelease(yor);
          out.println ("Record Label: ");
          String label = s.nextLine();
          Record[x].setLabel(label);
          System.out.println();
          x=x+1;//moves to next CDList object;
          x=0;
          while (x<4) {
          Record[x].getArtistName();
          Record[x].getAlbumTitle();
          Record[x].getYearOfRelease();
          Record[x].getLabel();
          Record[x].printout();
          x=x+1;
               out.println("Enter a Record Number: ");
               x=s.nextInt();
               x=x-1;
               Record[x].getArtistName();
            Record[x].getAlbumTitle();
            Record[x].getYearOfRelease();
            Record[x].getLabel();
            Record[x].printout();
     }//end main
}//end class          First, I'd like to ask anyone out there to see if I could have written this any more efficiently, with the understanding that I'm only one hundred pages into the book, and I've only gotten as far as getter and setter methods, instance variables, objects and methods. The scanner feature I got from another book, but I abandoned it in favor of HFJ.
Secondly --
I'm confused about getter and setter methods -- I'd like someone to explain to me what they are used for exactly and the difference between the two. I have a general idea, that getters get a result from the method and setters set or maybe assign a value to variable. I submitted this code on another site, and one of the responders told me I wasn't using the returned values from the getter methods (he also told me about using a constructor method, but I haven't got that far in the book yet.). The program compiles and runs fine, but I can't seem to figure out how I'm not using the returned values from the getter methods. Please help and if you can explain in 'beginners terms,' with any code examples you think are appropriate. It will be greatly appreciated.
By the way, I'm not a professional programmer -- I'm learning Java because of the intellectual exercise and the fun of it. So please keep that in mind as well.
Edited by: Straitsfan on Sep 29, 2009 2:03 PM

Straitsfan wrote:
First, I'd like to ask anyone out there to see if I could have written this any more efficiently, with the understanding that I'm only one hundred pages into the book, and I've only gotten as far as getter and setter methods, instance variables, objects and methods. The scanner feature I got from another book, but I abandoned it in favor of HFJ.Yes, there is tons you could have done more efficiently. But this is something every new programmer goes through, and I will not spoil the fun. You see, in 3 to 6 months when you have learned much more Java, assuming you stick with it, you will look back at this and be like "what the hell was I thinking" and then realize just haw far you have come. So enjoy that moment and don't spoil it now by asking for what could have been better/ more efficient. If it works it works, just be happy it works.
Straitsfan wrote:
Secondly --
I'm confused about getter and setter methods -- I'd like someone to explain to me what they are used for exactly and the difference between the two. I have a general idea, that getters get a result from the method and setters set or maybe assign a value to variable. I submitted this code on another site, and one of the responders told me I wasn't using the returned values from the getter methods (he also told me about using a constructor method, but I haven't got that far in the book yet.). The program compiles and runs fine, but I can't seem to figure out how I'm not using the returned values from the getter methods. Please help and if you can explain in 'beginners terms,' with any code examples you think are appropriate. It will be greatly appreciated.
By the way, I'm not a professional programmer -- I'm learning Java because of the intellectual exercise and the fun of it. So please keep that in mind as well.First, if you posted this somewhere else you should link to that post, it is good you at least said you did, but doubleposting is considered very rude because what inevitably happens in many cases is the responses are weighed against each other. So you are basically setting anyone up who responds to the post for a trap that could make them look bad when you double post.
You are setting you getters and setters up right as far as I can tell. Which tells me that I think you grasp that a getter lets another class get the variables data, and a setter lets another class set the data. One thing, be sure to use the full variable name so you should have setRecordLabel() and getRecodLabel() as opposed to setLabel() and getLabel(). Think about what happens if you go back and add a label field to the CDList class, bad things the way you have it currently. Sometimes shortcuts are not your friend.
And yes, you are using the getters all wrong since you are not saving off what they return, frankly I am suprised it compiles. It works because you don't really need to use the getters where you have them since the CDList Record (should be lowercase R by the way) object already knows the data and uses it in the printout() method. Basically what you are doing in lines like:
Record[x].getArtistName();is asking for the ArtistName in Record[x] and then getting the name and just dropping it on the floor. You need to store it in something if you want to keep it, like:
String artistName = Record[x].getArtistName();See how that works?
Hope this helped, keep up the good learning and good luck.
JSG

BW Extraction using DS returning empty records

Similar Messages

Maybe you are looking for