Can I please get a Debug code compiles

Question

The code below is supposed to use threads to get the checksum of two files chosen for Jfilechoosers and then compare there checksums and tell whether they are equal or not. I have all working but the values for the files individual checksums are not showing correctly because the threads are not completing before they are displayed. I have tried everything and I have even tried to implement code given to me from this forum but to no evail I have 15 Duke bucks left and they will go to the person who can give me a answer in code and where it is supposed to go plus a little explanation on why so I am not feeling as dumb as I do right now.
Along with the duke bucks a great apprecaition will come with this for you will have saved my but and my GPA.
here it is and THANKS to all.....
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.io.*;
public class EFile extends JFrame
     private JButton buttons [];
     private JLabel labels [];
     private JTextField text[];
     private JPanel buttonPanel, labelPanel;
     private String bNames []= {"file1", "file2", "compare"};
     private String lNames []= {"1st file name", "2nd file name", "Checksum1", "Checksum2"};
     private File fileName, fileName2;
     private RandomAccessFile input;
     Checksums cksum1 = new Checksums();
     Checksums cksum2 = new Checksums();
     public EFile()
          super( " Eric's File Comparison " );
          Container c = getContentPane();
          c.setLayout(new BorderLayout(25,25));
          buttons = new JButton[3];
          labels = new JLabel[4];
          text = new JTextField[4];
          buttonPanel = new JPanel();
          buttonPanel.setLayout(new GridLayout(buttons.length,1));
          for ( int count = 0; count < buttons.length; count++)
               buttons[count]= new JButton(bNames[count]);
               buttonPanel.add(buttons[count]);
          labelPanel = new JPanel();
          labelPanel.setLayout(new GridLayout(labels.length,1));
          for (int count = 0; count < labels.length; count++)
               labels[count]=new JLabel(lNames[count]);
               text[count]=new JTextField(count);
               labelPanel.add(labels[count]);
               labelPanel.add(text[count]);
          buttons[0].addActionListener(
// anonymous inner class to handle openButton event
new ActionListener() {
// call openFile when button pressed
public void actionPerformed( ActionEvent event )
openFile();
} // end anonymous inner class
); // end call to addActionListener
     buttons[1].addActionListener(
// anonymous inner class to handle openButton event
new ActionListener() {
// call openFile when button pressed
public void actionPerformed( ActionEvent event )
openFile2();
} // end anonymous inner class
     buttons[2].addActionListener(
// anonymous inner class to handle openButton event
new ActionListener() {
// call openFile when button pressed
public void actionPerformed( ActionEvent event )
          //Checksums c1 = new Checksums();
                         cksum1.setFileName(fileName);
                         cksum2.setFileName(fileName2);
                         Thread t1 = new Thread(cksum1);
                         Thread t2 = new Thread(cksum2);
                         Thread t3 = new Thread();
                         t1.start();
                         t2.start();
                         t3.start();
                         int d = cksum1.getChecksum();
                         int e = cksum2.getChecksum();
                         text[2].setText("" + d);     
                         text[3].setText("" + e);
                         testChecksums(d,e);
} // end anonymous inner class
          c.add(buttonPanel, BorderLayout.WEST);
          c.add(labelPanel, BorderLayout.CENTER);
          setSize(600,400);
          setVisible(true);
     public void testChecksums(int d, int e)
          if (d == e)
               JOptionPane.showMessageDialog( this, "The checksums ARE equal",
               "Equal", JOptionPane.ERROR_MESSAGE);
          else
               JOptionPane.showMessageDialog( this, "The checksums are NOT equal",
               "Not Equal", JOptionPane.ERROR_MESSAGE);
     private void openFile()
// display file dialog so user can select file
JFileChooser fileChooser = new JFileChooser();
fileChooser.setFileSelectionMode(
JFileChooser.FILES_ONLY );
int result = fileChooser.showOpenDialog( this );
// if user clicked Cancel button on dialog, return
if ( result == JFileChooser.CANCEL_OPTION )
return;
// obtain selected file
fileName = fileChooser.getSelectedFile();
// display error is file name invalid
if ( fileName == null ||
fileName.getName().equals( "" ) )
JOptionPane.showMessageDialog( this,
"Invalid File Name", "Invalid File Name",
JOptionPane.ERROR_MESSAGE );
else {
// open file
try {
input = new RandomAccessFile( fileName, "r" );
               text[0].setText(fileName.getName());
buttons[0].setEnabled( false );
buttons[1].setEnabled( true );
               buttons[2].setEnabled(true);
// catch exception while opening file
catch ( IOException ioException ) {
JOptionPane.showMessageDialog( this,
"File does not exist", "Invalid File Name",
JOptionPane.ERROR_MESSAGE );
} // end method openFile
private void openFile2()
// display file dialog so user can select file
JFileChooser fileChooser = new JFileChooser();
fileChooser.setFileSelectionMode(
JFileChooser.FILES_ONLY );
int result = fileChooser.showOpenDialog( this );
// if user clicked Cancel button on dialog, return
if ( result == JFileChooser.CANCEL_OPTION )
return;
// obtain selected file
fileName2 = fileChooser.getSelectedFile();
// display error is file name invalid
if ( fileName2 == null ||
fileName2.getName().equals( "" ) )
JOptionPane.showMessageDialog( this,
"Invalid File Name", "Invalid File Name",
JOptionPane.ERROR_MESSAGE );
else {
// open file
try {
input = new RandomAccessFile( fileName2, "r" );
               text[1].setText(fileName2.getName());
buttons[0].setEnabled( false );
buttons[1].setEnabled( false );
               buttons[2].setEnabled(true);
// catch exception while opening file
catch ( IOException ioException ) {
JOptionPane.showMessageDialog( this,
"File does not exist", "Invalid File Name",
JOptionPane.ERROR_MESSAGE );
} // end method openFile
private void closeFile()
// close file and exit
try {
input.close();
System.exit( 0 );
// process exception while closing file
catch ( IOException ioException ) {
JOptionPane.showMessageDialog( this,
"Error closing file",
"Error", JOptionPane.ERROR_MESSAGE );
System.exit( 1 );
     public static void main(String args[])
          EFile e = new EFile();
          e.setDefaultCloseOperation(2);
class Checksums extends JFrame implements Runnable
     //Thread runner;
     public File fileName;
     public RandomAccessFile input;
     public int checkSum ;
     Checksums()
          super();
     public void setFileName(File name)
          fileName = name;          
     public int getChecksum()
          return checkSum;
     public void run()
          try
                    input = new RandomAccessFile( fileName, "r" );
                    byte[] chunk = new byte[100000];
                    int readFile;
                    while ((readFile = input.read(chunk)) != -1)
                         checkSum = (checkSum + readFile)%65535;
               catch ( IOException ioException)
                    JOptionPane.showMessageDialog( this, "Error opening file",
                    "Error", JOptionPane.ERROR_MESSAGE);
     } //end run
} // end Checksums

Answer 1

looking at the code below :
public void actionPerformed( ActionEvent event )
//Checksums c1 = new Checksums();
cksum1.setFileName(fileName);
cksum2.setFileName(fileName2);
Thread t1 = new Thread(cksum1);
Thread t2 = new Thread(cksum2);
// this thread appears redundant.  why is it here?
// Thread t3 = new Thread();
t1.start();
t2.start();
// t3.start();
int d = cksum1.getChecksum();
int e = cksum2.getChecksum();
text[2].setText("" + d);
text[3].setText("" + e);
testChecksums(d,e);what is happening, as you have stated, is a race condition when you are trying to get d and e. So, something like this might be in order:
public void actionPerformed( ActionEvent event )
//Checksums c1 = new Checksums();
cksum1.setFileName(fileName);
cksum2.setFileName(fileName2);
Thread t1 = new Thread(cksum1);
Thread t2 = new Thread(cksum2);
t1.start();
t2.start();
int d = 0;
int e = 0;
try {
  t1.join();
  d = cksum1.getChecksum();
} catch (InterruptedException e) {
  e.printStackTrace();
try {
  t2.join();
  e = cksum2.getChecksum();
} catch (InterruptedException e) {
  e.printStackTrace();
text[2].setText("" + d);
text[3].setText("" + e);
testChecksums(d,e);for information on Thread.join(), I point you to the Thread javadoc.
for what its worth, the design of your program is not ideal - an ideal design would remove any likelihood of this sort of race condition by not allowing access to the "checksums" before they'd been set by the threads, either through a synchronized() block or object, or through the use of the Observer / Observable pattern. Thread.join() is messy.
hope this helps
McFinnigan