Can this train run any faster...?

Question

Hello virtual suggestion givers!
Everything's working pretty ok when I enter small values while instantiating Train class, the thing is that when I enter large values about lets say
new Train(5,96,5,10) its giving me IndexOutOfbounds exception or acting weirdly.
I think there might be some problem in my Train class...
should ArrayList be used instead of LinkedList?
what's the flaw in the code?
Is there anything redundant in this code?
I had lot's of time this time in my hand, so I didn't have to come in here frequently.
==========================================
concepts? inheritance? homework? don't understand?
==========================================
import type.lang.*;
import java.util.*;
public class Train {
    public Train(int numSaloonCars, int nSeats, int numSleepingCars,
                 int nBerths) {
        if((numSaloonCars + numSleepingCars) <= 0
                || (nSeats + nBerths) <= 0) {
            throw new IllegalArgumentException("input valid data!");
        } else {
            for(int i = 0; i < numSaloonCars; i++) {
                atotal.add(new SaloonCar(nSeats));
            for(int m = 0; m < numSleepingCars; m++) {
                btotal.add(new SleepingCar(nBerths));
    public String reserveSpace(String spaceType, int numP) {
        StringBuffer buf = new StringBuffer();
        if(( !spaceType.equals(BERTH) && !spaceType.equals(SEAT))
                || (numP <= 0)) {
            throw new IllegalArgumentException("enter proper data!");
        } else if(spaceType.equals(SEAT)) {
            List train = new LinkedList(atotal);
            for(int i = 0; i < train.size(); i++) {
                if(numP == ((SaloonCar) train.get(i)).getAvailableSpace()) {
                    buf.append(
                        ((SaloonCar) train.get(i)).addPassengers(numP));
                } else if(numP
                          < ((SaloonCar) train.get(i)).getAvailableSpace()) {
                    buf.append(((RailCar) train.get(i)).addPassengers(numP));
                } else {
                    throw new TrainFullException("Train's Full!");
        } else if(spaceType.equals(BERTH)) {
            List train2 = new LinkedList(btotal);
            for(int m = 0; m < train2.size(); m++) {
                if(numP == ((SleepingCar) train2.get(
                        m)).getAvailableSpace()) {
                    buf.append(
                        ((SleepingCar) train2.get(m)).addPassengers(numP));
                } else if(numP
                          < ((SleepingCar) train2.get(
                              m)).getAvailableSpace()) {
                    buf.append(
                        ((SleepingCar) train2.get(m)).addPassengers(numP));
                } else {
                    throw new TrainFullException("Train's Full!");
        return buf.toString();
    public String toString() {
        StringBuffer buf   = new StringBuffer("Train [");
        List         list  = new LinkedList(atotal);
        List         list2 = new LinkedList(btotal);
        for(int i = 0; i < list.size(); i++) {
            buf.append(" SaloonCar[ ");
            buf.append(((SaloonCar) list.get(i)).toString() + " ]");
        for(int m = 0; m < list2.size(); m++) {
            buf.append(" SleepingCar[ ");
            buf.append(((SleepingCar) list2.get(m)).toString() + " ]");
        return buf.toString();
    private List               atotal = new LinkedList();
    private List               btotal = new LinkedList();
    public static final String BERTH  = "berth";
    public static final String SEAT   = "seat";
import java.lang.*;
import java.util.*;
public abstract class RailCar {
    public RailCar(Collection s) {
        this.s = s;
    public abstract String addPassengers(int p);
    public String allocateAvailableSpace(int p) {
        StringBuffer buf   = new StringBuffer();
        int          inP   = p;
        int          total = 0;
        List         list  = new LinkedList(s);
        for(int i = 0; i < list.size(); i++) {
            if(inP > ((OccupiableSpace) list.get(i)).getMaximumOccupants())
            //check maximumoccupants allowed
                throw new IllegalArgumentException(
                    "shold be = or < MAXOccupants of seat");
            } else if(isFull()) {
                //check for total available space in the railcar
                throw new CarFullException("Car is full!");
        ++number;    // i replicator
            ((OccupiableSpace) list.get(number-1)).addOccupants(inP);
            buf.append(((OccupiableSpace) list.get(number-1)).getId() + " ,");
        return buf.toString();
    public int getAvailableSpace() {
        int  total = 0;
        List list  = new LinkedList(s);
        for(int i = 0; i < list.size(); i++) {
            total += (((OccupiableSpace) list.get(i)).getVacantSpace());
        return total;
    public abstract int getMaximumOccupancy();
    public boolean hasSpace() {
        if(getAvailableSpace() == 0) {
            return false;
        } else {
            return true;
    public boolean isFull() {
        if(getAvailableSpace() == 0) {
            return true;
        } else {
            return false;
    public String toString() {
        StringBuffer buf      = new StringBuffer();
        String       tostring = "";
        List         list     = new ArrayList(s);
        for(int i = 0; i < list.size(); i++) {
            if(((OccupiableSpace) list.get(i)) instanceof Seat) {
                tostring +=
                    "SaloonCar ["
                    + buf.append(
                        "Seat" + "[ " + ((Seat) list.get(i)).getId() + " = "
                        + ((Seat) list.get(i)).getOccupants() + "] ") + " ]";
            } else if(((OccupiableSpace) list.get(i)) instanceof Berth) {
                tostring +=
                    "SleepingCar"
                    + buf.append(
                        "Berth" + "[ " + ((Berth) list.get(i)).getId()
                        + " = " + ((Berth) list.get(i)).getOccupants()
                        + "] ") + " ]";
        return buf.toString();
    public Collection s;
    public static int number = 0;
import java.util.*;
public class SaloonCar extends RailCar {
    public static final int MAX_SEATS = 96;
    public SaloonCar(int numSeats) {
        super(new LinkedList());
        if( !((numSeats <= 0) || (numSeats > MAX_SEATS))) {
            for(int i = 0; i <= numSeats - 1; i++) {
                s.add(new Seat());
        } else {
            throw new IllegalArgumentException("should be >= 0 & < MAX");
    public String addPassengers(int p) {
        StringBuffer buf   = new StringBuffer();
        int          total = 0;
        List         bag   = new LinkedList(s);
        if(p <= 0) {
            throw new IllegalArgumentException("should be >= 0");
        } else if(p > getAvailableSpace()) {
            throw new CarFullException("car's full");
        } else {
            for(int i = 0; i < p; i++) {
                buf.append(allocateAvailableSpace(Seat.MAX_OCCUPANTS));
        return buf.toString();
    public int getMaximumOccupancy() {
        return MAX_SEATS;
import java.util.*;
public class SleepingCar extends RailCar {
    public static final int MAX_BERTHS = 16;
    public final int        ONE        = 1;
    public SleepingCar(int numSeats) {
        super(new LinkedList());
        if( !((numSeats <= 0) || (numSeats > MAX_BERTHS))) {
            for(int i = 0; i < numSeats; i++) {
                s.add(new Berth());
        } else {
            throw new IllegalArgumentException("should be >= 0 & < MAX");
    public String addPassengers(int p) {
        StringBuffer buf   = new StringBuffer();
        int          total = 0;
        List         bag   = new LinkedList(s);
        if(p <= 0) {
            throw new IllegalArgumentException("should be >= 0");
        } else if(p > getAvailableSpace()) {
            throw new CarFullException("car's full");
        } else {
            int    found = 0;
            double check = p;
            List   list  = new LinkedList(s);
            for(int i = 0; i < list.size(); i++) {
                if(list.get(i) instanceof Berth) {
                    if(check / 2 != 0) {
                        int num = ((Berth) list.get(i)).getOccupants();
                        if((num == 0) || (num == 1)) {
                            found = i;
            if(check / 2 == 0) {
                for(int m = 0; m < check / 2; m++) {
                    buf.append(allocateAvailableSpace(Berth.MAX_OCCUPANTS));
            } else if(check / 2 != 0) {
                ((Berth) list.get(found)).addOccupants(ONE);
                buf.append(((Berth) list.get(found)).getId() + " ,");
                check--;
                for(int z = 0; z < check / 2; z++) {
                    buf.append(allocateAvailableSpace(Berth.MAX_OCCUPANTS));
        return buf.toString();
    public int getMaximumOccupancy() {
        return MAX_BERTHS;
import type.lang.* ;
import java.lang.* ;
public abstract class OccupiableSpace
  public OccupiableSpace(String code)
    idcode = code ;
  public void addOccupants(int num)
    if (num > getMaximumOccupants() || num < 0)
      throw new IllegalArgumentException() ;
    else
      numOccupants += num ;
  public boolean equals(Object o)
    if (o ==null) return false;
    if (getClass() != o.getClass()) return false;
    OccupiableSpace oin = (OccupiableSpace) o;
    return idcode.equals(oin.getId());
  public String getId()
    return idcode ;
  public abstract int getMaximumOccupants() ;
  public int getOccupants()
    return numOccupants ;
  public int getVacantSpace()
    int left = getMaximumOccupants() - getOccupants() ;
    return left ;
  public boolean isOccupied()
   if (getVacantSpace() == 0)
   return true;
   else
   return false;
  public void removeOccupants(int o)
    if (o > getOccupants() || o <= 0)
      throw new IllegalArgumentException() ;
    else
      numOccupants -= o ;
  public String toString()
    String ans = getClass().getName() + "[ id=" + idcode + ", occupants=" +
        numOccupants + " ]" ;
    return ans ;
  public int numOccupants ;
  public String idcode = "" ;
public class Berth
    extends OccupiableSpace
  public Berth()
    super("B-"+number);
    number++ ;
  public int getMaximumOccupants()
    return MAX_OCCUPANTS ;
  public static final int MAX_OCCUPANTS = 2 ;
  private static int number = 1 ;
public class Seat
    extends OccupiableSpace
  public Seat()
    super("S-" + number) ;
    number++ ;
  public int getMaximumOccupants()
    return MAX_OCCUPANTS ;
  public static final int MAX_OCCUPANTS = 1 ;
  private static int number = 1;
public class TrainFullException extends RuntimeException {
   public TrainFullException() {
      super();
   public TrainFullException(String msg) {
      super(msg);
public class CarFullException extends RuntimeException {
   public CarFullException() {
      super();
   public CarFullException(String msg) {
      super(msg);

Answer 1

what could be wrong in this part?
using System.out ... in a class file !?
  if(( !spaceType.equals(BERTH) && !spaceType.equals(SEAT))
                || (numP <= 0)) {
            throw new IllegalArgumentException("enter proper data!");
        } else if(spaceType.equals(SEAT)) {
            List train = new LinkedList(atotal);
            for(int i = 0; i < train.size(); i++) {
                if(numP == ((SaloonCar) train.get(i)).getAvailableSpace()) {
                    buf.append(
                        ((SaloonCar) train.get(i)).addPassengers(numP));
                } else if(numP
                          < ((SaloonCar) train.get(i)).getAvailableSpace()) {
                    buf.append(((RailCar) train.get(i)).addPassengers(numP));
                } else {
                    throw new TrainFullException("Train's Full!");
            }ahh... may be i am exhaus...