Closing connection

Question

Hello, I work with jdeveloper. I had 10.1.2 which used java version 1.4.2 and I used a simple connection class to call stored procedures in an Oracle db. I have jdeveloper 10.1.3 which uses java version 1.5.0 and the same class fails when I try to use ResultSets. I use to close the connection then return the resultset to whatever called it, now it tells me the connection is already closed when I try to access the resultset. I know this is why it's failing now, because it works if I don't close anything.
Can someone tell me how/why this has changed, and what I can do about it?
Thanks
Classes that use to work:
public class dbConn {
public dbConn() {
public static Connection getCon()
InitialContext ctx = null;
DataSource ds = null;
Connection conn = null;
try {
ctx = new InitialContext();
ds = (DataSource) ctx.lookup("jdbc/app1");
conn = ds.getConnection();
catch(Exception e){
System.out.println("Connection Error");
e.printStackTrace();
return conn;
public static void closeCon(CallableStatement proc, Connection conn)
try {
proc.close();
conn.close();
catch(SQLException e){
System.out.println("Error closing connections: "+e);
public static void main()
public static ResultSet GenResSet(String uname, String procName)
Connection conn = null;
CallableStatement proc = null;
ResultSet rs = null;
String callString = "{ call "+procName+"(?,?) }";
try {
conn = dbConn.getCon();
proc = conn.prepareCall(callString);
proc.registerOutParameter(1,OracleTypes.CURSOR);
proc.setString(2, uname);
proc.execute();
rs = (ResultSet)proc.getObject(1);
catch(SQLException e) {
System.out.println("sql error");
e.printStackTrace();
finally {
dbConn.closeCon(proc,conn);
return rs;
}

Answer 1

Ok thanks. So I can learn.. what exactly is my
misconception about how it works? My beginner view is
you stored a cursor set from a database query in a
result set then you could iterate through it. Why
does it have to be stored in a collection first? I
was closing the connection before I returned it, or
so I thought. It went through the finally code to
close everytime, but I could still use the results.
Maybe it wasn't closing them?That's exactly your misconception. After you close the connection, your ResultSet is not valid. In simple words, you need a live connection to fetch values from the ResultSet. In your method, you close the connection in the finally block and return the resultset. You will need to hold the results in something else, which would be some suitable collection.