CMOD code efficiency

Question

Hi Experts,
I have written the following CMOD for enhancin 2lis_03_bf with fields from tables MKPF and MSEG. I understand that it is not efficient use of ABAP statements. Could you please help me decide write the following code more efficiently?
DATA: I_MC03BF0 LIKE MC03BF0,
  I_tabix like sy-tabix.
    CLEAR: I_MC03BF0.
    LOOP AT c_t_data INTO I_MC03BF0.
      IF NOT I_MC03BF0-MATNR IS INITIAL.
        I_tabix = sy-tabix.
        select single CPUDT CPUTM from MKPF into (I_MC03BF0-ZZCPUDT,I_MC03BF0-ZZCPUTM)
                              where
                               MBLNR = I_MC03BF0-MBLNR and
                               MJAHR = I_MC03BF0-MJAHR.
        Select single XAUTO FROM MSEG INTO I_MC03BF0-ZZXAUTO
                              WHERE
                              MBLNR = I_MC03BF0-MBLNR AND
                              MJAHR = I_MC03BF0-MJAHR AND
                              ZEILE = I_MC03BF0-ZEILE.
        modify c_t_data from I_MC03BF0.
        clear: I_MC03BF0.
     ENDIF.
    ENDLOOP.

Answer 1

Hi CC,
Although you could also consider to first extract the fields from the MKPF table to BW and then add them to data that are being extracted through the 2LIS_03_BF datasource, from a 'code point of view' you can try the following:
* Types for internal tables to select data
TYPES: Begin of ty_mkpf,
     MBLNR type MBLNR,
     MJAHR type MJAHR,
     CPUDT type CPUDT,
     CPUDM type CPUDM,
       end of ty_mkpf,
       Begin of ty_mseg,
     MBLNR type MBLNR,
     MJAHR type MJAHR,     
     ZEILE type MBLPO,
     XAUTO type MB_AUTO,
       end of ty_mseg.
* Field symbols for adding and checking additional fields
  FIELD-SYMBOLS : <fs_mkpf> type ty_mkpf,
            <fs_mseg> type ty_mseg,
                  <fs_MC03BF0> type MC03BF0.
* Internal tables to select data
  DATA: it_mkpf type HASHED table WITH UNIQUE KEY MBLNR MJAHR,
     it_mseg type HASHED table WITH UNIQUE KEY MBLNR MJAHR ZEILE,
        it_MC03BF0 TYPE SORTED TABLE OF MC03BF0.
* Clear internal tables
CLEAR: it_mkpf,
       it_mseg,     
       it_MC03BF0.
* Move c_t_data to internal table
  it_MC03BF0 = c_t_data[].
* Select additional fields from source system tables
IF it_MC03BF0 is not initial.
        SELECT MBLNR
               MJAHR
               CPUDT
               CPUTM
         FROM MKPF
         INTO table it_mkpf
         FOR ALL ENTRIES IN it_MC03BF0
         WHERE MBLNR = it_MC03BF0-mblnr
          AND MJAHR = it_MC03BF0-mjahr.
        SELECT MBLNR
               MJAHR
            ZEILE
               XAUTO 
         FROM MSEG
         INTO table it_mseg
         FOR ALL ENTRIES IN it_MC03BF0
         WHERE MBLNR = it_MC03BF0-mblnr
          AND MJARH = it_MC03BF0-mjahr.
* Loop on selected fields to add additional fields
      LOOP AT c_t_data ASSIGNING <fs_MC03BF0>.
        READ TABLE it_mkpf ASSIGNING <fs_mkpf>
          WITH TABLE KEY MLBNR = <fs_MC03BF0>-MLBNR
                MJAHR = <fs_MC03BF0>-MJAHR.
        READ TABLE it_mseg ASSIGNING <fs_mseg>
          WITH TABLE KEY MLBNR = <fs_MC03BF0>-MLBNR
                MJAHR = <fs_MC03BF0>-MJAHR
                ZEILE = <fs_MC03BF0>-ZEILE.     
      if sy-subrc = 0.
* Add additional fields to append in extract structure
        <fs_2lis_03_bf>-ZZCPUDT = <fs_MC03BF0>-CPUDT.
        <fs_2lis_03_bf>-ZZCPUTM = <fs_MC03BF0>-CPUTM.
        <fs_2lis_03_bf>-ZZXAUTO = <fs_MC03BF0>-XAUTO.
      endif.
      endloop.
endif.
Edited by: Edwin Neuenschwander on Jun 26, 2011 4:19 PM