Code review sap standard naming standards

Hi all,
My requirement is to review the code for FM and want to document it according to sap standards because these objects will be sent to sap. It is a product development object and it will be reviewed and adopted by sap itself.
send me some naming standards provided by SAP.
Thanks,
Arun.

Hi,
I agree that you should ask SAP but using code inspector (SCI) you can check your program for Naming conventions (Programming conventions). It has predefined values which should be similar/equal to what SAP use. You can also change it to your naming conventions.
Cheers

Similar Messages

Addition of my code in sap standard program

hi gurus,
              can i add my code in the sap enhancement below in sap standard program
i want add the logic below.
ENHANCEMENT-POINT MATERIALFINDUNG_10 SPOTS ES_SAPFV45P.
$$-Start: MATERIALFINDUNG_10----
$$
ENHANCEMENT 153 OI0_COMMON_SAPFV45P.    "active version
IF NOT G_OIK_SUBMAT IS INITIAL.                         "SOTK000026 DN
     TVAK-KALSU = G_OIK_KALSU.                           "SOTK000026 DN
     CLEAR PRODUCT_SELECTION_REKURSIV.                   "SOTK000026 DN
ENDIF.                                                  "SOTK000026 DN
ENDENHANCEMENT.
when i click on enhance button(shift+F4) it does not give me any place to write.
but if i click on the enhancement name i am able create one implementation. is that ok.should i add my code there.

Hi Kiran,
That is not the solution I am looking at. Also the link provided within the link you provided does not work which is:
http://www.synactive.net/site/index.htm
Do let me know if you have a solution to change the standard GUI status(Not by copying nor by using the access key) either by any menu exit or something of that sort.
Regards,
Deepak.

How to get Transaction code for SAP standard report painter in FI

Hi All -
Please let me know, How to get the transaction code for Standard SAP report painter / report writer in FI module.
These report painters are created thru GR51...
Thanks,
Kannan

Please refer to [Creating Transaction Code For Report Painter Reports|http://www.google.com/url?sa=t&source=web&ct=res&cd=1&ved=0CAgQFjAA&url=http%3A%2F%2Fdap-consulting.com%2Fyahoo_site_admin%2Fassets%2Fdocs%2FReport_Painter_Reports.47142031.pdf&ei=MiWYS5ilCYeOlAfn4pCGDQ&usg=AFQjCNEZ0YO6vJ97K24MbU_NI5ROTb5vJA&sig2=Ke-svnqddqrz8RMcTuEnaw].

Problem in SAP standard code modification for FB03

Hi Experts,
I am adding 4custom fields in FB03 tcode by doing a SAP standard code modification in SE51.
The program name is SAPMF05L and screen no. is 302(In some SAP verion, it is 304). This is the screen for document line item of an invoice.
My problem is:
When I add the fields in the screen, in which module will I put logic in the PBO and PAI as I am unable to figure out the German comments and the program structuring.
Also, if anybody can tell me what to write as I am little bit confused about the logic of populating my fields with the values.
FB03 is a display transaction so I have to keep my custom screen fields disabled.
Regards,
Sangeeta.

Hi Sangeeta,
For enhancing the screen of this Tcode, first of all search is there any Screen enhancement is provided by SAP or not and in case if it is provided then use that only.
Regards
Jagesh Lakdawala

How i can keep my code after %dba standard table in sap query

hi expert,
how i can keep my code after %dba standard table in sap query..
add 1 to %count-VBRP.
%linr-VBRP = '01'.
extract %fg01.
%linr-VBRP = '02'.
extract %fg02.
%linr-VBRP = '04'.
extract %fg04.
%linr-VBRP = '05'.
extract %fg05.
%ext-VBRP05 = 'X'.
extract %fgwrVBRP05.
endselect.
i want keep my code after filling the standard table generated by sap abap query
Thanks & regards
Sajad Ahmad

Hi,
the above code is excuted succesfully, but if i have
return "Navigation" ;
it is not working
any idea why??????????

If an employee changes Company code,how his YTD cumulations in CRT table calculates as per SAP Standards ?

Hi All,
Please help me out in understanding below scenario.
If an employee changes from one company code to another code, how his/her YTD cumulates in CRT table as per SAP Standards.
Let me go with example to make a clear understanding.
Ex : Payroll has run for an employee upto payperiod 05. As per his pay assume that his /101 is 5000.
                         Monthly                  Yearly
PP 1      :           5000                       5000
PP 2      :           5000                      10000
PP 3      :           5000                      15000
PP 4      :           5000                      20000
PP 5      :           5000                      25000
In PP 6 he has shifted from one company code to another company code. Now, how the system cumulates as per SAP standards ?
PP 6       :           5000                        ?
Will the amount nullifies or else adds to previous PP5 ?
Thanks in Advance....

Hi Ameet,
I understood the same. But my client is asking that the amount should nullify in CRT table for yearly when an employee changes company code.
And they have maintained different tax grouping for company codes in table v_t7ph0a. will that table makes any difference ?
Regards,
Nalini.

Where I can get SAP standard webdynpro application source code

Dear Experts,
Where can i get sap standard WebDynpro application source code, because i need to copy that source code and modify that according to my application.
My scnario.
Actually i need to develop Carloan WebDynpro application, but its similar ESS-> Travel Expenses->Plan my Travel Expense .. standard WebDynpro application model, so please any one suggest how to copy that source code means where can i get that source code, and when rebuilding time what type of problems facing..
please anyone suggest
appreciate if you help regarding this..

Hai saradha ji,
thank got i know you are the right person for solve my problame, because i study your blogs, please don't be leave this thred till the my problame solve,
ok once i find sca file what i want do steps.. please tell me..
give me any document step by step. i don't have FPM. i don't have market place ID, so i unable to download .
please send related artical this mail id [email protected]
first i search sca file in my development server once got file.. let you inform.
sincerely

Communication b/n iviews --- Can we get the code for SAP's standard iviews?

hi All,
I have a requirement where I have to pass the user input data obtained in a standard iview(provided by sap) to a custom built iview and process it from there.
If I have to use the EPCF's client data bag for this purpose, I must be able to edit the code which produces the standard iview(provided by sap) which I think is not possible, as we cannot get the code for the standard iviews provided by sap.
Have anybody come across this kind of issue? If so, can you help me in solving this issue? Is there any workaround for this?
Any input in this regard will be of great help to me and will be suitably rewarded.
Thanks & best regds,
Alagammai.

hi George,
Tnx a lot.
But I have already tried importing par files into NWDS. I am not able to see any source code(like jsp or java)which can be edited. I am able to see only class files.
Does that mean that the class files are to be decompiled, edited, compiled and then uploaded to the portal?
best regds,
alagammai.

Do you trust the SAP standard rule set ?

Hello all,
I have the impression that, too often, the SAP standard ruleset has been taken for granted : upload, generate and use. Here is a post as to why not to do so. Hopefuly, this will generate a interesting discussion.
As I have previously stated in other threads, you should be very careful accepting the SAP standard rule set without reviewing it first. Before accepting it, you should ensure that your specific SAP environment has been reflected in the functions. The 2 following questions deal with this topic :
1. what is your SAP release ? ---> 46C is different than ECC 6.0 in terms of permissions to be included in the function permission tab. With every SAP release, new authorization objects are linked to SAP standard tcodes. Subsequently some AUTHORITY-CHECK statements have been adapted in the ABAP behind the transaction code. So, other authorizations need to provided from an implementation point of view (PFCG). And thus, from an audit perspective (GRC-CC), other settings are due when filtering users' access rights in search for who can do what in SAP.
2. what are your customizing settings and master data settings ? --> depending on these answers you will have to (de)activate certain permissions in your functions. Eg. are authorization groups for posting periods, business areas, material types, ... being used ? If this is not required in the SAP system and if activated in SAP GRC function, then you filter down your results too hard, thereby leaving certain users out of the audit report while in reality they can actually execute the corresponding SAP functionality --> risk for false negatives !
Do not forget that the SAP standard ruleset is only an import of SU24 settings of - probably - a Walldorf system. That's the reason SAP states that the delivered rule set is a starting point.
So, the best practice is :
a. collect SAP specific settings per connector in a separate 'questionnaire' document, preferably structured in a database
b. reflect these answers per function per connector per action per permission by correctly (de)activating the corresponding permissions for all affected functions
You can imagine that this is a time-consuming process due to the amount of work and the slow interaction with the Java web-based GRC GUI. Therefore, it is a quite cumbersome and at times error-prone activity ...... That is, in case you would decide to implement your questionnaire answers manually. There are of course software providers on the market that can develop and maintain your functions in an off-line application and generate your rule set so that you can upload it directly in SAP GRC. In this example such software providers are particularly interesting, because your questionnaire answers are structurally stored and reflected in the functions. Any change now or in the future can be mass-reflected in all (hundreds / thousands of) corresponding permissions in the functions. Time-saving and consistent !
Is this questionnaire really necessary ? Can't I just activate all permissions in every function ? Certainly not, because that would - and here is the main problem - filter too much users out of your audit results because the filter is too stringent. This practice would lead too false negatives, something that auditors do not like.
Can't I just update all my functions based on my particular SU24 settings ? (by the way, if you don't know what SU24 settings are, than ask your role administrator. He/she should know. ) Yes, if you think they are on target, yes you can by deleting all VIRSA_CC_FUNCPRM entries from the Rules.txt export of the SAP standard rule set, re-upload, go for every function into change mode so that the new permissions are imported based on your SU24 settings. Also, very cumbersome and with the absolute condition that you SU24 are maintained excellent.
Why is that so important ? Imagine F_BKPF_GSB the auth object to check on auth groups on business areas within accounting documents. Most role administrator will leave this object on Check/Maintain in the SU24 settings. This means that the object will be imported in the role when - for example - FB01 has been added in the menu. But the role administrator inactivates the object in the role. Still no problem, because user doesn't need it, since auth groups on business areas are not being used. However, having this SU24 will result in an activated F_BKPF_GSB permission in your GRC function. So, SAP GRC will filter down on those users who have F_BKPF_GSB, which will lead to false negatives.
Haven't you noticed that SAP has deactivated quite a lot of permissions, including F_BKPF_GSB ? Now, you see why. But they go too far at times and even incorrect. Example : go ahead and look deeper into function AP02. There, you will see for FB01 that two permissions have been activated. F_BKPF_BEK and F_BKPF_KOA. The very basic authorizations needed to be able to post FI document are F_BKPF_BUK and F_BKPF_KOA. That's F_BKPF_BUK .... not F_BKPF_BEK. They have made a mistake here. F_BKPF_BEK is an optional auth object (as with F_BKPF_GSB) to check on vendor account auth groups.
Again, the message is : be very critical when looking at the SAP standard rule set. So, test thoroughly. And if your not sure, leave the job to a specialized firm.
Success !
Sam

Sam and everyone,
Sam brings up some good points on the delivered ruleset. Please keep in mind; however, that SAP has always stated that the delivered ruleset is a starting point. This is brought up in sap note 986996     Best Practice for SAP CC Rules and Risks. I completely agree with him that no company should just use the supplied rules without doing a full evaluation of their risk and control environment.
I'll try to address each area that Sam brings up:
1. Regarding the issue with differences of auth objects between versions, the SAP delivered rulset is not meant to be version specific. We therefore provide rules with the lowest common denominator when it comes to auth object settings.
The rules were created on a 4.6c system, with the exception of transactions that only exist in higher versions.
The underlying assumption is that we want to ensure the rules do not have any false negatives. This means that we purposely activate the fewest auth objects required in order to execute the transaction.
If new or different auth object settings come into play in the higher releases and you feel this results in false positives (conflicts that show that don't really exist), then you can adjust the rules to add these auth objects to the rules.
Again, our assumption is that the delivered ruleset should err on the side of showing too many conflicts which can be further filtered by the customer, versus excluding users that should be reported.
2. For the customizing settings, as per above, we strive to deliver rules that are base level rules that are applicable for everyone. This is why we deliver only the core auth objects in our rules and not all. A example is ME21N.
If you look at SU24 in an ECC6 system, ME21N has 4 auth objects set as check/maintain. However, in the rules we only enable one of the object, M_BEST_BSA. This is to prevent false negatives.
3. Sam is absolutely right that the delivered auth object settings for FB01 have a mistake. The correct auth object should be F_BKPF_BUK and not F_BKPF_BEK. This was a manual error on my part. I've added this to a listing to correct in future versions of the rules.
4. Since late 2006, 4 updates have been made to the rules to correct known issues as well as expand the ruleset as needed. See the sap notes below as well as posting Compliance Calibrator - Q2 2008 Rule Update from July 22.
1083611 Compliance Calibrator Rule Update Q3 2007
1061380 Compliance Calibrator Rule Update Q2 2006
1035070 Compliance Calibrator Rule Update Q1 2007
1173980 Risk Analysis and Remediation Rule Update Q2 2008
5. SAP is constantly working to improve our rulesets as we know there are areas where the rules can be improved. See my earlier post called Request for participants for an Access Control Rule mini-council from January 28, 2008. A rule mini-council is in place and I welcome anyone who is interested in joining to contact me at the information provided in that post.
6. Finally, the document on the BPX location below has a good overview of how companies should review the rules and customize them to their control and risk environment:
https://www.sdn.sap.com/irj/sdn/bpx-grc
Under Key Topics - Access Control; choose document below:
    o GRC Access Control - Access Risk Management Guide   (PDF 268 KB)
The access risk management guide helps you set up and implement risk
identification and remediation with GRC Access Control.

Module Pool Programming - Calling SAP Standard Text Screen

Hi Gurus
I am working on Module Pool Programming...In the one of the screen there is a column named "Description" where I need to keep a Button to call a SAP standard text editing screen and what ever information I enter in the field should be downloadable
is this option possible?If so...Plz send me the Sample code
Thanks
Ganesh

Hi Gani,
I can help you till getting the text editor in your module pool program.
TOP
PROGRAM ZREDDY_TEXT.
constants: line_length type i value 132.
   data:
reference to wrapper class of control
   g_editor type ref to cl_gui_textedit,
reference to custom container: necessary to bind TextEdit Control
   g_editor_container type ref to cl_gui_custom_container,
   g_repid like sy-repid,                        " getting program name
   g_ok_code like sy-ucomm,                " return code from screen
   g_mytable(132) type c occurs 0,        " getting the text of table
   g_mycontainer(30) type c,                " string for the containers
   v_result(256) type c,                        " getting the text of table control
   gw_thead like thead,                        " for header information
   it_line type table of tline with header line. " internal table of type tline
PBO
MODULE STATUS_0900 OUTPUT.
SET PF-STATUS 'ZTEXT'.
SET TITLEBAR 'xxx'.
if g_editor is initial.
create control container
   create object g_editor_container
   exporting
   container_name = 'CUSTOM_CONTROL' " Make sure when you create custom container in layout give name as Custom container
   exceptions
   cntl_error = 1
   cntl_system_error = 2
   create_error = 3
   lifetime_error = 4
   lifetime_dynpro_dynpro_link = 5.
   g_mycontainer = 'CUSTOM_CONTROL'.
create calls constructor, which initializes, creates and links
TextEdit Control
create object g_editor
   exporting
   parent = g_editor_container
   wordwrap_mode =
cl_gui_textedit=>wordwrap_off
   cl_gui_textedit=>wordwrap_at_fixed_position
cl_gui_textedit=>WORDWRAP_AT_WINDOWBORDER
   wordwrap_position                      = line_length
   wordwrap_to_linebreak_mode     = cl_gui_textedit=>true.
   refresh g_mytable. " to initialize table upon OK_CODE 'BACK' at PAI
   endif.
ENDMODULE.                 " STATUS_0900 OUTPUT
Cheers!!
Balu
Edited by: Balu CH on Oct 22, 2008 8:55 PM

How to fetch the SAP Standard Prog. built internal table into my_z_prog.?

Hi Experts,
Pls. let me know that,
How to fetch the SAP Standard Prog. built internal table into my_z_prog.?
For more explannation, pls. see my other thread with name of yestrday,
SUBMIT RFGLBALANCE WITH selection criteria, then How to get resulted itab?
thanq

Hi
Suppose RFGLBALANCE is your standard program and you have an internal table named I_RFGLBALANCE.
And lets say your Z program name is Z_SRINIVAS.
First find out the type of the internal table you want in your Z-program in the standard program. And declare an internal table of similar type in your Z-program.
I hope you can do this much.
Later wherever you are putting the below mentioned code.
SUBMIT RFGLBALANCE WITH selection criteria
Write the code which i have written.Obviously modify it to suit your requirement.
Please show what is not working fine so that even anyone else can help you with the problem you are facing.
Regards,
Mayank

Peer reviews,coding standards and audit norms

hi,
what is meant by peer reviews, coding standards and audit norms in development project of ABAP.
regds:
balakrishna.

Hi Bala,
Peer review: The code which is written by the developer will be cross checked by one of the team member if the code fulfills the technical spec or not.
Coding Standards: In a project the client and the software service provider will have an understanding regarding naming convention of all variables, constants, internal table, select-options, etc.
Example: if it is a select-options the field should be named with the first letter S_ then you will write S_Matnr, and for variables you have to follow V_ then V_maktx.
Audit norms: Audit norms will depend on the organization so it does not have any standard answer.
Regards,
Lakshmikanth

Modification in SAP standard programs.

Hi All
I am trying to make modification in SAP standard program by using a copy of code from the original program to my program..but facing many errors like the statement BEgin of block syntax is wrong..
i am trying to mdify the foloowing program--RFSSLD00...
Please help me and guide to make changes to this prog..
Also tell me that do we need to again create all the functiongroup and global data declarartion part.
thank u.

hi,
Please note that when you copy a standard Sap Program ,make sure all the objects are copied following your compays naming conventions.
Now RFSSLD00 can be copied without any difficuly.after that compare the new copied program with the standard program. going to version mngmt->remote comparison . doing this you can get the differences
check all the includes.. and type pool declartaion and gui status etc....by going to se80
regards,
Safel

Sap standard report for delivery document block.

Hi,
We want to block delivery document for further processing that picking and PGI.
For that we are looking for sap standard report if available so we could provide it to client.
so we need
SAP standard report for blocked delivery document.

Hi,
As far as my understanding there is no such report but you can try with report MATERIAL WHERE USED LIST
Please find t-code for this as due to system unavailable i am not mentioning t-code for same
kapil

How SAP standard run the interest calculation in AR module

Dear expert,
would like to seek for your advise, how SAP standard run the interest calculation in AR module ?
Also advise,does the interest calculation generate the interest base on the dunning run?What are relationship between interest calculation generate ?
What are the T-code for running the interest so that able to generate the interest posting according to baseline due date?
On top of that, does SAP have standard AR interest calculation report and what are the T-code ?
Between, do you have any ideal the Interest Indicator ZB stand and reminder date it is the last reminder date,waive,KIV and charge Interest and also noted item amount mean for in the AR Interest Calculation report?
Please help.
Regards,
Karen

Hi,
Thank you for the promtp reply.
I still have query would like to seek for your advise.
1.Does the interest calculation generate the interest base on the dunning run?For example, the interest is only can be post/generated when there is dunning run and vise versa.
2.What are relationship between interest calculation generate ?Does interest generation depand on the dunning run?
On top of that, does SAP have standard AR interest calculation report and what are the T-code ?
3.Between, do you have any ideal the reminder date it is the last reminder date,waive,KIV and charge Interest and also noted item amount mean for in the AR Interest Calculation report?
4.For posting use F.2B and that will calculate interest on open items of customers. Does this posting is post as noted item or posting document? Beside, do we every day need to run this posting F.2B in order to update the AR interest calculation report and post the interest for the overdue invoice?
5.Do you have any reference link/document /SAP notes on calculate interest on arres F.2B?
a)How the program calculate those overdue invoice for example: does sap calculate the interest base on interest + due amount until the customer made the payment?
b) If customer made payment on the due amount and not the interest and vise versa? How theF.2B program logic work on the calculation ?
Please help.
Regards,
KH

Code review sap standard naming standards

Similar Messages

Maybe you are looking for