Command button not working

Question

Hi,
I have a
<h:panelGrid><td><h:commandButton id="aButton" value="Add" action="#{hubreceivingbean.createRecord}" /></td></h:panelGrid> this is not working, I'm not sure what wrong I'm doing, my code is
============ hubReceiving.jsp=======================
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f" %>
<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h" %>
<%@ taglib uri="http://jakarta.apache.org/struts/tags-tiles" prefix="tiles" %>
<tiles:importAttribute scope="request"/>
<f:view>
<f:loadBundle basename="com.fcpa.him.columnheading" var="chdr"/>
<f:loadBundle basename="com.fcpa.him.Messages" var="msg"/>
<div id="location"></div>
<div class="bfrm" style="width: 720px;" >
<div style="height: 600px" class="cv_c">
<h:form id="rcvTxn">
<h:panelGroup>
<h:panelGrid columns="1">
<h:panelGrid>
<h:dataTable >
<h:column>
<f:facet name="header">
<td> <h:outputFormat style="width: 730px;" value="Receiving"/></td>
</f:facet>
</h:column>
</h:dataTable>
</h:panelGrid>
<h:panelGrid columns="3">
<h:panelGrid columns="5" style="width: 560px">
<h:column>
<h:panelGrid><td><h:outputText id="errorMessage" value="#{hubreceivingbean.errorMessage}" style="color: red; font-weight: bold;" /></td></h:panelGrid>
</h:column>
<h:column>
<h:panelGrid>
<h:panelGrid><td><h:outputText id="hRcvDate" value="Receiving Date:" style="width: 90px" /></td></h:panelGrid>
<h:panelGrid><td><h:outputText id="hHubName" value="Receiving At:" style="width: 90px" /></td></h:panelGrid>
<h:panelGrid><td><h:outputText id="hPackageType" value="Package Type:" style="width: 90px" /></td></h:panelGrid>
<h:panelGrid><td><h:outputText id="hPackageValue" value="Scan / Enter:" style="width: 90px" /></td></h:panelGrid>
</h:panelGrid>
</h:column>
<h:column>
<h:panelGrid>
<h:panelGrid><td><h:outputText id="vRcvDate" value="#{hubreceivingbean.date}" style="width: 130px"/></td></h:panelGrid>
<h:panelGrid><td><h:selectOneMenu id="vHubName" value="#{hubreceivingbean.hubName}" style="width: 130px">
<f:selectItems value="#{hubreceivingbean.hubList}"/>
</h:selectOneMenu></td></h:panelGrid>
<h:panelGrid><td><h:selectOneMenu id="vPackageType" value="#{hubreceivingbean.sourceType}" style="width: 130px" onchange="submit()" >
<f:selectItems value="#{hubreceivingbean.sourceTypeList}" />
</h:selectOneMenu></td></h:panelGrid>
<h:panelGrid><td><h:inputText id="vPackageValue" value="#{hubreceivingbean.sourceValue}" style="width: 130px" /></td></h:panelGrid>
</h:panelGrid>
</h:column>
<h:column>
<h:panelGrid>
<h:panelGrid><td><h:outputText style="width: 80px"/></td></h:panelGrid>
<h:panelGrid><td><h:outputText id="hTxnNum" value="Txn ID:" style="width: 80px"/></td></h:panelGrid>
<h:panelGrid><td><h:outputText id="hPartNumber" value="Part Number:" style="width: 80px; #{hubreceivingbean.componetEnableDisableStyle};"/></td></h:panelGrid>
<h:panelGrid><td><h:outputText id="hQty" value="Quantity:" style="width: 80px; #{hubreceivingbean.componetEnableDisableStyle};"/></td></h:panelGrid>
</h:panelGrid>
</h:column>
<h:column>
<h:panelGrid>
<h:panelGrid><td><h:outputText style="width: 130px" /></td></h:panelGrid>
<h:panelGrid><td><h:inputText id="vTxnNum" value="#{hubreceivingbean.rcvTxnHeaderID}" style="width: 130px" /></td></h:panelGrid>
<h:panelGrid><td><h:inputText id="vPartNum" value="#{hubreceivingbean.partNumber}" style="width: 130px; #{hubreceivingbean.componetEnableDisableStyle};" /></td></h:panelGrid>
<h:panelGrid><td><h:inputText id="vQty" value="#{hubreceivingbean.quantity}" style="width: 130px; #{hubreceivingbean.componetEnableDisableStyle};" /></td></h:panelGrid>
</h:panelGrid>
</h:column>
</h:panelGrid>
<h:panelGrid>
<f:subview id="rtMenu">
<tiles:insert definition="mainMenu" flush="false"/>
</f:subview>
</h:panelGrid>
</h:panelGrid>
<h:panelGrid><td><h:commandButton id="aButton" value="Add" action="#{hubreceivingbean.createRecord}" /></td></h:panelGrid>
<h:panelGrid>
<h:dataTable styleClass="standard">
<h:column >
<f:facet name="header">
<td> <h:outputFormat style="width: 70px; " value="#{chdr.rcvRefType}"/></td>
</f:facet>
</h:column>
<h:column>
<f:facet name="header">
<td> <h:outputText style="width: 80px;" value="#{chdr.rcvRefTypeValue}"/> </td>
</f:facet>
</h:column>
<h:column>
<f:facet name="header">
<td> <h:outputText style="width: 80px;" value="#{chdr.palletNumber}"/> </td>
</f:facet>
</h:column>
<h:column>
<f:facet name="header">
<td> <h:outputText style="width: 175px;" value="#{chdr.partNumber}"/></td>
</f:facet>
</h:column>
<h:column>
<f:facet name="header">
<td> <h:outputText style="width: 75px;" value="#{chdr.asnQty}"/> </td>
</f:facet>
</h:column>
<h:column>
<f:facet name="header">
<td> <h:outputText style="width: 75px;" value="#{chdr.rcvQty}"/> </td>
</f:facet>
</h:column>
<h:column>
<f:facet name="header">
<td> <h:outputText style="width: 100px;" value="#{chdr.remarks}"/> </td>
</f:facet>
</h:column>
<h:column>
<f:facet name="header">
<td> <h:outputText style="width: 50px;" value="#{chdr.delete}"/> </td>
</f:facet>
</h:column>
</h:dataTable>
</h:panelGrid>
<h:panelGrid styleClass="scrollPane" columns="1" style="width: 720px;">
<h:panelGroup>
<f:verbatim><DIV STYLE="overflow: auto; height: 170px;" styleClass="standard"></f:verbatim>
<h:dataTable value="#{hubreceivingbean.rcvDataArray}" var="databean" styleClass="standard">
<h:column>
<h:outputText style="width: 70px;" value="#{databean.referenceType}"/>
</h:column>
<h:column>
<h:outputText style="width: 80px;" value="#{databean.referenceValue}"/>
</h:column>
<h:column>
<h:outputText style="width: 80px;" value="#{databean.palletNumber}"/>
</h:column>
<h:column>
<h:outputText style="width: 175px;" value="#{databean.partNumber}"/>
</h:column>
<h:column>
<h:outputText style="width: 75px;" value="#{databean.asnQuantity}" />
</h:column>
<h:column>
<h:inputText id="rcvQty" style="width: 75px;" value="#{databean.rcvQuantity}" required="true"/>
<h:message for="rcvQty" errorClass="errors" />
<f:attribute name="rcvQty" value="Please Enter" />
</h:column>
<h:column>
<h:inputText style="width: 100px;" value="#{databean.rcvComments}" />
</h:column>
</h:dataTable>
<f:verbatim></DIV></f:verbatim>
</h:panelGroup>
</h:panelGrid>
</h:panelGrid>
</h:panelGroup>
</h:form>
</div>
</div>
</f:view>
====================HubReceivingBean.java=================
* HubReceivingBean.java
* Created on February 1, 2006, 6:09 PM
* To change this template, choose Tools | Options and locate the template under
* the Source Creation and Management node. Right-click the template and choose
* Open. You can then make changes to the template in the Source Editor.
package com.fcpa.him;
* @author vburla
import java.sql.*;
import java.util.*;
import java.text.*;
import java.io.*;
import java.util.Date;
import javax.faces.model.SelectItem;
import javax.faces.application.*;
import javax.faces.context.FacesContext;
import java.util.Locale;
import javax.servlet.jsp.jstl.sql.ResultSupport;
import javax.servlet.jsp.jstl.sql.Result;
import javax.faces.component.UIComponent;
import javax.faces.component.UIComponentBase;
import javax.faces.component.UIInput;
import javax.faces.component.UIViewRoot;
import javax.faces.validator.*;
import javax.faces.el.ValueBinding;
import java.io.Serializable;
import javax.swing.JOptionPane;
import java.net.*;
import com.fcpa.reportal.*;
import com.fcpa.eapps.*;
public class HubReceivingBean {
private String sourceType;
private String sourceValue;
private String rcvTxnHeaderID;
private Date date = new Date();
private static ArrayList sourceList;
private static ArrayList hubList;
private SysLogger log;
private JDBCConnPool db;
private String hubName;
private boolean hubNameEditable =true;
private ArrayList rcvDataArray = new ArrayList();
private String componetEnableDisableStyle = "display:none";
private String txnRefEnableDisable = "display:none";
private String partNumber;
private String quantity;
private String useDataSource = "Y";
private String errorMessage;
//private static final String[] SOURCE_TYPE = { "CARTON", "PALLET", "INVOICE","IO"};
//private static final String[] COLUMN_NAMES = {"Ref_Type","Ref_Value","Part_Number","ASN_Qty","RCV_Qty","Notes"};
/**Create connection */
public void setJdbcConnPoolClass(JDBCConnPool j) {
this.db = j;
public JDBCConnPool getJdbcConnPoolClass() {
return this.db;
public void setSysLoggerClass(SysLogger s) {
this.log = s;
public SysLogger getSysLoggerClass() {
return this.log;
/** Creates a new instance of HubReceivingBean */
public HubReceivingBean(){
private void fillRcvDataArray() throws Exception{
if ( (getRcvTxnHeaderID()!="") && (getRcvTxnHeaderID()!=null) ){
String strSQLstr = "SELECT lines.txn_line_id Txn_Line_ID, lines.reference_type Ref_Type,lines.reference_value Ref_Value,"+
" lines.pallet_number Pallet_Number, lines.part_number Part_Number,lines.asn_quantity ASN_Qty,"+
" lines.received_quantity RCV_Qty,lines.comments Notes "+
" FROM hif_rcv_txn_headers headers, hif_rcv_txn_lines lines "+
" WHERE headers.txn_header_id = lines.txn_header_id "+
" AND headers.txn_header_id = "+getRcvTxnHeaderID()+
" AND nvl(headers.txn_complete_flag,'N') = 'N' "+
" ORDER BY lines.txn_line_id desc";
System.out.println("Inside fill data-strSQLstr: "+strSQLstr);
ResultSet rs = db.getResultSet(strSQLstr);
while (rs.next()){
RcvTableDataBean bean = new RcvTableDataBean();
bean.setTxnLineID(rs.getString("Txn_Line_ID"));
bean.setReferenceType(rs.getString("Ref_Type"));
bean.setReferenceValue(rs.getString("Ref_Value"));
bean.setPalletNumber(rs.getString("Pallet_Number"));
bean.setPartNumber(rs.getString("Part_Number"));
bean.setAsnQuantity(rs.getString("ASN_Qty"));
bean.setRcvQuantity(rs.getString("RCV_Qty"));
bean.setRcvComments(rs.getString("Notes"));
rcvDataArray.add(bean);
public ArrayList getRcvDataArray()throws Exception {
rcvDataArray.clear();
fillRcvDataArray();
return rcvDataArray;
// PROPERTY: current date
public void setDate(Date newValue) { date = newValue; }
public String getDate() {
Date now = new Date();
DateFormat df = DateFormat.getDateInstance();
String s = df.format(now);
System.out.println("Today is " + s);
return s;
// PROPERTY: Hub Name
public void setHubName(String newValue) {
// System.out.println("Inside setSourceType");
hubName = newValue; }
public String getHubName() {
//System.out.println("Inside getSourceType");
return hubName; }
// PROPERTY: source type
public void setSourceType(String newValue) {
// System.out.println("Inside setSourceType");
sourceType = newValue; }
public String getSourceType() {
//System.out.println("Inside getSourceType");
return sourceType; }
// PROPERTY: source value
public void setSourceValue(String newValue) {
//System.out.println("Inside setSourceValue");
sourceValue = newValue; }
public String getSourceValue() {
//System.out.println("Inside getSourceValue");
return sourceValue; }
// PROPERTY: source type
public void setRcvTxnHeaderID(String newValue) {
// System.out.println("Inside setSourceType");
rcvTxnHeaderID = newValue; }
public String getRcvTxnHeaderID() {
//System.out.println("Inside getSourceType");
return rcvTxnHeaderID; }
// PROPERTY: Enable Disable
public void setComponetEnableDisableStyle(String newValue) {
// System.out.println("Inside setSourceType");
componetEnableDisableStyle = newValue; }
public String getComponetEnableDisableStyle() {
//System.out.println("Inside getSourceType");
return componetEnableDisableStyle; }
// PROPERTY: Enable Disable Txn Ref
public void setTxnRefEnableDisable(String newValue) {
// System.out.println("Inside setSourceType");
txnRefEnableDisable = newValue; }
public String getTxnRefEnableDisable() {
//System.out.println("Inside getSourceType");
return txnRefEnableDisable; }
// PROPERTY: part Number
public void setPartNumber(String newValue) {
// System.out.println("Inside setSourceType");
partNumber = newValue; }
public String getPartNumber() {
//System.out.println("Inside getSourceType");
return partNumber; }
// PROPERTY: Quantity
public void setQuantity(String newValue) {
// System.out.println("Inside setSourceType");
quantity = newValue; }
public String getQuantity() {
//System.out.println("Inside getSourceType");
return quantity; }
// PROPERTY: UseData Source
public void setUseDataSource(String newValue) {
// System.out.println("Inside setSourceType");
useDataSource = newValue; }
public String getUseDataSource() {
//System.out.println("Inside getSourceType");
return useDataSource; }
// PROPERTY: Error Message
public void setErrorMessage(String newValue) {
// System.out.println("Inside setSourceType");
errorMessage = newValue; }
public String getErrorMessage() {
//System.out.println("Inside getSourceType");
return errorMessage; }
// PROPERTY: User ID
public String getUserID() {
// System.out.println("Inside setSourceType");
return("1048"); }
// PROPERTY: Hub Name Editable
public boolean isHubNameEditable() {
return hubNameEditable; }
public void setHubNameEditable(boolean newValue) {
hubNameEditable = newValue; }
//PROPERTY: Hub List
public Collection getHubList() throws Exception {
log.general("Inside getSourceTypeList");
String strSQLstr = " SELECT hub_name hubName "+
" FROM eaf_hub_master "+
" WHERE nvl(enabled_flag,'N') = 'Y' "+
" AND nvl(end_date_active,sysdate+1) > sysdate";
ResultSet sl = db.getResultSet(strSQLstr);
hubList = new ArrayList();
int hubCt = 0;
while (sl.next()){
hubCt = hubCt + 1;
hubList.add(new SelectItem(sl.getString("hubName")));
//System.out.println("hubCt: "+hubCt);
if (hubCt > 1) {
setHubNameEditable(true);
// System.out.println("Setting setHubNameEditable as true");
} else{
setHubNameEditable(false);
// System.out.println("Setting setHubNameEditable as false");
setHubName("One Hub");
return(hubList);
//PROPERTY: source List
public Collection getSourceTypeList() throws Exception {
System.out.println("Inside getSourceType:"+getSourceType());
String sourceType = getSourceType();
System.out.println("sourceType:"+sourceType);
if (sourceType != null){
if (sourceType.equals("OTHERS")){
System.out.println("Inside getSourceType for OTHERS");
setComponetEnableDisableStyle("");
setUseDataSource("N");
}else {
System.out.println("Inside getSourceType for not OTHERS");
setComponetEnableDisableStyle("display:none");
setUseDataSource("Y");
}else{
System.out.println("Source Type is null");
setComponetEnableDisableStyle("display:none");
setUseDataSource("Y");
setErrorMessage(null);
log.general("Inside getSourceTypeList");
String strSQLstr =" SELECT lookup_code sourceType "+
" FROM hif_lookup_values "+
" WHERE lookup_type = 'RCV_SOURCE_TYPE' "+
" AND nvl(enabled_flag,'N') = 'Y' "+
" AND nvl(end_date_active,sysdate+1) > sysdate ";
ResultSet sl = db.getResultSet(strSQLstr);
sourceList = new ArrayList();
while (sl.next()){
sourceList.add(new SelectItem(sl.getString("sourceType")));
return(sourceList);
//PROPERTY: validate and insert data
public void createRecord() throws Exception{
updateTxn();
System.out.println("Inside createRecord");
System.out.println("getSourceValue()"+getSourceValue());
if ( !(getSourceValue()!="")){
System.out.println("getSourceValue()"+getSourceValue());
//JOptionPane.showMessageDialog(JOptionPane.getRootFrame(), "Please Scan / Enter value for "+getSourceType());
} else if ((getUseDataSource()=="N") &&
(!(getPartNumber()!="")||!(getQuantity()!=""))) {
System.out.println( "Please Enter Part Number and Quantity");
//JOptionPane.showMessageDialog(JOptionPane.getRootFrame(), "Please Enter Part Number and Quantity" );
else{
Connection con = db.getConnection();
try{
try{
System.out.println("SourceValue: "+sourceValue);
System.out.println("Hub Name"+getHubName());
String insertQuery = "begin "+
" hif_rcv_pkg.create_record(?,?,?,?,?,?,?,?,?,?,?);"+
"end; ";
CallableStatement cs = con.prepareCall(insertQuery);
cs.registerOutParameter(1,Types.VARCHAR);
cs.registerOutParameter(2,Types.VARCHAR);
cs.registerOutParameter(3,Types.VARCHAR);
cs.setString(3,getRcvTxnHeaderID());
cs.setString(4,getIP());
cs.setString(5,getUserID());
cs.setString(6,getHubName());
cs.setString(7,getSourceType());
cs.setString(8, getSourceValue());
cs.setString(9,getUseDataSource());
cs.setString(10,getPartNumber());
cs.setString(11,getQuantity());
cs.execute();
con.commit();
String txnHeaderID = cs.getString(3);
String errorCode = cs.getString(1);
String errorMessage = cs.getString(2);
if (errorMessage != null) {
setErrorMessage(errorMessage);
} else{
if (txnHeaderID != null ){
setRcvTxnHeaderID(txnHeaderID);
txnRefEnableDisable= " ";
setComponetEnableDisableStyle("display:none");
setUseDataSource("Y");
setSourceValue(null);
setPartNumber(null);
setQuantity(null);
}catch (Exception e) {
System.out.println("Error "+ e);
} finally {
con.close();
public void updateRcvQty() throws Exception{
System.out.println("Inside updateRcvQty");
//System.out.println("RcvRecord: "+rcvRecord.toString());
updateTxn();
Connection con = db.getConnection();
try{
try{
System.out.println("SourceValue: "+sourceValue);
System.out.println("getRcvTxnHeaderID: "+getRcvTxnHeaderID());
System.out.println("");
String insertQuery = "begin "+
" hif_rcv_pkg.update_rcv_qty (?,?,?,?,?,?,?);"+
"end; ";
CallableStatement cs = con.prepareCall(insertQuery);
cs.registerOutParameter(1,Types.VARCHAR);
cs.registerOutParameter(2,Types.VARCHAR);
cs.setString(3,getRcvTxnHeaderID());
cs.setString(4,getIP());
cs.setString(5,getUserID());
cs.setString(6,getSourceType());
cs.setString(7,getSourceValue());
cs.executeUpdate();
con.commit();
//setSourceValue(null);
}catch (Exception e) {
System.out.println("Error "+ e);
} finally {
con.close();
public void deleteRecord() throws Exception{
updateTxn();
System.out.println("Inside deleteRecord");
//System.out.println("RcvRecord: "+rcvRecord.toString());
Connection con = db.getConnection();
try{
try{
System.out.println("SourceValue: "+sourceValue);
System.out.println("");
String insertQuery = "begin "+
" hif_rcv_pkg.delete_record (?,?,?,?,?,?,?);"+
"end; ";
CallableStatement cs = con.prepareCall(insertQuery);
cs.registerOutParameter(1,Types.VARCHAR);
cs.registerOutParameter(2,Types.VARCHAR);
cs.setString(3,getRcvTxnHeaderID());
cs.setString(4,getIP());
cs.setString(5,getUserID());
cs.setString(6,getSourceType());
cs.setString(7, getSourceValue());
cs.executeUpdate();
con.commit();
setSourceValue(null);
}catch (Exception e) {
System.out.println("Error "+ e);
} finally {
con.close();
public void updateTxn()throws Exception{
System.out.println("Inside updateTxn");
int len = rcvDataArray.size();
Connection con = db.getConnection();
try{
for (int i = 0; i < len; i++) {
RcvTableDataBean bean = (RcvTableDataBean)rcvDataArray.get(i);
try{
System.out.println("Updateing Reference Value: "+ bean.getReferenceValue());
System.out.println("Updateing Comment Value: "+ bean.getRcvComments());
System.out.println("Updateing Receiving Qty: "+ bean.getRcvQuantity());
System.out.println("Updateing Receiving Qty: "+ bean.getRcvQuantity());
String updateQuery = "begin "+
" hif_rcv_pkg.update_txn(?,?,?,?,?,?,?,?,?);"+
"end; ";
CallableStatement cs = con.prepareCall(updateQuery);
cs.registerOutParameter(1,Types.VARCHAR);
cs.registerOutParameter(2,Types.VARCHAR);
cs.setString(3,getIP());
cs.setString(4,getUserID());
cs.setString(5,getRcvTxnHeaderID());
cs.setString(6,bean.getTxnLineID());
cs.setString(7,bean.getReferenceValue());
cs.setString(8,bean.getRcvQuantity());
cs.setString(9,bean.getRcvComments());
cs.execute();
con.commit();
}catch (Exception e) {
System.out.println("Error "+ e

Answer 1

1) Please use code tags in the future. Lengthy, unformatted code isn't likely to read be most people here who are trying to help you for free.
2) Next time, please use a short, compilable example that demonstrates your problem. Again, that is a lot of code to expect a volunteer to debug.
3) This does not appear to be a Swing question. Perhaps you should have posted this in one of the web-based forums.
Good luck.