Connection not it's released.

Question

In what cases the following code wouldn't work?
I'm doing this procedure to insert records on the database, however, to each record that is inserted is opened a new connection with the database.
The connection is opened, but it not it's closed.
Anyone know tell me what may be happening?
I'm using JDeveloper Studio 11.1.1.4.0.
ADF Swing.
        ApplicationModule am = null;
        public void adicionaRegistroIcatbEstacaoComView(Estacao estacaoAcess){
            String appModule = "hidro2.gov.snirh.ig.hidro.model.adf.app.AppModuleEstacao";
            String config = "AppModuleEstacaoLocal"; // Config name
            String viewObject = "IcatbEstacaoEnViewUp1";
            try{
                if (am == null) {       
                    am = Configuration.createRootApplicationModule(appModule, config);
                ViewObject vo = am.findViewObject(viewObject);
                Row row = vo.createRow();
                row.setAttribute("EstId", estacaoAcess.getEstId());
                row.setAttribute("EstNm" , estacaoAcess.getEstNm());
                row.setAttribute("EstStrId",estacaoAcess.getEstStrId());
                row.setAttribute("EstCdFlu", estacaoAcess.getEstCdFlu());
                row.setAttribute("EstCdPlu", estacaoAcess.getEstCdPlu());
                row.setAttribute("EstIcCampanha", 0);
                vo.getApplicationModule().getTransaction().commit();
            } catch (Exception e) {
                e.printStackTrace();
            } finally {
                if (am != null) {
                    Configuration.releaseRootApplicationModule(am, true);          
                    am.remove();
  }Edited by: Le on 11/08/2011 09:02

Answer 1

ADF uses the application module pool, which in turn uses a connection pool. Your code look OK to me, only the am.remove() is a bit fishy as you returned the application module ans told the framework to keep it for reuse. I'm not sure what this am.remove() does in this case.
The problem I see is that you create a root application module each time you call this function. This is a costly operation, as creating a root application module forced the framework to build it from scratch (and probably use a fresh db connection).
I'm by no means an expert in ADF Swing, but you should avoid creating an application module each time you call a function. If you reuse an application module (which is the default case for web apps) your connections get reused too.
Timo