Content of Variable

Question

Hi Expert,
I want to see content of variable , but no result by
"dbms_output.put_line" when exec procedure.
CREATE OR REPLACE PROCEDURE ms_alert_custbr (p_altcd varchar2) IS
v_altcomp msaltinval.ms_alt_comp%type;
v_altinval msaltinval.ms_alt_inval%type;
v_altstf msaltctc.ms_alt_stf%type;
v_mailadd varchar2(100);
v_emailadd varchar2(32767);
v_smail1 varchar2(50) := '/usr/local/bin/sendEmail -f [email protected] -t ';
v_smail2 varchar2(85) := ' -u "SendEmail Test" -s 123.123.123.123:25 -m "test" -a /u03/oradata/msdev/tempfile/';
v_fname varchar2(26) := v_altcomp || '_custbr.xls' ;
v_smcmd varchar2(32767) ;
CURSOR c_altinval IS
SELECT ms_alt_comp,ms_alt_inval
FROM msaltinval
WHERE ms_alt_cd = p_altcd ;
CURSOR c_altctc IS
SELECT ms_alt_stf
FROM msaltctc
WHERE ms_alt_cd = p_altcd and
ms_alt_comp = v_altcomp ;
BEGIN
OPEN c_altinval;
LOOP
FETCH c_altinval INTO v_altcomp,v_altinval ;
ms_alert_custbr_crexls(v_altcomp,v_altinval);
v_emailadd := NULL;
OPEN c_altctc ;
LOOP
FETCH c_altctc INTO v_altstf ;
SELECT ms_email_add
INTO v_mailadd
FROM msstaff
WHERE ms_staff_cd = v_altstf ;
v_emailadd := v_emailadd || ',' || v_mailadd ;
EXIT WHEN c_altctc%NOTFOUND;
END LOOP ;
CLOSE c_altctc ;
dbms_output.put_line(v_emailadd);
v_smcmd := v_smail1 || v_emailadd || v_smail2 || v_fname ;
dbms_output.put_line(v_smcmd);
Host_Command (p_command => v_smcmd) ;
EXIT WHEN c_altinval%NOTFOUND;
END LOOP;
CLOSE c_altinval;
END ms_alert_custbr ;
boris

Answer 1

> Besides, above procedure is ok or not ? somewhere need to improve ?
Most definitely not okay.
By coding a nested cursor fetch loop you are trying to re-invent an SQL join (a nested loop join to be specific) in PL/SQL. The SQL engine is very well capable of doing that without any outside assistance.
SQL is by far superior in this regard. Join the tables in SQL. Do not code manual joins in PL/SQL.
When fetching data in PL/SQL, consider using bulk collect to increase loop performance by reducing context switches from the PL/SQL engine to the SQL engine.
This code suffers from a typical (and very wrong) approach to databases that consider the database a bit bucket. The database is nothing but a file cabinet of sorts for the persistent storage of rows. SQL is then used as I/O routines to read and write records. Why treat the database as a flat file?
This approach stems from the 80's when we used COBOL and dealt with sequential files like ISAM. It has no place in the 21st century when dealing with the modern database.
Something that I seem to be repeating on a daily basis here in this forum:
1. Maximise SQL.
2. Minimise PL/SQL (or Java or Delphi or VB or C or C# or whatever)
SQL is the fastest and most powerful language to crunch database data. Use it to its full capability.