Creating an XML File

Question

I'm using this code to build an XML file and to write it on a file:
    DBConnect(); //connection to an Access DB
    StringBuffer sql = new StringBuffer();
    sql.append("SELECT * FROM atleti ORDER BY id");
    try{
      rs = st.executeQuery(sql.toString());             
      Document doc = XMLTool.parse("myXMLFile.xml");   
      NodeList nl = doc.getElementsByTagName("giocatori");
      Node node = nl.item(0);
        //Node root = doc.createElement("giocatori");
      while(rs.next()){
        Node n = doc.createElement("giocatore");
        Node n2 = doc.createElement("id");
        Node t2 = doc.createTextNode(rs.getString("id"));
        n2.appendChild(t2);
        n.appendChild(n2);
        Node n4 = doc.createElement("cognome");
        Node t4 = doc.createTextNode(rs.getString("cognome"));
        n4.appendChild(t4);
        n.appendChild(n4);
        Node n3 = doc.createElement("nome");
        Node t3 = doc.createTextNode(rs.getString("Nome"));
        n3.appendChild(t3);
        n.appendChild(n3);
        Node n5 = doc.createElement("codicefiscale");
        Node t5 = doc.createTextNode(rs.getString("codicefiscale"));
        n5.appendChild(t5);
        n.appendChild(n5);
        Node n6 = doc.createElement("tesserasanitaria");
        Node t6 = doc.createTextNode(rs.getString("tesserasanitaria"));
        n6.appendChild(t6);
        n.appendChild(n6);
     Node n7 = doc.createElement("cartaidentita");
        Node t7 = doc.createTextNode(rs.getString("cartaidentita"));
        n7.appendChild(t7);
        n.appendChild(n7);
        Node n8 = doc.createElement("luogonascita");
        Node t8 = doc.createTextNode(rs.getString("luogonascita"));
        n8.appendChild(t8);
        n.appendChild(n8);
        Node n9 = doc.createElement("datanascita");
        Node t9 = doc.createTextNode(rs.getString("datanascita").substring(0,10));
        n9.appendChild(t9);
        n.appendChild(n9);
        Node n10 = doc.createElement("indirizzo");
       Node n11 = doc.createElement("residente");     
          Node t11 = doc.createTextNode(rs.getString("residente"));
          n11.appendChild(t11);
       n10.appendChild(n11);
       Node n12 = doc.createElement("via");     
          Node t12 = doc.createTextNode(rs.getString("indirizzo"));
          n12.appendChild(t12);
          n10.appendChild(n12);
       Node n13 = doc.createElement("cap");     
          Node t13 = doc.createTextNode(rs.getString("cap"));
          n13.appendChild(t13);
          n10.appendChild(n13);
     n.appendChild(n10);
        Node n14 = doc.createElement("telefono");
       Node n16 = doc.createElement("fisso");     
          Node t16 = doc.createTextNode(rs.getString("telefonofisso"));
          n16.appendChild(t16);
          n14.appendChild(n16);
       Node n15 = doc.createElement("cellulare");     
          Node t15 = doc.createTextNode(rs.getString("telefonocellulare"));
          n15.appendChild(t15);     
          n14.appendChild(n15);      
     n.appendChild(n14);
        Node n17 = doc.createElement("email");
        Node t17 = doc.createTextNode(rs.getString("email"));
        n17.appendChild(t17);
        n.appendChild(n17);
        Node n18 = doc.createElement("squadra");
       Node n19 = doc.createElement("categoria");     
          Node t19 = doc.createTextNode(" ");
          n19.appendChild(t19);
          n18.appendChild(n19);
       Node n20 = doc.createElement("numero");     
          Node t20 = doc.createTextNode("0");
          n20.appendChild(t20);     
          n18.appendChild(n20);      
     n.appendChild(n18);
        node.appendChild(n);
        //node.normalize();
      //System.out.println(node);
      FileWriter fw = new FileWriter("OutputFile.xml");
      fw.write(node.toString());
      fw.flush();
      fw.close();I have 2 problems:
a) The output file is writed all on one line and I would like to have it indented so it will be more readable and "cool".
b) I have this error "null Text data??" and I don't know its mind!
Could anybody help me?

Answer 1

hi,
for a commercial grade app , u should rather
have a reusable method.
  public static void createXfile(Document doc, String filePath)
     FileOutputStream fos =null;
     try{
          File f = new File(filePath);
          OutputFormat of = new OutputFormat("XML","ISO-8859-1",true);
          of.setIndent(1);
          of.setIndenting(true);
          fos = new FileOutputStream(f);
          XMLSerializer printer = new XMLSerializer(fos, of);
          printer.asDOMSerializer();
          printer.serialize(doc);
          fos.close();
     catch(Exception e){
          //u wont reach this place until u messup something
          // real bad
          Logger.log("XUtil----------"+e.getMessage(), Logger.ERROR);
   dont go for transformer just for printing DOM.
HTH
vasanth-ct