Creating Well-Formed XML Question

Question

I need to create an xml document in a specific format. I've created a test case using the scott/tiger schema. Here's what I need:
<ALL_DEPARTMENTS>
<DEPEARTMENT>ACCOUNTING
<LOCATION>NEW YORK</LOCATION>
<NAME>CLARK
<JOB>MANAGER</JOB>
<HIREDATE>06/09/1981</HIREDATE>
</NAME>
</DEPARTMENT>
(repeat until all names exhausted for that department)
<DEPARTMENT>RESEARCH
(repeat until all departments and employees are exhausted)
</ALL_DEPARTMENTS>
Here's the script as I've created it:
set serveroutput on
declare
cursor myDept is
select deptno from scott.dept;
eachDept myDept%ROWTYPE;
cursor myEmp is
select * from scott.emp where
deptNo = eachDept.deptNo;
eachEmp myEmp%ROWTYPE;
targetDoc dbms_xmldom.domdocument;
root dbms_xmldom.domelement;
sourceDoc dbms_xmldom.domdocument;
elem dbms_xmldom.domelement;
firstTarget XMLType := xmlType('<ALL_DEPARTMENTS/>');
firstXML XMLType;
secondXML XMLType;
begin
targetDoc := dbms_xmldom.newDomDocument(firstTarget);
root := dbms_xmldom.getDocumentElement(targetDoc);
open myDept;
loop
fetch myDept into eachDept;
Exit when myDept%NOTFOUND;
select
xmlelement("DEPARTMENT",dname,
xmlelement("LOCATION",loc)) into firstXML from scott.dept
where deptno = eachDept.deptNo;
sourceDoc := dbms_xmldom.newdomdocument(firstXML);
elem := dbms_xmldom.getDocumentElement(sourceDoc);
elem := dbms_xmldom.makeElement(dbms_xmldom.importnode(targetDoc,dbms_xmlDom.makeNode(elem),true));
elem := dbms_xmldom.makeElement(dbms_xmldom.appendChild(dbms_xmldom.makeNode(root),DBMS_xmldom.makeNode(elem)));
Open myEmp;
Loop
fetch myEmp into eachEmp;
Exit when myEmp%NOTFOUND;
select xmlelement("NAME",ename,
xmlelement("JOB",job),
xmlelement("HIREDATE",to_char(hiredate,'MM/DD/YYYY')))
into secondXML
from
scott.emp
where
empNo = eachEmp.empNo;
sourceDoc := dbms_xmldom.newdomdocument(secondXML);
elem := dbms_xmldom.getdocumentelement(sourceDoc);
elem := dbms_xmldom.makeelement(dbms_xmldom.importnode(targetDoc, dbms_xmldom.makenode(elem),true));
elem := dbms_xmldom.makeElement(dbms_xmldom.appendchild(dbms_xmldom.makeNode(root), dbms_xmldom.makenode(elem)));
end loop;
close myEmp;
end loop;
close myDept;
dbms_output.put_line('XML = '||FirstTarget.getClobVal());
end;
The output is:
<ALL_DEPARTMENTS>
<DEPARTMENT>ACCOUNTING
<LOCATION>NEW YORK</LOCATION>
</DEPARTMENT>
<NAME>CLARK
<JOB>MANAGER</JOB>
<HIREDATE>06/09/1981</HIREDATE>
</NAME>
<NAME>KING
<JOB>PRESIDENT</JOB>
<HIREDATE>11/17/1981</HIREDATE>
</NAME>
<NAME>MILLER
<JOB>CLERK</JOB>
<HIREDATE>01/23/1982</HIREDATE>
</NAME>
<DEPARTMENT>RESEARCH
<LOCATION>DALLAS</LOCATION>
</DEPARTMENT>
<NAME>SMITH
<JOB>CLERK</JOB>
<HIREDATE>12/17/1980</HIREDATE>
</NAME>
<NAME>JONES
<JOB>MANAGER</JOB>
<HIREDATE>04/02/1981</HIREDATE>
</NAME>
<NAME>SCOTT
<JOB>ANALYST</JOB>
<HIREDATE>12/09/1982</HIREDATE>
</NAME>
<NAME>ADAMS
<JOB>CLERK</JOB>
<HIREDATE>01/12/1983</HIREDATE>
</NAME>
<NAME>FORD
<JOB>ANALYST</JOB>
<HIREDATE>12/03/1981</HIREDATE>
</NAME>
<DEPARTMENT>SALES
<LOCATION>CHICAGO</LOCATION>
</DEPARTMENT>
<NAME>ALLEN
<JOB>SALESMAN</JOB>
<HIREDATE>02/20/1981</HIREDATE>
</NAME>
<NAME>WARD
<JOB>SALESMAN</JOB>
<HIREDATE>02/22/1981</HIREDATE>
</NAME>
<NAME>MARTIN
<JOB>SALESMAN</JOB>
<HIREDATE>09/28/1981</HIREDATE>
</NAME>
<NAME>BLAKE
<JOB>MANAGER</JOB>
<HIREDATE>05/01/1981</HIREDATE>
</NAME>
<NAME>TURNER
<JOB>SALESMAN</JOB>
<HIREDATE>09/08/1981</HIREDATE>
</NAME>
<NAME>JAMES
<JOB>CLERK</JOB>
<HIREDATE>12/03/1981</HIREDATE>
</NAME>
<DEPARTMENT>OPERATIONS
<LOCATION>BOSTON</LOCATION>
</DEPARTMENT>
</ALL_DEPARTMENTS>
How can I get the closing </DEPARTMENT> to fall after all the names associated with that department? I'm sure it's something simple, but I'm just not seeing it.

Answer 1

Does this make sense to anyone?
<DEPARTMENT>ACCOUNTING
<LOCATION>NEW YORK</LOCATION>
</DEPARTMENT>
<NAME>CLARK
<JOB>MANAGER</JOB>
<HIREDATE>06/09/1981</HIREDATE>
</NAME>
<NAME>KING
<JOB>PRESIDENT</JOB>
<HIREDATE>11/17/1981</HIREDATE>
</NAME>
So, you have <NAME>KING but the closing tag is two lines down. I am not sure if that is legal. To get the job and hiredate also, this is what I had to do,
select xmlelement("AllDepartments",
     xmlagg(xmlelement("Department",
          xmlattributes(d.dname as "DeptName", d.loc as "Location"),
          (select xmlagg(xmlelement("ENames",
               xmlforest(e.ename as "Ename", e.job as "Job", e.hiredate as "Hiredate")))
               from emp e
               where e.deptno = d.deptno     
)).extract('/*') as deptxml
from dept d
and the result is
<AllDepartments>
<Department DeptName="ACCOUNTING" Location="NEW YORK">
<ENames>
<Ename>CLARK</Ename>
<Job>MANAGER</Job>
<Hiredate>1981-06-09</Hiredate>
</ENames>
<ENames>
<Ename>KING</Ename>
<Job>PRESIDENT</Job>
<Hiredate>1981-11-17</Hiredate>
</ENames>
<ENames>
<Ename>MILLER</Ename>
<Job>CLERK</Job>
<Hiredate>1982-01-23</Hiredate>
</ENames>
</Department>
<Department DeptName="RESEARCH" Location="DALLAS">
<ENames>
<Ename>SMITH</Ename>
<Job>CLERK</Job>
<Hiredate>1980-12-17</Hiredate>
</ENames>
<ENames>
<Ename>JONES</Ename>
<Job>MANAGER</Job>
<Hiredate>1981-04-02</Hiredate>
</ENames>
<ENames>
<Ename>SCOTT</Ename>
<Job>ANALYST</Job>
<Hiredate>1987-04-19</Hiredate>
</ENames>
<ENames>
<Ename>ADAMS</Ename>
<Job>CLERK</Job>
<Hiredate>1987-05-23</Hiredate>
</ENames>
<ENames>
<Ename>FORD</Ename>
<Job>ANALYST</Job>
<Hiredate>1981-12-03</Hiredate>
</ENames>
</Department>
<Department DeptName="SALES" Location="CHICAGO">
<ENames>
<Ename>ALLEN</Ename>
<Job>SALESMAN</Job>
<Hiredate>1981-02-20</Hiredate>
</ENames>
<ENames>
<Ename>WARD</Ename>
<Job>SALESMAN</Job>
<Hiredate>1981-02-22</Hiredate>
</ENames>
<ENames>
<Ename>MARTIN</Ename>
<Job>SALESMAN</Job>
<Hiredate>1981-09-28</Hiredate>
</ENames>
<ENames>
<Ename>BLAKE</Ename>
<Job>MANAGER</Job>
<Hiredate>1981-05-01</Hiredate>
</ENames>
<ENames>
<Ename>TURNER</Ename>
<Job>SALESMAN</Job>
<Hiredate>1981-09-08</Hiredate>
</ENames>
<ENames>
<Ename>JAMES</Ename>
<Job>CLERK</Job>
<Hiredate>1981-12-03</Hiredate>
</ENames>
</Department>
<Department DeptName="OPERATIONS" Location="BOSTON"/>
</AllDepartments>
Quite different from what you wanted.
Ben