Cursor to add data through a wizard

Question

Hi All,
Thanks in advance for any help.
I have several insert statements using cursors but am getting caught up on a few problems.
For the first portion I was trying to insert the id and description of a variable at the same time with no luck. Below is the code I am using however I get a ORA-01422: exact fetch returns more than requested number of rows error.
I am not sure if a select into statement is the right thing to do here, any help is appreciated.
FOR i IN 1..v_wi_phase.count
  Loop
  select description into v_description
  from trs_work_items
  where pha_id = v_wi_phase(i);
-- Insert data in the TRS_WORK_ITEMS table
    INSERT INTO TRS_WORK_ITEMS
    (ACT_ID
    ,PHA_ID
    ,IS_COMMENT_REQUIRED
    ,IS_OVERTIME_ALLOWED
    ,IS_BILLABLE
    ,OUT_ID
    ,START_DATE
    ,END_DATE
    ,ORG_ID
    ,DESCRIPTION
    VALUES
    (v_activity_id
    ,v_wi_phase(i)
    ,v_wi_is_comment_required
    ,v_wi_is_overtime_allowed
    ,v_wi_is_billable
    ,v_wi_out_id
    ,v_wi_start_date
    ,v_wi_end_date
    ,v_org_id
    ,v_wi_description || '-' || v_description
    )RETURNING ID INTO i_work_item_id;
End Loop;My second problem is that I need to return multiple ids from an insert statement but am not sure how to do this.
below is my attempt:
FOR i IN 1..v_work_item_id.count
    Loop
     FOR x IN 1..v_pha_id.count
     Loop
      If v_pha_id(x) = v_work_item_id(i)
    then
      INSERT INTO TRS_ACTIVITY_ALLOCATIONS
      (ACT_ID
      ,EMP_ID
      ,SEC_ID
      ,WIT_ID
      ,START_DATE
      ,END_DATE
      VALUES
      (v_activity_id
      ,null
      ,v_allocation_sec_id
      ,v_work_item_id(i)
      ,v_allocation_start_date
      ,v_allocation_end_date
end if;
    End Loop;
      End Loop;

Answer 1

Assuming that V_WORK_ITEM_ID is defined as some sort of collection rather than as a scalar, you could replace your LOOP and do something like (assuming that all the other local variables are initialized outside your loop
-- Insert data in the TRS_WORK_ITEMS table
    INSERT INTO TRS_WORK_ITEMS
    (ACT_ID
    ,PHA_ID
    ,IS_COMMENT_REQUIRED
    ,IS_OVERTIME_ALLOWED
    ,IS_BILLABLE
    ,OUT_ID
    ,START_DATE
    ,END_DATE
    ,ORG_ID
    ,DESCRIPTION
    SELECT
     v_activity_id
    ,wi_phases.column_value
    ,v_wi_is_comment_required
    ,v_wi_is_overtime_allowed
    ,v_wi_is_billable
    ,v_wi_out_id
    ,v_wi_start_date
    ,v_wi_end_date
    ,v_org_id
    ,v_wi_description || '-' || trs_phases.description
    FROM table( v_wi_phase ) wi_phases,
         trs_phases
   WHERE trs_phases.id = wi_phase.column_value
RETURNING ID BULK COLLECT INTO v_work_item_id;This doesn't seem to smell right for lack of a better term, though.
1) If V_WORK_ITEM_ID is a collection, the name ought to imply that it is a collection, not that it is a scalar number
1a) V_WI_PHASE is, similarly, not a particularly apt name for a collection of phases
2) It would seem odd that all the other local variables are initialized outside the loop. Maybe it makes sense that all these attributes are independent of the data in the V_WI_PHASE collection but the names seem to imply that they have something to do with phases. The fact that there is a TRS_PHASES table and a V_WI_PHASE collection also seems confusing at least. It would seem like the other columns in the SELECT ought to be populated with data from one of these two.
Justin