Edit method problem???

Question

Hi,forgive for all the code but i've asked this question before and people asked for more code.The problem is i get an error in publicationmain saying "undefined varible newpublication" so how do i fix this?and is my edit method goin to work?using the get and set method?can u show me how do do this please?feel free to make any other changes.thanxs a reply would be most heplful
public class publication
public int PublicationID;
public String publicationname;
public String publisher;
public String PricePerIssue;
public String pubstatus;
public String publicationtype;
public publication(int NewPublicationID, String Newpublicationname, String Newpublisher, String NewPricePerIssue, String Newpubstatus, String Newpublicationtype)
PublicationID = NewPublicationID;
publicationname = Newpublicationname;
publisher = Newpublisher;
PricePerIssue = NewPricePerIssue;
pubstatus = Newpubstatus;
publicationtype = Newpublicationtype;
public String toString ()
String pubreport = "---------------------------Publication-Information-----------------------------";
pubreport += "Publication ID:" PublicationID"/n";
pubreport += " Publication Title:" publicationname"/n";
pubreport += " publisher: " publisher"/n";
pubreport += " price Per Issue: " PricePerIssue"/n";
pubreport += " publication Status: " pubstatus"/n";
pubreport += " publication Type: " publicationtype"/n";
return pubreport;
public void SetPublicationID(int PubID)
PublicationID = PubID;
public int GetPublicationID()
return PublicationID;
public void Setpublicationname(String pubname)
publicationname = pubname;
public String Getpublicationname()
return publicationname;
public void Setpublisher(String Pub)
publisher = Pub;
public String Getpublisher()
return publisher;
public void SetPricePerIssue(String PPI)
PricePerIssue = PPI;
public String GetPricePerIssue()
return PricePerIssue;
public void Setpubstatus(String Status)
pubstatus = Status;
public String Getpubstatus()
return pubstatus;
public void Setpublicationtype(String Pubtype)
publicationtype = Pubtype;
public String Getpublicationtype()
return publicationtype;
import java.util.*;
import publication;
public class PublicationContainer
LinkedList PubList;
public PublicationContainer()
PubList = new LinkedList();
public int add (publication newpublication)
PubList.addLast(newpublication);
return PubList.size();
private class PubNode
public publication pubrecord;
public PubNode next;
public PubNode (publication thepublicationrecord)
publication p = thepublicationrecord;
next = null;
public String toString()
return PubList.toString();
public void remove(int PubID)
PubList.remove(PubID);
public publication get(int PubID)
return (publication)PubList.get(PubID);
public void set(int PubID,publication newpublication)
PubList.set(PubID, newpublication);
import cs1.Keyboard;
import publication;
import java.util.*;
public class publicationmain
public static void main(String args[])
PublicationContainer pubdatabase = new PublicationContainer();
int userchoice;
boolean flag = false;
while (flag == false)
System.out.println("------------------------------------Publications--------------------------------");
System.out.println();
System.out.println("please Make a Selection");
System.out.println();
System.out.println("1 to add publication");
System.out.println("2 to delete publication");
System.out.println("0 to quit");
System.out.println("3 to View all publications");
System.out.println("4 to Edit a publication");
System.out.println("5 to select view of publication");
System.out.println("6 to produce daily summary");
System.out.println();
userchoice = Keyboard.readInt();
switch (userchoice)     
case 1:
String PubName;
String PricePerIssue;
String Publisher;
String Pubstatus;
String Pubtype;
int PubID;
System.out.println ("Enter Publication ID:");
PubID = Keyboard.readInt();
System.out.println("Enter Publication Name:");
PubName = Keyboard.readString();
System.out.println("Enter Publisher Name");
Publisher = Keyboard.readString();
System.out.println("Enter Price per Issue:");
PricePerIssue = Keyboard.readString();
System.out.println("Enter Publication status");
Pubstatus = Keyboard.readString();
System.out.println("Enter Publication type:");
Pubtype = Keyboard.readString();
pubdatabase.add (new publication(PubID, PubName, Publisher, PricePerIssue, Pubstatus, Pubtype));
break;
case 0:
flag = true;
case 2:
System.out.println ("Enter Publication ID:");
PubID = Keyboard.readInt();
pubdatabase.remove (PubID);
System.out.println ("publication: "+(PubID)+" removed");
System.out.println();
break;
case 3:
System.out.println (pubdatabase);
break;
case 4:
System.out.println ("Enter Publication to be edited by Publication ID: ");
PubID = Keyboard.readInt();
pubdatabase.get(PubID);
pubdatabase.set(PubID, newpublication);
default:
System.out.println("Incorrect Entry");
}

Answer 1

Whoops! Anyone spot the mistake?
I (blush) forgot to re-instate the serial key for the publications after reading them in from disk.
Works now ;)
import javax.swing.JComponent;
import javax.swing.JList;
import javax.swing.DefaultListModel;
import javax.swing.JPanel;
import javax.swing.JOptionPane;
import javax.swing.JButton;
import javax.swing.JScrollPane;
import javax.swing.JLabel;
import javax.swing.JComboBox;
import javax.swing.JTextField;
import javax.swing.event.ListSelectionEvent;
import javax.swing.event.ListSelectionListener;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.MouseEvent;
import java.awt.event.MouseListener;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.awt.BorderLayout;
import java.awt.GridLayout;
import java.awt.Dimension;
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.Serializable;
class Publication
     implements Serializable
     private static final String sFileName= "Publications.ser";
     public static final byte UNKNOWN=     0;
     public static final byte HARDBACK=    1;
     public static final byte PAPERBACK=   2;
     public static final byte AUDIO=       3;
     public static final byte BRAIL=       4;
     public static final byte LARGE_PRINT= 5;
     public static final byte INSTOCK=      1;
     public static final byte BACK_ORDER=   2;
     public static final byte OUT_OF_PRINT= 3;
     private static final String[] sTypeNames=
          { "Unknown", "Hardback", "Paperback", "Audio", "Brail", "Large Print" };
     private static final String[] sStatusNames=
          { "Unknown", "In Stock", "Back Order", "Out of Print" };
     private int mId;
     private String mTitle;
     private String mAuthor;
     private String mPublisher;
     private float mPrice;
     private byte mStatus;
     private byte mType;
     private static Object sIdLock= new Object();
     static int sId;
     public Publication(
          String title, String author, String publisher,
          float price, byte status, byte type)
          setTitle(title);
          setPublisher(publisher);
          setAuthor(author);
          setPrice(price);
          setStatus(status);
          setType(type);
          synchronized (sIdLock) {
               mId= ++sId;
     public int getId() { return mId; }
     public void setTitle(String title) { mTitle= title; }
     public String getTitle() { return mTitle; }
     public void setAuthor(String author) { mAuthor= author; }
     public String getAuthor() { return mAuthor; }
     public void setPublisher(String publisher) { mPublisher= publisher; }
     public String getPublisher() { return mPublisher; }
     public void setPrice(float price) { mPrice= price; }
     public float getPrice() { return mPrice; }
     public void setStatus(byte status)
          if (status >= INSTOCK && status <= OUT_OF_PRINT)
               mStatus= status;
          else
               mStatus= UNKNOWN;
     public byte getStatus() { return mStatus; }
     public String getStatusName() { return sStatusNames[mStatus]; }
     public void setType(byte type)
          if (type >= HARDBACK && type <= LARGE_PRINT)
               mType= type;
          else
               mType= UNKNOWN;
     public byte getType() { return mType; }
     public String getTypeName() { return sTypeNames[mType]; }
     public String toString ()
          return
               " id= " +getId() +
               ", title= " +getTitle() +
               ", author= " +getAuthor() +
               ", publisher= " +getPublisher() +
               ", price= " +getPrice() +
               ", status= " +getStatus() +
               " (" +getStatusName() +")" +
               ", type= " +getType() +
               " (" +getTypeName() +")";
     private static void addPublication(DefaultListModel listModel) {
          editPublication(listModel, null);
     private static void editPublication(
          DefaultListModel listModel, Publication publication)
          JPanel panel= new JPanel(new BorderLayout());
          JPanel titlePanel= new JPanel(new GridLayout(0,1));
          JPanel fieldPanel= new JPanel(new GridLayout(0,1));
          JTextField fTitle= new JTextField(20);
          JTextField fAuthor= new JTextField();
          JTextField fPublisher= new JTextField();
          JTextField fPrice= new JTextField();
          JComboBox cbStatus= new JComboBox(sStatusNames);
          JComboBox cbType= new JComboBox(sTypeNames);
          fieldPanel.add(fTitle);
          fieldPanel.add(fAuthor);
          fieldPanel.add(fPublisher);
          fieldPanel.add(fPrice);
          fieldPanel.add(cbStatus);
          fieldPanel.add(cbType);
          titlePanel.add(new JLabel("Title:"));
          titlePanel.add(new JLabel("Author:"));
          titlePanel.add(new JLabel("Publisher: "));
          titlePanel.add(new JLabel("Price:"));
          titlePanel.add(new JLabel("Status:"));
          titlePanel.add(new JLabel("Type:"));
          panel.add(titlePanel, BorderLayout.WEST);
          panel.add(fieldPanel, BorderLayout.EAST);
          if (publication != null) {
               fTitle.setText(publication.getTitle());
               fTitle.setEditable(false);
               fAuthor.setText(publication.getAuthor());
               fPublisher.setText(publication.getPublisher());
               fPrice.setText("" +publication.getPrice());
               cbStatus.setSelectedIndex((int) publication.getStatus());
               cbType.setSelectedIndex((int) publication.getType());
          int option= JOptionPane.showOptionDialog(
               null, panel, "New Publication",
               JOptionPane.OK_CANCEL_OPTION,
               JOptionPane.PLAIN_MESSAGE,
               null, null, null
          if (option != JOptionPane.OK_OPTION)
               return;
          String title=
               fTitle.getText().length() < 1 ? "Unknown" : fTitle.getText();
          String author=
               fAuthor.getText().length() < 1 ? "Unknown" : fAuthor.getText();
          String publisher=
               fPublisher.getText().length() < 1 ? "Unknown" : fPublisher.getText();
          float price= 0.0f;
          try { price= Float.parseFloat(fPrice.getText()); }
          catch (NumberFormatException nfe) { }
          byte status= (byte) cbStatus.getSelectedIndex();
          byte type= (byte) cbType.getSelectedIndex();
          if (publication != null) {
               publication.setAuthor(author);
               publication.setPublisher(publisher);
               publication.setPrice(price);
               publication.setStatus(status);
               publication.setType(type);
          else {
               listModel.addElement(
                    new Publication(title, author, publisher, price, status, type));
     private static void deletePublications(JList list, DefaultListModel listModel)
          if (list.getSelectedIndex() >= 0) {
               Object[] values= list.getSelectedValues();
               for (int i= 0; i< values.length; i++)
                    listModel.removeElement(values);
     private static DefaultListModel getListModel()
          DefaultListModel listModel;
          try {
               ObjectInputStream is=
                    new ObjectInputStream(new FileInputStream(sFileName));
               listModel= (DefaultListModel) is.readObject();
               is.close();
               if (listModel.getSize() > 0) {
                    Publication.sId=
                         ((Publication)
                              listModel.get(listModel.getSize() -1)).getId();
          catch (Exception e) {
               JOptionPane.showMessageDialog(
                    null, "Could not find saved Publications, creating new list.",
                    "Error", JOptionPane.ERROR_MESSAGE);
               listModel= new DefaultListModel();
               // add a known book to the list (I'm pretty sure this one exists ;)
               listModel.addElement(
                    new Publication("The Bible", "Various", "God", 12.95f,
                         Publication.INSTOCK, Publication.HARDBACK));
          // add a shutdown hook to save the list model to disk when we exit
          final DefaultListModel model= listModel;
          Runtime.getRuntime().addShutdownHook(new Thread() {
               public void run() {
                    saveListModel(model);
          return listModel;
     private static void saveListModel(DefaultListModel listModel)
          try {
               ObjectOutputStream os=
                    new ObjectOutputStream(new FileOutputStream(sFileName));
               os.writeObject(listModel);
               os.close();
          catch (IOException ioe) {
               System.err.println("Failed to save Publications!");
               ioe.printStackTrace();
     public static void main(String args[])
          // store all the publications in a list model which drives the JList
          // the user will see - we save it on exit, so see if there's one on disk.
          final DefaultListModel listModel= getListModel();
          final JList list= new JList(listModel);
          // two panels, the main one for the dialog and one for buttons
          JPanel panel= new JPanel(new BorderLayout());
          JPanel btnPanel= new JPanel(new GridLayout(1,0));
          // an add button, when pressed brings up a dialog where the user can
          // enter details of a new publication
          JButton btnAdd= new JButton("Add");
          btnAdd.addActionListener(new ActionListener() {
               public void actionPerformed(ActionEvent e) {
                    addPublication(listModel);
          btnPanel.add(btnAdd);
          // a delete button, when pressed it will delete all the selected list
          // items (if any) and then disable itself
          final JButton btnDelete= new JButton("Delete");
          btnDelete.addActionListener(new ActionListener() {
               public void actionPerformed(ActionEvent e) {
                    deletePublications(list, listModel);
          btnDelete.setEnabled(false);
          btnPanel.add(btnDelete);
          // hook into the list selection model so we can de-activate the delete
          // button if no list items are selected.
          list.getSelectionModel().addListSelectionListener(
               new ListSelectionListener() {
                    public void valueChanged(ListSelectionEvent e) {
                         if (list.getSelectedIndices().length > 0)
                              btnDelete.setEnabled(true);
                         else
                              btnDelete.setEnabled(false);
          // Watch out for double clicks in the list and edit the document
          // selected
          list.addMouseListener(new MouseListener() {
               public void mouseClicked(MouseEvent e) {
                    if (e.getClickCount() == 2) {
                         editPublication(
                              listModel, (Publication) list.getSelectedValue());
               public void mousePressed(MouseEvent e) { }
               public void mouseReleased(MouseEvent e) { }
               public void mouseEntered(MouseEvent e) { }
               public void mouseExited(MouseEvent e) { }
          // Now keep an eye out for the user hitting return (will edit the selected
          // publication) or delete (will delete it)
          // Note: we have do the ugly "pressed" flag because JOptionPane closes
          // on keyPressed and we end up getting keyReleased. Can't use keyTypes
          // because it does not contain the virtual key code 8(
          list.addKeyListener(new KeyListener() {
               boolean pressed= false;
               public void keyTyped(KeyEvent e) { }
               public void keyPressed(KeyEvent e) {
                    pressed= true;
               public void keyReleased(KeyEvent e) {
                    if (pressed && e.getKeyCode() == e.VK_ENTER) {
                         editPublication(
                              listModel, (Publication) list.getSelectedValue());
                    else if (pressed && e.getKeyCode() == e.VK_DELETE)
                         deletePublications(list, listModel);
                    pressed= false;
          // Put the list in a scroll pane so we can see it all. Make it resonably
          // wide so we don't have top scroll horizonatly to see most publications
          JScrollPane listScrollPane= new JScrollPane(list);
          listScrollPane.setPreferredSize(new Dimension(640, 300));
          // layout the list and button panel
          panel.add(listScrollPane, BorderLayout.CENTER);
          panel.add(btnPanel, BorderLayout.SOUTH);
          // ok, ready to rumble, lets show the user what we've got
          JOptionPane.showOptionDialog(
               null, panel, "Publications",
               JOptionPane.DEFAULT_OPTION,
               JOptionPane.PLAIN_MESSAGE,
               null, new String[0], null
          // leg it
          System.exit(0);