Error : The value is not set for parameter number"

Question

Hello All,
I am getting an error message when I tried modifying a program by adding a new ID column to a database table.
All DML is working except the Delete. So to look at the delete method, I am setting the parameter correctly as can be seen in the code belwo.
Can someone please take a quick look and let me know where I need to tweak the code further.
Thanks
Fm
The piece of code is given below.
/* File Modified */
/* EmailSetupDao.java
* Generated by the MDK DAO Code Generator
package com.harris.mercury.setups.standard.emailsetup;
import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Vector;
import org.apache.log4j.Logger;
import com.harris.mercury.dao.CreateException;
import com.harris.mercury.dao.DAO;
import com.harris.mercury.dao.DataField;
import com.harris.mercury.dao.Holder;
import com.harris.mercury.dao.LocalResultProxy;
import com.harris.mercury.dao.RemoveException;
import com.harris.mercury.dao.ResultProxy;
import com.harris.mercury.system.DatabaseHelper;
import com.harris.mercury.system.database.dialect.Dialect;
* The EmailSetupDao class
public class EmailSetupDao implements DAO
protected static Logger logger = Logger.getLogger(EmailSetupDao.class);
/* This method is called by ResultProxies when they need
* the data they have retrieved in a ResultSet mapped
* to a holder.
public Holder createHolder(ResultSet rs) throws SQLException
EmailSetupHolder holder = new EmailSetupHolder(); // THE CODE GENERATOR NEEDS THIS VARIABLE
try
/* Assign the data into the new holder */
// $$START_CREATEHOLDER_CONVERSIONS
holder.setEmail_address( rs.getString("email_address") );
holder.setLogin_id( rs.getString("login_id") );
holder.setUser_name( rs.getString("user_name") );
holder.setSmtp( rs.getString("smtp") );
holder.setId(rs.getString("id") );
// $$END_CREATEHOLDER_CONVERSIONS
catch(SQLException sqle)
logger.error(sqle, sqle);
throw sqle;
return holder;
/* The findAll method returns a ResultProxy containing all the
* records in the pucemailr table, unless an extended where clause
* has been defined.
public ResultProxy findAll(Connection con) throws SQLException
LocalResultProxy result = null; // THE CODE GENERATOR NEEDS THIS VARIABLE
// $$START_ALLFIND
result = new LocalResultProxy(this,con, "select email_address, login_id, user_name, smtp, id from pucemailr"+makeOrderBy());
// $$END_ALLFIND
return result;
/* Inserts a record into the pucemailr table using a EmailSetupHolder.
* An exception is thrown if it is not sucessful.
public void insert(Connection con, EmailSetupHolder holder) throws CreateException
CreateException ce = null;
PreparedStatement ps = null; // THE CODE GENERATOR NEEDS THIS VARIABLE
try
// Insert into the data base
// $$START_INSERT_PS
     ps = con.prepareStatement("insert into pucemailr (email_address, login_id, user_name, smtp) values(?, ?, ?, ?) ");
// $$END_INSERT_PS
/* Assign the variables in the holder to their corresponding
* indexes in the prepared statement
ps = assignPreparedStatementValues(ps, holder, true) ;
// Try the insert
ps.executeUpdate();
catch (SQLException se)
ce = new CreateException(se.getMessage());
catch (Exception ex)
ce = new CreateException(ex.getMessage());
} finally {
DatabaseHelper.close(ps);
// Throw exception if error occurred
if (ce != null) {
throw ce;
/* This method will update a pucemailr record using the
* supplied EmailSetupHolder. If an error occurs, an exception
* is thrown.
public void update(Connection con, EmailSetupHolder holder) throws Exception
RuntimeException re = null;
PreparedStatement ps = null; // THE CODE GENERATOR NEEDS THIS VARIABLE
try
// $$START_UPDATE_PS
     ps = con.prepareStatement("update pucemailr set email_address=?, login_id=?, user_name=?,smtp=? where id=?");
// $$END_UPDATE_PS
/* Assign the variables in the holder to their corresponding
* indexes in the prepared statement
ps = assignPreparedStatementValues(ps, holder, false) ;
// Try the insert
int ret = ps.executeUpdate();
if (ret != 1)
re = new RuntimeException("Update failed on table pucemailr in EmailSetupDao");
catch (SQLException se)
re = new CreateException(se.getMessage());
catch (Exception ex)
re = new RuntimeException(ex.getMessage());
} finally {
DatabaseHelper.close(ps);
// Throw exception if error occurred
if (re != null) {
throw re;
/* Using the EmailSetupHolder, this method locates records in the pucemailr table.
* Null values found in the holder are not used in the search.
* An exception is thrown if an error occurs.
public ResultProxy find(Connection con, EmailSetupHolder holder) throws SQLException
// THE CODE GENERATOR NEEDS THESE VARIABLES
ResultProxy result = null;
int needAnd = 0;
StringBuffer selectStatement = new StringBuffer();
// $$START_FIND
selectStatement.append("select email_address, login_id, user_name, smtp, id from pucemailr ");
if(holder.getId() != null)
if ( needAnd > 0)
selectStatement.append(" and ");
else
selectStatement.append(" where ");
needAnd++;
selectStatement.append("id like ");
selectStatement.append("'"+ Dialect.getSafeDialect(con).escape(holder.getId())+"%'");
if(holder.getEmail_address() != null)
if ( needAnd > 0)
selectStatement.append(" and ");
else
selectStatement.append(" where ");
needAnd++;
selectStatement.append("email_address like ");
selectStatement.append("'"+ Dialect.getSafeDialect(con).escape(holder.getEmail_address())+"%'");
if(holder.getLogin_id() != null)
if ( needAnd > 0)
selectStatement.append(" and ");
else
selectStatement.append(" where ");
needAnd++;
selectStatement.append("login_id like ");
selectStatement.append("'"+ Dialect.getSafeDialect(con).escape(holder.getLogin_id())+"%'");
if(holder.getUser_name() != null)
if ( needAnd > 0)
selectStatement.append(" and ");
else
selectStatement.append(" where ");
needAnd++;
selectStatement.append("user_name like ");
selectStatement.append("'"+ Dialect.getSafeDialect(con).escape(holder.getUser_name())+"%'");
if(holder.getSmtp() != null)
if ( needAnd > 0)
selectStatement.append(" and ");
else
selectStatement.append(" where ");
needAnd++;
selectStatement.append("smtp like ");
selectStatement.append("'"+ Dialect.getSafeDialect(con).escape(holder.getSmtp())+"%'");
// $$END_FIND
result = new LocalResultProxy(this, con, selectStatement.toString()+makeOrderBy());
return result;
/* Creates an Order by clause */
public String makeOrderBy()
String result = "";
// $$START_ORDERBY
result = " order by smtp";
// $$END_ORDERBY
return result ;
/* This method deltes a single record that matches all the
* variables found in the EmailSetupHolder.
* An exception is thrown if an error occurs.
public void delete(Connection con, EmailSetupHolder holder) throws RemoveException
RemoveException re = null;
PreparedStatement ps = null; // THE CODE GENERATOR NEEDS THIS VARIABLE
boolean hasVars = false;
StringBuffer deleteSQL = new StringBuffer();
deleteSQL.append( "delete from pucemailr where " );
// $$START_DELETE_SQL
if (hasVars)
deleteSQL.append(" and ");
if (holder.getEmail_address() != null) {
deleteSQL.append("email_address=?") ;
} else {
deleteSQL.append("email_address is null");
hasVars = true;
if (hasVars)
deleteSQL.append(" and ");
if (holder.getLogin_id() != null) {
deleteSQL.append("login_id=?") ;
} else {
deleteSQL.append("login_id is null");
hasVars = true;
if (hasVars)
deleteSQL.append(" and ");
if (holder.getUser_name() != null) {
deleteSQL.append("user_name=?") ;
} else {
deleteSQL.append("user_name is null");
hasVars = true;
if (hasVars)
deleteSQL.append(" and ");
if (holder.getSmtp() != null) {
deleteSQL.append("smtp=?") ;
} else {
deleteSQL.append("smtp is null");
hasVars = true;
if (hasVars)
deleteSQL.append(" and ");
if (holder.getSmtp() != null) {
deleteSQL.append("id=?") ;
} else {
deleteSQL.append("id is null");
hasVars = true;
// $$END_DELETE_SQL
try
     ps = con.prepareStatement(deleteSQL.toString());
/* Assign the variables in the holder to their corresponding
* indexes in the prepared statement
int index = 1 ;
// $$START_DELETE_VARS
/* if( holder.getEmail_address() != null) {
ps.setString(index, holder.getEmail_address() );
index ++;
if( holder.getLogin_id() != null) {
ps.setString(index, holder.getLogin_id() );
index ++;
if( holder.getUser_name() != null) {
ps.setString(index, holder.getUser_name() );
index ++;
if( holder.getSmtp() != null) {
ps.setString(index, holder.getSmtp() );
index ++;
if( holder.getId() != null) {
ps.setString(index, holder.getId() );
index ++;
// $$END_DELETE_VARS
// Try the insert
int ret = ps.executeUpdate();
if (ret != 1)
re = new RemoveException("Delete failed on table pucemailr in EmailSetupDao");
catch (SQLException se)
re = new RemoveException(se.getMessage());
catch (Exception ex) {
re = new RemoveException(ex.getMessage());
} finally {
DatabaseHelper.close(ps);
// Throw exception if error occurred
if (re != null)
throw re;
/* This method finds records in pucemailr table that match the
* supplied where clause.
* An exception is thrown if an error occurs.
public ResultProxy advancedFind(Connection con, String whereclause) throws SQLException
// THE CODE GENERATOR NEEDS THIS VARIABLE AND THE PARAMETER VARIABLE 'whereclause'
StringBuffer selectStatement = new StringBuffer();
// $$START_ADVANCEDFIND
selectStatement.append("select email_address, login_id, user_name, smtp, id from pucemailr ");
// $$END_ADVANCEDFIND
selectStatement.append(" where ");
selectStatement.append(whereclause);
return new LocalResultProxy(this,con, selectStatement.toString()+makeOrderBy());
/* This methods returns a Vector of DataField objects that
* map the columns in the pucemailr table for the
* advanced find Where Clause Generator in the client. The extended
* where clause will be applied if one exists for this DAO.
public Vector<DataField> getQueryFields() {
Vector<DataField> v = new Vector<DataField>() ; // THE CODE GENERATOR NEEDS THIS VARIABLE
// $$START_QUERYFIELDS
v.addElement( new DataField( "email_address", "Email address", DataField.STRING ) ) ;
v.addElement( new DataField( "login_id", "Login id", DataField.STRING ) ) ;
v.addElement( new DataField( "user_name", "User name", DataField.STRING ) ) ;
v.addElement( new DataField( "smtp", "Smtp", DataField.STRING ) ) ;
v.addElement( new DataField( "id", "Id", DataField.STRING ) ) ;
// $$END_QUERYFIELDS
return v;
     * Jira Issue NS 30679 - Faiz Qureshi March 7, 2013
     * @param ps
     * @param holder
     * @param isInsert - Added Boolean parameter so the id parameter does not get passed for Insert DML statements
     * @return
     * @throws Exception
public PreparedStatement assignPreparedStatementValues(PreparedStatement ps, EmailSetupHolder holder, boolean isInsert)
throws Exception
// $$START_PS_SETS
if( holder.getEmail_address() != null)
ps.setString(1, holder.getEmail_address() );
else
ps.setNull(1, java.sql.Types.VARCHAR);
if( holder.getLogin_id() != null)
ps.setString(2, holder.getLogin_id() );
else
ps.setNull(2, java.sql.Types.VARCHAR);
if( holder.getUser_name() != null)
ps.setString(3, holder.getUser_name() );
else
ps.setNull(3, java.sql.Types.VARCHAR);
if( holder.getSmtp() != null)
ps.setString(4, holder.getSmtp() );
else
ps.setNull(4, java.sql.Types.VARCHAR);
if (!isInsert){
     if( holder.getId() != null)
     ps.setString(5, holder.getId() );
     else
     ps.setNull(5, java.sql.Types.VARCHAR);
// $$END_PS_SETS
return ps;
/* Do not delete this tag, it is reserved for adding new methods to the DAO */
// $$ START_MDK_RESERVED
// $$START_EDITABLE_SUB_TABLE_NAME
* Returns the table names used in this DAO
* @return the table names used in this DAO
public String[] getTableNames() {
// $$START_UNEDITABLE_SUB_TABLE_NAME
String[] tableNames = new String[] {"pucemailr"};
// $$END_UNEDITABLE_SUB_TABLE_NAME
return tableNames;
// $$END_EDITABLE_SUB_TABLE_NAME
// $$START_EDITABLE_SUB_FIND
* Using the EmailSetupHolder, this method locates records in the pucemailr table.
* Null values found in the holder are not used in the search.
* An exception is thrown if an error occurs.
* @param con The database connection
* @param holder holder containing the values to generate a query upon
* @param orderBy The order by clause. Note, you must specify the "ORDER BY". If you forget to add a
* space in front of the order by, it will be automatically handled. Specify null to use the default
* or empty string for no ordering.
* @return The result of the search
* @throws SQLException if an error occurs in the search.
public ResultProxy find(Connection con, EmailSetupHolder holder, String orderBy) throws SQLException
// THE CODE GENERATOR NEEDS THESE VARIABLES
ResultProxy result = null;
int needAnd = 0;
StringBuffer selectStatement = new StringBuffer();
// $$START_FIND
selectStatement.append("select email_address, login_id, user_name, smtp, id from pucemailr ");
if(holder.getEmail_address() != null)
if ( needAnd > 0)
selectStatement.append(" and ");
else
selectStatement.append(" where ");
needAnd++;
selectStatement.append("email_address like ");
selectStatement.append("'"+ Dialect.getSafeDialect(con).escape(holder.getEmail_address())+"%'");
if(holder.getLogin_id() != null)
if ( needAnd > 0)
selectStatement.append(" and ");
else
selectStatement.append(" where ");
needAnd++;
selectStatement.append("login_id like ");
selectStatement.append("'"+ Dialect.getSafeDialect(con).escape(holder.getLogin_id())+"%'");
if(holder.getUser_name() != null)
if ( needAnd > 0)
selectStatement.append(" and ");
else
selectStatement.append(" where ");
needAnd++;
selectStatement.append("user_name like ");
selectStatement.append("'"+ Dialect.getSafeDialect(con).escape(holder.getUser_name())+"%'");
if(holder.getSmtp() != null)
if ( needAnd > 0)
selectStatement.append(" and ");
else
selectStatement.append(" where ");
needAnd++;
selectStatement.append("smtp like ");
selectStatement.append("'"+ Dialect.getSafeDialect(con).escape(holder.getSmtp())+"%'");
if(holder.getId() != null)
if ( needAnd > 0)
selectStatement.append(" and ");
else
selectStatement.append(" where ");
needAnd++;
selectStatement.append("Id like ");
selectStatement.append("'"+ Dialect.getSafeDialect(con).escape(holder.getId())+"%'"); }
// $$END_FIND
result = new LocalResultProxy(this, con, selectStatement.toString() + (orderBy == null ? makeOrderBy() : com.harris.mercury.system.utils.StringUtils.padLeft(orderBy)));
return result;
// $$END_EDITABLE_SUB_FIND
// $$START_EDITABLE_SUB_FINDALL
* The findAll method returns a ResultProxy containing all the records in the pucemailr table,
* unless an extended where clause has been defined.
* @param con The database connection
* @param orderBy The order by clause. Note, you must specify the "ORDER BY". If you forget to add a
* space in front of the order by, it will be automatically handled. Specify null to use the default
* or empty string for no ordering.
* @return The result of the search
* @throws SQLException if an error occurs in the search.
public ResultProxy findAll(Connection con, String orderBy) throws SQLException
LocalResultProxy result = null; // THE CODE GENERATOR NEEDS THIS VARIABLE
// $$START_UNEDITABLE_SUB_FINDALL
result = new LocalResultProxy(this,con, "select email_address, login_id, user_name, smtp, id from pucemailr" + (orderBy == null ? makeOrderBy() : com.harris.mercury.system.utils.StringUtils.padLeft(orderBy)));
// $$END_UNEDITABLE_SUB_FINDALL
return result;
// $$END_EDITABLE_SUB_FINDALL
// $$START_EDITABLE_SUB_ADVANCEDFIND
* This method finds records in pucemailr table that match the supplied where clause.
* @param con The database connection
* @param whereclause The where clause for the select statement - do not include the "where" - it
* will be automatically prepended
* @param orderBy The order by clause. Note, you must specify the "ORDER BY". If you forget to add a
* space in front of the order by, it will be automatically handled. Specify null to use the default
* or empty string for no ordering.
* @return The result of the search
* @throws SQLException if an error occurs in the search.
public ResultProxy advancedFind(Connection con, String whereclause, String orderBy) throws SQLException
// THE CODE GENERATOR NEEDS THIS VARIABLE AND THE PARAMETER VARIABLE 'whereclause'
StringBuffer selectStatement = new StringBuffer();
// $$START_ADVANCEDFIND
selectStatement.append("select email_address, login_id, user_name, smtp, id from pucemailr ");
// $$END_ADVANCEDFIND
selectStatement.append(" where ");
selectStatement.append(whereclause);
selectStatement.append((orderBy == null ? makeOrderBy() : com.harris.mercury.system.utils.StringUtils.padLeft(orderBy)));
return new LocalResultProxy(this,con, selectStatement.toString());
// $$END_EDITABLE_SUB_ADVANCEDFIND
// $$ END_MDK_RESERVED
}

Answer 1

First thing to do is to edit the post and use some tags to format the code as it is unreadable and too much!
Read the FAQ (https://forums.oracle.com/forums/help.jspa) to find out how to do this.
Next we need to know the jdev version you are using!
As the code is generated I would first try to generate it again after the db change.
Timo