FAILED - ORA-01031: insufficient privileges

Question

Hi All,
When i am executing the procedure i am getting below error
FAILED - ORA-01031: insufficient privileges.
My procedure is given below.
create or replace procedure SAM (start_date_key number,end_date_key number) as
varstdt number:=start_date_key;
varendt number:=end_date_key;
MSG varchar2(3456);
varTblnm varchar2(3250);
varDtkey varchar2(3250);
v_chck number(9);
varSQLstmt varchar2(2340);
begin
for r1 in (select table_name from Sales_table where table_name='SALES')
loop
varTblnm := r1.table_name;
varSQLstmt := 'create table '||varTblnm||'_'||varendt||' as select * from '||varTblnm;
execute immediate varSQLstmt;
end loop;
EXCEPTION
WHEN NO_DATA_FOUND THEN
NULL;
WHEN OTHERS THEN
MSG := 'FAILED - '||SUBSTR (SQLERRM, 1, 200);
dbms_output.put_line('Error ' ||MSG );
commit;
RAISE;
end SAM;
please let me know if there are any mistakes in the code.

Answer 1

please let me know if there are any mistakes in the code.r1.table_name will always be equal to SALES. Therefore vartblnm will always be SALES. Is what you want?
start_date_key and v_chck are never used.
Then you attempt to create multiple tables, all called SALES_ suffixed with the value passed for end_date_key. You can't create several tables with the same name.
end_date_key and varendt are numeric. You should cast them as varchar and test them before trying to use them as part of a file name. What if the number passed is negative? Or fractional?
To commit within a procedure is an awful bug.
Your WHEN OTHERS clause may be hiding the information needed to debug the code. Get rid if it.
There are no comments anywhere.
On what line does the error occur?