Filling a jtable with an array of Portfolio objects

Question

I have created a class Portfolio and want to put an array of portfolio objects in a Jtable.
I created a tablePortfolioClass based on the AbstratTableModel and
changed the classical 2 dimensional data array into a one dimensional arry of portfolio objects.
The databaselayer correctly fills the Portfolio but does not display it inthe table...
what am I doing wrong ?
package DBpackage;
import java.lang.String;
public class Portfolio
public Portfolio()
public Portfolio(String sE)
sEcode=sE;
//here are normally set and getmethods that I left out
private String sEcode;
private double dQuantity;
private double dAvgPrice;
private double dPrice;
private double dExchRate;
private double dReturn;
private String sDescr;
private double dPerc;
private double dTotal;
=============================================================
package DBpackage;
import javax.swing.table.AbstractTableModel;
class tablePortfolioClass extends AbstractTableModel
Portfolio[]data=new Portfolio[50];
final String[] columnNames={"Ecode","Description","Quantity","Price", "Avg","%","Total","Return"};
public void tablePortfolioClass (int nrofRows)
iRows=nrofRows;
public void tablePortfolioClass(Portfolio[] pp)
data=pp;
public int getColumnCount() {
return columnNames.length;
public int getRowCount() {
return data.length;
public String getColumnName(int col) {
return columnNames[col];
public Object getValueAt(int row, int col) {
return data[row];
public void setValueAt(Portfolio value, int row, int col) {
data[row] = value;
fireTableCellUpdated(row, col);
private int iRows;
private int iCols=4;
=============================================================
this is what is done in the frame
Portfolio [] pf=new Portfolio[50];
tablePortfolioClass pp=new tablePortfolioClass();
//tablePortfolioClass pp=new tablePortfolioClass(pf); this one does not compile
JTable grdPP=new JTable(pp);
grdPP.setPreferredScrollableViewportSize(new Dimension(200,200));
JScrollPane jscrollPanePP=new JScrollPane(grdPP);
all more traditional implementations of the jtable work without any problem...
anyone ?

Answer 1

Your getValueAt() method should return the actual value you want to display in the table at the given row and column. Right now, it returns the whole Portfolio object. How is the table supposed to render a Portfolio object?
Something more like this would make more sensepublic Object getValueAt(int row, int col)
  switch (col) {
  case 0:
    return data[row].getEcode();
  case 1:
    return data[row].getDescr();
  case 7:
    return new Double(data[row].getReturn());
}The same can be said for your setValueAt() method. It should set the individual attributes of the Portfolio object at the given row rather than changing the whole object.