Funny bug in pl sql code

Question

Hi,
I have written a code to upload data from csv file to oracle table. it gives me a funny error. I have given below the sample contents of .csv file
"4951","TCSPL (TRADING A/C)","470","TISCO",20050419,"P",362.6550,212,0.00
"4951","TCSPL (TRADING A/C)","470","TISCO",20050419,"S",361.7500,212,-191.86
"4951","TCSPL (TRADING A/C)","477","ASHOKLEY",20050928,"P",28.5000,200,0.00
"4951","TCSPL (TRADING A/C)","477","ASHOKLEY",20050928,"S",28.4960,200,-0.80
for the first time if i run the sql code it uploads first 2 records and does not upload third record, if i change the figure of =-191.86 to 191.86 (if i remove - mark ) then it uploads all the records, if i reverse it back it does not the third record, the structure of the table is like this ( the data column where this data get inserted is number(15,4) datatype)
this type of problem is happening with that perticular row only, though several such kind of combination is there in the csv file.
sQL> desc UNITISCLTRXN
Name Null? Type
CLCODE VARCHAR2(10)
CLNAME VARCHAR2(120)
SCCODE VARCHAR2(10)
NSESYMBOL VARCHAR2(10)
TRDDATE DATE
PURSAL VARCHAR2(1)
RATE NUMBER(15,6)
CLQTY NUMBER(10,2)
PROFIT NUMBER(15,4)
the sql code i have written is as below
PROCEDURE upload_unitiscltrxn IS
file_id text_io.file_type;
     crec unitiscltrxn%rowtype;
linebuf VARCHAR2(1000);
i number:=1;
len number:=0;
spos number:=0;
tpos number:=0;
var varchar2(1000);
mon varchar2(5);
cnt number:=0;
     errnum NUMBER := ERROR_CODE;
     errtxt VARCHAR2(80) := ERROR_TEXT;
errtyp VARCHAR2(3) := ERROR_TYPE;
begin
          Delete from unitiscltrxn;
          File_id := Text_IO.Fopen('M:\UNITIS\db\final.csv', 'r');
     Text_IO.Get_Line(File_id,linebuf);
          cnt :=1;
          while linebuf is not null loop
     IF CNT<>1 THEN
          Text_IO.Get_Line(File_id,linebuf);
     END IF;     
          cnt :=1+cnt;
     len := length(linebuf);
     spos :=1;
     i:=1;
     tpos :=0;
     var:='';
     mon:='';     
     while i < 10 loop
     tpos := instr(linebuf,',',spos);
     if tpos >0 then
          var :=substr(linebuf,spos,tpos-spos);
     else
          var :=substr(linebuf,spos);
     end if;     
          ----------get values into variable.------------------     
     If i =1 then
          Crec.clcode := Replace(var,'"','');
     ElsIf     i =2 then
          Crec.clname := Replace(var,'"','');
     ElsIf     i =3 then
          Crec.sccode := Replace(var,'"','');
     ElsIf     i =4 then
          Crec.nsesymbol := Replace(var,'"','');
     ElsIf     i =5 then
          select Decode(substr(var,5,2),1,'JAN',2,'FEB',3,'MAR',4,'APR',5,'MAY',6,'JUN',7,'JUL',8,'AUG',
          9,'SEP',10,'OCT',11,'NOV',12,'DEC') into mon from dual;
          Crec.trddate := to_date(substr(var,7)||'-'||mon||'-'||substr(var,1,4),'DD-MON-YYYY');
     ElsIf     i =6 then
          If var = '"P"' Then
               Crec.pursal :='P';
          Elsif     var = '"S"' Then
               Crec.pursal :='S';
          end if;     
          --Crec.pursal := var;
     ElsIf     i =7 then
          Crec.rate := var;
     ElsIf     i =8 then
          Crec.clqty := var;
     ElsIf     i =9 then
          Crec.profit := var;
     End If;     
     i:=i+1;
     spos:=tpos+1;
     end loop;
     INSERT INTO UNITISCLTRXN VALUES(crec.clcode, crec.clname ,crec.sccode ,crec.nsesymbol,
     crec.trddate,crec.pursal,crec.rate,crec.clqty,crec.profit);
     text_io.new_line(file_id, 1);
     End loop;     
     EXCEPTION
     WHEN no_data_found THEN
     Text_IO.Put_Line('Closing the file...');
     Text_IO.Fclose(file_ID);
WHEN OTHERS THEN
     Message(errtyp||'-'||TO_CHAR(errnum)||': '||errtxt||'FF'||DBMS_ERROR_CODE);
     Message(errtyp||'-'||TO_CHAR(errnum)||': '||errtxt);
END;
END;
Thanks
Uday

Answer 1

Hi
Try to debug you procedure inserting a better exception handling and some dbms_output.put_line.
E.g.
ElsIf i =9 then
Crec.profit := var;
dbms_output.put_line(var || '  -  ' Crec.profit);
End If; Try to put the exception handling in the loop ... while i < 10 loop ... .
I don't think that it's an Oracle bug. It's a human error in your code!
Bye, Aron