Goddam Curly Brackets!!!

Question

HELP!
I'm having problems finding a missing or extra bracket within my code? Or at least I thik that is the problem.
The error I get is:
<----
270. try
542. }
--------^
*** Syntax Error: "Finally" inserted to complete TryStatement
I've tried using comparison software but it doesn't help!
I have attached the section of code that is causing the problem, but I think it may be deeped that just the following section.
All the brackes "seem" to match, but 271 goes to 501 in theory, but when I rightclick in my software (JCreator) and choose match bracket, it takes me to 531?
Anyhelp please!! Be most grateful!
See Attached Code:
try
     //System.out.println("Here 1");
* Check to see if Activity Option 'LABEL' is present. If it is not throw an exception.
* I think this could be where LABEL should be a user configured variable (map)
* Either here or above on line 109. (map) (then again maybe not!!!)
if (label_tmp == null)
abortMissingInput("Activity Option 'LABELREF'");
System.out.println("Here 2");
else
//     System.out.println("Here 3");
* Check to see if the nicelabel file already exists. If it does
* then we need to write the data into a temporary file.
// cam removed
// while(out.exists())
// cam removed
// System.out.println("Here 4");
* Build data for updating the next_number table. Before that happens we need to
* verify that the SFCs do not already exist in wip, if they do then we need to generate
* a new batch
/* map - Fix Rev 1.2 */
System.out.println("Label TMP "+label_tmp);
System.out.println("SFC Number "+SFCNumber);
if (label_tmp.equals("SB"))
/* map - Fix 1 Rev 1.2 */
     System.out.println("Here 5");
     requestConnection();
     try
     ItemBOHandle itembo = new ItemBOHandle(site,"*","*");
     nbBO = new NextNumberBOHandle(site,"S",itembo);
     StringBuffer next_number_query = new StringBuffer();
     next_number_query.append("SELECT current_sequence,prefix,suffix from next_number ");
     next_number_query.append("where HANDLE=");
     next_number_query.append(wrap(nbBO));
     Data number_query = executeQuery(next_number_query.toString());
     current_seq = (BigDecimal)number_query.get("CURRENT_SEQUENCE");
     prefix = (String)number_query.get("PREFIX");
     suffix = (String)number_query.get("SUFFIX");
     long sfc_seq = current_seq.longValue();
     first_sfc = current_seq.longValue();
                              int array_length = big.intValue();
     * Build an array to create the next SFC numbers. This information will
     * be used to select from the sfc table. If any of the SFCs in the array
     * are found, a new block should be generated.
     * I think this is where it implements the current sfc by 1. (map)
     new_sfc = new String[array_length];
     * map fix Rev 1.2 - loop until SFC_NBR test has been passed
     System.out.println("Here 8a1");
     if (Serialize == -1);
     /* map added do statement */
          do
     //while (Serialize == -1);
     System.out.println("Here 9");
     * map fix Rev 1.2
          for (int i=0;i<array_length;i++)
          if (suffix == null)
          new_sfc[i] = prefix+sfc_seq;
          else
          new_sfc[i] = prefix+sfc_seq+suffix;
          sfc_seq++;
          System.out.println(new_sfc);
          * Using the data we have generated above we need to check the SFC table.
          int new_sfc_array;
          new_sfc_array = new_sfc.length;
          for (int j=0;j<new_sfc_array;j++)
               System.out.println("Here 10");
          StringBuffer find_sfc = new StringBuffer();
          find_sfc.append("SELECT count(*) from sfc where ");
          find_sfc.append("sfc=");
          find_sfc.append(wrap(new_sfc[j]));
          System.out.println(find_sfc.toString());
          AreYouThere = executeQuery(find_sfc.toString());
          System.out.println("AreYouThere: "+AreYouThere);
          there_count = (BigDecimal)AreYouThere.get("COUNT(*)");
          //int array_length = big.intValue();
          System.out.println("Valueof There_count: "+there_count);
          int test = there_count.intValue();
          if (test > 0)
          System.out.println("The sfc is already in use : "+new_sfc);
          // We need a new block of sfc's one is already in use. Once we do that
          BigDecimal doubled = new BigDecimal(2);
          old_big = big;
          big=big.multiply(doubled);
          verify = true;
          break;
          if (Serialize == -1);
               break;
          // System.out.println("Data Returned from SFC select: "+AreYouThere);
          Serialize = 0;
     * map fix Rev 1.2
     //this it my bracket below while searching for the missing one!!!!!!!!!!!
          /* map added line below */
          while (Serialize == -1);
     * map fix Rev 1.2
     current_seq = current_seq.add(big);
     //System.out.println(now);
     System.out.println("Update sequence number: "+current_seq);
     // map commented this out as it is not set properly and will not compile.
     //java.util.Date now = new java.util.Date();
     //java.text.SimpleDateFormat formatter = new java.text.SimpleDateFormat("dd-MM-yy");
     //String time =formatter.format;
     /* Update the next_number table. Should be doing this using the CRUD methods, but didn't have time
     * to figure them out.
     StringBuffer update_next_number = new StringBuffer();
     update_next_number.append("UPDATE next_number set ");
     update_next_number.append("current_sequence="+wrap(current_seq)); /*+", "); */
     //update_next_number.append("modified_date_time="+wrap(time)+" ");
     update_next_number.append("where HANDLE="+wrap(nbBO));
     System.out.println("Update Next Number SQL: "+update_next_number);
     System.out.println("Executing update");
     executeUpdate(update_next_number.toString());
          finally
     cleanup();
/* map - Fix 1 */
     System.out.println("After Allocate SFC");
     /* map - Fix 1 */
/* This is where it actually writes the label and its contents.
* I also think its where it should be queuing the next label and not trying
* to overwrite it, like it does currently. (map)
     //File out = new file(file_time)
          /* map change Rev 1.3*/
          //sb.append(order_id+","+pos_id+","+spcode+","+pack+","+imei_number+","+final_template);
          /* This is the option to use the date as a time stamp.
     SimpleDateFormat formatter = new SimpleDateFormat("ddMMyyHmmss");
     Date currentTime_1 = new Date();
     fileDate = formatter.format(currentTime_1);
          System.out.println("Current Time : "+fileDate);
     file_path = ("C:\\TEMP\\"+fileDate+".Job");      
     out = new File(file_path);
     System.out.println("Output File Name : "+out);
     /* map change Rev 1.3*/
     //map new code...
     PrintWriter out = null;
     try
               out = new PrintWriter(new BufferedOutputStream(new FileOutputStream("c:/temp/nice.job", true)), true);
               out.print("LABEL \"");
               out.print(item);
               out.print("_");
               out.print(item_rev);
               out.print("_");
               out.print(label_tmp);
               out.print(".lbl\"");
               out.println();
               // All other stuff...
     finally
          try
               out.close();
          catch(Exception e)
               System.err.println("Unable to close output stream");
               e.printStackTrace();
     return inData;

Answer 1

Cheers, your a star!
The thing is, I have just been looking throughit after what you said and there seems to be only one catch and 3 trys and before I (fooked) around with it, it worked???
Here is the code. I think JCreator is not very helpful!!
Cheers
package com.genrad.app.core.prod.server;
import javax.ejb.*;
import java.rmi.RemoteException;
import javax.naming.*;
import javax.sql.DataSource;
import java.sql.*;
import java.math.*;
import java.io.*;
import java.lang.Thread.*;
import java.util.*;
import java.util.Date;
import java.text.*;
import javax.transaction.*;
import com.genrad.frame.*;
import com.genrad.app.common.server.*;
import com.genrad.app.nc.server.*;
import com.genrad.app.core.pd.server.*;
import com.genrad.app.core.sys.server.*;
import com.genrad.app.core.track.server.*;
import com.genrad.app.core.demand.server.*;
import com.genrad.app.core.env.server.*;
public class LexisBean extends BasicProductionBean implements SessionBean,LexisInterface
private final String ACTIVITY_ID = "CT520";
private final String TRUE = "true";
private String sfc_info = null;
private String get_prop_sfc = null;
private Data Context_List;
private Data test;
private Data itemBOrs;
private String item = null;
private String item_rev = null;
private String shoporder = null;
private Data LotSizeRS;
private Data results;
private Data hookData;
private Data AreYouThere;
private String printer = null;
private String label_tmp = null;
private BigDecimal big;
private BigDecimal current_seq;
private String site;
private String file_path;
private String file_time;
private String prefix;
private String suffix;
private boolean verify = false;
private NextNumberBOHandle nbBO;
private String[] new_sfc;
private int count=0;
private BigDecimal there_count;
private BigDecimal old_big;
private long first_sfc;
private int Serialize = -1;
private String fileDate;
//private PrintWriter out;
//private output_file;
// private StringBuffer buffer;
* Constructor
public LexisBean()
public Data execute(Data inData)throws RemoteException, BasicBOBeanException
* Need to get all the user options defined in the Activity. The only one that
* is not required in the printer name. There is no validation done on
* any of these options.
* Here I think it should be using the LABELREF User Argument in the Hook Activity
* within Resource Maintenance. (map)
String setting = null;
Utils.traceMsg("LexisBean . execute() : inData \n" + inData.toXMLString(), 10);
hookData = (Data)inData.get("HOOK_DATA",0);
Utils.traceMsg("LexisBean . execute() : hookData \n" + hookData.toXMLString(), 10);
results = (Data)hookData.get("ACTIVITY_OPTION", 0);
if (results != null)
String value = null;
String hookData = null;
Data countData = null;
* This should check the setting is not SB, don't pre-allocate SFC, just carry on
* and pass the current sfcnumber. This is my theory anyway!! (map)
for (int row = 0; row < results.size(); row++)
countData=results.extractRow(row);
setting = (String)countData.get("SETTING", 0);
value = (String)countData.get("EXEC_UNIT_OPTION", 0);
if (value != null && value.equals("PRINTER"))
printer = setting;
System.out.println("Printer: "+printer);
if (value != null && value.equals("LABELREF"))
System.out.println("Value: "+value);
label_tmp = setting;
System.out.println("Label TMP: "+label_tmp);
// Get the SFCBO, as that is the key to getting all the data we need.
Context_List = (Data)inData.get("CONTEXT_LIST",0);
item = (Context_List.get("CONTEXT_GBO",0)).toString();
sfc_info = (inData.get("SFC_BO")).toString();
//SFCBOInterface sfcBean = (SFCBOInterface)getEJB("SFCBO");
SFCBOHandle sfcbohand = (SFCBOHandle)inData.get("SFC_BO",0);
site = sfcbohand.getSite();
String SFCNumber = sfcbohand.getSFC();
// Need to grab the filename and full path from a system rule.
System.out.println("Fixing to try and get the Resource_BO");
ResourceBOHandle resource = (ResourceBOHandle)inData.get("RESOURCE_BO",0);
file_path = (String)getSystemRule("INLINE_PRINTING",site,resource);
File out = new File(file_path);
System.out.println("FilePath from resource "+file_path);
// Request connection to the database
requestConnection();
try
* Create a string buffer to build the SQL. Need to do this to
* get the itemBO from the SFC table. There currently is no method
* to get this information other than this. At lease not that I
* know of.
StringBuffer itemBOquery = new StringBuffer();
itemBOquery.append("SELECT ITEM_BO FROM SFC ");
itemBOquery.append("WHERE HANDLE=");
itemBOquery.append(wrap(sfcbohand));
itemBOrs = executeQuery(itemBOquery.toString());
System.out.println("ITEM BO FROM SELECT: "+itemBOrs);
ItemBOHandle itemBOHandle = new ItemBOHandle((String) itemBOrs.get("ITEM_BO"));
item = itemBOHandle.getItem();
item_rev = itemBOHandle.getRevision();
* Create a string buffer to build the SQL. Need to do this to get
* ShopOrderBO. This information is actually coming from the
* shop_order_sfc table. Once we have that it will be used to create
* the printjobname line in the label file.
StringBuffer soBOquery = new StringBuffer();
soBOquery.append("SELECT SHOP_ORDER_BO FROM shop_order_sfc ");
soBOquery.append("where SFC_BO=");
soBOquery.append(wrap(sfcbohand));
Data soBOrs = executeQuery(soBOquery.toString());
ShopOrderBOHandle shopBOHandle = new ShopOrderBOHandle((String) soBOrs.get("SHOP_ORDER_BO"));
shoporder = shopBOHandle.getShopOrder();
* Create a string buffer to build the SQL. Need to do this to get
* lotsize of an item. I will be getting this information from the
* item table. Once we have that information it will be used to
* create the PRINT line in the nicelabel.
* I think this is where it gets the item lot size and needs to get the sfc lot size,
* another one of Stuarts bugs...
StringBuffer LotSize = new StringBuffer();
LotSize.append("SELECT LOT_SIZE FROM ITEM ");
LotSize.append("where HANDLE=");
LotSize.append(wrap(itemBOHandle));
LotSizeRS = executeQuery(LotSize.toString());
big = (BigDecimal)LotSizeRS.get("LOT_SIZE");
System.out.println(LotSize.toString());
System.out.println("LOTSIZE: "+LotSizeRS);
finally
cleanup();
String sfc = sfcbohand.getSFC();
* The following try block is an attempt to write the information to
* the nice label file. It uses several of the string variables defined
* above.
try
     //System.out.println("Here 1");
* Check to see if Activity Option 'LABEL' is present. If it is not throw an exception.
* I think this could be where LABEL should be a user configured variable (map)
* Either here or above on line 109. (map) (then again maybe not!!!)
if (label_tmp == null)
abortMissingInput("Activity Option 'LABELREF'");
System.out.println("Here 2");
else
//     System.out.println("Here 3");
* Check to see if the nicelabel file already exists. If it does
* then we need to write the data into a temporary file.
// cam removed
// while(out.exists())
// cam removed
// System.out.println("Here 4");
* Build data for updating the next_number table. Before that happens we need to
* verify that the SFCs do not already exist in wip, if they do then we need to generate
* a new batch
/* map - Fix Rev 1.2 */
System.out.println("Label TMP "+label_tmp);
System.out.println("SFC Number "+SFCNumber);
if (label_tmp.equals("SB"))
/* map - Fix 1 Rev 1.2 */
     System.out.println("Here 5");
     requestConnection();
     try
     ItemBOHandle itembo = new ItemBOHandle(site,"*","*");
     nbBO = new NextNumberBOHandle(site,"S",itembo);
     StringBuffer next_number_query = new StringBuffer();
     next_number_query.append("SELECT current_sequence,prefix,suffix from next_number ");
     next_number_query.append("where HANDLE=");
     next_number_query.append(wrap(nbBO));
     Data number_query = executeQuery(next_number_query.toString());
     current_seq = (BigDecimal)number_query.get("CURRENT_SEQUENCE");
     prefix = (String)number_query.get("PREFIX");
     suffix = (String)number_query.get("SUFFIX");
     long sfc_seq = current_seq.longValue();
     first_sfc = current_seq.longValue();
                              int array_length = big.intValue();
     * Build an array to create the next SFC numbers. This information will
     * be used to select from the sfc table. If any of the SFCs in the array
     * are found, a new block should be generated.
     * I think this is where it implements the current sfc by 1. (map)
     new_sfc = new String[array_length];
     * map fix Rev 1.2 - loop until SFC_NBR test has been passed
     System.out.println("Here 8a1");
     if (Serialize == -1);
     /* map added do statement */
          do
     //while (Serialize == -1);
     System.out.println("Here 9");
     * map fix Rev 1.2
          for (int i=0;i<array_length;i++)
          if (suffix == null)
          new_sfc[i] = prefix+sfc_seq;
          else
          new_sfc[i] = prefix+sfc_seq+suffix;
          sfc_seq++;
          System.out.println(new_sfc);
          * Using the data we have generated above we need to check the SFC table.
          int new_sfc_array;
          new_sfc_array = new_sfc.length;
          for (int j=0;j<new_sfc_array;j++)
               System.out.println("Here 10");
          StringBuffer find_sfc = new StringBuffer();
          find_sfc.append("SELECT count(*) from sfc where ");
          find_sfc.append("sfc=");
          find_sfc.append(wrap(new_sfc[j]));
          System.out.println(find_sfc.toString());
          AreYouThere = executeQuery(find_sfc.toString());
          System.out.println("AreYouThere: "+AreYouThere);
          there_count = (BigDecimal)AreYouThere.get("COUNT(*)");
          //int array_length = big.intValue();
          System.out.println("Valueof There_count: "+there_count);
          int test = there_count.intValue();
          if (test > 0)
          System.out.println("The sfc is already in use : "+new_sfc);
          // We need a new block of sfc's one is already in use. Once we do that
          BigDecimal doubled = new BigDecimal(2);
          old_big = big;
          big=big.multiply(doubled);
          verify = true;
          break;
          if (Serialize == -1);
               break;
          // System.out.println("Data Returned from SFC select: "+AreYouThere);
          Serialize = 0;
     * map fix Rev 1.2
     //this it my bracket below while searching for the missing one!!!!!!!!!!!
          /* map added line below */
          while (Serialize == -1);
     * map fix Rev 1.2
     current_seq = current_seq.add(big);
     //System.out.println(now);
     System.out.println("Update sequence number: "+current_seq);
     // map commented this out as it is not set properly and will not compile.
     //java.util.Date now = new java.util.Date();
     //java.text.SimpleDateFormat formatter = new java.text.SimpleDateFormat("dd-MM-yy");
     //String time =formatter.format;
     /* Update the next_number table. Should be doing this using the CRUD methods, but didn't have time
     * to figure them out.
     StringBuffer update_next_number = new StringBuffer();
     update_next_number.append("UPDATE next_number set ");
     update_next_number.append("current_sequence="+wrap(current_seq)); /*+", "); */
     //update_next_number.append("modified_date_time="+wrap(time)+" ");
     update_next_number.append("where HANDLE="+wrap(nbBO));
     System.out.println("Update Next Number SQL: "+update_next_number);
     System.out.println("Executing update");
     executeUpdate(update_next_number.toString());
          finally
     cleanup();
/* map - Fix 1 */
     System.out.println("After Allocate SFC");
     /* map - Fix 1 */
/* This is where it actually writes the label and its contents.
* I also think its where it should be queuing the next label and not trying
* to overwrite it, like it does currently. (map)
     //File out = new file(file_time)
          /* map change Rev 1.3*/
          //sb.append(order_id+","+pos_id+","+spcode+","+pack+","+imei_number+","+final_template);
          /* This is the option to use the date as a time stamp.
     SimpleDateFormat formatter = new SimpleDateFormat("ddMMyyHmmss");
     Date currentTime_1 = new Date();
     fileDate = formatter.format(currentTime_1);
          System.out.println("Current Time : "+fileDate);
     file_path = ("C:\\TEMP\\"+fileDate+".Job");      
     out = new File(file_path);
     System.out.println("Output File Name : "+out);
     /* map change Rev 1.3*/
     //map new code...
     PrintWriter out = null;
     try
               out = new PrintWriter(new BufferedOutputStream(new FileOutputStream("c:/temp/nice.job", true)), true);
               out.print("LABEL \"");
               out.print(item);
               out.print("_");
               out.print(item_rev);
               out.print("_");
               out.print(label_tmp);
               out.print(".lbl\"");
               out.println();
               // All other stuff...
     finally
          try
               out.close();
          catch(Exception e)
               System.err.println("Unable to close output stream");
               e.printStackTrace();
     return inData;