Handle invalid_number exception for a procedure with numeric in paramete

Question

I have a procedure that takes an input parameter as number(numeric datatype) how can i handle an invalid_number exception (-01722) to display a message when a user tries entering non-numeric input
the procedure is shown below..
create or replace procedure orders(custid_in IN number) is
cursor order_cur is
select order_id, order_date, total
from product_order
where customer_id = to_number(custid_in);
order_row order_cur%rowtype; -- declare cursor variable
err_msg varchar2(512);
BEGIN
dbms_output.put_line('Order Details for customer with customer id '||custid_in|| ' is shown below: ');
dbms_output.put_line((chr(9)));
open order_cur;
LOOP
fetch order_cur into order_row;
exit when order_cur%notfound ;
dbms_output.put_line('Order ID: '||order_row.order_id);
dbms_output.put_line('Order Date: '||order_row.order_date);
dbms_output.put_line('Total: '||order_row.total);
dbms_output.put_line((chr(9)));
END LOOP;
close order_cur;
EXCEPTION
when invalid_number then
dbms_output.put_line('Customer ID not correct. Try again! ');
dbms_output.put_line((chr(9)));
WHEN others THEN
err_msg := sqlerrm;
dbms_output.put_line('The following error occured: ');
dbms_output.put_line(err_msg);
END;

Answer 1

My first recommendation is to remove the type conversion from your cursor:
cursor order_cur is
select order_id, order_date, total
from product_order
where customer_id = to_number(custid_in);making itcursor order_cur is
select order_id, order_date, total
from product_order
where customer_id = custid_in;because you are already passing it into your stored procedure as parameter of type number.
Then if you really want to check for the invalid number exception you will probably need to do it from where ever you are calling the procedure from since it's going to occur at the time it's called rather than once you are inside the procedure.
And finally, remove your final exception handler (the WHEN OTHERS exception) it serves no useful purpose and is in point of fact detrimental to your code in that it may improperly handle unexpected errors and allow processing to continue when it should not.