Help-- build a Thread to manage Client

Question

Login: it sends to Server a string= "CONNECTING" and Server will send a string = "CONNECTED" then EchoClient (is a thread which manage a connection from the outside) will call a new thread(ManageClient) with a new port to make a seperate connection.
Problem... while running Login and click the button after run EchoClient, there is no respond
Maybe it's too long.. Sorry and thanks for running my code and helping me
Login class
import java.awt.FlowLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.io.PrintWriter;
import java.net.Socket;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JTextArea;
public class Login extends JFrame {
     public ChatFrame chatFrame;
     private final int CONNECTED = 1;
     private final int CONNECTING = 11;
     private Socket connectSocket = null;
     BufferedReader in = null;
     PrintWriter out = null;
      * @param args
     public Login() {
          // TODO Auto-generated method stub
          setSize(50, 150);
          JButton loginButton = new JButton("Login");
          JPanel p = new JPanel();
          p.setLayout(new FlowLayout());
          p.add(loginButton);
          add(p);
//Wait and listen the line from server
          Thread t = new Thread() {
               public void run() {
                    try {
                         Socket connectSocket = new Socket("localhost", 903);
                         in = new BufferedReader(new InputStreamReader(connectSocket
                                   .getInputStream()));
                         out = new PrintWriter(connectSocket.getOutputStream());
                         String stringLine = in.readLine();
                         if (stringLine == "CONNECTED") {
                              int port = in.read();
                              chatFrame = new ChatFrame(port);
                              chatFrame
                                        .setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
                              chatFrame.show();
                              connectSocket.close();
                    } catch (Exception e) {
          t.start();
          //click Login button and send "CONNECTING"
          loginButton.addActionListener(new ActionListener() {
               @Override
               public void actionPerformed(ActionEvent e) {
                    try {                         
                         out.print("CONNECTING");
                         System.out.print("send ");
                    } catch (Exception exp) {
                         exp.printStackTrace();
     public static void main(String[] args) {
          Login login = new Login();
          login.show();
          login.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
EchoClient class
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.io.PrintWriter;
import java.net.ServerSocket;
import java.net.Socket;
import java.util.Random;
public class EchoClient extends Thread {
     private ServerSocket listenSocket = null;
     private Socket manageSocket = null;
     private int[] port = new int[9999];
     private BufferedReader in;
     private PrintWriter out;
     private int line;
     private int count;
     //private ClientNode[] clientArray = new ClientNode[9999];
     private ManageClient[] manageClient;
     private final int CONNECTED = 1;
     private final int CONNECTING = 11;
     private final int DISCONECTED = 2;
     public void run() {
          try {
               //manageClient = new ManageClient[9999];
               listenSocket = new ServerSocket(903);
               manageSocket = listenSocket.accept();
               while (true) {
                    in = new BufferedReader(new InputStreamReader(manageSocket
                              .getInputStream()));
                    out = new PrintWriter(manageSocket.getOutputStream());
                    String stringLine = in.readLine();
                    System.out.print(in.readLine());
//wait and listen from client
                    if (stringLine != null) {
                         //if recieve a string send "CONNECTED"
                         out.print("CONNECTED");
//"Creat a port for ChatFrame"
                         port[count] = (int) Math.ceil(Math.random() * 9999);
                         manageClient[count] = new ManageClient(port[count]);
                         manageClient[count].start();
                         out.print(port[count]);
                         count++;
                         listenSocket.close();
          } catch (Exception e) {
               e.printStackTrace();
     public static void main(String[] args) {
          EchoClient e = new EchoClient();
          e.start();
ManageClient class
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.io.PrintWriter;
import java.net.ServerSocket;
import java.net.Socket;
public class ManageClient extends Thread {
     private ServerSocket ssClient;
     private Socket sClient;
     private int port;
     public ManageClient(int port) {
          this.port = port;
     public int getPort() {
          return port;
     public void run() {
          try {
               ssClient = new ServerSocket(getPort());
               sClient = ssClient.accept();
               while (true) {
                    BufferedReader in = new BufferedReader(new InputStreamReader(
                              sClient.getInputStream()));
                    PrintWriter out = new PrintWriter(sClient.getOutputStream());
                    String s = in.readLine();
                    if (s != null)
                         out.print("have recieved");
          } catch (Exception e) {
               e.printStackTrace();
ChatFrame class need for running
import java.awt.BorderLayout;
import java.awt.FlowLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.io.PrintWriter;
import java.net.Socket;
import javax.swing.JButton;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JScrollPane;
import javax.swing.JSplitPane;
import javax.swing.JTabbedPane;
import javax.swing.JTextArea;
import javax.swing.JTextField;
import javax.swing.JTree;
import javax.swing.tree.DefaultMutableTreeNode;
public class ChatFrame extends JFrame {
     private JTree tree = null;
     private ClientNode[] clientArray = new ClientNode[9999];
     private JTextArea textChat = null;
     private JTextField[] textBox = new JTextField[9999];
     private Socket connection = null;
     private BufferedReader in = null;
     private PrintWriter out = null;
     private int port;
     private JTabbedPane communicationTab;
     private JButton sendButton;
     public ChatFrame(int port) {
          setSize(300, 300);
          this.port = port;
          DefaultMutableTreeNode user = new DefaultMutableTreeNode(
                    "Another users");
          DefaultMutableTreeNode Client1 = new DefaultMutableTreeNode("Client 1");
          user.add(Client1);
          tree = new JTree(user);
          JScrollPane treeScrollPane = new JScrollPane(tree);
          JPanel p = new JPanel();
          p.add(treeScrollPane);
          communicationTab = new JTabbedPane();
          JSplitPane upperSplitPane = new JSplitPane(JSplitPane.HORIZONTAL_SPLIT,
                    communicationTab, p);
          upperSplitPane.setContinuousLayout(true);
          upperSplitPane.setOneTouchExpandable(true);
          upperSplitPane.setResizeWeight(1);
          textChat = new JTextArea();
          textChat.setLineWrap(true);
          textChat.setWrapStyleWord(true);
          JScrollPane scroll = new JScrollPane(textChat);
          JPanel q = new JPanel();
          sendButton = new JButton("Send");
          sendButton.setSize(2, 2);
          q.setLayout(new FlowLayout());
          q.add(sendButton);
          JPanel tc = new JPanel();
          tc.setLayout(new BorderLayout());
          tc.add(scroll, BorderLayout.CENTER);
          tc.add(q, BorderLayout.EAST);
          JSplitPane underSplitPane = new JSplitPane(JSplitPane.VERTICAL_SPLIT,
                    upperSplitPane, tc);
          underSplitPane.setLastDividerLocation(1);
          underSplitPane.setResizeWeight(1);
          connectToServer();
          getContentPane().add(underSplitPane, "Center");
          sendButton.addActionListener(new ActionListener() {
               @Override
               public void actionPerformed(ActionEvent arg0) {
                    // TODO Auto-generated method stub
                    if (textChat.getText() != "")
                         send(textChat.getText());
                    textChat.setText("");
     public void connectToServer() {
          try {
               connection = new Socket("serverName", getPort());
               while (true) {
                    in = new BufferedReader(new InputStreamReader(connection
                              .getInputStream()));
                    out = new PrintWriter(connection.getOutputStream());
                    String s = in.readLine();
                    if (s != null) {
                         textChat.append(s);
          } catch (Exception e) {
     public int getPort() {
          return port;
     public static void main(String[] args) {
          ChatFrame c = new ChatFrame(903);
          c.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
          c.show();
     public void send(String s) {
          try {
               out.print(s);
               out.print("\r\n");
               out.flush();
          } catch (Exception e) {
               e.printStackTrace();
}Edited by: rockfanskid on Oct 17, 2007 9:47 AM

Answer 1

I agree with DrClap.
Another thing: do NOT compare Strings with == unless you want to check for identity equals (as in the same object). Use String.equals() instead for equality.
Example:
String a = "test";
String b = "test";
String c = new String("test".getBytes());
System.out.println(a.equals(b)); // true
System.out.println(a == b); // true
System.out.println(b.equals(c)); // true
System.out.println(b == c); // falseThis is just a trick from Sun to confuse you ;) String's are internally pooled by the String class. Look at the javadoc of String.intern() for instance for more information. But use String.equals() in your code...