Help needed Converting MSSQL function to PL/SQL

Question

Hello,
I have the following MSSQL code which I need to migrate to Oracle 10g. The problem I am having is the MSSQL code creates a temp table as the return type and I am unsure how to get the same functionality in PL/SQL.
MSSQL CODE_
CREATE FUNCTION [dbo].[QueryCurrentWhy]
@ColumnID INT,
@GroupID INT,
@Parents VARCHAR(8000)
RETURNS @R TABLE(ID1 int IDENTITY (1, 1) NOT NULL, ID2 int, ColID int, [Name] VARCHAR(255), Tlevel int, ParentID int, Processed BIT)
AS
BEGIN
RETURN
END
The code I have currently written in PL/SQL is below. I firstly create a global temp table and then a sequence and trigger for it. I then create the Function in the hope I can specify the temp table as the return type. Problem is I get the error "PLS-00201: identifier 'TEMPR' must be declared". Im guessing this is because the temp table is declared outside the function declaration?
ORACLE CODE_
CREATE GLOBAL TEMPORARY TABLE tempR
ID1 INT NOT NULL,
ID2 INT,
ColID INT,
Name VARCHAR2(255),
Tlevel INT,
ParentID INT,
Processed CHAR(1)
CREATE SEQUENCE gCounter
     START WITH 1
     INCREMENT BY 1
CREATE OR REPLACE TRIGGER gTrigger
BEFORE INSERT ON tempR
FOR EACH ROW
DECLARE TEMP_NO INT;
BEGIN
     SELECT gCounter.NEXTVAL INTO TEMP_NO FROM DUAL;
:NEW.ID1 := TEMP_NO;
END;
CREATE OR REPLACE FUNCTION TSORADB.QueryCurrentWhy
aColumnID INT,
aGroupID INT,
aParents VARCHAR2(8000)
RETURN tempR
AS
BEGIN
RETURN;
EXCEPTION when NO_DATA_FOUND then null;
END;
Basically is it possible for me to declare the temp table in the return statement, if not then what is the best way to go about this?
Thanks in advance
Toby
Edited by: redeye on Jul 27, 2009 3:26 PM

Answer 1

Unfortunately I didnt write the original function or stored procedure and the person who did is no longer with the company, so apologies for any confusion with what I am saying.
Maybe it'll be more helpful if i paste the contents of the function?
CREATE OR REPLACE FUNCTION TSORADB.QueryCurrentWhy
aColumnID INT,
aGroupID INT,
aParents VARCHAR2(8000)
RETURN tempR
AS
--BEGIN
aPKColTypeID INT;
aFKDColTypeID INT;
aFKDSColTypeID INT;
aFKIColTypeID INT;
aColType VARCHAR2(30);
aTableID INT;
aName VARCHAR2(255);
aNameWhyMost VARCHAR2(255);
aNameWhyMost2 VARCHAR2(255);
aLongNameStr VARCHAR2(1000);
aConnectStr VARCHAR2(1000);
aColID INT;
aColIDWhyMost INT;
aColIDWhyMost2 INT;
aColIDWhyMostLast INT;
aCount INT;
aID1 INT;
aID2 INT;
aPreID2 INT;
aMaxID2 INT;
aCurrentID2 INT;
aTLevel INT;
aTLevel2 INT;
aTlevelLast INT;
aNewLevel INT;
aMaxTLevel INT;
aMaxTLevel2 INT;
aParentID INT;
aParentID2 INT;
aNewParentID INT;
aProcessed number (1);
--aCurVar1 CURSOR;
aParent INT; aStrEntityIDSet varchar(2000); aStrPipeSepValsInput varchar(2000); aEndPointInput int; aSeperatorIndex int;
aNumTempDoc INTEGER := 0;
--aColumnID INT DEFAULT(0);
--aGroupID INT DEFAULT(0);
--aParents VARCHAR(8000) DEFAULT('');
BEGIN
SELECT ColumnTypeID INTO aPKColTypeID FROM TSORADB.HKColumnType WHERE ColumnTypeName = 'PK';
SELECT ColumnTypeID INTO aFKDColTypeID FROM TSORADB.HKColumnType WHERE ColumnTypeName = 'FKD';
SELECT ColumnTypeID INTO aFKDSColTypeID FROM TSORADB.HKColumnType WHERE ColumnTypeName = 'FKDS';
SELECT ColumnTypeID INTO aFKIColTypeID FROM TSORADB.HKColumnType WHERE ColumnTypeName = 'FKI';
IF (aGroupID is null)
THEN
     aGroupID := -1;
END IF;
--Tokenize the parent array and get back a set of values.
IF(aParents is not null)
THEN
BEGIN
     aStrEntityIDSet := aParents;
     aStrPipeSepValsInput := '|' + ltrim(rtrim(aStrEntityIDSet)) + '|';
     --print aStrPipeSepValsInput
     aEndPointInput := INSTR(aStrPipeSepValsInput, '|');
     aStrPipeSepValsInput := INSTR (aStrPipeSepValsInput, LENGTH (aStrPipeSepValsInput) - aEndPointInput); -- take out the '|' pattern
     WHILE (LENGTH (aStrPipeSepValsInput) > 0)
     LOOP
     BEGIN
          aEndPointInput := INSTR(aStrPipeSepValsInput, '|'); -- get the next '|' pattern
          aParent := SUBSTR(aStrPipeSepValsInput, 1, aEndPointInput - 1);
          --PRINT 'aParent is ' + CONVERT (NVARCHAR, aParent)
          aStrPipeSepValsInput := INSTR (aStrPipeSepValsInput, LENGTH (aStrPipeSepValsInput) - aEndPointInput);
          INSERT INTO TmpParent (ColID) VALUES (aParent);
     END;
     END LOOP;
END;
END IF;
SELECT hkc.TableID, hkc.Name, hkct.ColumnTypeName
INTO aTableID, aName, aColType
FROM TSORADB.HKColumns hkc
INNER JOIN TSORADB.HKColumnType hkct on hkc.ColTypeID = hkct.ColumnTypeID
WHERE hkc.ColumnID = aColumnID;
IF aColType in ('PK','PKD')
THEN
     -- Generate Unique Path Table Start
     SELECT
     CASE WHEN FKIs3.Name is null
     THEN PKs3.Name
     ELSE FKIs3.Name
     END Name
     INTO aName
     FROM TSORADB.HKColumns PKs3
     INNER JOIN
     SELECT hkc3.TableID FROM TSORADB.HKColumns hkc3
     WHERE hkc3.ColumnID = aColumnID
     ) HKC3 ON PKs3.TableID = HKC3.TableID
     LEFT OUTER JOIN
     SELECT TableID, Name
     FROM TSORADB.HKColumns
     WHERE ColTypeID = aFKIColTypeID
     ) FKIs3 ON PKs3.TableID = FKIs3.TableID
     WHERE PKs3.ColTypeID = aPKColTypeID AND ((aGroupID=-1 AND PKs3.GroupID IS NULL) OR PKs3.GroupID=aGroupID);     
END IF;
-- Insert query column itself
aTlevel := 0;
aParentID := 0;
aID2 := 1;
IF (aColType = 'ATT')
THEN
BEGIN
INSERT INTO tempR(ID2, ColID, Name, Tlevel, ParentID, Processed)
SELECT distinct aID2, TopHKCs.ColumnID as ColID, aName as Name,aTlevel as Tlevel, aParentID as ParentID, 1 as Processed
     FROM TSORADB.HKColumns TopHKCs
WHERE TopHKCs.ColumnID = aColumnID;
aID2 := aID2 + 1;
aTlevel := 1;
     aParentID := aColumnID;
     -- Get the non-compound name for the parent
     SELECT
     CASE WHEN FKIs3.Name is null
     THEN PKs3.Name
     ELSE FKIs3.Name
     END Name
     INTO aName
     FROM TSORADB.HKColumns PKs3
     INNER JOIN
     SELECT hkc3.TableID FROM TSORADB.HKColumns hkc3
     WHERE hkc3.ColumnID = (SELECT ColumnID FROM TSORADB.HKColumns WHERE TableID = aTableID AND ColTypeID = aPKColTypeID)
     ) HKC3 ON PKs3.TableID = HKC3.TableID
     LEFT OUTER JOIN
     SELECT TableID, Name
     FROM TSORADB.HKColumns
     WHERE ColTypeID = aFKIColTypeID
     ) FKIs3 ON PKs3.TableID = FKIs3.TableID
     WHERE PKs3.ColTypeID = aPKColTypeID AND ((aGroupID=-1 AND PKs3.GroupID IS NULL) OR PKs3.GroupID=aGroupID);
     INSERT INTO tempR(ID2, ColID, Name, Tlevel, ParentID, Processed)
SELECT aID2, ColumnID, aName, aTlevel, aParentID, 0
FROM TSORADB.HKColumns
     WHERE TableID = aTableID
     AND ColTypeID = aPKColTypeID;
aID2 := aID2 + 1;
END;
ELSE
BEGIN
     INSERT INTO TmpR1(ColID, Name, Tlevel, ParentID, Processed)
     SELECT nonCompoundHks.ColumnID as ColID, aName as Name,aTlevel as Tlevel, aParentID as ParentID, 0 as Processed
     FROM TSORADB.HKColumns nonCompoundHks
     WHERE nonCompoundHks.Name = aName --lower(nonCompoundHks.Name) = lower(aName)
     AND ((aGroupID=-1 AND nonCompoundHks.GroupID IS NULL) OR nonCompoundHks.GroupID=aGroupID)
     AND nonCompoundHks.ColTypeID = aPKColTypeID
     AND EXISTS
          select ColumnID
          From TSORADB.HKColumns hkc4
          WHERE hkc4.TableID = nonCompoundHks.TableID
          AND (hkc4.ColTypeID = aFKDColTypeID OR hkc4.ColTypeID = aFKDSColTypeID)
     AND NOT EXISTS
          select ColumnID
          From TSORADB.HKColumns hkc5
          WHERE hkc5.TableID = nonCompoundHks.TableID
          AND hkc5.ColTypeID = aFKIColTypeID
          AND ((aGroupID=-1 AND hkc5.GroupID IS NULL) OR hkc5.GroupID=aGroupID)
     INSERT INTO TmpR1(ColID, Name, Tlevel, ParentID, Processed)
     SELECT compoundPk.ColumnID as ColID, aName as Name,aTlevel as Tlevel, aParentID as ParentID, 0 as Processed
     FROM TSORADB.HKColumns compoundPk
     INNER JOIN TSORADB.HKColumns compoundHkc on compoundHkc.TableID = compoundPk.TableID AND compoundHkc.ColTypeID = aFKIColTypeID
INNER JOIN (
          SELECT hkc.ColumnID
          FROM TSORADB.HKColumns hkc
          WHERE hkc.ColTypeID = aPKColTypeID
          AND hkc.Name = aName --lower(hkc.Name) = lower(aName)
          AND ((aGroupID=-1 AND hkc.GroupID IS NULL) OR hkc.GroupID=aGroupID)
          AND NOT EXISTS
          select ColumnID
          From TSORADB.HKColumns hkc2
          WHERE hkc2.TableID = hkc.TableID
          AND (hkc2.ColTypeID = aFKDColTypeID OR hkc2.ColTypeID = aFKDSColTypeID)
          AND ((aGroupID=-1 AND hkc2.GroupID IS NULL) OR hkc2.GroupID=aGroupID)
) Indys ON Indys.ColumnID = compoundHkc.ForeignKey
     WHERE compoundPk.ColTypeID = aPKColTypeID;
     INSERT INTO tempR(ID2, ColID, Name, Tlevel, ParentID, Processed)
     SELECT ID2, ColID, Name, Tlevel, ParentID, Processed FROM TmpR1;
     FETCH FROM aCurVar1 INTO aColID, aName, aTlevel, aParentID, aProcessed
     WHILE aafetch_status = 0
     BEGIN     
          IF(aParents is null or EXISTS (SElECT ColID FROM aTmpParent WHERE ColID = aColID) )
          BEGIN
               INSERT INTO tempR(ID2, ColID, [Name], Tlevel, ParentID, Processed) VALUES(aID2, aColID, aName, aTlevel, aParentID, aProcessed)
               SET aID2 = aID2 + 1
          END
          FETCH NEXT FROM aCurVar1 INTO aColID, aName, aTlevel, aParentID, aProcessed
     END
     CLOSE aCurVar1 */
END;
END IF;
     begin
     SELECT COUNT(*) INTO aNumTempDoc FROM tempR WHERE Processed = 0 and Tlevel < 1;
     end;
WHILE aNumTempDoc > 0
LOOP
BEGIN
-- Get current row
     SELECT ID1, ID2, ColID, Name, Tlevel, ParentID
     INTO aID1, aID2, aColID, aName, aTlevel, aParentID
     FROM tempR
     WHERE Processed = 0 AND ROWNUM = 1
     ORDER BY ID1;
UPDATE tempR SET processed = 1 WHERE ID1 = aID1;
aPreID2 := aID2;
-- Get why parents
declare CURSOR aCurVar1 IS --SELECT * FROM TSORADB.HKColumns;
     SELECT distinct FKDPKs.ColumnID as ColID,
          CASE WHEN FKDFKI.NAME is null
          THEN FKDPKs.Name
          ELSE FKDFKI.Name
          END Name,
     (aTlevel+1) as Tlevel,
     PREHKCs.ColID AS ParentID,
     0 as Processed
     FROM TSORADB.HKColumns FKDPKs
     INNER JOIN
     TSORADB.HKColumns FKDFKs ON FKDPKs.ColumnID = FKDFKs.ForeignKey
INNER JOIN
     TSORADB.HKColumns FKDFKs2 ON FKDFKs2.TableID = FKDFKs.TableID
     INNER JOIN
     tempR PREHKCs ON PREHKCs.ColID=aColID AND PREHKCs.ColID = FKDFKs2.ColumnID AND PREHKCs.Tlevel=aTlevel
     LEFT OUTER JOIN
     SELECT TableID, Name, GroupID
     FROM TSORADB.HKColumns
     WHERE ColTypeID = aFKIColTypeID
     ) FKDFKI ON FKDFKI.TableID = FKDPKs.TableID
     INNER JOIN TSORADB.HKColumnType ON FKDPKs.ColTypeID=HKcolumnType.ColumnTypeID
     WHERE FKDPKs.ColTypeID=aPKColTypeID AND FKDPKs.ColumnID <> aColumnID
     AND FKDFKs.ColTypeID=aFKDColTypeID
AND ((aGroupID=-1 AND FKDPKs.GroupID IS NULL) OR FKDPKs.GroupID=aGroupID);
     BEGIN
OPEN aCurVar1;
aCount := 1;
SELECT MAX(ID2) INTO aID2 FROM tempR;
LOOP
     FETCH aCurVar1 INTO aColID, aName, aTlevel, aParentID, aProcessed;
     Exit when aCurVar1%NOTFOUND; -- Exit the loop when no more rows are found.
--WHILE aafetch_status = 0
BEGIN
IF (aCount = 1) -- The first Why Parent
          THEN
               INSERT INTO tempR(ID2, ColID, Name, Tlevel, ParentID, Processed) VALUES(aPreID2, aColID, aName, aTlevel, aParentID, 0);
ELSE -- The multiple Why Parents
BEGIN
               aID2 := aID2 + 1;
-- Copy the previous parent with increased ID2
INSERT INTO tempR(ID2, ColID, Name, Tlevel, ParentID, Processed) SELECT aID2 as ID2, ColID, Name, Tlevel, ParentID, 1 AS Processed FROM tempR WHERE ID1 <= aID1 AND ID2 = aPreID2;
-- Insert the new why parent
INSERT INTO tempR(ID2, ColID, Name, Tlevel, ParentID, Processed) VALUES(aID2, aColID, aName, aTlevel, aParentID, 0);
END;
END IF;          
aCount := aCount + 1;
          --FETCH NEXT FROM aCurVar1 INTO aColID, aName, aTlevel, aParentID, aProcessed;
END;
     END LOOP;
CLOSE aCurVar1;
     END;
     SELECT COUNT(*) INTO aNumTempDoc FROM tempR WHERE Processed = 0 and Tlevel < 1;
END;
END LOOP;
-- Generate Unique Path Table End
RETURN;
EXCEPTION when NO_DATA_FOUND then null;
END;
The table which is returned to the SProc is used in the following way, (MSSQL code, as am yet to migrate). Basically using some of the returned column values along with DB values to populate a second temp table
INSERT INTO #TmpR1 SELECT * FROM QueryCurrentWhy(@ColumnID, @GroupID, @Parents)
SET @Tlevel = 1
INSERT INTO @R
SELECT HKColumns.Columnid as ColID, HKColumns.Tableid as TblID, R1.Name as [Name], HKColumns.NounID AS KeyCompA, R1.ParentID AS KeyCompB, HKColumns.ColTypeID as ColTypeID, ColumnTypeName as ColType, 0 as HasWhats,
CASE WHEN R2.ColID is null
THEN 0
ELSE 1
END HasWhyParent,
0 as IsSelected
FROM HKColumns
INNER JOIN #TmpR1 AS R1
ON HKColumns.ColumnID = R1.ColID AND R1.Tlevel=@Tlevel
INNER JOIN HKColumnType
ON HKColumns.ColTypeID=HKcolumnType.ColumnTypeID AND HKColumns.ColTypeID=@PKColTypeID
LEFT JOIN #TmpR1 AS R2
ON R2.ID2 = R1.ID2 AND R2.Tlevel=@Tlevel+1 AND R2.ParentID=R1.ColID